summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
67d2ce0)
Issue
=====
The `current_packet_offset_bytes` variable is incremented before the
initialization of the current `index_entry` by `init_index_entry()`.
This lead to each entry having the offset of the next entry and the last
entry having a erroneous offset.
Solution
========
Increment the `current_packet_offset_bytes` variable after the
initialization of each entry.
Drawbacks
=========
None.
Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Change-Id: I7592b2d70f402aa413de97a687bfe4fe1bf1b825
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1409
Tested-by: jenkins
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>
- current_packet_offset_bytes += current_packet_size_bytes;
- BT_LOGD("Seeking to next packet: current-packet-offset=%jd, "
- "next-packet-offset=%jd",
- current_packet_offset_bytes - current_packet_size_bytes,
- current_packet_offset_bytes);
-
index_entry = g_new0(struct ctf_fs_ds_index_entry, 1);
if (!index_entry) {
BT_LOGE_STR("Failed to allocate a new index entry.");
index_entry = g_new0(struct ctf_fs_ds_index_entry, 1);
if (!index_entry) {
BT_LOGE_STR("Failed to allocate a new index entry.");
g_ptr_array_add(index->entries, index_entry);
g_ptr_array_add(index->entries, index_entry);
+ current_packet_offset_bytes += current_packet_size_bytes;
+ BT_LOGD("Seeking to next packet: current-packet-offset=%jd, "
+ "next-packet-offset=%jd",
+ current_packet_offset_bytes - current_packet_size_bytes,
+ current_packet_offset_bytes);
+
} while (iter_status == BT_MSG_ITER_STATUS_OK);
if (iter_status != BT_MSG_ITER_STATUS_OK) {
} while (iter_status == BT_MSG_ITER_STATUS_OK);
if (iter_status != BT_MSG_ITER_STATUS_OK) {