Fix -Wpointer-sign warning in sol-thread.c

This fixes a couple of compiler warnings in rw_common when calling
target_read_memory/target_write_memory due to the type of parameter
"buf" (char *) not matching what these function expect (gdb_byte *).

gdb/ChangeLog:

        * sol-thread.c (rw_common): Change type of parameter "buf"
        to "gdb_byte *".
        (ps_pdwrite, ps_ptwrite): Cast parameter "buf" in call to
        rw_common to "gdb_byte *" instead of "char *".

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 05f431dd0a3e2b9f86999d96dd766e27d40417b5..2c272fd9a80bcd3ebf25a979f5dab606d8237454 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -2,6 +2,13 @@
 
        * MAINTAINERS (Write After Approval): Add myself to the list.
 
+2013-04-30  Joel Brobecker  <brobecker@adacore.com>
+
+       * sol-thread.c (rw_common): Change type of parameter "buf"
+       to "gdb_byte *".
+       (ps_pdwrite, ps_ptwrite): Cast parameter "buf" in call to
+       rw_common to "gdb_byte *" instead of "char *".
+
 2013-04-30  Joel Brobecker  <brobecker@adacore.com>
 
        * sol-thread.c (info_cb) [ti.ti_startfunc != 0]: Change type

diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index fd29100f8a466014da25b3ec92dbaacba7b8210a..969bfafe48637277c01db25f21833c3018655922 100644 (file)
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -782,7 +782,7 @@ ps_pglobal_lookup (gdb_ps_prochandle_t ph, const char *ld_object_name,
 
 static ps_err_e
 rw_common (int dowrite, const struct ps_prochandle *ph, gdb_ps_addr_t addr,
-          char *buf, int size)
+          gdb_byte *buf, int size)
 {
   int ret;
   struct cleanup *old_chain;
@@ -831,7 +831,7 @@ ps_err_e
 ps_pdwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr,
            gdb_ps_write_buf_t buf, gdb_ps_size_t size)
 {
-  return rw_common (1, ph, addr, (char *) buf, size);
+  return rw_common (1, ph, addr, (gdb_byte *) buf, size);
 }
 
 /* Copies SIZE bytes from target process .text segment to debugger memory.  */
@@ -849,7 +849,7 @@ ps_err_e
 ps_ptwrite (gdb_ps_prochandle_t ph, gdb_ps_addr_t addr,
            gdb_ps_write_buf_t buf, gdb_ps_size_t size)
 {
-  return rw_common (1, ph, addr, (char *) buf, size);
+  return rw_common (1, ph, addr, (gdb_byte *) buf, size);
 }
 
 /* Get general-purpose registers for LWP.  */