Remove preprocessor conditionals for ANSI-standard signals

The six signals SIGINT, SIGILL, SIGABRT, SIGFPE, SIGSEGV and SIGTERM
are ANSI-standard and thus guaranteed to be available.  This patch
removes all preprocessor conditionals relating to these symbols.

gdb/
2014-06-06  Gary Benson  <gbenson@redhat.com>

	* common/signals.c: Remove preprocessor conditionals for
	always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE,
	SIGSEGV and SIGTERM.
	* proc-events.c: Likewise.

gdb/testsuite/
2014-06-06  Gary Benson  <gbenson@redhat.com>

	* gdb.base/call-signals.c: Remove preprocessor conditionals
	for always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE,
	SIGSEGV and SIGTERM.
	* gdb.base/sigall.c: Likewise.
	* gdb.base/unwindonsignal.c: Likewise.
	* gdb.reverse/sigall-reverse.c: Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 458e218be829566d375379bbc0a2d814b1807e13..9d7ae825feac6788217e0a41891cf52e7576fdca 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2014-06-06  Gary Benson  <gbenson@redhat.com>
+
+       * common/signals.c: Remove preprocessor conditionals for
+       always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE,
+       SIGSEGV and SIGTERM.
+       * proc-events.c: Likewise.
+
 2014-06-06  Markus Metzger  <markus.t.metzger@intel.com>
 
        * symfile.c (symfile_free_objfile): Remove restriction to

diff --git a/gdb/common/signals.c b/gdb/common/signals.c
index 5e81356fb13dd72ae512a118a01cb6b4349c6a94..ea0c19a0c2ab52496f7937c7a2b8d39829164de1 100644 (file)
--- a/gdb/common/signals.c
+++ b/gdb/common/signals.c
@@ -131,34 +131,26 @@ gdb_signal_from_host (int hostsig)
   if (hostsig == SIGHUP)
     return GDB_SIGNAL_HUP;
 #endif
-#if defined (SIGINT)
   if (hostsig == SIGINT)
     return GDB_SIGNAL_INT;
-#endif
 #if defined (SIGQUIT)
   if (hostsig == SIGQUIT)
     return GDB_SIGNAL_QUIT;
 #endif
-#if defined (SIGILL)
   if (hostsig == SIGILL)
     return GDB_SIGNAL_ILL;
-#endif
 #if defined (SIGTRAP)
   if (hostsig == SIGTRAP)
     return GDB_SIGNAL_TRAP;
 #endif
-#if defined (SIGABRT)
   if (hostsig == SIGABRT)
     return GDB_SIGNAL_ABRT;
-#endif
 #if defined (SIGEMT)
   if (hostsig == SIGEMT)
     return GDB_SIGNAL_EMT;
 #endif
-#if defined (SIGFPE)
   if (hostsig == SIGFPE)
     return GDB_SIGNAL_FPE;
-#endif
 #if defined (SIGKILL)
   if (hostsig == SIGKILL)
     return GDB_SIGNAL_KILL;
@@ -167,10 +159,8 @@ gdb_signal_from_host (int hostsig)
   if (hostsig == SIGBUS)
     return GDB_SIGNAL_BUS;
 #endif
-#if defined (SIGSEGV)
   if (hostsig == SIGSEGV)
     return GDB_SIGNAL_SEGV;
-#endif
 #if defined (SIGSYS)
   if (hostsig == SIGSYS)
     return GDB_SIGNAL_SYS;
@@ -183,10 +173,8 @@ gdb_signal_from_host (int hostsig)
   if (hostsig == SIGALRM)
     return GDB_SIGNAL_ALRM;
 #endif
-#if defined (SIGTERM)
   if (hostsig == SIGTERM)
     return GDB_SIGNAL_TERM;
-#endif
 #if defined (SIGUSR1)
   if (hostsig == SIGUSR1)
     return GDB_SIGNAL_USR1;
@@ -388,34 +376,26 @@ do_gdb_signal_to_host (enum gdb_signal oursig,
     case GDB_SIGNAL_HUP:
       return SIGHUP;
 #endif
-#if defined (SIGINT)
     case GDB_SIGNAL_INT:
       return SIGINT;
-#endif
 #if defined (SIGQUIT)
     case GDB_SIGNAL_QUIT:
       return SIGQUIT;
 #endif
-#if defined (SIGILL)
     case GDB_SIGNAL_ILL:
       return SIGILL;
-#endif
 #if defined (SIGTRAP)
     case GDB_SIGNAL_TRAP:
       return SIGTRAP;
 #endif
-#if defined (SIGABRT)
     case GDB_SIGNAL_ABRT:
       return SIGABRT;
-#endif
 #if defined (SIGEMT)
     case GDB_SIGNAL_EMT:
       return SIGEMT;
 #endif
-#if defined (SIGFPE)
     case GDB_SIGNAL_FPE:
       return SIGFPE;
-#endif
 #if defined (SIGKILL)
     case GDB_SIGNAL_KILL:
       return SIGKILL;
@@ -424,10 +404,8 @@ do_gdb_signal_to_host (enum gdb_signal oursig,
     case GDB_SIGNAL_BUS:
       return SIGBUS;
 #endif
-#if defined (SIGSEGV)
     case GDB_SIGNAL_SEGV:
       return SIGSEGV;
-#endif
 #if defined (SIGSYS)
     case GDB_SIGNAL_SYS:
       return SIGSYS;
@@ -440,10 +418,8 @@ do_gdb_signal_to_host (enum gdb_signal oursig,
     case GDB_SIGNAL_ALRM:
       return SIGALRM;
 #endif
-#if defined (SIGTERM)
     case GDB_SIGNAL_TERM:
       return SIGTERM;
-#endif
 #if defined (SIGUSR1)
     case GDB_SIGNAL_USR1:
       return SIGUSR1;

diff --git a/gdb/proc-events.c b/gdb/proc-events.c
index 31812a9360022223081d212f7f2c4791c48d5eb1..9bd7b311f7f07ae0e4c0bd9cb70d027c3f3f6dd2 100644 (file)
--- a/gdb/proc-events.c
+++ b/gdb/proc-events.c
@@ -1404,39 +1404,29 @@ static struct trans signal_table[] =
 #ifdef SIGHUP
   { SIGHUP, "SIGHUP", "Hangup" },
 #endif
-#ifdef SIGINT
   { SIGINT, "SIGINT", "Interrupt (rubout)" },
-#endif
 #ifdef SIGQUIT
   { SIGQUIT, "SIGQUIT", "Quit (ASCII FS)" },
 #endif
-#ifdef SIGILL
   { SIGILL, "SIGILL", "Illegal instruction" }, /* not reset when caught */
-#endif
 #ifdef SIGTRAP
   { SIGTRAP, "SIGTRAP", "Trace trap" },                /* not reset when caught */
 #endif
-#ifdef SIGABRT
   { SIGABRT, "SIGABRT", "used by abort()" },   /* replaces SIGIOT */
-#endif
 #ifdef SIGIOT
   { SIGIOT, "SIGIOT", "IOT instruction" },
 #endif
 #ifdef SIGEMT
   { SIGEMT, "SIGEMT", "EMT instruction" },
 #endif
-#ifdef SIGFPE
   { SIGFPE, "SIGFPE", "Floating point exception" },
-#endif
 #ifdef SIGKILL
   { SIGKILL, "SIGKILL", "Kill" },      /* Solaris: cannot be caught/ignored */
 #endif
 #ifdef SIGBUS
   { SIGBUS, "SIGBUS", "Bus error" },
 #endif
-#ifdef SIGSEGV
   { SIGSEGV, "SIGSEGV", "Segmentation violation" },
-#endif
 #ifdef SIGSYS
   { SIGSYS, "SIGSYS", "Bad argument to system call" },
 #endif
@@ -1446,9 +1436,7 @@ static struct trans signal_table[] =
 #ifdef SIGALRM
   { SIGALRM, "SIGALRM", "Alarm clock" },
 #endif
-#ifdef SIGTERM
   { SIGTERM, "SIGTERM", "Software termination signal from kill" },
-#endif
 #ifdef SIGUSR1
   { SIGUSR1, "SIGUSR1", "User defined signal 1" },
 #endif

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index bc81a07a8090ddadab4c6537d6958e2409e8d1da..1b4d87f9ef00ed11e7e2e2d2ea2ad71e1d3baba0 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,12 @@
+2014-06-06  Gary Benson  <gbenson@redhat.com>
+
+       * gdb.base/call-signals.c: Remove preprocessor conditionals
+       for always-defined signals SIGINT, SIGILL, SIGABRT, SIGFPE,
+       SIGSEGV and SIGTERM.
+       * gdb.base/sigall.c: Likewise.
+       * gdb.base/unwindonsignal.c: Likewise.
+       * gdb.reverse/sigall-reverse.c: Likewise.
+
 2014-06-06  Yao Qi  <yao@codesourcery.com>
 
        * gdb.base/hbreak-unmapped.exp: Read memory at address 0.  If

diff --git a/gdb/testsuite/gdb.base/call-signals.c b/gdb/testsuite/gdb.base/call-signals.c
index 2d2bbf8eea5845abb9da488d9ecf7ad90f7e0e2b..c1d473df019ef55aed024f703523fd2742f43608 100644 (file)
--- a/gdb/testsuite/gdb.base/call-signals.c
+++ b/gdb/testsuite/gdb.base/call-signals.c
@@ -31,9 +31,7 @@ void
 gen_signal ()
 {
   /* According to sigall.exp, SIGABRT is always supported.  */
-#ifdef SIGABRT
   kill (getpid (), SIGABRT);
-#endif
   /* If we get here we couldn't generate a signal, tell dejagnu.  */
   printf ("no signal\n");
 }

diff --git a/gdb/testsuite/gdb.base/sigall.c b/gdb/testsuite/gdb.base/sigall.c
index 68f3ecbe41c6e4252c4b52b86417bd490de49e5f..7a7610e15f01b195c64c3369b21b5adaec880742 100644 (file)
--- a/gdb/testsuite/gdb.base/sigall.c
+++ b/gdb/testsuite/gdb.base/sigall.c
@@ -819,11 +819,7 @@ return 0;
 int
 gen_ILL ()
 {
-#ifdef SIGILL
   kill (getpid (), SIGILL);
-#else
-  handle_ILL (0);
-#endif
 return 0;
 }
 
@@ -874,11 +870,7 @@ return 0;
 int
 gen_SEGV ()
 {
-#ifdef SIGSEGV
   kill (getpid (), SIGSEGV);
-#else
-  handle_SEGV (0);
-#endif
 return 0;
 }
 
@@ -1050,7 +1042,7 @@ return 0;
 int
 gen_LOST ()
 {
-#if defined(SIGLOST) && (!defined(SIGABRT) || SIGLOST != SIGABRT)
+#if defined(SIGLOST) && SIGLOST != SIGABRT
   kill (getpid (), SIGLOST);
 #else
   handle_LOST (0);
@@ -1593,21 +1585,15 @@ main ()
 #ifdef SIGQUIT
   signal (SIGQUIT, handle_QUIT);
 #endif
-#ifdef SIGILL
   signal (SIGILL, handle_ILL);
-#endif
 #ifdef SIGEMT
   signal (SIGEMT, handle_EMT);
 #endif
-#ifdef SIGFPE
   signal (SIGFPE, handle_FPE);
-#endif
 #ifdef SIGBUS
   signal (SIGBUS, handle_BUS);
 #endif
-#ifdef SIGSEGV
   signal (SIGSEGV, handle_SEGV);
-#endif
 #ifdef SIGSYS
   signal (SIGSYS, handle_SYS);
 #endif
@@ -1653,7 +1639,7 @@ main ()
 #ifdef SIGWINCH
   signal (SIGWINCH, handle_WINCH);
 #endif
-#if defined(SIGLOST) && (!defined(SIGABRT) || SIGLOST != SIGABRT)
+#if defined(SIGLOST) && SIGLOST != SIGABRT
   signal (SIGLOST, handle_LOST);
 #endif
 #ifdef SIGUSR1

diff --git a/gdb/testsuite/gdb.base/unwindonsignal.c b/gdb/testsuite/gdb.base/unwindonsignal.c
index 5631e73da60c5684c5f1e92e93283cb980fcd6db..393a1ff44bb320acf6e169f5437030e203ae4c26 100644 (file)
--- a/gdb/testsuite/gdb.base/unwindonsignal.c
+++ b/gdb/testsuite/gdb.base/unwindonsignal.c
@@ -25,9 +25,7 @@ void
 gen_signal ()
 {
   /* According to sigall.exp, SIGABRT is always supported.  */
-#ifdef SIGABRT
   kill (getpid (), SIGABRT);
-#endif
   /* If we get here we couldn't generate a signal, tell dejagnu.  */
   printf ("no signal\n");
 }

diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.c b/gdb/testsuite/gdb.reverse/sigall-reverse.c
index ea7ae6a02bf21fe469baf5940f9c74abab2ee70b..6ccea424b65043ebf2119a3d9c6f85b3a252e4a4 100644 (file)
--- a/gdb/testsuite/gdb.reverse/sigall-reverse.c
+++ b/gdb/testsuite/gdb.reverse/sigall-reverse.c
@@ -410,11 +410,7 @@ return 0;
 int
 gen_ILL (void)
 {
-#ifdef SIGILL
   kill (getpid (), SIGILL);
-#else
-  handle_ILL (0);
-#endif
 return 0;
 }
 
@@ -465,11 +461,7 @@ return 0;
 int
 gen_SEGV (void)
 {
-#ifdef SIGSEGV
   kill (getpid (), SIGSEGV);
-#else
-  handle_SEGV (0);
-#endif
 return 0;
 }
 
@@ -641,7 +633,7 @@ return 0;
 int
 gen_LOST (void)
 {
-#if defined(SIGLOST) && (!defined(SIGABRT) || SIGLOST != SIGABRT)
+#if defined(SIGLOST) && SIGLOST != SIGABRT
   kill (getpid (), SIGLOST);
 #else
   handle_LOST (0);
@@ -1183,21 +1175,15 @@ main ()
 #ifdef SIGQUIT
   signal (SIGQUIT, handle_QUIT);
 #endif
-#ifdef SIGILL
   signal (SIGILL, handle_ILL);
-#endif
 #ifdef SIGEMT
   signal (SIGEMT, handle_EMT);
 #endif
-#ifdef SIGFPE
   signal (SIGFPE, handle_FPE);
-#endif
 #ifdef SIGBUS
   signal (SIGBUS, handle_BUS);
 #endif
-#ifdef SIGSEGV
   signal (SIGSEGV, handle_SEGV);
-#endif
 #ifdef SIGSYS
   signal (SIGSYS, handle_SYS);
 #endif
@@ -1243,7 +1229,7 @@ main ()
 #ifdef SIGWINCH
   signal (SIGWINCH, handle_WINCH);
 #endif
-#if defined(SIGLOST) && (!defined(SIGABRT) || SIGLOST != SIGABRT)
+#if defined(SIGLOST) && SIGLOST != SIGABRT
   signal (SIGLOST, handle_LOST);
 #endif
 #ifdef SIGUSR1