Style: correct pep8 errors

diff --git a/linuxautomaton/linuxautomaton/irq.py b/linuxautomaton/linuxautomaton/irq.py
index 25476557896791fc906561a6cd76cf78e73d2006..f669b48e6f6740ade2586cb93bca450d9dcbfe10 100644 (file)
--- a/linuxautomaton/linuxautomaton/irq.py
+++ b/linuxautomaton/linuxautomaton/irq.py
@@ -55,8 +55,7 @@ class IrqStateProvider(sp.StateProvider):
 
         self.state._send_notification_cb('irq_handler_entry',
                                          id=irq.id,
-                                         irq_name=event['name']
-        )
+                                         irq_name=event['name'])
 
     def _process_irq_handler_exit(self, event):
         cpu = self._get_cpu(event['cpu_id'])
@@ -112,6 +111,5 @@ class IrqStateProvider(sp.StateProvider):
 
         cpu.current_softirqs[vec][0].stop_ts = event.timestamp
         self.state._send_notification_cb('softirq_exit',
-                                         softirq=cpu.current_softirqs[vec][0]
-        )
+                                         softirq=cpu.current_softirqs[vec][0])
         cpu.current_softirqs[vec].pop(0)

diff --git a/linuxautomaton/linuxautomaton/syscalls.py b/linuxautomaton/linuxautomaton/syscalls.py
index ddbcd25a5f81cc32e0e1b2fe0d4881b4150bbce8..77022e7e0c8a223790ba55dd74d8f8ef8ab666b5 100644 (file)
--- a/linuxautomaton/linuxautomaton/syscalls.py
+++ b/linuxautomaton/linuxautomaton/syscalls.py
@@ -432,7 +432,7 @@ class SyscallsStateProvider(sp.StateProvider):
 
     def _per_tid_syscall_exit(self, name, ret, event, c):
         t = self.tids[c.current_tid]
-        if not name in t.syscalls:
+        if name not in t.syscalls:
             return
         s = sv.SyscallEvent()
         s.ret = ret

diff --git a/lttnganalyses/lttnganalyses/analysis.py b/lttnganalyses/lttnganalyses/analysis.py
index 941a2ef65e73221db93da51515c862a7f3655b55..b1eea6f96ab1de27917703699721d822dc8e783b 100644 (file)
--- a/lttnganalyses/lttnganalyses/analysis.py
+++ b/lttnganalyses/lttnganalyses/analysis.py
@@ -36,7 +36,7 @@ class Analysis:
         if name in self._cbs:
             self._cbs[name](ev)
         elif 'syscall_entry' in self._cbs and \
-        (name.startswith('sys_') or name.startswith('syscall_entry_')):
+             (name.startswith('sys_') or name.startswith('syscall_entry_')):
             self._cbs['syscall_entry'](ev)
         elif 'syscall_exit' in self._cbs and \
                 (name.startswith('exit_syscall') or

diff --git a/lttnganalyses/lttnganalyses/irq.py b/lttnganalyses/lttnganalyses/irq.py
index d47673d1483acae60121a52de3ee80ebc5b7a9c7..78be5a911493e6b3aee9cb8d8375d17764581755 100644 (file)
--- a/lttnganalyses/lttnganalyses/irq.py
+++ b/lttnganalyses/lttnganalyses/irq.py
@@ -156,11 +156,11 @@ class SoftIrqStats(IrqStats):
 
         raise_latency = irq.start_ts - irq.raise_ts
         if self.min_raise_latency is None or \
-        raise_latency < self.min_raise_latency:
+           raise_latency < self.min_raise_latency:
             self.min_raise_latency = raise_latency
 
         if self.max_raise_latency is None or \
-        raise_latency > self.max_raise_latency:
+           raise_latency > self.max_raise_latency:
             self.max_raise_latency = raise_latency
 
         self.total_raise_latency += raise_latency

diff --git a/lttnganalysescli/lttnganalysescli/cputop.py b/lttnganalysescli/lttnganalysescli/cputop.py
index 97b50468d86cfbc8f3de05f2314a59e616e29edf..0ecc9d7390c3a5fce9b9eaf70b9f015cc9b65b00 100644 (file)
--- a/lttnganalysescli/lttnganalysescli/cputop.py
+++ b/lttnganalysescli/lttnganalysescli/cputop.py
@@ -94,7 +94,6 @@ class Cputop(Command):
         self._reset_total(end)
 
     def _print_results(self, begin_ns, end_ns):
-#        print('event count: {}'.format(self._analysis.event_count))
         count = 0
         limit = self._arg_limit
         total_ns = end_ns - begin_ns

diff --git a/lttnganalysescli/lttnganalysescli/irq.py b/lttnganalysescli/lttnganalysescli/irq.py
index 5f5116073edfc0377627ba06c608a3badcb058c5..932d6c1729c6d10e817220ff6249d4d65cbf6eff 100644 (file)
--- a/lttnganalysescli/lttnganalysescli/irq.py
+++ b/lttnganalysescli/lttnganalysescli/irq.py
@@ -165,7 +165,7 @@ class IrqAnalysisCommand(Command):
                 return str(irq.id) in self._arg_irq_filter_list
             if self._arg_softirq_filter_list:
                 return False
-        else: # SoftIRQ
+        else:  # SoftIRQ
             if self._arg_softirq_filter_list:
                 return str(irq.id) in self._arg_softirq_filter_list
             if self._arg_irq_filter_list:
@@ -202,7 +202,8 @@ class IrqAnalysisCommand(Command):
                                                     self._arg_multi_day,
                                                     self._arg_gmt),
                              '%0.03f' % ((irq.stop_ts - irq.start_ts) / 1000),
-                             '%d' % irq.cpu_id, irqtype, irq.id, name + raise_ts))
+                             '%d' % irq.cpu_id, irqtype, irq.id,
+                             name + raise_ts))
 
     def _print_irq_stats(self, irq_stats, filter_list, header):
         header_printed = False
@@ -337,8 +338,8 @@ class IrqAnalysisCommand(Command):
             )
             header += '-' * 82 + '|' + '-' * 60
             self._print_irq_stats(self._analysis.softirq_stats,
-                                 self._arg_softirq_filter_list,
-                                 header)
+                                  self._arg_softirq_filter_list,
+                                  header)
 
     def _compute_stats(self):
         pass

diff --git a/lttnganalysescli/lttnganalysescli/memtop.py b/lttnganalysescli/lttnganalysescli/memtop.py
index 8d1a73c38989350042afaa9e7680b10bcc61fac9..82ee005f35c31bd2be4ab9366f881b28a6944da3 100644 (file)
--- a/lttnganalysescli/lttnganalysescli/memtop.py
+++ b/lttnganalysescli/lttnganalysescli/memtop.py
@@ -147,7 +147,7 @@ class Memtop(Command):
             freed += tid.freed_pages
 
         print('\nTotal memory usage:\n- %d pages allocated\n- %d pages freed' %
-             (alloc, freed))
+              (alloc, freed))
 
     def _add_arguments(self, ap):
         # specific argument

diff --git a/parser_generator.py b/parser_generator.py
index 2f6ce0a488c77f9d6d2b0a50a3ec8c983fbffa78..8558ec603b7278befafa113c1e3df3b1daa69d38 100755 (executable)
--- a/parser_generator.py
+++ b/parser_generator.py
@@ -124,7 +124,7 @@ def gen_parser(handle, fd, args):
             fd.write("\n        self.event_count[event.name] += 1\n")
             if not args.quiet:
                 fd.write("        print(\"%s }\" %% (%s))\n\n" %
-                        (fmt_str[0:-2], fmt_fields[0:-1]))
+                         (fmt_str[0:-2], fmt_fields[0:-1]))
 
 
 if __name__ == "__main__":