[gdb/testsuite] Fix gdb_target_cmd

In commit 81dc3ab594 "[gdb/testsuite] Handle unreachable network in
server-connect.exp" a regression was introduced in gdb_target_cmd, causing
ERRORs like this:
...
ERROR: tcl error sourcing src/gdb/testsuite/gdb.server/abspath.exp.
ERROR: wrong # args: should be "gdb_target_cmd {$args}"
    while executing
"gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport"
...

Fix the argument passing in gdb_target_cmd.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2019-09-19  Tom de Vries  <tdevries@suse.de>

	* lib/gdbserver-support.exp (gdb_target_cmd): Fix argument passing.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 2acc1f734232b422fc906902a8b8a4df6fd04bac..d5a5309fdf36253ee7de99235bba6fdc63b5b6a8 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2019-09-19  Tom de Vries  <tdevries@suse.de>
+
+       * lib/gdbserver-support.exp (gdb_target_cmd): Fix argument passing.
+
 2019-09-19  Tom de Vries  <tdevries@suse.de>
 
        * lib/gdbserver-support.exp (gdb_target_cmd_ext): Return 2 (meaning

diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp
index 2ad53c1f6086a863254bc245a7d70be436c5b690..00f46c82649914b803408f180fc4fedfcff6d690 100644 (file)
--- a/gdb/testsuite/lib/gdbserver-support.exp
+++ b/gdb/testsuite/lib/gdbserver-support.exp
@@ -112,8 +112,8 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } {
 
 # Like gdb_target_cmd_ext, but returns 0 on success, 1 on failure.
 
-proc gdb_target_cmd { $args } {
-    set res [gdb_target_cmd_ext $args]
+proc gdb_target_cmd { args } {
+    set res [eval gdb_target_cmd_ext $args]
     return [expr $res == 0 ? 0 : 1]
 }