cp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.

gdb/ChangeLog:

	* cp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1c79b3366c7d9522c6902d7316a7c514180db436..ccad5edd3f36c1cb85cd22de7199f1b564292e81 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2014-12-22  Doug Evans  <xdje42@gmail.com>
+
+       * cp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.
+
 2014-12-22  Doug Evans  <xdje42@gmail.com>
 
        * cp-namespace.c: Whitespace cleanup.

diff --git a/gdb/cp-namespace.c b/gdb/cp-namespace.c
index bcb2275ff385211391de29532ad9b1569f3fb2dc..b3ecffbb5e47db124b43494db81ed923aeb522eb 100644 (file)
--- a/gdb/cp-namespace.c
+++ b/gdb/cp-namespace.c
@@ -317,21 +317,20 @@ cp_lookup_symbol_in_namespace (const char *namespace,
                                const struct block *block,
                                const domain_enum domain, int search)
 {
-  if (namespace[0] == '\0')
-    {
-      return lookup_symbol_file (name, block, domain, 0, search);
-    }
-  else
-    {
-      char *concatenated_name = alloca (strlen (namespace) + 2
-                                       + strlen (name) + 1);
+  char *concatenated_name = NULL;
+  int is_anonymous = namespace[0] != '\0' && cp_is_in_anonymous (namespace);
 
+  if (namespace[0] != '\0')
+    {
+      concatenated_name = alloca (strlen (namespace) + 2
+                                 + strlen (name) + 1);
       strcpy (concatenated_name, namespace);
       strcat (concatenated_name, "::");
       strcat (concatenated_name, name);
-      return lookup_symbol_file (concatenated_name, block, domain,
-                                cp_is_in_anonymous (namespace), search);
+      name = concatenated_name;
     }
+
+  return lookup_symbol_file (name, block, domain, is_anonymous, search);
 }
 
 /* Used for cleanups to reset the "searched" flag incase