-Wpointer-sign: coff-pe-read.c: treat strings in PE/COFF data as char *.

A couple places take a pointer to the middle of some raw section
buffer and treat them as strings.  Add casts to char * as appropriate,
fixing -Wpointer-sign warnings.

gdb/
2013-04-19  Pedro Alves  <palves@redhat.com>

	* coff-pe-read.c (read_pe_exported_syms): Handle strings as char.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6e6cf671161c03e5472345e6e73b15f0d9403472..47a8ac2c188992e77643a1732ae68b0b4652d39d 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
+       * coff-pe-read.c (read_pe_exported_syms): Handle strings as char.
+
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
        * record-full.c (record_full_get_bookmark): Change local 'ret'

diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c
index 8961c7816217d21ef7e87b8a3d3a08a4439d7ac0..91ee3f60dcb76b98b49fa357ca5845cc4a4a81e9 100644 (file)
--- a/gdb/coff-pe-read.c
+++ b/gdb/coff-pe-read.c
@@ -505,7 +505,7 @@ read_pe_exported_syms (struct objfile *objfile)
   exp_funcbase = pe_as32 (expdata + 28);
 
   /* Use internal dll name instead of full pathname.  */
-  dll_name = pe_as32 (expdata + 12) + erva;
+  dll_name = (char *) (pe_as32 (expdata + 12) + erva);
 
   pe_sections_info.nb_sections = otherix;
   pe_sections_info.sections = section_data;
@@ -579,9 +579,10 @@ read_pe_exported_syms (struct objfile *objfile)
          if ((func_rva >= section_data[sectix].rva_start)
              && (func_rva < section_data[sectix].rva_end))
            {
+             char *sym_name = (char *) (erva + name_rva);
+
              section_found = 1;
-             add_pe_exported_sym (erva + name_rva,
-                                  func_rva, ordinal,
+             add_pe_exported_sym (sym_name, func_rva, ordinal,
                                   section_data + sectix, dll_name, objfile);
              ++nbnormal;
              break;