Improve "'g' reply is is to long" error message

... by adding the expected size, and the received size.  I found this
useful when debugging gdbarch/remote issues, since it gives a hint of
what gdb expects and what the remote sent.

gdb/ChangeLog:

	* remote.c (process_g_packet): Update error message.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3ba07ce5f8f9d9adbe58aab0651b4417ed5d3876..27922083662c3131e744a0d9583a641e736ead63 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-05  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * remote.c (process_g_packet): Update error message.
+
 2017-09-05  Yao Qi  <yao.qi@linaro.org>
 
        * configure.tgt (gdb_target_obs): Add i386.o for x86_64-*

diff --git a/gdb/remote.c b/gdb/remote.c
index 3347dd8022b9b4669d0dc5aaf23373eb94bc1c37..abeef0d9fd025359869e401da198df6dfb4c3d69 100644 (file)
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7591,7 +7591,8 @@ process_g_packet (struct regcache *regcache)
 
   /* Further sanity checks, with knowledge of the architecture.  */
   if (buf_len > 2 * rsa->sizeof_g_packet)
-    error (_("Remote 'g' packet reply is too long: %s"), rs->buf);
+    error (_("Remote 'g' packet reply is too long (expected %ld bytes, got %d "
+            "bytes): %s"), rsa->sizeof_g_packet, buf_len / 2, rs->buf);
 
   /* Save the size of the packet sent to us by the target.  It is used
      as a heuristic when determining the max size of packets that the