From: Francis Deslauriers Date: Wed, 4 Jul 2012 13:15:25 +0000 (-0400) Subject: Several fixes for bt_iter_pos related functions X-Git-Tag: v1.0.0-rc5~50 X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;ds=sidebyside;h=5acdc773a649e8fe104cc0e3647b568280c58f05;hp=5acdc773a649e8fe104cc0e3647b568280c58f05;p=babeltrace.git Several fixes for bt_iter_pos related functions Add verification so we free the array only if iterator is of type BT_SEEK_RESTORE Add return statement at the end of case Set type of bt_iter_pos returned by bt_iter_get_pos [ Mathieu Desnoyers edit: check the iter_pos->type before the restore pointer in bt_iter_free_pos. The && operator is a sequence point, so the first check is done before the second. Since we might not be using the union for restore if type != BT_SEEK_RESTORE, check the type first before accessing the (possibly wrong) union field. ] Signed-off-by: Francis Deslauriers Signed-off-by: Julien Desfossez Signed-off-by: Mathieu Desnoyers ---