From: Matthew Khouzam <matthew.khouzam@ericsson.com>
Date: Tue, 12 Jan 2016 03:42:01 +0000 (-0500)
Subject: ctf: remove StructDeclaration#getFields()
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=03a3d600d1ba158d9e459dc9c094d70b0e6334f5;p=deliverable%2Ftracecompass.git

ctf: remove StructDeclaration#getFields()

this exposes an internal map and can be dangerous

Change-Id: Icc1d5ecbd7d5dc5eab472b314669312ffe26a8a6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64118
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
---

diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDeclaration.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDeclaration.java
index 733bd22ef0..83fb2e2198 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDeclaration.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDeclaration.java
@@ -92,15 +92,6 @@ public class StructDeclaration extends Declaration {
         return fFieldMap.containsKey(name);
     }
 
-    /**
-     * Get the fields of the struct as a map.
-     *
-     * @return a Map of the fields (key is the name)
-     */
-    public Map<String, IDeclaration> getFields() {
-        return fFieldMap;
-    }
-
     /**
      * Get the field declaration corresponding to a field name.
      *
diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeSpecifierListParser.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeSpecifierListParser.java
index 29712309d8..b21ab57bea 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeSpecifierListParser.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/TypeSpecifierListParser.java
@@ -127,7 +127,7 @@ public final class TypeSpecifierListParser extends AbstractScopedCommonTreeParse
         case CTFParser.STRUCT:
             declaration = StructParser.INSTANCE.parse(firstChild, new StructParser.Param(trace, identifier, scope));
             StructDeclaration structDeclaration = (StructDeclaration) declaration;
-            IDeclaration idEnumDecl = structDeclaration.getFields().get("id"); //$NON-NLS-1$
+            IDeclaration idEnumDecl = structDeclaration.getField("id"); //$NON-NLS-1$
             if (idEnumDecl instanceof EnumDeclaration) {
                 EnumDeclaration enumDeclaration = (EnumDeclaration) idEnumDecl;
                 ByteOrder bo = enumDeclaration.getContainerType().getByteOrder();
diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/trace/TraceDeclarationParser.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/trace/TraceDeclarationParser.java
index c9a8b0e650..cce4a19423 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/trace/TraceDeclarationParser.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/metadata/tsdl/trace/TraceDeclarationParser.java
@@ -274,7 +274,7 @@ public final class TraceDeclarationParser extends AbstractScopedCommonTreeParser
                             decl.isSigned(), decl.getBase(), byteOrder,
                             decl.getEncoding(), decl.getClock(),
                             decl.getAlignment());
-                    sd.getFields().put(s, newI);
+                    sd.addField(s, newI);
                 }
             }
         }