From: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Date: Mon, 23 Nov 2015 21:19:55 +0000 (-0500)
Subject: tmf : Avoid concatenating nonliterals in a StringBuffer
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=0d57407a724dd170a2ce32a442ab4af70bd5293d;p=deliverable%2Ftracecompass.git

tmf : Avoid concatenating nonliterals in a StringBuffer

Change-Id: Idc6a9804bc5f2b101a8ada406d7bbd362c1161c5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61072
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
---

diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/parsers/custom/CustomXmlTrace.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/parsers/custom/CustomXmlTrace.java
index 8df4b1b105..6dac5bcc3d 100644
--- a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/parsers/custom/CustomXmlTrace.java
+++ b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/parsers/custom/CustomXmlTrace.java
@@ -458,7 +458,9 @@ public class CustomXmlTrace extends TmfTrace implements ITmfPersistentlyIndexabl
                 if (!element.hasChildNodes()) {
                     buffer.append(element.getNodeName());
                 } else if (element.getChildNodes().getLength() == 1 && element.getFirstChild().getNodeType() == Node.TEXT_NODE) {
-                    buffer.append(element.getNodeName() + ":" + element.getFirstChild().getNodeValue().trim()); //$NON-NLS-1$
+                    buffer.append(element.getNodeName());
+                    buffer.append(':');
+                    buffer.append(element.getFirstChild().getNodeValue().trim());
                 } else {
                     buffer.append(element.getNodeName());
                     buffer.append(" [ "); //$NON-NLS-1$