From: Alan Modra <amodra@gmail.com>
Date: Thu, 26 Dec 2019 05:34:20 +0000 (+1030)
Subject: ubsan: crx: index 5 out of bounds for type 'operand_desc const[5]'
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=100b122fc125bdf1fe768a3331a0cd413c3d1261;p=deliverable%2Fbinutils-gdb.git

ubsan: crx: index 5 out of bounds for type 'operand_desc const[5]'

	* crx-dis.c (get_number_of_operands): Don't access operands[]
	out of bounds.
---

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 07f30e27d6..25c29b235c 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-26  Alan Modra  <amodra@gmail.com>
+
+	* crx-dis.c (get_number_of_operands): Don't access operands[]
+	out of bounds.
+
 2019-12-26  Alan Modra  <amodra@gmail.com>
 
 	* v850-dis.c (disassemble): Avoid signed overflow.  Don't use
diff --git a/opcodes/crx-dis.c b/opcodes/crx-dis.c
index 3834748616..e44fca1111 100644
--- a/opcodes/crx-dis.c
+++ b/opcodes/crx-dis.c
@@ -105,7 +105,7 @@ get_number_of_operands (void)
 {
   int i;
 
-  for (i = 0; instruction->operands[i].op_type && i < MAX_OPERANDS; i++)
+  for (i = 0; i < MAX_OPERANDS && instruction->operands[i].op_type; i++)
     ;
 
   return i;