From: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Date: Wed, 28 Oct 2015 15:40:39 +0000 (-0400)
Subject: analysis: avoid division by 0 in latency statistics
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=1198ba6ea1acc85f83b6bd99827fbb995a256a14;p=deliverable%2Ftracecompass.git

analysis: avoid division by 0 in latency statistics

Change-Id: Iaa30a5989517777b37aa4b7b21b5c4da025dcec9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59133
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
---

diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/statistics/AbstractSegmentStoreStatisticsViewer.java b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/statistics/AbstractSegmentStoreStatisticsViewer.java
index ba8fd85946..128bb8878c 100644
--- a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/statistics/AbstractSegmentStoreStatisticsViewer.java
+++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui/src/org/eclipse/tracecompass/internal/analysis/os/linux/ui/views/latency/statistics/AbstractSegmentStoreStatisticsViewer.java
@@ -72,17 +72,18 @@ public abstract class AbstractSegmentStoreStatisticsViewer extends AbstractTmfTr
                 if (columnIndex == 0) {
                     value = ((HiddenTreeViewerEntry) element).getName();
                 }
-            } else {
-                LatencyTreeViewerEntry obj = (LatencyTreeViewerEntry) element;
-                if (obj != null) {
-                    if (columnIndex == 0) {
-                        value = String.valueOf(obj.getName());
-                    } else if (columnIndex == 1) {
-                        value = toFormattedString(obj.getEntry().getMin());
+            } else if (element instanceof LatencyTreeViewerEntry) {
+                LatencyTreeViewerEntry entry = (LatencyTreeViewerEntry) element;
+                if (columnIndex == 0) {
+                    return checkNotNull(String.valueOf(entry.getName()));
+                }
+                if (entry.getEntry().getNbSegments() > 0) {
+                    if (columnIndex == 1) {
+                        value = toFormattedString(entry.getEntry().getMin());
                     } else if (columnIndex == 2) {
-                        value = String.valueOf(toFormattedString(obj.getEntry().getMax()));
+                        value = String.valueOf(toFormattedString(entry.getEntry().getMax()));
                     } else if (columnIndex == 3) {
-                        value = String.valueOf(toFormattedString(obj.getEntry().getAverage()));
+                        value = String.valueOf(toFormattedString(entry.getEntry().getAverage()));
                     }
                 }
             }