From: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Date: Mon, 23 Nov 2015 20:50:21 +0000 (-0500)
Subject: tmf : Avoid concatenating nonliterals in a StringBuilder
X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=5e1ee19ae9809908fed1422fb2b8196d35bd6ad8;p=deliverable%2Ftracecompass.git

tmf : Avoid concatenating nonliterals in a StringBuilder

Split the append() call in two lines

Change-Id: Icd7b69f793bf8a19b44b89d8506981cfbad38ddb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61069
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
---

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/parsers/wizards/CustomXmlParserInputWizardPage.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/parsers/wizards/CustomXmlParserInputWizardPage.java
index 853df7979b..dee6739462 100644
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/parsers/wizards/CustomXmlParserInputWizardPage.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/internal/tmf/ui/parsers/wizards/CustomXmlParserInputWizardPage.java
@@ -725,7 +725,8 @@ public class CustomXmlParserInputWizardPage extends WizardPage {
                 StringBuilder sb = new StringBuilder();
                 String line = null;
                 while ((line = reader.readLine()) != null) {
-                    sb.append(line + "\n"); //$NON-NLS-1$
+                    sb.append(line);
+                    sb.append('\n');
                 }
                 parseXmlInput(sb.toString());
                 return sb.toString();