From: Tom Tromey Date: Thu, 28 Nov 2019 03:42:57 +0000 (-0700) Subject: Make two range_bounds bitfields unsigned X-Git-Url: http://git.efficios.com/?a=commitdiff_plain;h=bab05c83ac4333bb087a41f843af0e66218ec054;p=deliverable%2Fbinutils-gdb.git Make two range_bounds bitfields unsigned While debugging gdb, I noticed that the bitfields in a range_bounds were signed, causing the values of these fields to be -1. I think this is odd; and while we haven't yet committed to boolean bitfields, I think it is a small improvement to change these types to unsigned. gdb/ChangeLog 2019-11-28 Tom Tromey * gdbtypes.h (struct range_bounds) : Now unsigned. Change-Id: Ia377fd931594bbf8653180d4dcb4e60354d90139 --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ce8286af98..c777def757 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-11-28 Tom Tromey + + * gdbtypes.h (struct range_bounds) : Now unsigned. + 2019-11-28 Tom Tromey * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 8fc770c5d3..2e128aae06 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -631,12 +631,12 @@ struct range_bounds /* True if HIGH range bound contains the number of elements in the subrange. This affects how the final high bound is computed. */ - int flag_upper_bound_is_count : 1; + unsigned int flag_upper_bound_is_count : 1; /* True if LOW or/and HIGH are resolved into a static bound from a dynamic one. */ - int flag_bound_evaluated : 1; + unsigned int flag_bound_evaluated : 1; }; /* Compare two range_bounds objects for equality. Simply does