deliverable/tracecompass.git
8 years agotmf : Introduce pattern segment and pattern segment builder
Jean-Christian Kouame [Wed, 16 Dec 2015 16:29:10 +0000 (11:29 -0500)] 
tmf : Introduce pattern segment and pattern segment builder

The pattern segments are generated using an XML description. They will
be generated by the XML pattern matching analysis and could be used to
feed views such as the timing analysis views.

Change-Id: I366cf8fa4344c05e0067a61dd1e0f720b18d51a3
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62873
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Add properties to the state system analyses
Geneviève Bastien [Wed, 27 Jan 2016 04:17:27 +0000 (23:17 -0500)] 
tmf: Add properties to the state system analyses

Change-Id: I91b9a583fd269c1f8d2de72dc517dce2ab2cf2d8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65228
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Add XML analysis helper properties
Geneviève Bastien [Wed, 27 Jan 2016 03:36:22 +0000 (22:36 -0500)] 
tmf: Add XML analysis helper properties

Change-Id: I35eeb288a97071930c01dedd449a54161512032b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65227
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Set redraw false also for when refreshing the CFV
Bernd Hufmann [Wed, 10 Feb 2016 18:50:20 +0000 (13:50 -0500)] 
tmf: Set redraw false also for when refreshing the CFV

This avoids a flickering in Windows.

Change-Id: I28732f4a11e87a6e25b77e9cc7c056b5e991c2c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66337
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agotmf: bug 486053 Add the possibility for analyses to provide properties
Geneviève Bastien [Wed, 27 Jan 2016 03:17:14 +0000 (22:17 -0500)] 
tmf: bug 486053 Add the possibility for analyses to provide properties

Change-Id: I29058e50f71509c214f7d2a11cede4ca89b5a93c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65226
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoanalysis: Update CpuUsageView to use new TmfChartView API
Bernd Hufmann [Mon, 15 Feb 2016 19:10:21 +0000 (14:10 -0500)] 
analysis: Update CpuUsageView to use new TmfChartView API

Also add some null annotations and checks.

Change-Id: I73f962d19f34fe1e2eb485c5418b7c1458c7b4d6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66641
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoNew method for specifying left child composite in TmfChartView
Samuel Gagnon [Sun, 14 Feb 2016 20:24:25 +0000 (15:24 -0500)] 
New method for specifying left child composite in TmfChartView

TmfChartView creates an empty composite to fill space at the
left of its graph. This commit adds a new method to allow classes
that extend the TmfChartView to create a TmfViewer to replace the
default empty composite.

Change-Id: Ie603e1cbabc27d9dc95389489d0bc2e401971a1d
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66571
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf.ui: only start zooming if we are in the time graph area of a time graph.
Matthew Khouzam [Mon, 15 Feb 2016 19:48:10 +0000 (14:48 -0500)] 
tmf.ui: only start zooming if we are in the time graph area of a time graph.

Ignore zoom operations in the "namespace" area.

Change-Id: Ib9398cce255112a598e02e8e3c01002b10548c61
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66650
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Fix some tests not working in different time zones
Marc-Andre Laperle [Sat, 13 Feb 2016 15:23:01 +0000 (16:23 +0100)] 
tmf: Fix some tests not working in different time zones

Also print the timezone at the start of test to help troubleshoot
if it happens on a server.

Change-Id: I4cd10054f4c767a4089e17447089e401ade19b6e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66579
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Close Sequence Diagram view after tests
Marc-Andre Laperle [Sat, 13 Feb 2016 11:12:20 +0000 (12:12 +0100)] 
tmf: Close Sequence Diagram view after tests

If the test ran first then the perspective checker test second,
the perspective test failed.

Change-Id: Ia9c07855a8aca5a7a7f4e8960736b1e64c6b1e95
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66578
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoss: Bug 486689: Add methods for getting an optional attribute quark
Patrick Tasse [Wed, 27 Jan 2016 22:15:24 +0000 (17:15 -0500)] 
ss: Bug 486689: Add methods for getting an optional attribute quark

Change AttributeTree.getQuarkDontAdd() to return -1 instead of throwing
an AttributeNotFoundException.

Add methods optQuarkAbsolute() and optQuarkRelative() to the
ITmfStateSystem API.

Define and use quark constants ROOT_ATTRIBUTE and INVALID_ATTRIBUTE.

Use the new methods in the implementation of StateSystem.getQuarks().

Change-Id: I9f28e8aa8f3ba7377bebf8a5e8042ae7675aecab
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65328
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis.graph: Fix getHead() to return the earliest vertex
Geneviève Bastien [Thu, 11 Feb 2016 17:39:24 +0000 (12:39 -0500)] 
analysis.graph: Fix getHead() to return the earliest vertex

Instead of returning the first vertex of the first element, make sure it
returns the earliest vertex.

Change-Id: I4c29fa02f97128ca80e8510560c8ae5512f3d72c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66418
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis.os: add more complete tests to the CPU usage analysis
Geneviève Bastien [Wed, 10 Feb 2016 21:10:12 +0000 (16:10 -0500)] 
analysis.os: add more complete tests to the CPU usage analysis

It uses the state system unit test utility methods to allow more
complete testing of the CPU usage analysis resulting state system.

Change-Id: Ic31c7ff94e42c51862a1cafdc77e2d9f053b9c04
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66404
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agostatesystem: Add utility methods to help unit test state systems
Geneviève Bastien [Tue, 2 Feb 2016 20:21:42 +0000 (15:21 -0500)] 
statesystem: Add utility methods to help unit test state systems

These methods and classes can be used to easily unit test the intervals
for an attribute for the duration of the tree, or the values of many attributes
at a given timestamp.

Change-Id: I3eb9fc8bdc1d2ba8a388c9e0f979b506a60e3ae1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66403
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agotmf : Fix potential null pointer dereference in XmlUtils
Jean-Christian Kouame [Wed, 10 Feb 2016 20:37:12 +0000 (15:37 -0500)] 
tmf : Fix potential null pointer dereference in XmlUtils

There is a possible null pointer exception that would have happened if
I/O errors occur.

Change-Id: I89bde3aaf4d82c71fb46fe6b4e9720603ad481bf
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66347
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Ignore xml analysis files not having xml file extension
Bernd Hufmann [Tue, 9 Feb 2016 18:46:37 +0000 (13:46 -0500)] 
tmf: Ignore xml analysis files not having xml file extension

Change-Id: If9261146b9fd8d03cb9cbd66e12a166f130b17b4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66240
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoanalysis.timing: make AbstractSegmentStoreAnalysisModule more generic
Matthew Khouzam [Fri, 29 Jan 2016 22:48:51 +0000 (17:48 -0500)] 
analysis.timing: make AbstractSegmentStoreAnalysisModule more generic

No longer expect a file, so in memory analyses are supported.
No longer refer to its segment store as syscalls.

Change-Id: I029c1e77b9a107836d27288936b94d73e00c65fb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65502
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoanalysis: Bug 487388: Fix intermittent SWTBot test failure
Bernd Hufmann [Mon, 8 Feb 2016 14:35:13 +0000 (09:35 -0500)] 
analysis: Bug 487388: Fix intermittent SWTBot test failure

The intermittent failure is due to the issue with the process having
the wrong parent which patch tried to fix:
https://git.eclipse.org/r/#/c/65024/

In the filter dialog the number of processes checked varies due the
issue above. So, when checking the value it might fail from time to
time. However, this is irrelevant to this test class and doesn't need
to be verified. The Filter dialog is tested elsewhere and doesn't need
to be verified in this test (see ControlFlowViewTest).

Change-Id: Ib48ff75e8ffc029f1e814e163369d64ed80916c7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66124
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf: Ignore invalid clock description elements
Alexandre Montplaisir [Mon, 8 Feb 2016 21:45:28 +0000 (16:45 -0500)] 
ctf: Ignore invalid clock description elements

The clock "offset" element is supposed to be signed integer constant[1].
LTTng uses 64-bit integers for this, however there is a bug with current
versions where this can be set to values above 2^63.

Right now Trace Compass refuses to open the trace and reports the
invalid value as a CTF error. We could accomodate and still load these
traces, ignoring the invalid definitions.

[1] This is not explicitly mentionned in the spec, but it was discuted
    with the spec's authors, and it should be updated in the future.

Change-Id: I44fc4f4b90c1c9f046c03d83d63cea2fee8bb57f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66159
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis: Show thread priority in critical path view
Geneviève Bastien [Tue, 9 Feb 2016 03:21:33 +0000 (22:21 -0500)] 
analysis: Show thread priority in critical path view

This effectively allows the critical path to become a priority
inversion explorer too.

Note: Priority inversions should not happen in modern OSes. But
users can badly set their thread priority. This patch highlights
that error.

Change-Id: I4db2f5b69329a0b868758a35f15ee6cfc13fa43c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66063
Reviewed-by: Hudson CI
8 years agoanalysis: allow critical path view to display tooltips
Geneviève Bastien [Tue, 9 Feb 2016 02:55:43 +0000 (21:55 -0500)] 
analysis: allow critical path view to display tooltips

Change-Id: I0a155c89ed3ebdac7b4d97c2a7399d478c5d6df5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66062
Reviewed-by: Hudson CI
8 years agoanalysis.graph: allow workers to return additional information
Geneviève Bastien [Tue, 9 Feb 2016 02:50:13 +0000 (21:50 -0500)] 
analysis.graph: allow workers to return additional information

This information can be displayed as tooltips or extra columns in the views.

Change-Id: Ib992ffa0d32b89c5811510e5a9a3270a1df1003d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66060
Reviewed-by: Hudson CI
8 years agotmf: Add ellipses to manage xml menu item
Bernd Hufmann [Tue, 9 Feb 2016 19:57:48 +0000 (14:57 -0500)] 
tmf: Add ellipses to manage xml menu item

Change-Id: I76f0d0748a45f44fffa0774155f4b703ee598a7f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66241
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agoLTTng: Add user documentation for the virtual machine analysis
Geneviève Bastien [Wed, 21 Jan 2015 21:16:21 +0000 (16:16 -0500)] 
LTTng: Add user documentation for the virtual machine analysis

Change-Id: I608fb10e85ac21017f44542a2f4ddda743f33247
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/40089
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf : Remove import XML analysis command
Jean-Christian Kouame [Mon, 25 Jan 2016 21:14:57 +0000 (16:14 -0500)] 
tmf : Remove import XML analysis command

Change-Id: Ia8626d3a797caa9ed8a8942a0c7934b0e357bb3e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65142
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf : Add manager for XML analysis files
Jean-Christian Kouame [Fri, 22 Jan 2016 21:49:03 +0000 (16:49 -0500)] 
tmf : Add manager for XML analysis files

Change-Id: I48efa950f90d56e2fb23a4c7c6944a46220c0f29
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65141
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Replace Color resource with RGBA descriptor in marker events
Patrick Tasse [Fri, 5 Feb 2016 21:54:31 +0000 (16:54 -0500)] 
tmf: Replace Color resource with RGBA descriptor in marker events

This avoids the marker event sources from having to manage, create and
dispose color resources.

Also adds a RGBA to Color map in the time graph color scheme object
which is shared between the time graph control and scale.

Change-Id: I168c949e2aa63c0f5e958385490dc2543ecde7a5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66046
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agocommon: Add NonNull external annotation to Enum.name
Marc-Andre Laperle [Tue, 9 Feb 2016 07:26:00 +0000 (08:26 +0100)] 
common: Add NonNull external annotation to Enum.name

Because it can't be null.

Change-Id: Id87a19010a0a0c5e3daa3ff80d094cd5df660bd4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66173
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
8 years agocommon: Add NonNull external annotation to File.getName
Marc-Andre Laperle [Tue, 9 Feb 2016 07:09:55 +0000 (08:09 +0100)] 
common: Add NonNull external annotation to File.getName

Because it can't be null.

Change-Id: I81e9797e7e753a3cd04b8a580ec324f199569f71
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66172
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf : Fix get analysis modules when executing analysis in TmfTrace
Jean-Christian Kouame [Thu, 4 Feb 2016 21:44:25 +0000 (16:44 -0500)] 
tmf : Fix get analysis modules when executing analysis in TmfTrace

Previously, all existing modules were loaded. Now, only the modules
related to this specific trace are loaded. This prevents to execute
unnecessary analysis.

Change-Id: I3f949f6973f487903fe0e83b0f9d0f7347aa8c41
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66043
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf : Add a test to validate an XML pattern file
Jean-Christian Kouame [Tue, 8 Dec 2015 20:59:49 +0000 (15:59 -0500)] 
tmf : Add a test to validate an XML pattern file

Change-Id: Id2d016d8a3c93cf067110478405c06e9131339c1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62274
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf : Add the XML Schema Definition for the pattern matching analysis
Jean-Christian Kouame [Mon, 7 Dec 2015 20:01:32 +0000 (15:01 -0500)] 
tmf : Add the XML Schema Definition for the pattern matching analysis

Change-Id: Iba12a35cd4e33a5302ec13727a335ccffc2d28d0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62260
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoUpdating to latest orbit
Marc-Andre Laperle [Thu, 4 Feb 2016 20:28:34 +0000 (15:28 -0500)] 
Updating to latest orbit

Change-Id: I45094085fc7e90765f287cc460f181e45909d51a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65949
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoFix jacoco agent not added to command line (code coverage)
Marc-Andre Laperle [Thu, 4 Feb 2016 22:29:43 +0000 (17:29 -0500)] 
Fix jacoco agent not added to command line (code coverage)

It seems that tycho.testArgLine doesn't get set again by
tycho-surefire if it was set in the root properties.
I orginally defined it to nothing so that it would be defined
when running without jacoco. Instead, we can introduce a new
variable and never touch tycho.testArgLine.

Change-Id: I5f2969ad65292ad2e6fa84d3fb46bf925064981c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65953
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoreleng: Fix missing about.html
Marc-Andre Laperle [Thu, 4 Feb 2016 03:26:17 +0000 (22:26 -0500)] 
releng: Fix missing about.html

See https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg12981.html

Change-Id: I5b0b4274179bdfb83bf0dce388d06b01b3812dde
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65853
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoanalysis: Fix dependency on Eclipse 4.5.1 instead of just 4.5
Marc-Andre Laperle [Thu, 4 Feb 2016 02:44:51 +0000 (21:44 -0500)] 
analysis: Fix dependency on Eclipse 4.5.1 instead of just 4.5

eclipse.core.resources 3.10.1 is from Eclipse 4.5.1.
There is no special need to depend on the service release instead
of the original 4.5 release.

This was noticed by trying to install Trace Compass form master
on top of Eclipse 4.5.0.

Change-Id: I22879ac99b24d8628b4e378d586564d33e0d7358
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65852
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Avoid unnecessary redraw in TmfClosestDataPointTooltipProvider
Patrick Tasse [Thu, 4 Feb 2016 15:37:32 +0000 (10:37 -0500)] 
tmf: Avoid unnecessary redraw in TmfClosestDataPointTooltipProvider

On a mouseMove event, it is only necessary to redraw (once) if the hover
highlight needs to be removed.

Change-Id: Ib14d35699ef276929ec66e84775d0350268e9717
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65907
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoctf: Increase time-out of CtfTestSuiteTest
Marc-Andre Laperle [Thu, 4 Feb 2016 02:25:07 +0000 (21:25 -0500)] 
ctf: Increase time-out of CtfTestSuiteTest

This has been timing out intermittently and I haven't been able to
reproduce it in a way that I can diagnose the problem further. A theory
is that the build machine just gets slow sometimes (it is shared between
many projects). Increasing the time-out shouldn't hurt and if it still
happens, it will be even more suspicious.

Bug: 486209
Change-Id: Ib71f8313b02ce6152bb2eb119bc9ffa11fd44d68
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65851
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis: Persist sort column sorting and selection in time graph views
Bernd Hufmann [Tue, 26 Jan 2016 02:26:40 +0000 (21:26 -0500)] 
analysis: Persist sort column sorting and selection in time graph views

The settings are persisted per open trace.

Change-Id: Ic021f6f19cccee629d1a456e3abf5fd51fb34cce
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65156
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoUpgrade eclipse-jarsigner-plugin to 1.1.3
Marc-Andre Laperle [Fri, 29 Jan 2016 16:31:58 +0000 (11:31 -0500)] 
Upgrade eclipse-jarsigner-plugin to 1.1.3

This upgrade doesn't really affect our build but it's good practice
to stay current. Eventually, we could use the DMG packager for a
nicer installation on Mac.

https://projects.eclipse.org/projects/technology.cbi/releases/maven-plugins-1.1.3

Change-Id: I6b839630765551b98eb8d9bfa5cac9999b80ab44
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65486
Reviewed-by: Hudson CI
8 years agolttng: Bug 487163: Resources view traces are unsorted
Patrick Tasse [Wed, 3 Feb 2016 19:04:32 +0000 (14:04 -0500)] 
lttng: Bug 487163: Resources view traces are unsorted

When an experiment is opened, its traces are now sorted alphabetically.

Change-Id: Idae538a53182d661d066f82b676a8b3a14442c2b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65836
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoLTTng: Add developer documentation for virtual machine analysis
Geneviève Bastien [Thu, 22 Jan 2015 03:27:17 +0000 (22:27 -0500)] 
LTTng: Add developer documentation for virtual machine analysis

Change-Id: Ibbbd0680190c0a5992a7d088c4df54c460fa6341
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/40090
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng: add SWTBot tests for verifying Control flow view sorting
Bernd Hufmann [Fri, 22 Jan 2016 20:43:47 +0000 (15:43 -0500)] 
lttng: add SWTBot tests for verifying Control flow view sorting

Change-Id: I17e7803f95eca3fedbe8377b91c13a48c1a91565
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65025
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoRevert "ctf: Fix slow test due to expected timeout"
Marc-Andre Laperle [Wed, 3 Feb 2016 03:38:56 +0000 (22:38 -0500)] 
Revert "ctf: Fix slow test due to expected timeout"

This reverts commit 55d0eb8e748bcf27d4afc39f5553d419d9b2922a.

This commit broke the staging build. This will need a different
solution.

Change-Id: I53235d4155e680f6400f4e91212234812a9c5dc0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65752
Reviewed-by: Hudson CI
8 years agoctf: Fix slow test due to expected timeout
Marc-Andre Laperle [Tue, 2 Feb 2016 22:56:50 +0000 (17:56 -0500)] 
ctf: Fix slow test due to expected timeout

The test was looking for a possible checkbox (in 4.6) but when it
it was not there (4.5) it had to wait 50 secs for it to time out.
Instead we can set a very short timeout because it will instantly
either be there or not.

Change-Id: I05acf8844619377362accd32af7d994e050d5ec6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65747
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agoreleng: Add profile to disable jacoco
Marc-Andre Laperle [Wed, 27 Jan 2016 08:11:21 +0000 (03:11 -0500)] 
releng: Add profile to disable jacoco

So that we can disable it for the Gerrit trigger and make it a bit
faster, hopefully. To disable it use
mvn clean install -Dskip-jacoco=true

Change-Id: I5ab53302df910ddeac1d2fa4afa2f2c020c85ff3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65235
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Keep focused item aligned on vertical zoom
Patrick Tasse [Mon, 1 Feb 2016 20:45:37 +0000 (15:45 -0500)] 
tmf: Keep focused item aligned on vertical zoom

When doing a vertical zoom with the keyboard, if the selected entry is
visible, make sure that it remains at the same vertical position.

When doing a vertical zoom with the mouse wheel, make sure that the
entry under the mouse cursor remains at the same vertical position.

When repeatedly doing a vertical zoom within a short amount of time, use
the initial event's entry and position for the subsequent alignments.

Fix the method getItemIndexAtY() to find items that are above the
visible bounds.

Change-Id: I803229c5cf5295b855d4615a6756751158b78346
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65605
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: Show closest event tool tip when hovering over blank space
Patrick Tasse [Mon, 1 Feb 2016 22:57:55 +0000 (17:57 -0500)] 
tmf: Show closest event tool tip when hovering over blank space

Show the tool tip for the closest between the next and previous event
when hovering over the blank space of a time graph entry, if the
distance to the event position is within a threshold.

Change-Id: I8a95d488e03c1d5012a1ee0bd4597f863b2ba3b6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65612
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng: Bug 486404: Process name is not always drawn in Resources view
Patrick Tasse [Fri, 22 Jan 2016 22:22:51 +0000 (17:22 -0500)] 
lttng: Bug 486404: Process name is not always drawn in Resources view

Change-Id: I2e8a130e8fd22445eaa4dbf4245058dfb1896c1d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65030
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf: change ITmfTraceProperties to a more generic ITmfPropertiesProvider
Geneviève Bastien [Wed, 27 Jan 2016 20:31:24 +0000 (15:31 -0500)] 
tmf: change ITmfTraceProperties to a more generic ITmfPropertiesProvider

This allow other elements than traces to implement this interface and also
provide properties to display in the UI.

Change-Id: I11fe5bdc4825e2cc548f1d683b21a90e5fd2f3ae
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65323
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agodoc: User guide updates for missing or incorrect content
Bernd Hufmann [Thu, 28 Jan 2016 20:20:37 +0000 (15:20 -0500)] 
doc: User guide updates for missing or incorrect content

- Resources view - add filter dialog, remove arrows buttons
- Project Explorer and events table - refreshing of local traces
- Control Flow view - column sorting, updated filtering

Change-Id: I6fd28938e1abc25d26529eeecc8f2d7b3e4b20a1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65410
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoctf: expose UTC offset in trace properties
Matthew Khouzam [Thu, 28 Jan 2016 01:56:01 +0000 (20:56 -0500)] 
ctf: expose UTC offset in trace properties

This shows the time of boot of the system wrt UTC for
most CTF traces. Initial step towards fixing bug 484620

Change-Id: I62a934051f5d06c0e5c151743cbcc868f311e50f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65229
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agorcp: Fix icons for project explorer on Eclipse 4.6M5
Bernd Hufmann [Sat, 30 Jan 2016 02:10:59 +0000 (21:10 -0500)] 
rcp: Fix icons for project explorer on Eclipse 4.6M5

All the platform icons where changed to png file types and file
extension. Since in the RCP we need to register these images for
the RCP product and there are no constants available we need to check
for gif and png file extension to support Eclipse 4.5 and 4.6.

Change-Id: I2d751df1177adc991e300ec9e12a19922c163fe9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65505
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Fix TestImportExportPackageWizard on Eclipse 4.6M5
Marc-Andre Laperle [Fri, 29 Jan 2016 23:08:59 +0000 (18:08 -0500)] 
tmf: Fix TestImportExportPackageWizard on Eclipse 4.6M5

ArchiveFileExportOperation doesn't include linked resources by
default anymore, we have to call setIncludeLinkedResources(true).
Because of that, the exported package did not contain the trace
files. The method doesn't exist in Eclipse 4.5 so we have to use
reflection for the time that we want to support both versions of
Eclipse.

Change-Id: Ie7216e81fd3004e362e4200946e6ce81f81aa676
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65503
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoctf: Fix StandardImportAndReadSmokeTest on Eclipse 4.6M5
Marc-Andre Laperle [Fri, 29 Jan 2016 04:10:52 +0000 (23:10 -0500)] 
ctf: Fix StandardImportAndReadSmokeTest on Eclipse 4.6M5

The export dialog changed and doesn't include linked resources
anymore. However, there is a checkbox that displays them again.
See bug 355049

Change-Id: Ibbdf33839653127f15efd07ad72f887b6ba21697
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65424
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoanalysis: no longer call overridable methods from constructors
Matthew Khouzam [Wed, 6 Jan 2016 15:30:09 +0000 (10:30 -0500)] 
analysis: no longer call overridable methods from constructors

Change-Id: I6b8e639f04e42ac840a114690a6ddbc639c5873c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63650
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf: Attempt to gracefully recover from a malformed packet context
Matthew Khouzam [Tue, 26 Jan 2016 11:15:28 +0000 (06:15 -0500)] 
ctf: Attempt to gracefully recover from a malformed packet context

If a packet context has an end time that is less than the start time
tracecompass will give an error message and refuse to read the trace.

This patch makes tracecompass log a warning instead and try to read
the trace.

Seeking should not be affected.

Bug 486670

Change-Id: I352af4c79476c73b0ced2cefd65f82bd04d6762d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65168
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Update TmfSimpleTableViewer use of comparator generics
Patrick Tasse [Thu, 28 Jan 2016 18:54:14 +0000 (13:54 -0500)] 
tmf: Update TmfSimpleTableViewer use of comparator generics

Update is required due to changes in ViewerComparator from Bug 483190.

Change-Id: If8cf7b0d233515907f78fa85fe6f361e0ad49612
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65401
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf: annotate StructDeclaration#addField to @NonNull
Matthew Khouzam [Thu, 28 Jan 2016 03:01:49 +0000 (22:01 -0500)] 
ctf: annotate StructDeclaration#addField to @NonNull

This way we know that all null fields received don't exist.

Change-Id: Icd7d2280653c0fe2eb4705fcd6ef8ee950a630f3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65331
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf.tests: remove one test trace from ignored list
Matthew Khouzam [Mon, 25 Jan 2016 21:29:21 +0000 (16:29 -0500)] 
ctf.tests: remove one test trace from ignored list

This was fixed by commit 8460a46d8b186d302a42d614ef6fac81056e1e2e
ctf: make parser support scoped typedefs [Bug 470846]

Change-Id: I8aab4c9bede302b9f59f61a3747e4e4ce58bdbf8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57877
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
8 years agorcp: Bug 486745: Open traces with name conflict from cmd-line correctly
Bernd Hufmann [Thu, 28 Jan 2016 16:42:02 +0000 (11:42 -0500)] 
rcp: Bug 486745: Open traces with name conflict from cmd-line correctly

Change-Id: I4cff3ef47fc52df07c7e0b4df3bab44fdc2e2344
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65378
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoanalysis.xml: Remove "throws Exception"
Matthew Khouzam [Thu, 28 Jan 2016 03:43:58 +0000 (22:43 -0500)] 
analysis.xml: Remove "throws Exception"

Replaces throws Exception with throws IOException.

Using such generic exceptions prevents calling methods from
handling true, system-generated exceptions differently than
application-generated errors.

Or, as the former lead of our former project said:
"Don't mess with Exception"

Change-Id: I61f517b8721a5e660d92b7cba7bf97c1382381af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65333
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoanalysis.xml: fix potential null dereference
Matthew Khouzam [Thu, 28 Jan 2016 03:40:16 +0000 (22:40 -0500)] 
analysis.xml: fix potential null dereference

File#listFiles() can return null. Even though the test
"isDirectory()" and "exists()" are able to pick it up, executing
the command and null checking it is the best garanty.

Change-Id: Ic3cefdaecf3d5d88dbeaeb3f3d58689abdb05347
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65332
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agocontrol: Support recordings snapshot for multiple sessions from menu
Bernd Hufmann [Tue, 26 Jan 2016 19:18:53 +0000 (14:18 -0500)] 
control: Support recordings snapshot for multiple sessions from menu

It has been already possible from the toolbar button.

Change-Id: I2c1122ea61cbc0168aced8b27343236090ee2ecd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65216
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agocontrol: Bug 486586: Allow snapshots in inactive state
Bernd Hufmann [Tue, 26 Jan 2016 19:16:46 +0000 (14:16 -0500)] 
control: Bug 486586: Allow snapshots in inactive state

Change-Id: Iee0e5a53169f5d573865df4a634da900eaad71cc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65215
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoChange unnecessary declaration of thrown exception to warning in tests
Patrick Tasse [Thu, 14 Jan 2016 21:45:55 +0000 (16:45 -0500)] 
Change unnecessary declaration of thrown exception to warning in tests

Change-Id: I4c5fe96c227b3cf89d26b46ded8dc318eb62060b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64410
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf: remove StructDeclaration#getFields()
Matthew Khouzam [Tue, 12 Jan 2016 03:42:01 +0000 (22:42 -0500)] 
ctf: remove StructDeclaration#getFields()

this exposes an internal map and can be dangerous

Change-Id: Icc1d5ecbd7d5dc5eab472b314669312ffe26a8a6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64118
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoctf: enhance unit tests around EnumDeclaration
Matthew Khouzam [Fri, 15 Jan 2016 02:53:35 +0000 (21:53 -0500)] 
ctf: enhance unit tests around EnumDeclaration

Change-Id: If6f6cc514e13a8dbe50738cb6a7c41cd0c47f351
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64429
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf.ui: add test for Control Flow view dialogs
Matthew Khouzam [Tue, 12 Jan 2016 12:40:02 +0000 (07:40 -0500)] 
tmf.ui: add test for Control Flow view dialogs

Change-Id: I433af57a2a2e713bc1c74a712d7d1b927c48c838
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64119
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoxml: bug 486434 bring analysis module source back to core plugin
Geneviève Bastien [Mon, 25 Jan 2016 04:11:44 +0000 (23:11 -0500)] 
xml: bug 486434 bring analysis module source back to core plugin

Change-Id: I2ead4d309cdd8e633b2990b020bbaf05bd08775c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65116
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoxml: remove dependency to ui element from the module source
Geneviève Bastien [Mon, 25 Jan 2016 04:01:39 +0000 (23:01 -0500)] 
xml: remove dependency to ui element from the module source

The TmfXmlAnalysisOutputSource class is now advertised with the 'listener'
element of the analysis extension point.

Change-Id: I7ac2be77774f029e29eabd643e6fd891317bd898
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65115
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Add a listener element to the analysis extension point
Geneviève Bastien [Mon, 25 Jan 2016 03:16:04 +0000 (22:16 -0500)] 
tmf: Add a listener element to the analysis extension point

This element allows to add listener classes that will be registered to
the
analysis manager.

Change-Id: I65fc1949350156ec945db6c2a48020f8aec3e9f7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65114
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoxml: remove dead store of value in XmlPresentationProvider.java
Matthew Khouzam [Tue, 19 Jan 2016 15:00:21 +0000 (10:00 -0500)] 
xml: remove dead store of value in XmlPresentationProvider.java

Change-Id: I50bf309c3aa38b8bf4d09ada185cb4be52708410
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64702
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoanalysis: Fix sonar warnings in CFV column sorting code
Bernd Hufmann [Mon, 25 Jan 2016 15:13:17 +0000 (10:13 -0500)] 
analysis: Fix sonar warnings in CFV column sorting code

Change-Id: I4f4bb7e367946e9b9acb46414962722eb156eb87
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agolttng: Handle compat_syscall_exit_* events correctly
Alexandre Montplaisir [Mon, 25 Jan 2016 20:26:04 +0000 (15:26 -0500)] 
lttng: Handle compat_syscall_exit_* events correctly

The compatibility layer syscall entry events were handled correctly,
but not the corresponding exit ones.

Bug: 486351

Change-Id: I2709a406eec805a8410651972fac618dcaf27dc4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/65134
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agolttng: Remove unneeded @Nullable annotations in KernelStateProvider
Alexandre Montplaisir [Mon, 25 Jan 2016 20:15:19 +0000 (15:15 -0500)] 
lttng: Remove unneeded @Nullable annotations in KernelStateProvider

The event name can not be null, so these utility methods could use
@NonNull parameters.

Change-Id: Ib651dc89e1e3da434c6e5bed2cb222f764346868
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/65133
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoImprovements to Oomph setup
Marc-Andre Laperle [Wed, 20 Jan 2016 22:23:50 +0000 (17:23 -0500)] 
Improvements to Oomph setup

-The Eclipse ini redirection makes your IDE use the local setup from
your git clone for that IDE's setup. This way you can edit your setup,
test the changes locally, and then commit it.
-Add features necessary in the Eclipse installation so that you can use
any Eclipse package to develop Trace Compass. For example, you can
select Eclipse for C/C++ and it will still install PDE, etc.

Change-Id: I06a2700a79b724ade54f5c961f64835ddc5a8dd0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64815
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agoctf: Speed up TestInvalidCtfTrace
Marc-Andre Laperle [Fri, 22 Jan 2016 02:14:50 +0000 (21:14 -0500)] 
ctf: Speed up TestInvalidCtfTrace

- Do not delete project every test
- Do not delay when opening the editor

Change-Id: I40032167cfec2ea8d99fc81974d142ab82befb3a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64942
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoctf: Speed up StandardImportAndReadSmokeTest
Marc-Andre Laperle [Fri, 22 Jan 2016 01:26:18 +0000 (20:26 -0500)] 
ctf: Speed up StandardImportAndReadSmokeTest

- Only clear the trace folder at the end of a test
- Only do the views sanity check for a couple of tests

Change-Id: I731bc8a59b704c86dca87cfa74365d5b09bc3e56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64941
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoReplace references to TreeSet with NavigableSet in InMemoryBackend
Matthew Khouzam [Sat, 23 Jan 2016 00:25:02 +0000 (19:25 -0500)] 
Replace references to TreeSet with NavigableSet in InMemoryBackend

Change-Id: I74f6fc7d6292406a552abd6ba20d5538fabbf8a4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65034
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoRemove references to ArrayList<> in fields of TimeChartView
Matthew Khouzam [Sat, 23 Jan 2016 00:26:06 +0000 (19:26 -0500)] 
Remove references to ArrayList<> in fields of TimeChartView

Change-Id: Icb4bc0a248b93c7e83540a2d0cf66c8b672de7ae
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65035
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoMake some inner classes static
Matthew Khouzam [Sat, 23 Jan 2016 03:34:50 +0000 (22:34 -0500)] 
Make some inner classes static

These classes are inner classes, but they do not use its embedded
reference to the object which created them.  This reference makes
the instances of the class larger, and may keep the reference to
the creator object alive longer than necessary.

The classes should be static.

Change-Id: I76982a42e10fa89ea7e18524914605d60016fbf3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65036
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoanalysis: Add context switch core tests
Matthew Khouzam [Wed, 23 Sep 2015 03:01:36 +0000 (23:01 -0400)] 
analysis: Add context switch core tests

Change-Id: I8b044f66608a0aa36393cdda2fc89f1724a6f42c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/56487
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoanalysis: introduce context switch analysis
Alexis Cabana-Loriaux [Fri, 7 Aug 2015 15:00:35 +0000 (11:00 -0400)] 
analysis: introduce context switch analysis

Change-Id: Iccde08930c6111b93e16bab7d6d3e1b894c9c557
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53413
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoMake LostEventDeclaration final
Matthew Khouzam [Fri, 22 Jan 2016 04:20:27 +0000 (23:20 -0500)] 
Make LostEventDeclaration final

Classes with only private constructors should be final.

Change-Id: Ib4d9344fcf5c65449eb84e04d970b90016d683af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64944
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agovm: change private method to take a List instead of ArrayList
Matthew Khouzam [Fri, 22 Jan 2016 04:15:36 +0000 (23:15 -0500)] 
vm: change private method to take a List instead of ArrayList

Declarations should use Java collection interfaces such as "List"
rather than specific implementation classes such as "LinkedList"

The purpose of the Java Collections API is to provide a well defined
hierarchy of interfaces in order to hide implementation details.

Implementing classes must be used to instantiate new collections,
but the result of an instantiation should ideally be stored in a
variable whose type is a Java Collection interface.

Change-Id: I380287ab4b425167e6378f1b0c4d9aa1af4a8b02
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64943
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agodocumentation: Add documentation for Latency views
Matthew Khouzam [Mon, 18 Jan 2016 22:49:31 +0000 (17:49 -0500)] 
documentation: Add documentation for Latency views

Change-Id: If3c4366e4e2f0c8aa876833ae85467a98e71ca3a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64610
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoanalysis: support for sorting of control flow view columns
Bernd Hufmann [Tue, 12 Jan 2016 17:53:59 +0000 (12:53 -0500)] 
analysis: support for sorting of control flow view columns

Each column in the control flow view can be now sorted by clicking on
the column header. By default, it's sorted by birth time. For an
experiment the traces are sorted independently. The tree hierarchy is
kept, i.e. tree level is sorted separately.

An API has been added to support sorting of time graph entries
(ITimeGraphEntry) generically.

Change-Id: I05631ca69ea5cd57cdd97b3815cc263e7de9e43e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64403
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng: Fix thread ordering in virtual machine view
Geneviève Bastien [Wed, 13 Jan 2016 03:42:57 +0000 (22:42 -0500)] 
lttng: Fix thread ordering in virtual machine view

Threads in the virtual machine view are now ordered by their numeric thread IDs
instead of the corresponding string which makes it more intuitive.

Change-Id: I681e3423dcea9e946b74bebe4e2d0416680ccfa9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64205
Reviewed-by: Hudson CI
8 years agorcp: Add profile to build only one rcp (one environment)
Marc-Andre Laperle [Wed, 20 Jan 2016 16:14:39 +0000 (11:14 -0500)] 
rcp: Add profile to build only one rcp (one environment)

When running validation builds (Gerrit trigger), we don't need
to build all environments. A failure to assemble the product on
only one platform is highly unlikely and would be caught by the
nightly build, at worse.

This patch adds a profile so that only one environment is built
(Linux 64).

Change-Id: Icba6d6a1b01da605db6fe19cceb2e3a2b3694315
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64784
Reviewed-by: Hudson CI
8 years agolttng: VirtualMachineView: extract some methods to simplify the class
Geneviève Bastien [Mon, 18 Jan 2016 03:59:26 +0000 (22:59 -0500)] 
lttng: VirtualMachineView: extract some methods to simplify the class

This fixes some sonar warnings that methods were too complex. Some
repeated code was also extracted to a method so that both thread and CPU
entries can make use of it.

Change-Id: I18af32bfb2d16d63ee80e0bb1aba0664728ca633
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64617
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf : Improve toString() in TmfXmlStateValue and TmfXmlCondition
Jean-Christian Kouame [Wed, 20 Jan 2016 18:50:17 +0000 (13:50 -0500)] 
tmf : Improve toString() in TmfXmlStateValue and TmfXmlCondition

Change-Id: I25dc5961d71c84a6c3af82d6669a45fedcaa1504
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64804
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoctf: Introduce IEventDefinition
Matthew Khouzam [Thu, 14 Jan 2016 22:02:29 +0000 (17:02 -0500)] 
ctf: Introduce IEventDefinition

This interface is extracted from EventDefinition. It allows all of
IEventDeclaration to return only the interface and leave the internals
in the internal folder.

This should improve the maintainability of the CTF plugin without impacting
performance or testability.

Change-Id: I398c4440c67738eaa80a2e63e6d562352d0d64a8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64412
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf.ui: Fix dead store in TimeAlignmentSynchronizer
Matthew Khouzam [Wed, 20 Jan 2016 01:36:36 +0000 (20:36 -0500)] 
tmf.ui: Fix dead store in TimeAlignmentSynchronizer

The algorithm in getReferenceView should pick the view with left-most
time-axis position (to maximize viewing area). It was written like
that originally but a break statement snuck in.

Change-Id: I177c512d9b6553fb553d8eda6e2ab833aa3867c9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64716
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
8 years agolttng: Fix sonar warnings in VirtualMachinePresentationProvider
Geneviève Bastien [Mon, 18 Jan 2016 04:18:10 +0000 (23:18 -0500)] 
lttng: Fix sonar warnings in VirtualMachinePresentationProvider

Change-Id: I27d475f49da87af2e81337e4ad8ea856b6722d4f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64616
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolttng: Fix sonar warnings in VirtualMachineViewEntry
Geneviève Bastien [Mon, 18 Jan 2016 04:24:31 +0000 (23:24 -0500)] 
lttng: Fix sonar warnings in VirtualMachineViewEntry

Change-Id: I85b1bd21b93aaa5680af56bc80468ae70242438e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64615
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.ui: ensure that the Histogram's text label is layouted
Matthew Khouzam [Wed, 20 Jan 2016 01:25:47 +0000 (20:25 -0500)] 
tmf.ui: ensure that the Histogram's text label is layouted

Change-Id: I399c98892b96953c7a310cc0c90ffea53103014e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64714
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agoPrint some environment information at the start of SWTBot
Marc-Andre Laperle [Wed, 20 Jan 2016 05:43:34 +0000 (00:43 -0500)] 
Print some environment information at the start of SWTBot

This will help us investigate failing tests in the case where the
environment differs from what is known to work.

Change-Id: I4b6cf42355050bf57d420a5a95df4e1b35618fe2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64723
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: avoid dead store in deleteHandler
Matthew Khouzam [Wed, 20 Jan 2016 01:31:52 +0000 (20:31 -0500)] 
tmf.ui: avoid dead store in deleteHandler

Change-Id: I5918ccd5408502fceda12c447d0d40d27c9e218c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64715
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoFix typo in System call density vs time title
Matthew Khouzam [Mon, 18 Jan 2016 22:35:16 +0000 (17:35 -0500)] 
Fix typo in System call density vs time title

Change-Id: I587a9af2bc01d6b5a74e69c42c53fbd4d8f88bb1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64608
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
This page took 0.050804 seconds and 5 git commands to generate.