lttng/tmf: Enable and fix parameter assignment warnings

FindBugs also warns for these, so might as well have them
enabled straight within Eclipse.

Change-Id: I1318a26c22e1bb379b5af02e1fc4840c2cd39093
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9472
Tested-by: Hudson CI

tmf: Fix remaining Java warnings in tmf.ui

Change-Id: I02cc52ad3dca97512c29aa7d92c2ce32005e8e73
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9467
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Add missing Javadoc to tmf.ui

This goes a long way into fixing the remaining warnings!

This commit contains only documentation and formatting fixes,
no actual code changes. Except for some protected fields in
TmfEventsTable, which were changed to private to remove them
from the API.

Change-Id: I6c524c9e9b91f0efafad739cec62aa7d60429972
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9463
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Update bookmarks file API, link to editor and delete & rename handlers

- Implement different methods in trace element and experiment element to
get the bookmarks file with or without creating it.
- Update TmfEditorLinkHelper to use the new methods to get the bookmarks
file from trace or experiment element.
- Update TmfEditorLinkHelper to no longer activate the found editor
part. Doing so would make the Project Explorer view lose focus.
- Update TmfEventsEditor to also broadcast TmfTraceSelectedSignal when
part is brought to top without being activated. Selected flag is added
to ensure the signal is sent only once as long as the same trace is
selected.
- Fix equals() method of TmfProjectModelElement. Path is used for
equality check. Using name and location would return true when comparing
a trace element and a link to the same trace under an experiment, which
would confuse the Project Explorer tree navigator model. Update
hashCode() to only use path.
- Fix rename trace handler to propagate rename to experiment traces
based on trace name since the equals method no longer matches for the
different trace element under Traces folder and under an experiment.
- Fix delete trace handler to propagate deletion to experiment traces
based on trace name. Using location could unnecessarily remove trace
from an experiment which was a different linked trace to the same
location as the deleted trace.
- Dispose temporary trace used in validate() of CtfTmfTrace and
CtfKernelTrace. This allows deletion soon after import.

Change-Id: Ib2624732d7c8d9a2677a15d8709e27d99f76e880
Reviewed-on: https://git.eclipse.org/r/9435
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add missing @since annotations in Utils.TimeFormat

Change-Id: I3fa5f684ebcc206e7e021291849e828d374d5f56
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9431
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Remove unused import in TmfTimestampFormat

Change-Id: I8aa86e5f20ca620cde3492bcac3a137f5cd65d2e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9430
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

lttng/tmf: add a "unit-less" representation of time in timechart

Change-Id: Ia2c2b9a55a1d380f7656c473c535b775553c4bf1
Reviewed-on: https://git.eclipse.org/r/8204
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

Add missing @since tags

Change-Id: I208ad218b914d0087754449d44845d04874b539e
Reviewed-on: https://git.eclipse.org/r/9424
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

Close trace and improve error handling on delete and rename commands

- Close trace or experiment editor on delete and rename commands, to
dispose the trace(s) and release file resources to allow the file
operations to succeed
- Show message dialog to user on delete error
- Fix message dialog for rename error
- Move creation of bookmarks file to trace or experiment element
- Fix leaking of project model elements

Change-Id: I585df4fd4b3547dc4b71735ebbd47184585c0eef
Reviewed-on: https://git.eclipse.org/r/9339
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Implement dispose of CTF traces

Dispose method is implemented for CtfTmfTrace and its contained objects.
File streams are closed and references to MappedByteBuffer objects are
cleared. The trace manager is cleared when a trace is removed from the
iterator manager and the trace iterators are disposed.

Change-Id: I6a5f8cc73ef5157842c67bb5dd0e7a2cb38a23ff
Reviewed-on: https://git.eclipse.org/r/9338
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix endless loop in Resources view when trace is disposed

Change-Id: Ia030dd809de82af07eff8e7de78f0eb45e6c2b2a
Reviewed-on: https://git.eclipse.org/r/9361
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI

Adjust list kernel events handling due to new output format

lttng-tools 2.1 has a different string output for command
lttng list -k if no kernel tracer is available. This fix
adjust the command output parsing to ignore this case correctly.

Change-Id: Ibfc8fd19609b6489e5ef9fd31ba75058ea0f6631
Reviewed-on: https://git.eclipse.org/r/9328
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Clear text controls and labels when histogram is empty

- Do not display default time (epoch) for text controls and
start/end labels when histogram is initialized or when last trace is
closed
- Prevent user update of text controls when histogram is empty
- Fix layout problem on time format update

Change-Id: I9285853b127e0dca0fa0c2035fea1c414390a759
Reviewed-on: https://git.eclipse.org/r/9273
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Add support for link with editor in tracing projects

- Extend extension org.eclipse.ui.navigator.linkHelper
- Add implementation of ILinkHelper interface
- Implement getParent() in TmfNavigatorContentProvider

Change-Id: I6e37bff9b7891866a61f2a0960e789d8bfbc5fa5
Reviewed-on: https://git.eclipse.org/r/9246
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix trace not indexed on reuse of editor

Change-Id: I9c6e62c6081bb7d1ea1bf3c2552fddb1cc0c1c7a
Reviewed-on: https://git.eclipse.org/r/9244
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI

Update LTTng user guide and remove trailing spaces

Change-Id: Ica7fea78df7e230f54caceddf1b0aeef0ada61ab
Reviewed-on: https://git.eclipse.org/r/9235
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Move Manage Custom Parsers view menu item to tracing context menu

- The Manage Custom Parsers... command is removed from the Project
Explorer view menu, and added to the Traces folder context menu and to
the trace's Select Trace Type... context sub-menu.
- A bullet icon is added to the selected trace type's category menu item
in the Select Trace Type... context sub-menu.

Change-Id: I77156a8de320264c0fac3db623a2c9cf7831718e
Reviewed-on: https://git.eclipse.org/r/9233
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Add process and syscall labels to Control Flow and Resources views

Change-Id: I9fd570da4f5acce1f03098a7a2f20e2baccd20f0
Reviewed-on: https://git.eclipse.org/r/9172
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: Fix API inconsistencies

Some API methods would return or take as parameter classes
that were not part of the API themselves. This little rework
seems to fix the problem, mainly by exporting BitBuffer, Stream
and StreamInput.

Change-Id: I3bac3619426d51c1a1484a6a0a336ec93e700175
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9173
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Correctly export all packages in runtime plugins

The API tools need the packages to be correctly exported
(even the internal ones, they should be explicitely set to
"hidden from all plug-ins except: <nothing>").

This patch enables the project-specific settings to warn for
missing exported packages, exports the missing ones, and fixes
a missing annotation.

Change-Id: Id63e1e6a586eddc66dc3f14e6b58ec6bc3bd9dfe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9168
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

ctf: Enable the API tool on the CTF plugins

Bump the plugin version to 2.0.0, as needed, and add missing
annotations.

Change-Id: I182ad7187be62130b12cdf5785adef36f53aa3cb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9164
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Bump up Linux Tools master snapshot release to 2.0.0.

Change-Id: I5b9ab2cf7a5408714a33626d20aca0b06bfbf8fc
Reviewed-on: https://git.eclipse.org/r/9162
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
IP-Clean: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>

tmf: Bring back "@since 1.2" annotations in master

Those were temporarily bumped to 2.0 in lttng-kepler, but
were actually part of the 1.2 release.

Change-Id: I30027dd9b0e3f1a86f55de9ebb5b5c9d900b77c2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9159
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Merge branch 'lttng-kepler'

Fix order of execution in CTF JUnit tests.

The order of test case within a JUnit tests file doesn't ensure the
order of execution. So, each test case within a file have to be
self-contained.

Change-Id: Ie7cdff17f4c176062a4eabd038de3870e44834de
Reviewed-on: https://git.eclipse.org/r/9146
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Include CTF and Kernel state system JUnit tests to maven build

Change-Id: I3429e28f98606031c9238adf699a3a839ef1c2be
Reviewed-on: https://git.eclipse.org/r/9145
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Consolidate all state systems in ITmfTrace

In the initial design, a trace would have only one single
state system. ITmfTrace.getStateSystem() would do the job.

Then, the need for different state systems for different trace
types arose. Up until now, we've used a hybrid approach, where
we keep the interface method the same, but a given user/view
could access a specific state system by casting the trace
in the specific type. So far so good.

But now, we are reaching the point where we can need to define
*many* state systems for a single trace type (ie, Matthew's
CPU usage view). I think we now need to centralize all of a
trace's state systems in the ITmfTrace interface itself.

This patch changes ITmfTrace's getStateSystem() to add the
state's ID as parameter (state systems already define a unique
ID, so we can reuse that one). It also adds a listStateSystems()
method to list the current registered ones for this trace.

The implementation in TmfTrace uses a HashMap. It's very simple,
and gives a maximum amount of flexibility ; sub-classes can
decide to overwrite a superclass' state history, decide to run
them or not, etc.

Change-Id: I6c819ad8987767015543dc54b613ec3cdc6ea50d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8767
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

lttng/o.e.l.tmf.ui/.../TimeGraphScale.java: avoid "java.lang.ArithmeticException: / by zero": _timeDelta can no longer be Zero

Change-Id: Ibce7df7bffd3ceb72b9541ef19a24636520d32f3
Reviewed-on: https://git.eclipse.org/r/8932
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

Fix histogram current event and time stamp format parsing

The parsing of date format is updated to use the time stamp format's
time zone.

DAY_OF_YEAR field is not copied from the reference time as setting it
also updates the MONTH and DATE, causing premature break out of the
field-copying loop.

HOUR_OF_DAY field is used to copy from the reference time instead of
the HOUR field, as the latter only uses a 12-hour clock.

The current event text control now uses the current event time value as
a reference time for parsing, instead of the trace start time. This
allows a time stamp format preference, which contains insufficient date
and time fields to fully represent the whole trace range, to be usable
in the text control. The non-visible date and time fields are assumed to
be set equal to those of the current event.

Change-Id: I25c67787c20aa26a0f267f8d460b441b74185122
Reviewed-on: https://git.eclipse.org/r/9051
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Add missing @since annotation

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Change-Id: Id2c182e7731e952f129a3c1efee4cb0c52e89b53
Reviewed-on: https://git.eclipse.org/r/9078
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI

Fix corrupted cache when clear interrupts cache population request

Change-Id: Ifebd1362ebfdaafcf0d13140c927680400580aed
Reviewed-on: https://git.eclipse.org/r/9052
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Fix mouse wheel zoom in time range histogram

Change-Id: I4739526671a7835fdb420313bbdb9f8e81e79b5f
Reviewed-on: https://git.eclipse.org/r/9026
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI

Add notification for reset of time scale in TimeGrapViewer

A recent change removed the notification of reset time scale
in the TimeGraphViewer. The ResoucesView and ControlFlowView
was affected by that. This update adds the notification
when executing the reset scale action.

Change-Id: Ic822157d4617ed7ce81a67e8640ac8b62eedc694
Reviewed-on: https://git.eclipse.org/r/9036
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix deleting of supplementary files on remove of trace from experiment

Change-Id: I84bd7694a4836dbfaf03eb40fb134c803b3514ca
Reviewed-on: https://git.eclipse.org/r/9029
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Update Documentation to better reflect branch

* Describe time stamp formatting
* Update descriptions of event views to editors
* Update images to reflect better timestamps
* Add description of events properties view
* Update Description of statistics view
* Recompress images

Change-Id: Ia00b76353ed6fb9fa8f81c819d2ff39ad3b78608
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8946
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI

Add support for filters in Time Chart view

Change-Id: I6c096f0af66918429e77ad7f0ea6119ae4b7b4cd
Reviewed-on: https://git.eclipse.org/r/9013
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

Add synchronization to TmfTimestampFormat

SimpleDateFormat is not synchronized. Therefore users of that
class have to ensure synchronization.

Change-Id: Icbf51e3df816bf40747827a46245981043cec3ef
Reviewed-on: https://git.eclipse.org/r/9012
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

lttng/o.e.l.tmf.ui:TmfVirtualTable.java: add a getter for the Table menu, so getter and setter are consistent

Change-Id: I285314981d6981001571774ca616802afc4c6119
Reviewed-on: https://git.eclipse.org/r/8764
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

No range updated signal from TimeGraphControl for selection

Only send range updated signal when the mouse was dragged and
not when selection was done without moving the mouse.

Change-Id: I6707c10625b1ff5f816a3284e9a137fc78bfec53
Reviewed-on: https://git.eclipse.org/r/8984
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

Fix time scaling problem in Histogram View

If scale of TmfTimestamps of a trace is not nano-seconds
the start and end time of a trace have to be scaled when comparing
with entered time values.

Additionally, a NPE was fixed that was happening when clearing
the histogram while executing asyncExec() to update the display

Change-Id: I39dd3ed3e375ee520678f1de9cb45ee5fccf77d5
Reviewed-on: https://git.eclipse.org/r/8985
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

Make lower priority requests pre-emptible

The current request priority handling is based on splitting lower
priority requests into chunks of a fixed size that don't take too long
to process. If a higher priority request is issued (e.g. as the result
of a user action), it is simply put in front of the request queue i.e.
before the next low-priority chunk.

This patch modifies the TmfRequestExecutor to use 2 queues (one for each
priority) and implements a pre-emption scheme to make higher priority
requests run immediately.

This is the first step in a more comprehensive overhaul of the TMF
Request Model.

Change-Id: I6413cbbd69985d88b3fd5b5375a0b7ec59104682
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8983
Tested-by: Hudson CI

Implement TmfTimestampDelta for deltas of timestamps

The toString() method of this class returns the timestamp string
formatted with TmfTimestampFormat.DefaultIntervalFormat() and
also considers negative values correctly.

The getDelta() method of TmfTimestamp and TmfSimpleTimestamp
returns now an instance of TmfTimestampDelta.

This also fixes the incorrect display of timestamps deltas in
the Sequence Diagram view.

Change-Id: I249ab9ac7a5f4170f86f038bc89d419dcce9514a
Reviewed-on: https://git.eclipse.org/r/8944
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

Handle concurrent seek and dispose in CtfTmfTrace properly

Change-Id: I097f7f062e5c301fe9f00bab52f709b7afebb376
Reviewed-on: https://git.eclipse.org/r/8938
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix for column width problem in Linux

Change-Id: Ib439b88740fd8585fa32a8ebaf263bb41c031817
Reviewed-on: https://git.eclipse.org/r/8933
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix time range synchronization issues

- Histogram view, Control Flow view and Resources view ignore synch to
time range outside of trace range
- Histogram view updates time range to intersection of requested range
and trace range on synch to time range
- Fix Histogram view update of time range from Window Span text entry

Change-Id: I668db769452535272a7d3ee52144c8d7d2a1a6b8
Reviewed-on: https://git.eclipse.org/r/8924
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

Fix SWT widget disposed Exception in Sequence diagram view

Additionally:
- Fix typo in OpenTraceHandler
- Add check for file existence in CTFTrace

Change-Id: I88d7da6003c4fc587fb09ad5023ee0c72d61a845
Reviewed-on: https://git.eclipse.org/r/8916
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

Add handling of initial range offset in experiments

Change-Id: I3eb8353c183747eaac3e1b39816efcfe29bd3864
Reviewed-on: https://git.eclipse.org/r/8914
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Change LTTng help plugin generation

The generation of the LTTng help plugin used to be done from
a wiki stored at Eclipse.org. This wiki matches the latest
delivered source code. However, when developing new features
or updating existing features it is required to document the
new or updated feature. But this cannot be done on the wiki
web page. This causes that the writing of documentation
is often postponed before the next official release.

This commit changes the way the help plugin is build. The source
wiki text file along with the relevant images as part of are
stored as part of the git repository. The build-helper.xml was
updated to build the help from the local wiki file. This allows
the designer to update the documentation along with the feature
implementation. Note, that the local wiki can be edited with the
MyLyn wiki text editor.

When a release to open source is done and these new or updated
feature are part of it, then the open source wiki at Eclipse.org
needs to be aligned to the wiki which is stored in the git
repository.

How to know if someone updated the open source wiki independent to
the one in the git repository? For that, the build-helper.xml file
also builds the help plugin files as it used to be done. After a
Ant build with the build-helper.xml file the changes will show
as changes in the git repository. Knowing what changed, it can be
easily transfered to the local wiki stored in git.

Note that the legacy help files were removed from the repository.

Change-Id: Iba1b140a78a5e4aaa2b2a7ffbdb0cf852f9b6030
Reviewed-on: https://git.eclipse.org/r/8794
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix test cases to use time zone offsets

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: Icfbef5df8913f1fd34486b85a9016f0176c874ec
Reviewed-on: https://git.eclipse.org/r/8866
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Use threads in open experiment/trace for long init operations

Additionally, the error handling in open experiment/trace
is changed to dispose the trace object in an error case. Also
some error print-outs are updated.

Change-Id: I49c9d8fbf04a83b2b7d3c36acbc52c1daa831998
Reviewed-on: https://git.eclipse.org/r/8836
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Change timestamps to output in local time

Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: I45bbe2a8cf0d3d4f68d57fa733e032d58548c514
Reviewed-on: https://git.eclipse.org/r/8815
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Fix clearing of histograms

When histograms are cleared, the full trace histogram does not clear its
range duration, and this allows it to still be drawn, however with the
obsolete duration the range box can be drawn at arbitrary location due
to overflow of x coordinates. The range duration and other
instance variables are now cleared.

When histogram no longer has data after it has been cleared, the
mouseHover will not set the Canvas tool tip text. It will still show the
tool tip text of the previous occurrence that mouse was hovered. The
tool tip text is now cleared.

Change-Id: I2bf26e5a6e75484496070c5f1842e71c0a1ebe7c
Reviewed-on: https://git.eclipse.org/r/8797
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Save and restore current time and range when switching traces

- ITmfTrace augmented with methods to return current time and current
range.
- TmfTrace implements the new interface.
- TmfTrace provides a method to return the default initial range offset
that can be overridden.
- TmfTrace initializes the time range when the first event is parsed.
- TmfTrace updates the current time and range on time and range synch
signals. The current time and range are only updated if they intersect
with the trace range.
- ControlFlowView uses the trace's current time and range when a trace
is selected.
- ResourcesView uses the trace's current time and range when a trace is
selected.
- HistogramView uses the trace's current time and range when a trace is
selected.
- TmfStatisticsViewer uses the trace's current range when a trace is
selected.
- TmfUml2SDSyncLoader uses the trace's current range when moving to a
new page.
- TimeChartView uses the trace's current time when a trace is selected.
- Reading of the first event to initialize the start time if moved from
TmfTrace.traceOpened() to TmfEventsEditor.createPartControl(), to ensure
that this always occurs before any signal handler is called regardless
of the order in which TmfTraceOpenedSignal is broadcast.

Change-Id: I82b5222521842fcbda28892f6e07c68a05dd8e2f
Reviewed-on: https://git.eclipse.org/r/8802
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix null pointer exceptions in CtfTmfTrace when location is null

This can happen when calling seekEvent(ITmfTimestamp) in TmfTrace with a
time stamp that is past the end of the trace.

Change-Id: I5656b196164925f8179768f9958be1fc1b040550
Reviewed-on: https://git.eclipse.org/r/8801
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix custom traces not indexed for wizard output preview table

Change-Id: Ic0e13babc4444f4a8ec6d5f4f110e50957b31f91
Reviewed-on: https://git.eclipse.org/r/8821
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix first histogram bucket not drawn

Change-Id: I969316f3f0b6c20fb78e7f6e19ed6a89e75ac5e9
Reviewed-on: https://git.eclipse.org/r/8823
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Support for multiple events for same timestamp at checkpoint

If a trace has multiple events with the same timestamps before
a checkpoint and at the checkpoint, the seek to this timestamp
used to return the event at the checkpoint. The implementation
was changed so that the first event in the trace with this
timestamp is returned.

Also the compareTo() method of TmfCheckpoint has been updated
to consider the checkpoint location if the timestamp to search
is equal to the timestamp of a checkpoint. This ensure that
the first checkpoint is found of multiple checkpoints with same
timestamp

Change-Id: I73fa8f19d8a2dcc45da10bd44eaaa4e402f4a0dd
Reviewed-on: https://git.eclipse.org/r/8758
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

Update TMF Environment view to use tree with columns

The new implementation uses a tree to group environment
variables per CTF trace (instead of one flat list).
This improves the readability of this view.

Change-Id: I4784adf32bc88360cec68c54f688000b251e08aa
Reviewed-on: https://git.eclipse.org/r/8757
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Handle 'null' active pages in views

There is a possible race condition when launching the program,
between the platform's window and the views' active page.

Use getSite() in views where possible instead of PlatformUI, and
add null checks where this is not possible.

Change-Id: I2f94a9eb44817ac9ea906ac93efcf6863511a6d8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8772
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix NPEs in Sequence Diagram Framework during shutdown

Multiple instances of NPEs:
- TmfUml2SDSyncLoader
- LoaderManager
- SDView

Change-Id: Iaea3f46b60527cd84dd8f51bd79319c27925ecce
Reviewed-on: https://git.eclipse.org/r/8781
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

Merge branch 'master' into lttng-kepler

Remove LTTng specific sonar and JaCoCo settings

Change-Id: I7e9b6523b16b0342ba427f60fb265c23996e7343
Reviewed-on: https://git.eclipse.org/r/8766
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.ctf.core.tests/pom.xml
lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/StreamInputPacketReader.java
lttng/org.eclipse.linuxtools.lttng.releng-site/pom.xml
lttng/org.eclipse.linuxtools.lttng/feature.xml
lttng/org.eclipse.linuxtools.lttng/pom.xml
lttng/org.eclipse.linuxtools.lttng2.kernel/feature.xml
lttng/org.eclipse.linuxtools.lttng2.kernel/pom.xml
lttng/org.eclipse.linuxtools.lttng2/feature.xml
lttng/org.eclipse.linuxtools.lttng2/pom.xml
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfEvent.java
lttng/org.eclipse.linuxtools.tmf/feature.xml
lttng/org.eclipse.linuxtools.tmf/pom.xml

Change-Id: I5f85d26a7d5d4008cae9a5ed3ed6ebce7f1bd527

ensure bytes returned as int are never negative

Change-Id: I173304573594c66d1d4eccaa9827ce6ac8154b94
Reviewed-on: https://git.eclipse.org/r/8203
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

Fix time range synchronization issues

- ResourcesView is unnecessarily refreshing with initial window offset
on setFocus(). This is removed.

- TimeGraphViewer method resetStartFinishTime() causes time range
notification callback. The method is changed to call
setStartFinishTime() instead of setStartFinishTimeNotify().

- TimeGraphScale handling of mouse double-click is calling
resetStartFinishTime() expecting the notification. The notification is
now triggered explicitly by calling notifyStartFinishTime().

- HistogramView initial window span can be clipped if it is set early
when not enough events have been indexed in the trace. The full trace
histogram time range is now re-set on reception of TmfTraceUpdated
signal.

- The full trace histogram uses the zoom's duration in updateTimeRange()
on mouse up, and this duration could have been clipped. The method now
used the stored range duration, which does not get clipped.

Change-Id: Id480340933494855330fc6d4fae9429155efa88f
Reviewed-on: https://git.eclipse.org/r/8745
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Implement simultaneously opened traces in TMF

- Change all supporting views to use a generic ITmfTrace instead of a
TmfExperiment.
- TmfExperiment* signals removed, replaced by generic TmfTrace* signals.
- TmfTraceOpened signal is sent when opening a trace. Views should get
ready to receive TmfTraceRangeUpdated if they need to coalesce requests.
It is too early to access any state system.
- TmfTraceRangeUpdated signal is sent from the TmfTrace after receiving
TmfTraceOpened. Request coalescing can happen handling this signal.
- TmfTrace base class triggers its indexing on receiving
TmfTraceRangeUpdated.
- Removed indexing of custom traces in initTrace, now triggered by
TmfTraceOpened in TmfTrace base class.
- TmfExperiment initializes the streaming monitor on reception of
TmfTraceOpened.
- TmfTraceSelected signal is sent when the trace is initially brought to
top or any time it becomes the active trace. Any component can also
broadcast the signal to trigger bringing the trace to top.
- TmfTraceClosed signal is sent when the trace is closed. All
jobs/threads/requests related to this trace should be canceled. The
trace will be disposed after the signal has been broadcast.
- These signals can contain a TmfExperiment as the affected trace. Any
view which needs to check or handle individual trace should specially
handle an instance of TmfExperiment and examine its underlying traces.
- Building of state system and statistics moved from initTrace to
reception of TmfTraceOpenedSignal. This allows, in the case of a
reopened trace, for the previous trace to be disposed and its files
closed before the new instance initializes the state system.
- All supporting views cancel running jobs/threads/requests on
TmfTraceClosedSignal.
- ControlFlow/Resources view store entry list of all opened traces in
hash map.
- ControlFlow/Resources view use cancelable BuildThread.
- Cleanup the state system when disposing a CtfKernelTrace.
- Dispose of CtfTmfTrace clears reference to CTFTrace and this is used
to prevent NPE on getNext of disposed trace.
- Replace Events view with editor area in LTTng Kernel and Tracing
perspectives.
- Updated definition of traceType extension for defaultEditor element.
- OpenExperimentHandler opens the experiment in events editor. Default
editor is used unless all underlying traces share a common defaultEditor
in their respective traceType definition.
- OpenTraceHandler opens the trace in default or specified events
editor. It no longer uses a dummy experiment to wrap the trace.
- Removed methods and variables related to current experiment.
- Removed EventsViewEditor previously used as a workaround to open
bookmarks in Events view.
- Removed Clears Views command, made obsolete by closing all traces
(Close All on any tab).
- ITmfEventsFilterListener/Provider interfaces removed and replaces with
signal handling. This removes complexity of handling multiple listeners
and providers being added and removed.
- Fixed missing scaling to nanoseconds of timestamps in
AbstractStateChangeInput.
- Fixed synchronization issue with armRequest in TmfTrace when trace is
disposed (executor is shutdown).
- TmfEditorInput modified to prevent lingering reference in platform.
- TmfEventsEditor implements IPartListener to trigger broadcast of
TmfTraceSelectedSignal, instead of at setFocus which was sometimes
called twice by the platform.
- TmfEventsEditor no longer needs to use inner TmfExperiment subclass to
trigger indexing when experiment opened from bookmark.
- UnsortedPropertySheetPage class created instead of inner class in
TmfEventsEditor which was causing lingering reference to editor in
platform.
- Remove unused TmfTraceParserUpdatedSignal.
- TmfEnvironmentView refactored to update its table on
TmfTraceSelectedSignal.
- Use nanosecond timestamp scale constant where appropriate.
- Add interface to HistogramView to allow its controls to retrieve the
current trace.
- Implement synchronization of time range in TimeChartView.
- Fix lingering reference to completed requests in TmfUml2SDSyncLoader.
- Fix TmfVirtualTable setSelection allowing top rank to be too large
when selecting near end of table.
- Fix hanging wait cursor in sequence diagram view for traces without
any sequence events.

Change-Id: I357accc8fc7ea96544d32db758abff4760682304
Reviewed-on: https://git.eclipse.org/r/8554
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Add the Histogram query API to ITmfStatistics

See the added Javadoc for the complete description. This will
allow the Histogram view to easily plug into the trace's
ITmfStatistics object to get its information (so it can be
optimized for each trace type, etc.)

Change-Id: Ib94aeaa369a8bf40da5246825152e26326a45e92
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8675
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix bug when contexts are enabled but there are no contexts

Change-Id: Iad9f0f9456e4d1e2ee3db6b56e0cd2a30c620bd5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8737
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix benchmark to use ctftmflightweightcontexts

Change-Id: I64ff93f6564aec865370d4f166f7dcadf58a3295
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6769
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

IOStructGen cleanup

Change-Id: If159227f14366770e64c4db494cb986a86bc2a0b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8548
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Add support for older Eclipse version (e.g. 3.6) than 3.8

Change-Id: I67ec91e26e608ddb4b243eb9f21261b070ae6d03
Reviewed-on: https://git.eclipse.org/r/8654
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix unintended black background in HistogramTextControls

This problem is caused by a style bit which is not applicable
for the Group class. The problem is only shown in Eclipse 4.2.0

Change-Id: I11416e8a9642c0d9637d696b2a72c04b1150a5f4
Reviewed-on: https://git.eclipse.org/r/8652
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix initial trace time range.

The initial start time of TmfTrace is set to BIG_BANG so that the
initial time range is equal to NULL_RANGE. This allows to prevent
unnecessary histogram requests when a trace is opened.

Since its base class defaults to NULL_RANGE, it is no longer necessary
to explicitly set it in the TmfExperiment constructor.

Unit tests updated accordingly.

A fix is implemented in custom traces for possible NullPointerException
that uncovered this issue.

Change-Id: Ib1e49f372e1c5b1eaa3aecb972cc2b3830b3fbe3
Reviewed-on: https://git.eclipse.org/r/8603
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Remove seek(time) from CtfTmfTrace and use parent implementation

The implementation of CtfTmfTrace of seek by timestamp worked
correctly to seek within the CTF trace. However, the returned
context contains an incorrect rank of always 0.

This incorrect rank will cause a wrong selected event in the
TmfEventsTable if the trace is used directly and not through an
experiment.

The solution is to use the TmfTrace implementation of seek(time)
instead which is handling the rank correctly.

Change-Id: Ie28c88c8e3263cbcb42349bb033cc61f69634a72
Reviewed-on: https://git.eclipse.org/r/8719
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Replace ITmfTimestamp by long in ITmfStatistics API

Some methods in the statistics imlementations can call each
other, and having to create new wrapper objects every event
is not very interesting... The normalization already happens
in the Statistics view anyway.

Change-Id: I9769a867953d8f38dd2816ca7931b35dc22898a3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8650
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

Implement MultiLineInputDialog for Add Bookmark action.

Supports multiple line description.
Tool tip position calculation is corrected.

Change-Id: I1bf7fc4b32a507b90475f321a054ee4ab7ced823
Reviewed-on: https://git.eclipse.org/r/8615
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

Fix default Content column in events table.

The default Content column in TmfEventsTable was being populated using
the event content value's toString if available, or the event content's
toString otherwise.

This was preventing the possibility to show different information in the
Content column and in the raw viewer. The raw viewer is populated using
the event content value's toString.

Therefore if an event's root content had a value defined for use in the
raw viewer, the root content's toString was ignored for use in the table
column, and the column always showed the same data as the raw viewer.

The Content column is now always populated using the event content's
toString. The (optional) event content value's toString is only used by
the raw viewer.

The filter base class implementation is modified to use the same data as
is displayed by the table when filtering on the default Content
column.

Change-Id: Ic976104743eb8850d8176ce232ca84e0574badd3
Reviewed-on: https://git.eclipse.org/r/8570
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Update Grammar and Add support for callsites

A new feature in CTF v1.9
Add test cases for callsites
Improve other test cases

Change-Id: I10d28768ee267001638c7d5c94452e6eb26b311c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8373
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix incorrect seek by timestamp in CtfIterator.

Change-Id: I7902dead3d15dda15e692738bed227669d49b7e4
Reviewed-on: https://git.eclipse.org/r/8541
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

tmf/lttng: Fix newly-introduced Javadoc warnings

Change-Id: Ic0562e0dbc8538603f9749c8dfe402b5cf34fc01
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8474

Update project settings for CTF/LTTng/TMF

Remove the automatic line wrapping and unwrapping for code
lines. It had the tendency to absolutely destroy the formatting
if used on a complete file. The auto-wrapping of comments
remains at 80 columns.

Also enabled Javadoc warnings for protected fields and methods.
Since protected members in exported packages are part of the API,
those should be Javadoc-umented too.

Change-Id: Iab722d674e1f209f1e2b937ead9f058b9b09cab1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8473
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

tmf: Handle race between state system queries and diposal

It's possible that a state system gets disposed while a query
is ongoing (happens between two successive .getNextChild()
calls, for example).

Instead of implementing a convoluted reader-writer-lock, we can
just catch the ClosedChannelException and rethrow a
StateSystemDisposed exception.

Change-Id: I93f72860bbb94a63e86e7c6f51682af659599fe3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8520
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add a StateSystemDisposedException

Once a state system is diposed, no future queries should be run on
it. If such a thing happens, the new StateSystemDisposedException
will be thrown. This can help views know that they should stop
doing queries.

Change-Id: I1a887cd322a1ac1ee6ffb1705c0c7e794f848f1f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8497
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add dispose methods to the state and stats backends

When a trace/experiment is closed while a state history is
being built (either for storing kernel states or statistics),
the build should be cancelled as part of the trace's dispose().
This means the threads should be stopped cleanly, the files
should be closed, and any ongoing requests should be cancelled.

Change-Id: I0313ed37a927330a46b68024d1926922ddcaefb8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8491
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI

tmf: Add some unit tests to the ITmfStatistics

Also fixed some bugs that those tests exposed:
- Time ranges are now inclusive (both at the beginning and end)
  for all implementations.
- All methods in TmfStateStatistics will now wait for the history
  construction to be complete, so hopefully no more hundreds of
  AttributeNotFoundException's.
- State system queries at the end time should now work correctly
  (the work-around was removed).
- A time range beginning at the trace's start time should now
  return the correct values. I couldn't test with the edge case
  where you have more than 1 event exactly at the start time, but
  I assume it should work correctly too.

Change-Id: Ia4268eeb1c04033a41b4e8ea011a6007bc90187e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8463
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Drop the Type in CtfTmfTimestamp

Also removed all redundant methods in the class and the test.
This brings CtfTmfTimestamp much closer to TmfTimestamp, now
it's simply a wrapper that ensures the scale is set to nanoseconds.

Change-Id: I8242434af7221ae1d6dd964d5c8d80cd0f4e60bc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8047
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

Fix for LTTng/TMF version IDs for R1.2

Change-Id: I933e12a6d0eaef2d8e64baa690d13598b7ebd398
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8471

tmf: Make TmfTimestamp and TmfTimeRange immutable

Mark the fields in TmfTimestamp/TmfTimeRange final, to ensure they
do not get modified after the object is created. The setter methods
didn't seem to be used anywhere so the impacts are minimal.

Change-Id: I693ffef78588e9e68fa3b22516cf93b3f98c6613
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7278
Tested-by: Hudson CI

Update minor version number for plug-in and relevant features.

Change-Id: Id51f03f37d767b26260986f928217613758a3823
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7255

Conflicts:
lttng/org.eclipse.linuxtools.lttng.releng-site/category.xml
lttng/org.eclipse.linuxtools.tmf.core/META-INF/MANIFEST.MF
lttng/org.eclipse.linuxtools.tmf.core/pom.xml

Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Change-Id: Ifce4d4a18d59ca785517bbf8ac64007175e68328
Reviewed-on: https://git.eclipse.org/r/8462
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Statistics provider based on event requests

This patch adds a TmfEventsStatistics, which uses trace event
requests and counts the instances of each event types to
provide statistics information. This is useful for trace types
that cannot use the default implementation using the state
system (traces where events are not chronologically ordered,
for example).

The previous TmfStatistics has been renamed TmfStateStatistics,
to better differentiate between the two alternatives that are
now available.

To keep the request coalescing, the separate threading is now
done is a new ITmfStatistics.updateStats(). This allows the signal
handler code to send the queries, but return immediately and
spawn a thread that will wait for the requests to be done.

When the results are ready, they will be sent back to the view
using the new TmfStatsUpdatedSignal. This makes the handler for
the StateSystemBuildCompleted signal obsolete.

Change-Id: I5b6237aef7f5c7cb373c68e4624376146a6e5086
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8376
Tested-by: Hudson CI
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

Fix for supplementary comments on TmftimestampFormat implementation

Change-Id: I46acc468c064d76cf301618fa47377820d17262f
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8435
Tested-by: Hudson CI

tmf: Allow waiting for a state system's completion

ITmfStateSystem.waitUntilBuilt() will now block the calling
thread until the state system underneath is finished building.
This will be immediately useful for statistics (intermediate
queries are useless, we need to wait until it's ready anyway).

It's implemented using a CountDownLatch, similar to the
.waitForCompletion() in event requests.

Change-Id: I98420acc3ca2903d76a315259f25dca7d88b8d42
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8427
Tested-by: Hudson CI

tmf: Store totals separately in TmfStatistics

This allows the get*Total() methods to query the state directly.
With that, no need to get the map of events per type (which was
already longer by itself), and then add its contents at every
single query.

Change-Id: I2e6708a2708abcdae6cd68baab9b6c26a2cc2d30
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8380
Tested-by: Hudson CI

Fix for the time range histogram

The time range histogram doesn't refresh very well when the new range
has no events either at the start or the end. This patch properly keeps
the range.

Change-Id: I414bb9288327dd9cf56ca8eb22ac2672f4e9e362
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8428
Tested-by: Hudson CI

Implement TmfTimestampFormat

Change-Id: I29d4f815679503c82a14ac74e8395f9aa3dc0cbf
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/8419
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Add support for scoped event contexts

Change-Id: I19f0ed63b494d6f27b434c58691ed428dc991911
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/8110
Tested-by: Hudson CI

Add support for selected event in Properties view.

Change-Id: I41e8cc7a9d9e0c9f8870445741f9559f951eba0f

Temporary fix API version for Kepler

Change-Id: I303c9bbf3b023a4c551586fa04b90d7b8649f69a

Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml

Change-Id: Id994aa08fb1af64b99be885c30fbbeda4e67ce24

Workaround for bug 391232: ISharedImages constants not recognized.

Change-Id: I671fb92236d22c4829bd38a3a076e951595434a6