custom.parsers: bug 494697 Define event names in custom parsers

In custom traces, all events had the same name which corresponded to the
custom parser name. Now it is possible to define a field for the custom
event type.

Change-Id: Icdef3b0dfc73e403b39bd7ceb0e8ff2afaa12db2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73803
Reviewed-by: Hudson CI

Update formatter settings for all plugins

Update all formatter settings files to the Eclipse 4.6 synthax.

The only value that was changed was to allow wrapping at method
invocations. This means that successive method calls on separate
lines won't be auto-unwrapped anymore:

  list.stream()
    .map(...)
    .filter(...)
    .collect(...)

All the other settings are simply new ones, left to their default
values.

Change-Id: I4d405f4954c1587dfafde23cd9f1058bf515b7c0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74106
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Stabilize CriticalPathTest

To reproduce the issue:
Inside CriticalPathView.CriticalPathContentProvider.BuildThread.run()
add a Thread.sleep(5000) just before the refresh() call.

It fails because we get all the tree items of the Critical Path view
before the algorithm and the redrawing is done. Since not all of this
process is done in a job, the waitForJobs is not sufficient. Instead,
wait for the UI to update in the state we want to "assert" on.

Bug: 496588
Change-Id: I2617b017f1d94f000600cd2f25ccce98b3cfe5be
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76153
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: update 4.5 target to build with neon for o.e.remote

Change-Id: Ia01384cf4a417670be77e4470a6cafa37dba4f07
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76122
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis.lami: Add units to timestamp axis title

Units are currently missing in the axis title when the axis is a
timestamp series. This patch adds units based on the axis timestamp
format pattern.

Bug: 493941

Change-Id: I6f03267c5a2704d4b729cc3d666dd30df533053d
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74093
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

releng: Update to tracecompass-test-traces 1.5.0

Contains updated traces with debug-info information, courtesy
of Simon Marchi.

Change-Id: I5e42d08b097fa5e3727c2a41ba0c928e8132c8fd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76104
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

releng: Don't use composite repos in targets

Composite repos often take extremely longer to resolve.
Point to real p2 repos where we can.

Change-Id: Ia5fc195df85de81a33eee3d062b2e9a67fb07ea7
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/76096
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Simplify boolean expression in compareTo()

Change-Id: I7a40de618de0ae6fbc9afbaf21c24ff3cc745f4f
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72104
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

ctf: Remove Array loop from update()

Change-Id: I367978db1df697af90b9e4d56159cf0d7cba3fd7
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71958
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make Trace Compass work with mars (4.5)

Patch https://git.eclipse.org/r/75736 changed the dialog box for
deletion of trace folders to use JFace dialog. The change uses an
API that didn't exist in 4.5. This patch will change it to use the
4.5 APIs.

Change-Id: I71ec510eaedefb790b296264bda6cac857ebc89c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/76037
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

swtbot: Help stabilize SWTChart tests by waiting for number of series

Some tests do not have any waiting for the chart to be populated
before starting to inspect its content. By waiting until the expected
number of series is reached, it is much more likely that the expected
content will be there.

Change-Id: Id0c4f8ec2fae2507ed37c2e3ef9178f789af8b5e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75782
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

lttng: Add Lttng Execution Graph analysis benchmarks

This benchmarks the build time and memory usage of the kernel execution
graph
analysis on some lttng kernel traces. The graph is used to calculate the
critical path

Change-Id: I7e787f4120f084c1acd5a8fdad835bfdb7e71559
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72973
Reviewed-by: Hudson CI

analysis: Keep selection when switching traces Kernel Memory Usage View

Change-Id: I45ba60e1476995c07b9bb0df32733ff837943ddc
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75601
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Keep thread selection and follow CPU when switching traces

Keep thread selection and follow CPU when switching traces in CPU Usage
View. The data is saved in a map in the trace context, so if the view
is closed, it will remember the thread selection and the followed CPU
for each trace when reopening.

Change-Id: I8c56d852a133d0615f58cdb3e8e6b965a7c2f73d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75600
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Add shift-mousewheel to scroll horizontally in xy charts

This makes the behavior of XY charts and timegraphs inlined.

Change-Id: I8296d4f79e34d4f0905bb7cd29fcdc765fe360e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75768
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add system call analysis usage benchmark

This benchmarks iterating through all the segments and getting the intersecting
elements for different times

Change-Id: I1bef84370bec226625ff052a9a912f51aa33e6b0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73054
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.ui: Algorithm for grouping threads in CFV

This patch adds an algorithm for grouping threads in the
ControlFlowView. It works by looking at the arrows that are
shown in the view for a given time range. Those arrows represent
CPU transitions and the grouping is done based on this information.

Change-Id: I4292ea0ba6057f33d22c00f4dbd3e6f1ce46f4d4
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69212
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

releng: Update targets and API baselines to Neon release

Remote and Launchbar do not have release repositories.

Change-Id: I7ae124d1c7ebc0644a43e268cc366fe3f295ca25
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75784
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SWTBot tests for trace actions in Project Explorer

Change-Id: I3c181a0d60c07a259e84cf33d401d9ad97cd82f5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75014
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add missing @since 2.1 in new methods

Change-Id: Idf79b3b39463a257825414b58c3f37dad48e0253
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75679
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Link to LTTng-Analyses releases, not the git tree

Since 0.5+ are not yet supported, the user guide should guide
the user towards downloading the 0.4.x releases.

Change-Id: I8b63a58c8f2d3ed336aba9ee7cdb6fae3a219ac4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75767
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Convert Delete trace dialog to a JFace dialog

It's the same functionality as before when it was a native dialog. But
now it allows us to control it in SWTBot.

Change-Id: I44af835a15bb00d2be6b294c837399caa23c83fb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75736
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

xml: Use equalsIgnoreCase for the 'cpu' field string

Change-Id: Ia410993b506febb5be343c480020d88444a3cf59
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72078
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Prepare the history tree backend for more unit tests

The constructor calls a new @VisibleForTesting protected method
to initialize the history tree. This will allow the stub to
provide its own implementation.

Change-Id: I8bfdcb454ed49b9e77648c7d6da67aa35d6b9efa
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70888
Reviewed-by: Hudson CI

tmf.ui: make XY charts drag the canvas when CTRL-leftclicked

This is more inline with the timegraph view.

Change-Id: Iba8bb83a345be99cd40c7b5e1fdbd300998966c4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75103
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Add utility method to search for events matching a Predicate

Add methods in TmfUtils to search for events, forwards or
backwards in the trace, until an event matching the given
Predicate is found.

This will be used to implement a "Go to next/previous event of
current time graph entry" option for time graph views.

Change-Id: I19c78a459f1918cc41b0094f2a16bf0172b34804
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75325
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

control: command support for excluding specific events by name

We can add exclusions to UST tracepoints. Events that match any of the
items of the list are not going to be enabled. Even if they match a
wildcard definition of enabled events.

Change-Id: Id1522633046f3a3251605ea9b6664be17c40bc49
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74105
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: make XY charts zoom on CTRL-MOUSEWHEEL

This makes the control much more inline with tracecompass as mousewheel
is typically for moving up-down.

Change-Id: I6de6a809e0b15161e6059939d8aedff65f2a596e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75102
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make Shift-Click extend selection ranges

Change-Id: If2130443830b87d83a3e3e012e1f5b944a323f00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75359
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

control.test: SWTBot test for enabling specific event type by name

Change-Id: I900b990712423203710f5b73b920d0995f637bad
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73099
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

control: Bug 490322: command support for enabling specific event by name

Change-Id: I14628d04a7546c10f518c84a2b64be4069cd9196
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72838
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Use 4.6 target by default in Oomph setup

Since we build with 4.6 by default, it makes sense that the Oomph
setup uses 4.6 by default as well.

Change-Id: I63177df57c91eb1c08b806f4b8022dc6c53b0b81
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72177
Reviewed-by: Hudson CI

control: fix tree item selection in SWTBot tests

Before the all tree node was not selected. The test still was
successful due to default behaviour

Change-Id: I6356def3db40cdd3414185d6df6d3d2c16415a6c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75181
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Revert "ctf.core: making some classes final"

This reverts commit 266c4d511bd4c26ca6e5063b53715d9c9ecea674.

Change-Id: I21b23499a79084100256591ba59c8af14de06a2e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75196
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Revert "ust.core: making some classes final"

This reverts commit ac52feb8c7e7dbc3caa69207c1df59b841a7012d.

Change-Id: I4bbdb49c9f4cecf10e628a8274c8fd0f6ef1ac56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75195
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add Trace Compass 2.0.0 baseline

For now, use RC4 update site. Will switch to final release update
site when it's available.

Change-Id: I5bdb53ffd13875912e1aa87a169bbb7a13759f59
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75194
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.ui: hide title and legend in swtcharts by default

Change-Id: Ic4ac8b6ec66732986651a0483fcf3d51a54edc09
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72302
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.core: making fInstance private

Private members encapsulate data well in a class and are not used
anywhere else in the code so they can be easily modified or enhanced
without any side-effects.

Change-Id: Ida21a9a5c576f20ee2a5bee29b80ef02de9eb630
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75095
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Remove overriding methods

Change-Id: I4ff9a10a618f14f5a08ce9d46cc15ca6ce94349a
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71943
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: Change the == operator with the equals() method

Change-Id: I4633d1aa33c49fc7e1da3bb449cb5a25e85870a4
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71935
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Split axis titles in label and units

The axis titles are now built using the label and units strings,
which makes it easier to override or remove the units of an axis.

Bug: 493941

Change-Id: Icd63f9678084029c6ccaf2a6c51b607ccc71c0ab
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74092
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: buf 495911 Fix timestamp transform fast for small timestamps

Change-Id: I64f3fc6c113fd240506a6d972430bda94ed05afb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75187
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

linux.core: making SyscallNameAspect final

This patch is to make a class final in linux.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: I6df113ac664cb7e11981de84d64460d3c90cacb3
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74715
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

control: command support for enabling all tracepoints/syscalls

Change-Id: I68f2783bfa9ff7882f8956a06028c0d63d286e98
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72207
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: allow filters for when enabling events on domain level

Change-Id: I1dcebc5c204f7d906ce5dd723a25153280689d96
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72206
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: add names of traces in sync algorithm stats

Two lines were added to match traces Ids with traces names so it can be
easier to see which pairs were synchronized.

Change-Id: Iec69283080a12668c02d5886b4bbf95e1440ac00
Signed-off-by: Cédric Biancheri <cdc.biancheri@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74674
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Update targets with latest launchbar

Change-Id: Ic67b5dcd47c94cb5da04123f9a330d5400f25d6c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74912
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

rcp: Update copyright year in branding files

Change-Id: Id72825366f573b71a4247402a015c7baebc3d74d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74891
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

releng: Update targets for Neon RC4

Also update staging target, I forgot to update it last time.

Change-Id: I1f6846934bd21147a07c6e97e6a715bad816c098
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74847
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Document the external analyses feature

Bug 495211

Change-Id: I323e83b23f3a90591a9d24d0ecd067cb6e34b925
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74813
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: Correctly reject lttng-analyses > 0.4

Trace Compass does not currently support the LAMI 1.0 protocol,
which means lttng-analyses 0.5 and up should not be available
and should be striked out.

Correctly update the max version number to make it so.

Change-Id: I65a33db732dba7725284840b2bcd0b2ecaab9d3a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74839
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Bug 495211. Add flat/hierarchical threads presentation user guide

Change-Id: I11a6c4f9293e0118f032e0da01d2984d8bb65fc1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74777
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Bug 495219: Fix NPE in checkpoint indexer seeking on disposed trace

In BTree, if it is disposed (file is null), return -1 (insertion point
0) in the binary search. This will correspond to checkpoint 0 in the
flat array.

In FlatArray, if it is disposed (file is null) return null as checkpoint
in get(long).

In TmfCheckpointIndexer, if the returned checkpoint is null in
restoreCheckpoint(long), return the context given by the trace
implementation of seekEvent((ITmfLocation) null). It should properly
handle a disposed trace.

Change-Id: I3148d2e10118628e387d206054de55d5238a9807
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74474
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Make use of "is_pic" event field in debug info analysis

A field with name "is_pic" is now present in LTTng 2.8 final in
"bin_info" events to indicate if the referred binary is PIC
(position-independent code) or not. We can make use of this
field to identify PIC binaries much more reliably than by just
looking at the file name.

Bug: 495551

Change-Id: Ib553f43e8236c399c56387ff8e20a8428c688fb5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74616
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Update targets for Neon RC3

- launchbar doesn't have a RC3, only RC2.
- Make sure SWTChart 0.7.0 is used, the newer version will not be
used for Neon.

Change-Id: I5bb6195bc79651e5f596ade765e37086794a162a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74160
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Bug 495211. Update follow CPU in user guide

Add follow CPU to Resources View user guide and CPU filtering to CPU
Usage View user guide.

Change-Id: Ie0572582f9228b7a4784d612e21fcca07dc9ccba
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74718
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ust: Simplify conditional in equals()

Change-Id: I66add0ec275904fdc25df899d440041b7fa78882
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71962
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Bug 495211: Update developer guide for ITmfStateSystem API

Change-Id: I20bad86bfbd2bde033e04b8ea215fe0a6d2ac847
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74725
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Bug 495211: Update TmfTimestampFormat reference API

Update TmfTimestampFormat.html link to external user guide location.

Update pom.xml to copy the reference directory in deploy-doc profile.

Update external Javadoc links to Java 8.

Change-Id: I6fc2e12ca4c0b8aac8253d0f805ad3c5d76dd8c7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74716
Reviewed-by: Hudson CI

doc: Bug 495211: Update developer guide signal reference

Change-Id: I432fb33f118c39f0011708187b85022996bccd6d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74726
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Bug 495211. Update Statistics View user guide

Change-Id: Id266dbb9ba577edea8acafbc196cfbc29f37cfb2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74704
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

analysis.lami: Use openResource command to run analyses

Bug: 493941

Change-Id: I628c5f7aef0674f4e83dbd9e611ec3616754f758
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74615
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

analysis.lami: Use the openResource command to open reports

Instead of defining our own command, we can hook into the
Eclipse-provided org.eclipse.ui.navigate.openResource command,
so that the reports can then be opened using the usual
keybindings to open resources.

Also hook it into OpenAction so that Enter and double-click
opens the report.

Bug: 493941

Change-Id: I4c546b60a77c2d531c8c9f18961984e5962ef56f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74569
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

analysis: bug 494786. Clear process selection when switching trace

Clear selection in CPU Usage view and Kernel Memory Usage View when
switching trace.

Change-Id: I57618581048995904fa71a9f24d65453eea9ae94
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74261
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Bug 495211. Add timing views and viewers developer guide

Change-Id: Icc60e2838c884188fcf314032ff89cde8bbef743
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74544
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Bug 495211. Update Go to min/max documentation

Change-Id: Ia6817483a4b6c03afcde050026ea218479681ad4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74380
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Bug 494952: Remove deadlock in Time Chart view

The handling of signal TmfTraceUpdated is now done in a
ProcessTraceThread. There is only one such thread per trace active at a
time. If an update is requested while a thread is active, the thread is
marked to be restarted after its current iteration completion.

The starting or restarting of a ProcessTraceThread is consolidated in a
method and synchronized.

The ProcessTraceThread now always processes the full time range of the
trace, even when the view is opened with a trace already opened.

A missing synchronization on DecorateThread concurrent access is added.

Method ITimeDataProvider.resetStartFinishTime(boolean) is added to allow
the TimeChartView to reset its window range without notifying listeners.

Change-Id: I0d49d2712af4e5c645bd61bfde46ba37fc42779c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73996
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: bug 495211 Add the I/O analysis documentation

Change-Id: I9e790c1b9bfd0e9a0c35f303d9660bb522c6cf93
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73985
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

kernel.core: making some classes final

This patch is to make some classes final in kernel.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: Ie74fb3a6a36075cd355bdc58f4fe1deb3fc4a82a
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74558
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

doc: bug 495211 Update analysis requirement doc

Change-Id: I8fe98347c74de13dbb5786bc2b0654875227b0a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74669
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: bug 495211 document the critical flow view

The documentation introduces the view and the required steps to actually load
and run the wait analysis on a process.

Change-Id: I860ef950ef48381c5b5da3009d0a780970684f94
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74568
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

doc : Bug 495211. Update analysis requirement doc for new API

Change-Id: I1523b873303c8958fe6b91ab5bf1537897ba2373
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74546
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: merge control flow on ranges equal zero

Even thought it is the expected behaviour Coverity/Sonar flags the two
"if"s as a potential code duplication and infers an error.

Let's comply to Coverity/Sonar.

Note: Patrick Tassé did mention to merge the two "if"s during initial
review [1] and it was simply forgotten.

Coverity ID: 115874

[1] https://git.eclipse.org/r/#/c/73239/7/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/format/LamiTimeStampFormat.java

Change-Id: I22cf9499eb53fd547ae3ebfc73161f21db5cac47
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74314
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Hudson CI

xml.ui: Bug 495415: Safely absolute a hashcode

It is possible for a call to hashCode to return
Integer.MIN_VALUE. Take the absolute value of such
a hashcode and you'll still have a negative number.
Since your code is likely to assume that it's a
positive value instead, your results will be unreliable.

Similarly, Integer.MIN_VALUE could be returned from
Random.nextInt() or any object's compareTo method,
and Long.MIN_VALUE could be returned from Random.nextLong().
Calling Math.abs on values returned from these methods
is similarly ill-advised.

Change-Id: I44396a35d3efd046b8a082ebb57c070387d9f90d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74533
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

doc: Document how to use LTTng-UST 2.8 source lookup

Bug: 495211
Change-Id: I6cd1dda9bb9039ad028ec65cf07447da9ad9e85b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70716
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Enable address mapping config action for all traces

The Call Stack View only enables the "Configure address mapping"
action for traces that provide function entry/exit info. However,
since this configuration is now used by the generic ISymbolProvider
and can be used by other analyses, the dialog should be accesssible
for all traces, as long as they provide a preference page.

Bug: 494212

Change-Id: Ia9db94e051226fb79adfd502f6081857954042d0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73337
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: test TmfRawEventViewer using SwtBot

This tests keystrokes too to make sure that there are
no surprise exceptions.

Change-Id: Ia2a325a0a520bde3db56a04ddf1779a095342ecb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72865
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 495067: Canceling remote import shows Internal error dialog

The OperationCanceledException is now caught gracefully.

Change-Id: I2da2fd00e50b14d3a215aa2389ea241e51fb698f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74117
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 494810: SelectionEvent not sent after using vertical slider

The vertical slider used by the TmfVirtualTable is created with the
SWT.NO_FOCUS style. In Linux-GTK, this hint is not respected and the
slider can gain focus. When this happens, give back the focus to the
table.

This allows the SelectionEvent to be sent when extending a selection
using Shift+Click in the event table after using the vertical slider.

Change-Id: I9a8d7083300a5c515c24110d5572d30b6bd9d7d6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74119
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

xml: bug 493954: Allow string states to be displayed in time graph views

If a string state value is to be displayed in the time graph, it will add
a new state to the presentation provider with color. This state will be re-used
when the same string is displayed again. This is ideal for time graphs of state
system where there is a fixed number of strings as value, yet impossible to
define with definedValues because specific to a trace.

Change-Id: I2d1fa041e578e0a7dbccc3138153db3fd4684c62
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71970
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Bug 495211 Update XML XY view documentation

The kernel analysis was moved.

Change-Id: Ibaf3843b43e15d7fe742e1e9b05b6e40250f5fec
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74326
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Bug 495211 Update CTF documentation

Change-Id: Iafeacbf118de123d96d54e422e718a0d2a7fff37
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74325
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

segstore.core: Synchronize isEmpty

This avoids race conditions

Change-Id: Ifb252a4011aed88118b2db8abd6c49be49c0d175
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73744
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf.xml: Delete existing supplementary files when importing xml analysis

Previously, if we import a file that was previously loaded once, traces
won't be notified that the file changed.
Now, if the file already exist, the supplementary files for the analysis
are deleted and the related traces are closed.

Change-Id: I62ce6e6f4295db5f0c82e4c77ae73b4e5a4c1b85
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73648
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

doc : Introduce the data driven XML pattern documentation

Change-Id: Ib00876610f4b93000a3968b20487077fdebe47a1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72304
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

linux.swtbot: Add basic critical flow view test.

This tests runs a true integration test with the control flow view.
It signals the critical path view from a right click on the cfv.

Change-Id: Icc04e03de0b745eb966bb711494eab749b8b08c6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72360
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.lami: remove unused font height for error labels

The method setHeight() does not modify the reciever. Thus,
the size of the error label didn't change.

Change-Id: I1cb656429d5a45dff310c8f6fe94aa99760b92fa
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73981
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

pcap.core: making some classes final

This patch is to make some classes final in pcap.core component.
It should be final to improve readability and since you should never extend
it. It also allows the jvm to inline methods and improve performance.

Change-Id: I7288b25324cb343a33cf6536b80cdaae3619211f
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ctf.core: making some classes final

This patch is to make some classes final in ctf.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve performance.

Change-Id: I6e9bef701898716978c6e7b4b20254eabc8cd6c8
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73771
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ust.core: making some classes final

This patch is to make some classes final in ust.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: Ifa5d1e667efb3e18f5cd4a9037082469574c16c6
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73972
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: correctly handle Number (double, long etc.) type graphing

LTTng analysis return mostly long values either for the time stamps or
actual measurements. SWTChart, on the other hand, deals only with
"double" numerical values. Casting long to double causes a loss of
precision for big long value (e.g time stamps).

E.g: Loss of precision occurs when time ranges with a big minimal value
(2^62) but with little delta (1 ns) between events exist. Graphs
generated from such time ranges as an axis would result in a single dot
which is a clear problem.

The presented solution uses linear mapping to preserve resolution and
precision when possible.

The linear mapping requires two ranges: the internal range and the
external range.

Each graph is responsible to provide an internal LamiGraphRange. This
range is the internal representation in double in which all raw
(external) value are to be mapped. For now the default internal range is
0 to 1.

The external range [raw values range] is generated by finding the
minimal value and maximal values of aspects to be plotted.

Each point is then mapped to a corresponding value from the internal
range:

eV = external value
eR = external range
iV = internal value
iR = internal range

iV = (( eV - eR.minimum ) * ( iR.delta / eR.delta )) + iR.minimum

Since the default internal range is from 0 to 1 all raw values are
mapped to a value from 0 to 1.

On graph tick generation axis formatter transforms internal
representation to external representation and formats the result.

Other change:
- Aspects now return their numerical values via resolveNumber to ensure
  no casting is done.
- Move axis formatter to ui plugin.

Bug: 493941

Change-Id: I289180e10a7f1cbf6ecdd1beba93549b8fbe4c23
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73239
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Bug 495054: Importing or exporting custom parsers fails silently

When importing custom parsers from a file that does not contain any
custom parser definition, a message dialog is shown to the user.

When exporting a custom parser to an existing file that is not a valid
custom parser definition file, a message is logged to the Error Log.

Change-Id: I2f0bb781d9d43d8bbaf05da2b7ec06c2a65d47d3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74094
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: [bug 494974] Fix left panel click handling in timegraph in Linux

Clicking on the left panel in Linux currently deselects the
entry. This behavior is particularly egregious in the case of
UI unit tests.

Change-Id: I18fbe001c6b7325c6618e46c22f13ad976357abe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73998
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 494767: Events in selection not updated in Statistics view

- Make sure the time range created from TmfSelectionRangeUpdatedSignal
always has the earliest time as start time.

- If the events per type map is empty for a time range stats update,
reset all time range event counts.

Change-Id: I2c860bdd0dd9e033933c690f230aaf79e6f60b5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73973
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494790: Time Chart view does not update when adding bookmarks

The Time Chart view now properly shows the bookmark decorations.

Change-Id: I5e25171f61afea79fdd0e2206ef3254731ecb497
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73956
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494589: Event table loses focus when pressing Ctrl+Enter or Esc

This gives back focus to the table after pressing Ctrl+Enter or Esc from
a header row cell editor.

Change-Id: I85fe91739a0b4422de3168dd9ea2fbb197853a6b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73953
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

critical path: bug 495020 fix statistics when reopening a trace

Change-Id: Ie67aec3a9ea5c114dd7005817da76daf9b764d5e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74043
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

critical path: bug 490086 Set start/end time for the trace

Previously, the start and end times of the critical path were set when building
the entries list for each critical path. Each worker had different start/end
times, different from the trace's and when getting a previously calculated
critical path, it would not reset the start/end time so the results were not
displayed correctly.

This patch sets the start and end time of the critical path view with the data
from the main execution graph, not the current worker's critical path.

It also gets the previously computed statistics in the content provider instead
of the analysis start.

Change-Id: I7c08f7776b375b033575bc56c51d1cff36b72068
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73513
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

critical path: bug 494196 reset selection when trace selected

This resets the selection in the parameter provider so that if a thread is
selected again in the control flow view, the selection change is triggered
again.

Change-Id: I92f4203d0181f996efcbc2618c32d35311761003
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73318
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

critical path: bug 490085 Always start critical path from head vertex

Previously, the critical path was calculated starting at the start of the
window range, but that behavior was not intuitive to the user and it was not
possible to change that window range once it is calculated.

Now the critical path is calculated for the whole of the worker's lifetime.

Change-Id: Id76192eec04dff6d3c45c1bd1314248d4ea991fb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73515
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>