lttng: Add script to copy the project settings from tmf.core

This will help keep consistent project setttings across plugins.

Change-Id: I20ebb8efdecf0c93d02cdb0f192fca387173b3b4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25092
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix IOException drag and dropping trace on open experiment

The editors must be closed before deleting supplementary files.

Change-Id: I538c77dd1da3b2ccfb99986ce225e9b6a2c46f7a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25213
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Add a unit test helper to execute protected methods

This new class contains a method to call the protected executeAnalysis of
TmfAbstractAnalysisModule to be able to test the analysis execution simply,
without having to go through an Eclipse job and needing different threads.

Change-Id: I8043f956d405b4bf7f81787e028f67601a4c3fa0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24897
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Refresh only the supplementary files for the current trace

The method has been moved to the TmfTraceManager
Also corrected a typo in a constant name.

Change-Id: Ieaa83c525defad09499458ab48a45ef14b2baa0a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23939
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI

tmf: Fix Select Traces command does not refresh trace type

The trace type for an experiment trace in the Properties view did not
appear until restart.

Change-Id: I426403cca68ad650637c9d625198ce80948fb977
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24883
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Add an interface for strings regarding a session configuration

Creation of the lttng2.core.session package with the strings that will be used
for session configuration generation. We also externalized the bundle for the
kernel and ust plugin.

Change-Id: If51a4805064ed701a2bbf31a7f327406410f71a6
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23422
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ctf: Do not call System.gc() in CTFTrace.close()

This call is used to workaround a bug/limitation of MappedByteBuffer
(see JDK-4724038). But CTFTrace.close() is called quite often
(for example, once per trace when closing an experiment), so it is not
the best place to call System.gc(). Instead, only call it when we are
about to delete/rename a trace.

Change-Id: Ib9b346dd04df4f64289ac9db0b976e6b70ff2551
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25174
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Add a view for the CPU usage analysis

This view contains a tree viewer to show all threads spending time on the CPU
in the time range, and an XY chart viewer to display the total CPU of all
threads and the CPU usage of the currently selected from the tree viewer.

Change-Id: Id96fa1005623601539fad10e28949691b70ea1df
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22522
Tested-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Increase the delay in SignalThrottlerTest

This test started failing spuriously on Hudson recently, but the
delays were a bit aggressive. Increase them a bit to give the
test more chance to pass.

Change-Id: I07b6933bcedbb8e095dced0fb57e582b8ba8adff
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25171
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make CtfTmfTrace AutoCloseable

While we won't be able to make ITmfTrace closeable anytime soon (every
time you get a local reference to a trace, it'd expect you to close()
it, which is not what we want), CtfTmfTrace can benefit a bit from it,
as it helps pointing out some tests that are causing resource leaks.

Change-Id: Iaa163799390e01c9d4e996e2be1c5f160382aacd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25091
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Make CTFTrace and its reader classes AutoCloseable

Basically just replace their dipose() method with close(). This
small change allows us to benefit from the compiler warnings for
when a resource is allocated locally in a method but never disposed.

Which then allows to find leaks. Many leaks ! Many tests were leaking
CTFTraceReaders and the like, but the biggest offender is probably the
validation methods in LttngKernelTrace and LttngUstTrace: trying to
validate a non-CTF trace could potentially leak a number of file
descriptors equal to the number of files in that trace(!)

Change-Id: I7e54416b608992a14a7bfd3cd29ffb8dc3cee898
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24986
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Split "CTF adaptor" into separate plugins/feature

This allows using TMF without CTF, for more flexibility and
better separation of dependencies.

Change-Id: I5d84ebcf92014601eb293b95085ef1a046e7188e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24752
Tested-by: Hudson CI

LTTng: CPU usage analysis from the LTTng kernel trace

This analysis creates a new state system to save the total time spent on each
CPU by the different threads. It then uses it, along with the LTTng kernel
state system to compute CPU usage statistics in a time range.

Change-Id: Ia60e95c3bace646477aef06d58bdb7ed64c32bd4
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/21633
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

TMF: Add an API to query analyses to obtain their requirements

Change-Id: I764291e0ca5281550a16d61a9aa8dbf5ca05d390
Signed-off-by: Mathieu Rail <contact@mathieurail.com>
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/22389
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI

TMF: Remove dependency on CTF for analysis unit tests

A new trace stub is added to allow running the test analysis
with a second trace type.

Change-Id: I64298d41c08254031eccf4637369233a5c3ce7bf
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/25018
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: allow intervals with variable size

Remove the fix data size of a HTInterval in HTNode.

Change-Id: I116053884328318379a72643e7c4bf64b3b912c0
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/24795
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Fix drag and drop to experiment unnecessarily prompts for rename

When dropping a trace to an experiment in the same project, name
collision occured and the user was prompted for rename.

Change-Id: I0db0d81610a7afbb1df762838bf2129db510c962
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24884
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf/tmf: allow multiple traces to be open with name clashing events

This is a problem not yet encountered but that will be a showstopper.
If you have two traces with event definitions that have the same name
but different payloads the second one will override the first.

This means that if I have two traces with events that are named "bob"
and we have a state provider for each that looks up different fields
in "bob", one will no longer return the correct values and exceptions
will be thrown everywhere.

Change-Id: I05f9bc0fbbd67374fcf3680d75fcb769c4f32a3a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23285
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Use Antlr 3.5.2 for parser generation only

This change keeps the Antlr rutime at the same version (3.2)
but upgrades to 3.5.2 at the parser generation time (maven)
so that it builds with Java 8.

Change-Id: If9969034777534671d9ec23b19495ce2cf341fdb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24821
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : queryHistoryRange performance fix

This patch removes unnecessary loops for small resolutions,
which increases the performance.

Benchmark :

Before :
Query resolution 1022444670: 0.245
Query resolution 102244467: 1.167
Query resolution 10224446: 3.390s
Query resolution 1022444: 4.028s
Query resolution 102244: 4.285s
Query resolution 10224: 5.451s
Query resolution 1022: 10.970s
Query resolution 102: 37.396s
Query resolution 10: 306.308s

After :
Query resolution 1022444670: 0.278s
Query resolution 102244467: 1.138s
Query resolution 10224446: 3.373s
Query resolution 1022444: 3.976s
Query resolution 102244: 4.329s
Query resolution 10224: 5.309s
Query resolution 1022: 8.001s
Query resolution 102: 8.145s
Query resolution 10: 8.231s

Reference :
Performance with queryHistoryRange without resolution : 8.414s

Change-Id: I6022dc6c562d994310f9419c362dd1f06a414036
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21155
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

TMF: Moved the "Import XML file" under the custom parsers

And changed the text of this menu item.

Change-Id: Ie49a2a65664ee5341b9d4da275050412415a02fb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24737
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Temporarily revert to previous update sites.

Change-Id: I3473e08891b74d3aaa235234482ef4986a633528
Reviewed-on: https://git.eclipse.org/r/24812
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>

lttng: Updates to target definitions

- Use eclipse.platform instead of SDK since we don't need JDT, PDE, etc
  This doesn't work for the 3.8 and 4.2 target because the
  org.eclipse.platform.ide product fails to start (missing splash
  screen?).
- Use cdt.dsf.gdb feature only since we don't need anything else from
  CDT
- Depend on Kepler's jdt.annotation package in the 4.4 target, to make
  sure we get 1.1.0 instead of 2.0.0 (the latter requires Java 8).
- Add license feature (to export RCP from inside Eclipse)
- Use latest Orbit repo

Change-Id: Ia5535cd054fccf2089c333828b331342d0fb434f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24744

tmf: Fix TimeRangeException in TmfStateStatistics

Change-Id: I300a1ef9dcfdf32abc99bbcbec2d80999b51d0ba
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24670
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fold AlphaNumAttritbute class into the main one

Initially it was planned to allow for different types of attributes,
which could have children whose name could only be numbers, or
sequences of alphanumerical characters.

In the end, it was too complicated to expose this functionality in
StateSystem's API, so to remain as generic as possible, all attributes
are of type "alphanumerical".

The separate class is now unneeded. This also simplifies synchronizing
the container of sub-attributes (which should fix bug #431706).

Change-Id: I626bd07de660131ef6432cb10b0e783201c24782
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24275
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix IndexOOB exception in HT node with concurrent read/write

Similar to bug #432191, but with the History Tree backend. It's possible
for an attribute to be created, sent to the backend, and written to a
node, all while a query is ongoing. (That's a race condition where you
race a Formula 1 against a turtle, but the turtle somehow arrives first).

Simply ignore those new attributes, since their value at time 't' would be
null anyway.

Change-Id: I072a08e84795a321c3b2bb393d9880ac4ba13a6a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24674
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add Guava dependency

This allows usage of some Guava goodies, namely additional
Collections (MultiMap etc.), the convenience methods (Lists.*),
and the ImmutableCollection versions.

Change-Id: I85c4fb32e7d5db368c35f17109563caedb2c9d73
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24587
Tested-by: Hudson CI
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Fix IndexOutOfBoundException when querying state system

Fixes bug 432191 where the size of the stateInfo array may be smaller than
the ongoingStateInfo when the method is called. We use the size we know is the
smallest to avoid this exception to be thrown.

Change-Id: I1494940726b952ffe94560a7bed6e5764ff3d8f9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24661
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Refactor bookmarks file handling

The interfaces used to set or get the bookmarks file from an editor or
experiment are removed as they are not necessary. The bookmarks file is
the file in the FileEditorInput of an opened trace editor.

A convenience method is added in the trace manager to get the editor
file for an opened trace.

Change-Id: Ia4bd1999a4015b0251f867d46d0bd2d732a8c4bd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24355
Tested-by: Hudson CI

tmf: Fix linked property inadvertently removed by 35b4320

Change-Id: Iecb9aff2965b0572e8854bd937dcd4926a0b6b11
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24584
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 424964: Drag and dropping a linked trace doesn't create a link

Unless the DROP_LINK operation is specifically requested by the user
(e.g. by holding Alt key), the source resource type (linked or not) is
now maintained during the drag and drop operation.

The handling is also changed to allow drag and drop of a resource in a
Tracing project that is not part of the tracing model (e.g. a file or
folder that is outside of the Traces and Experiments sub-trees).

A possible NullPointerException is fixed when the link creation fails.

Change-Id: I3b80ee508bfecb4023a1b52b2befdda7003d3794
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24475
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Beautify TmfExperimentContext's API

Instead of exposing arrays and letting callers change the arrays as
they please, provider getter and setter methods for each operation.

Change-Id: Ideb685697925d3fc8f0c7ba086be29af276c7d1e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24125
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf rcp: Disallow opening trace viewer with the same workspace

Change-Id: I1edac96b395ed9bfd8b87246940626e39e83ade2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24544
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add source location to trace properties

The source location property is added and contains an URI indicating the
original source for a trace.

The source location URI depends on the method used to add the trace to a
Tracing project:

- Import wizard
- Batch Import wizard
- Open Trace File command
- Open Trace Directory command
- Drag and Drop from workspace
- Drag and Drop from external source

file:/<path>/<file>
file:/<path>/<folder>/

- Import Trace Package wizard

jar:file:/<path>/<archive>!/<path>/<file>
jar:file:/<path>/<archive>!/<path>/<folder>/

- Import action in LTTng Control view

sftp://<host>:<port>/<path>/<file>
sftp://<host>:<port>/<path>/<folder>/

Change-Id: I6bc4dc52bbbddd03d6f33ac4fc3d194cc1bded74
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24268
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Add XML state system view definition to the XSD

Change-Id: I3cad7bd42b2b263837b62392b5169781c5f9b26a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23159
Tested-by: Hudson CI

tmf: Add Open With menu for trace elements in project explorer

The menu item is only available when the trace resource is a file.

Change-Id: I6951764fe5e357467020938c3f3802621e591aef
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23926
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

TMF: Add support for XML-defined analysis outputs

Change-Id: Ifb1436b79a342e3ce169616f65ad293bf5eae1a6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23158
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

TMF: Refactor XML model code, using factories to re-use element parsers

The same XML syntax (and thus parsing) can be used for many XML components'
element, like state providers and views, but the behavior of each component
may be different. We use a factory to define create the classes with the
various behaviors.

Change-Id: Iec5d54155b93a79b1ebc5ffeb8eaffef5e6569ca
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23157
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Replace event matching API to use Collection

instead of straight arrays. This is more flexible, and indicates
that there is no notion of ordering of the traces. Had to replace
one instance of List.get(i) with a map of traces.

Change-Id: Ia25d79b4735b0acb5d4c56975e5e384ad39ad583
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24078
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Fix batch import doesn't respect user-chosen trace name on copy

When the user changes the trace display name in the batch import wizard
(for example to resolve a name conflict), this name is not used when
importing if the copy option is selected and the trace is a folder.

This prevents the trace type to be set correctly on a single trace
import, and prevents name-conflicted traces to be imported properly.

Change-Id: I3dd04ca5deeaf5d4f9327ef13e7c1fdd5dcd2b62
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24122
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Avoid unnecessary trace type selection during drag & drop

In some cases of drag & drop the trace type id of the target resource is
already known (set during the copy/link of the source resource, or if
the source is a trace in the same project).

In that case the trace type id should be used for refreshing the trace
type of the target element, instead of selecting the trace type by
validating the trace against all known trace types.

Change-Id: Iffa7b3c90034d7ce23b81e31d7e5632f74de189c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23881
Tested-by: Hudson CI

tmf: Fix empty trace properties when trace name has regex special chars

The trace properties (e.g. CTF environment variables) are empty when the
trace name contains regex special characters such as '(' ')' because
this causes failure of a replace of the trace name in the prefix of the
property descriptor key.

Change-Id: Ie682ee91f14249d32b26dd60d8c9511004c1ab1f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24027
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: mini benchmark for performance regressions

Change-Id: I951e3abe0f51e7e267411d416e0bccd83f8327c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23662
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Validate new trace type before setting it

Also change the return type of TraceTypeHelper#validate to return an IStatus
instead. This patch fixes bug #431646

Change-Id: I893ade44645f92dfe231cb603e16e6fbf17209eb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24208
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Convert CreateSessionDialog to a TitleAreaDialog

This allows to display an error message as the fields are modified.

Change-Id: I0974265872e1648e8a7c7ca7a7d89cf36b260394
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23592
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Speed up the lttng.ui tests by reducing a delay

waitForJobs checks every second if the job manager is idle.
I could check more frequently. With this change, the test
runs in 90 secs instead of 240 secs.

Change-Id: I97900a9bd5b511db5309180724eef982d0fb1f57
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24035
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

[TMF] Increase visibility of some package protected methods

Therefore, these methods can be used in subclasses and/or from other packages.

Change-Id: Ie5ef3408dfc8add0d4da8279c18a7c6391381250
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-on: https://git.eclipse.org/r/24057
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Fix NPE when dropping trace with unknown trace type

NullPointerException occurs when drag and dropping a trace with unknown
trace type to an experiment, or from another project to the traces
folder, but as a link.

Change-Id: I5060ac7315a3be1eb37779d933a12fdfa2f42cb2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24095
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: Fix trace properties not shown when location URI has encoded chars

The trace properties (e.g. CTF environment variables) are not shown when
the trace element's location URI contains encoded characters (e.g.
space=%20), because the trace path uses the decoded characters and
therefore does not match the trace element's location.

The patch also modifies the output of the 'location' property to show
the unencoded URI string.

Change-Id: Ida0c56096b88690058eccfc5e408222fd461f7b7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24022
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

TMF: Add get parent to state system

It is possible to get the children of an attribute. This patch add also
required methods to query the parent attributes.

* Add getParent() method to Attribute, AttributeTree and StateSystem
* Add unit test to check the functionality
* Provides the required documentation

Change-Id: I635326068c2a298b32952599e09b2426b2e1fbb0
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24026
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Fix time graph combo freezing when expanding parent of many items

When expanding an item in the time graph combo, the expanded state of
every child item needs to be synched between the tree and the time
graph, due to inconsistent behavior between platforms. When the parent
has hundreds of child items, this can take several seconds due to the
inefficient searching for the item corresponding to a time graph entry
in both the tree and the time graph, for getting and setting the
expanded state.

For the tree, instead of gettting the expanded state of each item from
the tree viewer using the model element, the set of expanded elements
is retrieved once and the expanded state can be deduced by the presence
or absence of a model element in this set. Furthermore the synching of
expanded state is only performed for child items that have children
themselves.

For the time graph, the item model is changed to use a map from time
graph entry to time graph item, which greatly reduced the time necessary
to find the item corresponding to an entry. The expanded item index is
also stored directly in the item which avoids the need to iterate to
find an expanded time graph entry's index.

Change-Id: Icefc393be8a5e2ee1a98b98a2c6b126da7490035
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23817
Tested-by: Hudson CI

tmf: Improve time graph combo responsiveness

- Optimize computation of visible expanded items list and prevent
unnecessary recomputation.

- Optimize alignment of tree and time graph item heights and only align
currently visible items.

- Remove the paint listener used to align item heights and add a common
method to simultaneously align the top index and the item heights when
necessary.

Change-Id: I4aedb6ca5973f867288a8334d92c53e688b775fe
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23413
Tested-by: Hudson CI
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix potential memory leak by dispose histogram data model.

It removes the references to trace objects.

Change-Id: I58f7793d79c4c6dc766eef119f29ed1d0c2063ed
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23736
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

add key shortcut for zoom control

Change-Id: I0d6aef31b8ad27d073708883d44e614c0cc7f345
Reviewed-on: https://git.eclipse.org/r/23687
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

lttng: Move createSession parameters into SessionInfo class

Change-Id: Iaa45647fcfa69fd3e62fdb56baf68070b27cad27
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23591
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Use ConcurrentHashMap in TmfStatisticsTreeNode

Since multiple threads can update the statistics when using
experiments with more than one trace the tree node structure needs
to thread-safe. Using a ConcurrentHashMap instead of a regular HashMap
avoids ConcurrentModificationException for the current way this class
is used in TMF.

Change-Id: I38127466066660f82fb9cddd1465cb5e62c114c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23719
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: dispose viewer in TmfStateSystemExplorer when view is closed

By doing that the viewer is deregistered as signal handler.

Change-Id: I2766d32053c11cd7c8bb14d45bf7f5a479bdaa88
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23670
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI

tmf: fix memory leak in TmfTrace by clearing analysis modules map.

Change-Id: I54d6078d2c2e447263f4fede6978f781ef37cc31
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23737
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: add test to check if views are populated in a given perspective

Test tracing perspective
Test kernel perspective
Fix perspective id

Change-Id: Ia671ad54215899fb5a5d578cc592f33669088065
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23510
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

TMF: fix bug in XML getChildElements to return only the children of a node

The getElementsByTagName() method used returns all sub elements with the given
tag under the calling element. The returned nodes are not just the children,
but also the grand-children and grand-grand-children. We want only the
children.

Change-Id: If9ea54ec738580320684533c7fe1a094295b9761
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23561
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

ctf: move ArrayDefinition.isString to be part of the declaration

Multiple definitions of the same ArrayDeclaration will all return the
same value. The method makes more sense to be in ArrayDeclaration.

Change-Id: I245dba73c7f726ed9a792a6e443e0fe4cbec0e6a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23283
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF XML: Add unit tests for XML file extension point

Change-Id: I7d2314167177c45c1e2ae42806f7492833e2cf78
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23213
Tested-by: Hudson CI

TMF XML: Add support of the XML file extension point to the modules source

Change-Id: I2f651ec4e6698d5edcfa1f6f279ffa979328d545
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23212
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF XML: Add an extension point to let plugins advertise builtin XML files

Plugins will be able to pre-package some XML-defined analysis and views using
this extension point.

Change-Id: I433b91c76b513ce3298d4ef7d3e6a9ec6fd0890d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23211
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Fix a bug where the experiment trace type is not refreshed right away

Change-Id: I82b2589e978e3a466c260105ca0605253d70200e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23407
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

TMF: Add interfaces for XML-defined components

One interface is for all XML-defined top level components, such as state
providers and eventually view items. Another interface is specific for
XML-components dealing with state systems

Change-Id: I4295beabe2d237b089543e18cfb0d4029baae490
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23156
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Add some utility methods to XmlUtils

Change-Id: Ic81b17b6d89342fb41cd9f5898830ef20e8c1b93
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23155
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Increase delay until ProjectModelTestData times out

Change-Id: I08c3bffd36041a8464b6b303573cca4f550993e8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23417
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Update README following removal of the license feature

Change-Id: Ibf251b3f14bee179af5aca264a101dfd3429de9a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/23419
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: make CustomTxtParserInputWizardPage.Java more inline with coding style

Change-Id: I148b64419154691beb6de0fb976c6f7a172b3dc7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23412
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: replace find() with matches() in CustomTxtTrace.java

This should provide a nice performance boost and make the regexes less
ambiguous.

With matches, the reader will match per line instead of searching for a
match. this can save up to an order of magnitude in reading.

Change-Id: I267426a9f2ab672590e35edafef2913ac32ac8f2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22637

ctf/tmf: make CtfIterator more inline with code style

Change-Id: I5c5f808b671642bf37e91c8a7bbdb43481edaa40
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23354
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: use TmfTraceManager.getTraceSet() in CallStackView

instead of using duplicated code.

Change-Id: Id1dad9619d915b686ac6c1b3d665baf735e0de82
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23389
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Refactor XML schema files

Change-Id: I36d912469345e34f49b1d22c8b317473e7783e71
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23154
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf/tmf: Make CtfTmfEventType more inline with coding style

Change-Id: I325c3bf2e65d93df701164b90d65ecdcd71f1695
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23361
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf/tmf: make CtfTmfEventField more inline with coding style

Change-Id: Icd2cbf4262d9109e505bea4c2ef0a8ec761c45a8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23360
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf/tmf: Make CtfTmfEvent more inline with coding style

Change-Id: Ibc660e5572fd772a21546fceae59d1030a6299ff
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23359
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf/tmf: Make CtfTmfContext inline with coding style

Change-Id: Ibbd979d5ea2361f0de8eb418c38fda937eb5e526
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23358
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf/ctf: Make CtfLocationInfo inline with code style

Change-Id: I40b698178df4a01b68a0575a9fee6f1371879a64
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23357
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf/tmf: Make CtfLocation more inline with code style.

Change-Id: I8fe1eaa819ef437b300ea785ee6b14d0c495f8d3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23356
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: use Boolean.parseBoolean() for isDirectory attribute

Change-Id: I71875c74b0cb47a1d79a72c96fcb7fd427d63377
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23216
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Use CBI license feature.

Change-Id: Ia423ae0a80efac36c3170f1adc1e1127e08eb4c3
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/23345
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
IP-Clean: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>

tmf: move the TMF statistics analysis module to tmf.core plug-in

and use the analysis output extension point to register the view to
the module.

Change-Id: Ic9f8fa68a4740f7787761f5861021b3bf263e2bf
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23322
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: don't execute statistics analysis module for experiments

because it's not used.

Change-Id: I6ac3a898ad720c99a751893c7738dda2a9ce85b8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23316
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Change cast in analysis output to fix warning in luna

Change-Id: Id5cd7be0d4eb65f6ae793f8de50555ef056062df
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23279
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

TMF: Add rebuild() method to abstract time graph view

It is useful when some action in the view requires the view to rebuild the
list of entries, for a same trace.

This patch also adds a getPresentationProvider() method to the time graph
view so concrete classes may make changes to the presentation provider.

Change-Id: Ida104642607b98d4d285bcc54a8e86dd73602506
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23147
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: remove warning in HistogramBucket class

Change-Id: I980b64e880ed434ee83bd5ce2f2252ff8eb42fe8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23323
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>

tmf: fix minimum total size in AttributeTree

The fix will prevent that the state system for the experiment
statistics is rebuild every time.

Change-Id: I7c494d3a515bc16ea9313ece370b727fd4947e6c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23244
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

gdbtrace: Remove unused import

Change-Id: Ie808fe5f2b590e3560c328f486525c59597970a1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23286
Tested-by: Hudson CI

TMF: Fix a NPE when no tracetype extension is specified in UI for experiment

Change-Id: I026ae7249716e06d5612cf428f4180deec51caac
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23281
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

TMF: Add possibility to add new module listener to analysis manager

Also cleanup the source and output initialization

Change-Id: I61f363a798734757f9ac3d991a34fd0c13ee6143
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23153
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

TMF: Force getId() from IAnalysisModule to be NonNull

Change-Id: I5658b167767fc17bfda397aeee1623ae1f053a80
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23146
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

TMF: Add the possibility to set properties on analysis outputs

Change-Id: If77d58ccb7d8105d9600e6a673e1c1392e944425
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23145
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: reactivate persistent experiment index

The assignment of the traces of an experiment where moved after the
super.initialize() method call. This lead to the in-memory being used
instead of the persistent index.

Change-Id: I4280929453a3f3f951f1e6897c4b72511c547517
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23242
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

tmf: Cancel modules when disposed

When running org.eclipse.linuxtools.lttng.alltests, the uml tests wait
forever because an analysis is running and never gets canceled. I think
modules should get canceled when disposed.

Change-Id: I745c32eae93ffad41e107ef8c29d02001d76e288
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23168
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI

tmf: Export xychart packages in tmf.ui

Change-Id: I93f3e10617e8a061a686313926434e163aa6ce81
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/22046
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI

ctf: Specify a timeout for the CTF testsuite download

The default timeout of the Ant "get" task is reasonable, but the
default for "exec" (which we use for pulling the CTF testsuite) feels
like 5 minutes. This makes building offline, or behind a proxy, a bit
more painful.

Shorten the delay to 20 seconds.

Change-Id: Ic0751330c4c747fee4344d549257f7a6ab556d0d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/23070
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

gdbtrace: Fix table scrolling back to beginning

Instead of selecting the frame at the end of the populate cache,
select the frame at the end of indexing.

Change-Id: I1974ed4fc3a0c07ca2447f72f3888ea9d58505ff
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23151
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

gdbtrace: Prevent hang when a lot of commands are sent to GDB

This can happen when commands are sent to GDB on the UI thread
and the GDB traces console gets full. The UI thread is responsible of
doing the "flush" of the console buffer so if the UI thread waits for
the flush it will wait for itself forever. The solution is to not send
GDB commands on the UI thread.

Bug: 415728
Change-Id: I6eacb9680f4966183a24c5ad915e4ddff256f40d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23019
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Don't use assumeTrue() in @BeforeClass in ctfadaptor tests

The behavior of a failed assumeTrue() placed within a @BeforeClass
method is really inconsistent between Eclipse and Maven. It can lead
to test failures, when it should really only skip the class.

Change-Id: Ibcd42a56ffd6280ad6682a57c587ddcd2a634e3f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/22697
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>