pcap: Remove AutoCloseable from PcapTrace

Change-Id: Ide58410feef5b85bbe7c2c2a274b200bf614045b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51543
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Open and close trace only once in ImportAndReadKernelSmokeTest

Change-Id: Ieaae2b0871fcbb5ff7009b84cca678d83806d4ac
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51541
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Update user guide for split aspect combo in filter viewer

Change-Id: I09158bbce40217e0211bbd4326836c52785243c0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/55345
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 476481: NullTimeEvent should not affect time graph entry bounds

This fixes the process entry's Birth time in the Control Flow view.

Change-Id: If0cb2aa0c644d930720fd4e95b074e3edb748cd8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/55232
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Add error logging when a closed iterator is selected for reattribution

In replaceRandomElement, a check has been added to create a new
iterator when encountering a closed one. This situation should
never happen, and so means that something is broken somewhere
else, e.g. that an ITmfContext hasn't been disposed properly.
This patch adds an error message log when that case is met to
allow further investigation and correction of the origin of
the problem.

Change-Id: Ib35f9906045f21042fbc9fea216a0e5da81221d3
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/55242
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Add proper locking to the AttributeTree

Instead of using a Collections.synchronizedList, extend the locking
the whole object. This makes sure that data stays consistent in the
longer methods like getQuarkAndAdd()/getQuarkDontAdd().

Bug: 476474.

Change-Id: Ia57f77ad109dd8c0b90e1824ba04d3a57140c1b6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/55156
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Split aspect combo in filter viewer

Instead of a single aspect combo containing all trace types and their
respective event aspects, use a first combo for the trace type and a
second combo for the event aspects corresponding to the selected trace
type in the first combo.

Change-Id: I9e6189590d701ac8fea048a59e16d064491ccd01
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54941
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

rcp: Use rcp repository as source for creating the installations

With this option, the build implicitly verifies that it would also
be possible to install the product (and its features) from that
repository.

This means that it provides some basic sanity check for installing
Trace Compass features. At least, for the ones included in the RCP.

For example, it would have uncovered the missing segement plugin in
the tmf feature, fixed here: https://git.eclipse.org/r/#/c/54804/

See
https://eclipse.org/tycho/sitedocs/tycho-p2/tycho-p2-director-plugin/materialize-products-mojo.html#source

Change-Id: I54e8ab63f830cbdb712b6c5c88d2c344f38e4518
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54918
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Build the RCP by default

Activate the "build-rcp" profile by default, and document how to
disable it to skip building the RCP.

Change-Id: I118db241eac28446121a4a6f5d1b71f1e5a7f1fb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/54943
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add a more reliable way to get the active editor with SWTBot

StandardImportGzipTraceTest assumes that after double-clicking on the
trace, there will be an active editor right away. Instead, we can
have a method that waits until there is an active editor.

I've seen the failure:
WidgetNotFoundException: There is no active editor
here:
http://eclip.se/5l

Change-Id: I41dd5c7c4f30f789dabab813eb8bcbb81fdcb48e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54154
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 476148: Fix time range synchronization problem in time graph

Change-Id: Idafa2029da4c57d32f85414f3545401c13b91b11
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54816
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Change TmfEventsTable to not use Display.getCursorLocation

This makes CallsiteEventsInTableTest (SWTBot) more stable because
Display.getCursorLocation is getting the cursor location straight
from the windowing system and therefore does not work properly with
SWTBot. Instead, we can use the last position of the MenuDetect
event to know the location.

Also update the targets sequence numbers to pick up required fix
from SWTBot, see SWTBot bug 474747.

Bug: 474435
Change-Id: I7e8f4377e93d78030ebe582e0b4a92666a81e966
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53515
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix Negative seek offset in indexer

If a Btree is saved to disk without any checkpoints stored in it, the
root node is not serialized out and invalid data is read when
reopening the index.

This is because the dirty flag for a node is set to false initially.
This works correctly for all child nodes because they are always
modified at least once right after being allocated but this is not
true for the root node since it is always allocated regardless of
whether or not it will contain checkpoints (and other child nodes).
Setting the dirty flag to true initially fixes the issue because
this will ensure nodes are serialized-out at least once. Nodes that
are serialized-in are not dirty until modified again.

Bug: 475543
Change-Id: I62db56445951f40ce0f27af04dd6f0d927f0c2fc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54841
Reviewed-by: Hudson CI

tmf: Fix wrong context menu in ColumnHeaderMenuTest

This worked before because SWTBot didn't send the appropriate
MenuDetect when right-clicking on a table so the TmfEventsTable
still had the last context menu (the header's). Now that it does
send MenuDetect, it right-clicks in the middle of the table and the
context menu is not the header's context menu. The context menu call
should be done on the header instead.

Change-Id: I205d3f1de12d0b8b04100d956f5c1557aa10f57d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54940
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

ctf: Smooth out some API breaks in CtfTmfEvent

- Keep getCPU() instead of getCpu(), not much value in changing this.
- Keep a @Deprecated getReference() that will call getChannel().

Change-Id: Ib5f603c926bc9db35423ba829d3696dc2dcfa60f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/54857
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: add details to bitbuffer exception

Change-Id: I4b64f99112644dca381edb40275e4f3990686326
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54648
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: remove getParent() from CTFStreamInputReader

Bump the API to 2.0, remove a useless coupling method and field

Change-Id: I951236c3b401c00ae57e9080fb9e4fb47ecb73fb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54646
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: make StreamInputPacketIndexEntry start at time 0

Change-Id: I77302be9b2f26b53bb4c4fddd8c5d9808625b470
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54645
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: add segment store plugin to tmf feature

... otherwise it won't be part of the update site and installations
would fail

Change-Id: I07fca482b139c6e4d440a47c916d61ff546bf671
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54804
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: make dead tasks return the state to null instead of blocked.

This will make the control flow view show a task finish instead of go
on and on and on. After this, PIDs can be more clearly re-used.

This patch updates the test cases as the behaviour of the state provider
changes.

Change-Id: Ib9fd24a868734b94cca9063c6753d88aa1185eb0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54415
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.linux: add TASK_STATE_DEAD and javadoc to LinuxValues.java

TASK_STATE_DEAD is useful to check if a task is still runnable or not.
This will be useful to see if a task can run or not when it is scheduled
out.

I had to read the kernel code for a while to figure out what
some of the flags mean, this should help others save time.

Change-Id: If538ce6b928c40ccf985ea655c58ce2da268539d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54630
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: Bug 476129: NullPointerException in GenerateTestValues.java

The preferences service is not initialized since GenerateTestValues does
not load the Eclipse platform. The default preferences should be used.

Change-Id: I8a033bc59e224e8b9aac79cf5e1e7f21d5b24b75
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54788
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

control: replace ImportDialog with TMF remote fetch wizard

Change-Id: I14ad7587e0e278f511d83c586b4cfd65306877f6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53604
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add unit tests for TmfEventField using arrays as values

Change-Id: I021dec1e8ee7fafdd67b5a8ae1faa8343636de44
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51214
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: CtfTmfEvent improvements

- Rename getReference() to getChannel().
- Rename getCPU() to getCpu().
- Remove getID(). It was not used by anything, and as was mentioned
  in its Javadoc, it's better to use the event name instead, so it
  is not very useful to expose it.
- Add @NNBD, and related annotations and checks
- Add equals() and hashCode() methods.

Change-Id: I83eb42b01b98895bbdb63a8c6fdba7249f93ec06
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/52121
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Use getter methods instead of fields in TmfEvent#equals()

Since the various getter methods in TmfEvent are not final,
which means that subclasses can (and do) extend them, the
method calls should be used instead of the object's fields
to correctly compare two such objects.

Refs bug #471733.

Change-Id: I2f4a2b8f455cfecd2b2a11f480092cd751eb50d3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51139
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add a timeout to TmfTraceManagerTest

Change-Id: I93666b60a88cd83afc3502ef9b77b5e444507a4c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/54618
Reviewed-by: Hudson CI

ctf: make StreamInputPacketIndex more thread safe

This patch makes append synchronized. The SIPI can only grow and elements,
once in the index, cannot be changed. Therefore synchronization on reading
does not seem essential. If the same packet is written twice, the second
time, it will fail gracefully. The packet will still be there. This
should help "CtfTmfContextTest.testTooManyTraces".

Change-Id: Ic4dfcdda71fc1ebb58039066dab836e67458506f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54344
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: introduce latency table view

Change-Id: Icdad089daf432306146cd390bf5694a95dc0b5f8
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/52255
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Export a package that was missing

Change-Id: I697dd93d410692cb97f820ce5ab482aa4ba96d82
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/54176
Reviewed-by: Hudson CI

tmf: support sorting lazy content provider in TmfSimpleTableViewer

Change-Id: I9e45b78473dac2600f7b4a2b3ea07b14d5b06615
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54352
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

piecharts: add tree selection when a piechart slice is selected

Change-Id: I2450a060cf72a2d2661b9196d87c693326cf7be5
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54162
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: make piecharts not visible when only one event type

Change-Id: I165811275f378aeecab7b4462b257b0c94c3d990
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54268
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add support for grid lines in time graph

This adds support for optional grid lines in the time graph control. The
default is that grid lines are enabled. The grid line color can be set.

Change-Id: Ia52371e05d83a951e2e5babe0fb36c62f08c6d13
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54039
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Avoid redrawing background for every time graph entry.

The whole background is already filled for the bounds of the time graph.
It is unnecessary to draw it again for every time graph entry. For the
selected entry and entries with no time events, the background with
different color and/or bounds needs to overwrite the default. The drag
zoom range does not need to be painted for every time graph entry, it is
already painted over with transparency after all items have been drawn.

These backgrounds are painted in one step before any of the item states
are drawn. This will allow to paint elements that should be below the
time events (such as gridlines) over the time graph background without
them being overwritten by the unnecessary redrawing of the background.

The computation of item, name and state rectangle bounds is optimized.

The state rectangle height computation is changed to ensure that the
default margin height of 3 pixels does not make it too small.

Change-Id: I2ef87fb3ab2963f5dfeca3f3d1c7d55618dead23
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54038
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Document the -Dtarget-platform option in the README

Change-Id: I3141344e1a71a289a0e5b530ec6521507e3b3460
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/53738

tmf: Make tracing log to stdout, like other Eclipse tracing options

When enabling tracing in Eclipse, things are usually logged to stdout with
some plugins having the option to log to file as well. I think to be more
consistent, Trace Compass should log to stdout. It's also a bit more
convenient if you don't need to keep the output.

Change-Id: I57517ab43c007ba1f5f1f249ab114c75cdd17243
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53847
Reviewed-by: Hudson CI

ss: Bug 475300: Fix inconsistent TreeMapStore due to value comparators

Add Comparable to the ISegment interface for segments to specify
a natural ordering. This ordering will then be used by the tree map
to "break ties" when segments have the same start and end times.

Also removed the getElementAtIndex() method. It was not doing what
the Javadoc said it did, and it does not seem to be useful for the
analysis as it is.

Change-Id: Ic65f50b12f6e94c59d4a60f0e96d9c78ee04b741
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/54146
Reviewed-by: Hudson CI

tmf: Support resuming the trace index

This allows resuming the indexing job after a trace was closed while the
indexing was not finished.
This also allows to index new content that was added to a trace, even if the
content was added after closing the trace and the indexer was finished.

Change-Id: I58296c0114a9f495605836f8c6df6dfceb424654
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53851
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: make piecharts not visible when no trace opened

Change-Id: Id59ec9bb8a6c861b0de98cb4a5072f075add85b0
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/54171
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 473280: Internalize TMF Statistics UI API

Change-Id: I0031b2fcb45dd52144d8a3feb3cd348d74467c5d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53491
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ctf: Lose reference to StreamInputReader in EventDefinition

StreamInputReader is AutoCloseable, it is better to not have a
reference to it in the event.

Change the constructor to require the CPU number instead of the
whole StreamInputReader, as it is the only thing that the
EventDefinition uses.

While we are changing most calls, we can merge both versions of
the constructor into one, since they only differ by one @Nullable
parameter.

Change-Id: Ibeae8e7ff7e4f78ab1f11a24d61c739706bfc881
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/53327
Reviewed-by: Hudson CI

ctf: accelerate eventheaderdefinition timestamp parsing

Change-Id: I9d244f317c9974c4aea923f58852a26d7df6962b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54184
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: update api to 2.0 baseline

Change-Id: Id29a6346da26885f918d55136abd21ab05268b8b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53923
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: extract UpdateJob class and introduce TmfPieChartViewer

Change-Id: I0371ed878bce9e3121eed98141248dac80dec95d
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53160
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: update feature versions to 2.0

Change-Id: I891313eae9fb1428d6007f08b46939edf33bcdca
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54091
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add grouping separator in indexer job

This makes it easier to read big numbers and track the progress of the job.

Change-Id: I2fc4329b378e71c78a738200b5c0886e183118c6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53849
Reviewed-by: Hudson CI

ctf: Update CtfTmfContextTest

- Dispose the trace after the test
- Remove unused array
- Avoid extra expected value due to math rounding

Change-Id: I46e8fdff95dd3e39d12b786d5efc4560b46fefe5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53357
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

[CTF] Events wrongly parsed as Lost Events

In CTFStreamInputPacketReader, setCurrentPacket can be called multiple times
without necessarily calling readNextEvent, which means that the cached value
for fHasLost can be wrong the next time readNextEvent is called.

Bug: 475007
Change-Id: I36c22c22c144cb8307403f93c76c996c60ff52aa
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53811
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Replace a few Boolean.valueOf(foo).booleanValue() with Boolean.parseBoolean

Change-Id: Ia45aa4f137f051f7a4cb650fddcb452249d7d874
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/54033
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Add indexer tracing option and add some trace points

Change-Id: I2a29558b197c0e25b068fdb3139539643d80e2a5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53848
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Remove unused filter methods in time graph control

The methods getTraceFilter() and getFilteredOut() were not used and
their implementation did not return a valid result.

Change-Id: Id1d330acab4e36a80259bfead3eccbeb3ffce82e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53587
Reviewed-by: Hudson CI

releng: Add a Maven profile to run a custom test suite in alltests

Change-Id: I8484e5de675ad0b469182e3e2e1aeacdd380170a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51777
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Make StandardImportGzipTraceTest more robust

In a build, I got the failure:
"IllegalArgumentException: The row number (2) is more than the
number of rows(1) in the table"
http://eclip.se/5i

I think it's a case of the assertion hapenning before the table
was completely filled. Adding a few waitUntil should fix it.

Change-Id: I89b15a29bd0ae9f64f213fa0ffa715566127650a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53915
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 474710: Time graph combo expanded state is not synchronized

When a time graph combo is refreshed, newly discovered items are
expanded to the auto-expand level in the time graph viewer, and the tree
viewer item expanded states are synchronized with those of the time
graph viewer. The expanded state of existing items is no longer affected
by the call to refresh().

Change-Id: I709681ef488e7d22991d5b7384c667532afd3410
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53558
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add a timeout to AnalysisModuleTest

Change-Id: Ieb5c436b53760002ce3e35769bda2641ade92a4b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51994
Reviewed-by: Hudson CI

build: add minimum version to guava references in tmf.remote.core

Change-Id: If901686b2b9358160a5237914533fc4985ac5168
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53710
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Use basic comparators in TmfSimpleTableViewer

- Make the method createColumn() public and remove createColumns()
  so that the class can be using without needing to be extended.

- Remove ViewerCompoundComparator. We can use basic
  java.util.Comparator's in the analysis and the view, all the
  way until we convert them to ViewerComparator's to pass to the
  TableViewer object.
  This will allow us to re-use comparators defined in the core
  plugin. Chaining of multiple comparators can be done using
  Guava's Ordering.compound() method.

- Support DeferredContentProvider which must be supplied with the
  sort order and ignores the sorter set on the table viewer.
  Remove the method sortOrderChanged().

Change-Id: I3acd9e79e5a2298707e67cd668c17cca1e428234
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53584
Reviewed-by: Hudson CI

analysis: Add graph ui plug-in skeleton

Creating the skeleton early in the change set avoids the plug-in project
directory to disappear when rebasing, which otherwise causes Eclipse to
bail.

Change-Id: I631c7768d085f1ea5daeaa80d79f70672b988da7
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53338
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Split UST event names in a separate interface

Remove the definitions pertaining to event and field names in
UstMemoryStrings, and move them to a global interface.

These names can change from one version to the other of the
tracer, so this is the first step in abstracting away the actual
trace event names from the "concepts" the library and analysis
agree upon.

Change-Id: Ia8ccf528029cc8cd3e5de13e4e7041ad6e89eeae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/50312
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Fix leaking context in CtfTmfTrace.initTrace()

The context used to read the first event of the trace is never disposed.
Its trace reader is auto-closed after registering the event types.

This leaves the context with its closed trace reader in the iterator
manager. If the iterator manager becomes full, the trace reader can be
reused for another context but this will fail since it's been closed.

Change-Id: Iab224db1349d2ded5cb0f2d69b7b418a53e5eca0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53332
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Bug 473441: Fix concurrency issue in ThreadedHistoryTreeBackend

We add a blockingPeek() method to the BBQ, which allows blocking
on the queue without removing elements from it. This allows
iterating threads doing query to continue seeing the element
while it is being inserted.

The implementation is changed so that the output buffer remains in the
inner queue until it is empty. Only then is it removed from the inner
queue and the next head of the queue becomes the output buffer.

The iterator is fixed to be a true descending iterator without
duplications and that properly handles concurrent modification of the
inner queue.

The size() method is added.

Change-Id: I9e708824748a625010aded82a3198f096c1fc427
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52640
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix some sonar warnings (naming conventions)

Change-Id: I7f06c66253d9a6b58236334757c21e84f09e9d8d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53282
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: add unit tests for the segment store

Change-Id: Ic29ccc34190a4f09723dc259ce79da4ec213b84a
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51279
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix generics warning in ViewerCompoundComparator

We extend a class that uses Java 1.4 syntax, but in the 1.5+
world, Comparator takes a generic type.

Change-Id: Ie40c8ce4a22d6c1611d53d16dbb30d1f01e6ca22
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/53430
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

swtbot: Fix CopyToClipboardTest

The table sometimes did not react fast enough to the selection to remove
the Copy to Clipboard item from its context menu. The condition is
changed to wait until the item is no longer found and won't fail even if
the item is still found for a short time.

Also temporarily fixed to handle the consequences of SWTBot Bug 474063.

Change-Id: I6db683abbcec3ec86d4b70c67b6abcf588cd5783
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53426
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: add Comparators and refresh content to Simpletable

Change-Id: Ib5fc283a0f78ca86bd7b9ce50764bc94739748ea
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52254
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Provide a basic implementation of ISegment

Change-Id: Ic66504a2b136ac00c21a37ac526b09db4dba32db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/52816
Reviewed-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Also clear the size of the TreeMapStore in its dispose()

Change-Id: I9c69017fea1fae562b8e693300672bdff7a5ad7b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/52813
Reviewed-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Temporarily change @since 1.1 tags to @since 2.0

These should be reverted back to @since 1.1 when that baseline is out.

Change-Id: Icb415848daedcc526a41ce203665b4cb14f9bdd2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/53324
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ss: Fix wrong indexing in TreeMapStore

Change-Id: I348ba5af90aecd237ce057e077ca5f081631c6f1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/52752
Reviewed-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: add test trace for dynamic scopes, timestamps in fields, and empty streams

Change-Id: I7aacff3ea04281c6025c982e51048c4e009e1e5a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52991
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Remove unused batch import trace wizard source code

Change-Id: Ie1b141449812504447ec80352922eaeaccdf6944
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53281
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Make ResourcesView extend AbstractStateSystemTimeGraphView

Change-Id: If12898c07fede5b9f8a53127fcc87a82280ec678
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52967
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Make ControlFlowView extend AbstractStateSystemTimeGraphView

Change-Id: I2a721725c271f40092ae4e988c935e324efdfbfe
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52966
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add an abstract state system time graph view

This subclass of the abstract time graph view can be used when the time
events are built using a state system. The full states of the state
system are first queried chronologically for the whole time range using
a time resolution, and the list of full states is kept in memory and
reused by every time graph entry to build its time event list. This
avoids repeatedly loading the state system nodes from disk for each time
graph entry, which can be very slow if the full time range queries
require more nodes than is available in the state system cache.

Change-Id: I7dcac5d546a84462dba0e5a0cf320ba18d3617f5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52965
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Allow time graph zoomed event list to be built incrementally

Instead of being replaced with a whole new list in one operation, time
events can now be incrementally merged into the zoomed event list.

The time graph entry adds a method to add time events to the existing
zoomed event list, replacing the last event if necessary.

NullTimeEvent is updated to correctly split without losing its type.

Change-Id: Icf51199483244a61580592d3f193ef460eded655
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52964
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: fixes tsdl in verbose metadata

This patch does many things that are tightly coupled. Splitting up IOStructGen will help making more
atomic patches here.

* Make enums and floats update their endianness if a trace declares it.
* Make variants register children even if typedeffed
* Make enums retain children when endianness is swapped
* NullCheck event fields before iterating over them

Change-Id: I6ecf769b0dcbda0489d8c971fd0cd124f7e8b234
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53097
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: support timestamps in event contexts

Someone may put timestamps in contexts, this is handled as a last resort lookup

Change-Id: Iad1703a5e7a8b543bad5ab7402c0ef7962d40eac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53098
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Close sequence diagram view after sequence diagram tests

This will make sure that the sequence diagram view is not open in
other tests while running all JUnit tests.

This should fix failures when running all JUnit tests in a loop.

Change-Id: I13109a0edff4d08f228d0dc218b8a5564accc067
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52983
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng control: Fix number of connection nodes not zero after deletion.

It is possible that the connections are saved due to the auto-save
feature of the workbench which calls ControlView.saveState(IMemento).
This can happen at any time (e.g. when calling delay()).

When showing the view above ControlView.init(IMemento) is called which
restores saved connections.

The tests require that the ControlView is empty. So we remove all the
connection nodes from the root when initializing the tests.

Change-Id: If94dd42cd3ba4bc3de1ea7bec959cc9117b91582
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52970
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Fix priority list containing closed streams

When a CTFTraceReader was closed, the priority list was not
emptied. The hasMoreEvents() method thus returned true in
cases where the CTFTraceReader was closed before the end of
the trace. This patch fixes that behavior.

Change-Id: I43f9ad60ddf67bfe0561834e32d6e5872fcf7b55
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52890
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: make metadata field names respect coding style.

Change-Id: I871b8ce03eb9adc7748f07e25bb18e6439a46492
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50674
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

releng: Upgrade to Tycho 0.23.1

See
https://wiki.eclipse.org/Tycho/Release_Notes/0.23#New_and_Noteworthy

Change-Id: I767ceca42c533a3300348309f346d49d631352b3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51762
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: Fix closed iterators still reattributed in CtfIteratorManager

CtfIterator extends CTFTraceReader which implements AutoCloseable,
making it closing its streams when used in a try-block.
CtfIteratorManager reattributes randomly the iterators when its
ArrayList contains the defined maximum number of elements. It thus
sometimes reattributes a CtfIterator with closed streams that
will never be reopened. This patch allows to verify if the
reattributed iterator has stream input readers before
reattributing it, and, if it's not the case, replace it with
a fresh new CtfIterator.

Change-Id: I67ff06280381529a01bac8dc0a596ca3e876754d
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52868
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: add support for empty streams in a trace

This can handle "touch"ed files in a trace folder, or 0 byte streams due to poor setting up
of lttng-tools.

Change-Id: Ib9916c92b8728098f9d844c88baab7a1c068d063
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52548
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix FetchRemoteTracesTest on Mac

1) Opening the Preferences through the menu doesn't work...anymore?
I have gone back to Eclipse 4.4 and SWTBot 2.2.1 to see if it worked and it doesn't.
I suspect it might be a change in OSX but I don't have access to an older one.
I am also not 100% sure this ever worked but I thought it did.

2) We need to wait for the Preferences dialog to be active before looking
for the tree in it. That seems like a good fix for all platforms.

Change-Id: Ib9b3ed6edee75d368d3238451dc57a982f65ee0a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51861
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Wrong menu manager passed to appendToRawPopupMenu

Change-Id: Iee28118fa0711412295bd9c1c892e8a70e4da7e9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52748
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Fix a bug where history tree node utilization is inaccurate

When a node is read from a file, the size of interval section is left at 0,
so using that metric to monitor the performance of the state system was
misleading.

Change-Id: I885a41ae744ea7f38dd25f1adce42268fe2fbd6f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/52681
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

Update Oomph setup for 4.5 target and new 1.0.0 baseline

Change-Id: I3279d34c1b2aa592940bc0c816c8ce5bc2e83efd
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52678
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix TmfEventField#equals()

Since the getter methods are not final, they can be extended
by sub-classes. This means the equals() and hashCode() method
should use these instead of the direct fields.

In the case of fFields however, since it is not exposed
directly, we can mark its separate getter methods final, and
use the class attribute in equals() safely.

We also need to handle the case where the Object value could be
implemented as a [] array of any type. This will require special
care, since standard Object.equals() will not check the contents.

Change-Id: I21f20ebee9a7c6485df9d16859f736b8ca961587
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51213
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

Analysis: Add unit tests for the graph base classes

Change-Id: I2fa96a924d17e760191906fb75aa5a8e1a29876a
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41478
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Analysis: Add the dependency graph plugin and base classes

Adds a new plugin: org.eclipse.tracecompass.analysis.graph.core and the base
classes used to represent a dependency graph.

Change-Id: I8bd45263cbf02b42d62b44868409b50ac46125ac
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41477
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Add ObjectUtils with static methods deepEquals and deepHashCode

These methods allow equals() and hashCode() to consider arbitrary
objects which may be arrays or collections of arrays with equal elements
to be equal, recursively.

Change-Id: Ic33f6451f5b535989ad8bed1cc35095bff500b0a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52187
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: fix parser not parsing "thing := keyword typealias;" regression

This regression was introduced when dynamic scopes added stricter checks
to tsdl parsing. The checks are good, this fix will extract the pertinent
data before the check.

Change-Id: Id0e0571973569f219339b3733545286a0b53face
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52447
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

remote: add automatic archive extraction to remote import.

Change-Id: I05e062bf72cc7745b1fed0d659af593e3b99136c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52269
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: allow traces to read timestamps in fields [bug 470845]

This adds declaration looking up their sub-fields.

Change-Id: Ie2b40d418014893aa28bb9efb3c745de35411e69
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51654
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 473195: Invalid thread access closing editors in non-UI thread

Change-Id: If216cc1032c9bca918a393142f0dca43ddebabbb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/52316
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Split ImportTraceWizardPage into multiple classes

This should make it easier to reuse some parts and also reduce the file
complexity.

Change-Id: I790f8c86a1e7e7011d9f8350d68de4bbc73f5e76
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51815
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make Filter and Colors tests close the views they opened

That way if the perspective checker runs again, it won't fail.

Change-Id: Iba279630f58ea18abb4b5be4abaa4b8f770cc396
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51773
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>