tmf: fix regression in trace type detection

Patch 281def4 moved the trace type detection to tmf.core. With this
change the traces that validate with confidence 0 for more than one
trace type will have a trace type set that is first in the list.
Before previous patch the trace type was not set if the confidence
was 0.

Change-Id: I2fb3dbd933ae673ce54569356f190c19a7d72d49
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67346
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Register CallStackView contextMenu

Register the CallStackView/TreeViewer/contextMenu to allow contribution
to it from extension points.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=488120
Change-Id: I65fddedf968bd1a9c621e588dc77426ace67f485
Signed-off-by: Robert Kiss <robert.kiss@gmail.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67032
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: use a null backend for the kernel analysis benchmark

This adds a benchmark that does not save the state system to disk. It
allows to benchmark only the analysis (and the reading of the events).

Change-Id: I271064111a4c55cf3010c66b3c9c6998d2444a27
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66853
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

common: Annotate some methods in Guava Iterators

The various versions of the following methods:

Iterators.cycle()
Iterators.concat()

always return a new iterator, and as such can be marked @NonNull.

Change-Id: I4e766ebbe5035d5dac6d59218c1a29b626e54ea5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67181
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Annotate Integer.toString()

All variants of Integer.toString() return a new, real String.
It can be marked @NonNull.

Change-Id: I15633360b831087f7216d00588fec09f0dfcfdd0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66209
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make timechart select the right time range when being opened

The timechart now shows the window range if opened after a trace is opened

Change-Id: I743303ca674d5a51e1cc6f7719657a43320422c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46287
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 488042: TmfStatisticsModule returns null in @NonNull interface

Change-Id: I65f1d5fb0176b57182abdd01a4e7f3e533097812
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66850
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

ss: Fix typo in package name

Change-Id: If3db5852ec370597613b6d4825e0ce95e9f82fbd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67100
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Annotate Optional.get() as @NonNull

Optional.get() throws an exception if the value is null, so if the
method returns the value is necessarily @NonNull.

Change-Id: I25cea786763b567b8f7cafcb5a4119f0d359a48b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67099
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: move trace type detection utility to tmf.core

and have the UI utility call this method. But doing this the trace
type detection can be run independently from the UI.

Change-Id: I6ec3043791647773a7768f4117f1dcdef2211e32
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66530
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

statesystem: Fix a condition to get the average node usage

Change-Id: Ib52dac782e49a17c13e5105043d09feec93ce228
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66947
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Add collapse, expand and hide category buttons on marker axis

Change-Id: If5b6552e8dd350ee0b1655643c8fa5153244ede6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66777
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Preserve order of marker categories

Some marker event sources can have a logical order to the list of marker
categories they return in IMarkerEventSource.getMarkerCategories(). This
order should be preserved, so the categories should not be sorted
alphabetically.

Change-Id: I0423b391271fdd0803aba6bd357d7482938aad4b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66541
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add time graph marker axis for marker labels

The marker labels are moved from the time graph scale to this bottom
axis.

There is one row of markers per marker category. Only the visible
categories with at least one computed marker are shown.

Clicking on a marker label sets the time selection to its time or range.

Mouse wheel over the marker axis can be used to zoom horizontally.

Change-Id: I7caf8168abd27fa9dac9e4729a4c1303775a81e6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66355
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add irq_softirq_raise to lttng 2.7 layout

This patch adds the definition for soft irq raises.

When LTTng 2.7 came out, it renamed softirq raise, entry and exit
events. That patch[1] was tested using the critical path analysis which
does not look up the raise event, only entry and exit. The only view
that shows raised states is the resources view, This patch fixes the
regression on that patch. Testing is only done with an LTTng 2.0 trace
therefore it fell through the cracks on that side too.

[1] e8e9291 lttng: additions definitions for lttng 2.7 and 2.8

Change-Id: Ibd9902d57a8dfb908153df257650235f369a48e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66877
Reviewed-by: Hudson CI

control: Bug 487847: Fix intermittent failure of ControlViewProfileTest

On Hudson multiple instances of this test can run at the same time.
The test reads and writes to the same directory for lttng profiles.
This is not the problem. The problem is that all instances use the same
file name which is derived from the LTTng session. To fix this, each
instance needs to generate session different session names. In the
implementation the method System.nanoTime() is used for that.

Since the test uses a LTTng Tools stub where the input and output of a
command are read from a testfile the session name must not be hardcoded
in the file. The stub was update so that it's possible to inject a
session name.

Change-Id: Idab89827e4ba5e2670d3ee947a1406a5a6dd78ed
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66943
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Fix intermittent failure in MemoryUsageViewTest

It's possible that the series are not there yet after the jobs running.
This is because of an asyncExec in the view code.
To reproduce the issue, in TmfCommonXLineChartViewer.updateDisplay,
change the asyncExec to a timerExec(5000, ...)

We can use a waitUntil to wait until the series are there.

Change-Id: Ic70d3adbec88578c155b53a4f42e51c568180511
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66865
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix TestRefreshTextTrace failure because of bad time zone reset

Commit 6941941dae56 (https://git.eclipse.org/r/#/c/66579/)
changed tests to set explicitly a time zone but it doesn't
reset it properly. Because of this, TestRefreshTextTrace had
mismatching time stamps.

This can reproduced by running FilterViewerTest first then
running TestRefreshTextTrace. The easiest way is to modify
SWTBotStressTests to have this:

s.addTest(new JUnit4TestAdapter(FilterViewerTest.class));
s.addTest(new JUnit4TestAdapter(TestRefreshTextTrace.class));

To fix it, we reset the time zone to the time zone id, not the label.
The safest way to do this is to use what we decided to use in the
default preference map.

Change-Id: I9b25e2c3a458cee62b74cfde61043270b62b1c01
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66723
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add periodic marker event source

Change-Id: Ie33c0c9ef0aaaab6ea396276bda4778ad277f854
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60370
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Annotate list elements as @NonNull in IMarkerEventSource

Change-Id: I83946811d96c2d1e30869086ae83ccdeda45597c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66828
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

doc: Drop the specific requirement on Ant 1.8.1

We now use maven-antrun-plugin 1.8, which pulls in Ant 1.9.4, so
we should not need to override the dependency version anymore.

Change-Id: Ib2cec2e7f62a1a7a3aae21f87693fa1d4b6ba87f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66781
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Add explicit dependency on mylyn.wikitext.core.ant

With recent versions of Mylyn Wikitext, it seems the
"org.eclipse.mylyn.wikitext.core.ant" bundle (which contains the Ant
task definitions) is not depended on by
"org.eclipse.mylyn.wikitext.core" anymore, so it does not end up
on Maven's compile classpath, and is not available for the Ant scripts.

Rectify this by adding an explicit dependency to it in the doc/ plugins.

Note that this is a compile-time dependency only, not a runtime one,
so we specify it in the build.properties file.

This should fix a current build failure with the staging target.

Change-Id: I358da1ed51754c3b355cb5e7f9a2d92e0e65f2a6
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66773
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Simple RCPTT test for opening a single trace and integrate to build

This commit act as a foundation for RCP testing via the RCP Testing
Tools[1].

More information can be found in "README.md".

[1] https://www.eclipse.org/rcptt/

Change-Id: Ia59dccc9d1eda38c84c88b89fc26d5da052d3007
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61810
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Add JUnits for control flow entry comparators

Change-Id: I5c6df522c04b1fb422140599d5d99e34f354993b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66350
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add test suite for the pattern segment builder

Change-Id: I2ff10d945ce398c943d25a795925a4fc37b0f7b5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62874
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Introduce pattern segment and pattern segment builder

The pattern segments are generated using an XML description. They will
be generated by the XML pattern matching analysis and could be used to
feed views such as the timing analysis views.

Change-Id: I366cf8fa4344c05e0067a61dd1e0f720b18d51a3
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62873
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add properties to the state system analyses

Change-Id: I91b9a583fd269c1f8d2de72dc517dce2ab2cf2d8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65228
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add XML analysis helper properties

Change-Id: I35eeb288a97071930c01dedd449a54161512032b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65227
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Set redraw false also for when refreshing the CFV

This avoids a flickering in Windows.

Change-Id: I28732f4a11e87a6e25b77e9cc7c056b5e991c2c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66337
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: bug 486053 Add the possibility for analyses to provide properties

Change-Id: I29058e50f71509c214f7d2a11cede4ca89b5a93c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65226
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Update CpuUsageView to use new TmfChartView API

Also add some null annotations and checks.

Change-Id: I73f962d19f34fe1e2eb485c5418b7c1458c7b4d6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66641
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

New method for specifying left child composite in TmfChartView

TmfChartView creates an empty composite to fill space at the
left of its graph. This commit adds a new method to allow classes
that extend the TmfChartView to create a TmfViewer to replace the
default empty composite.

Change-Id: Ie603e1cbabc27d9dc95389489d0bc2e401971a1d
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66571
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: only start zooming if we are in the time graph area of a time graph.

Ignore zoom operations in the "namespace" area.

Change-Id: Ib9398cce255112a598e02e8e3c01002b10548c61
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66650
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix some tests not working in different time zones

Also print the timezone at the start of test to help troubleshoot
if it happens on a server.

Change-Id: I4cd10054f4c767a4089e17447089e401ade19b6e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66579
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Close Sequence Diagram view after tests

If the test ran first then the perspective checker test second,
the perspective test failed.

Change-Id: Ia9c07855a8aca5a7a7f4e8960736b1e64c6b1e95
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66578
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Bug 486689: Add methods for getting an optional attribute quark

Change AttributeTree.getQuarkDontAdd() to return -1 instead of throwing
an AttributeNotFoundException.

Add methods optQuarkAbsolute() and optQuarkRelative() to the
ITmfStateSystem API.

Define and use quark constants ROOT_ATTRIBUTE and INVALID_ATTRIBUTE.

Use the new methods in the implementation of StateSystem.getQuarks().

Change-Id: I9f28e8aa8f3ba7377bebf8a5e8042ae7675aecab
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65328
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.graph: Fix getHead() to return the earliest vertex

Instead of returning the first vertex of the first element, make sure it
returns the earliest vertex.

Change-Id: I4c29fa02f97128ca80e8510560c8ae5512f3d72c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66418
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.os: add more complete tests to the CPU usage analysis

It uses the state system unit test utility methods to allow more
complete testing of the CPU usage analysis resulting state system.

Change-Id: Ic31c7ff94e42c51862a1cafdc77e2d9f053b9c04
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66404
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

statesystem: Add utility methods to help unit test state systems

These methods and classes can be used to easily unit test the intervals
for an attribute for the duration of the tree, or the values of many attributes
at a given timestamp.

Change-Id: I3eb9fc8bdc1d2ba8a388c9e0f979b506a60e3ae1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66403
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf : Fix potential null pointer dereference in XmlUtils

There is a possible null pointer exception that would have happened if
I/O errors occur.

Change-Id: I89bde3aaf4d82c71fb46fe6b4e9720603ad481bf
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66347
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Ignore xml analysis files not having xml file extension

Change-Id: If9261146b9fd8d03cb9cbd66e12a166f130b17b4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66240
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.timing: make AbstractSegmentStoreAnalysisModule more generic

No longer expect a file, so in memory analyses are supported.
No longer refer to its segment store as syscalls.

Change-Id: I029c1e77b9a107836d27288936b94d73e00c65fb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65502
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Bug 487388: Fix intermittent SWTBot test failure

The intermittent failure is due to the issue with the process having
the wrong parent which patch tried to fix:
https://git.eclipse.org/r/#/c/65024/

In the filter dialog the number of processes checked varies due the
issue above. So, when checking the value it might fail from time to
time. However, this is irrelevant to this test class and doesn't need
to be verified. The Filter dialog is tested elsewhere and doesn't need
to be verified in this test (see ControlFlowViewTest).

Change-Id: Ib48ff75e8ffc029f1e814e163369d64ed80916c7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66124
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Ignore invalid clock description elements

The clock "offset" element is supposed to be signed integer constant[1].
LTTng uses 64-bit integers for this, however there is a bug with current
versions where this can be set to values above 2^63.

Right now Trace Compass refuses to open the trace and reports the
invalid value as a CTF error. We could accomodate and still load these
traces, ignoring the invalid definitions.

[1] This is not explicitly mentionned in the spec, but it was discuted
    with the spec's authors, and it should be updated in the future.

Change-Id: I44fc4f4b90c1c9f046c03d83d63cea2fee8bb57f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66159
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Show thread priority in critical path view

This effectively allows the critical path to become a priority
inversion explorer too.

Note: Priority inversions should not happen in modern OSes. But
users can badly set their thread priority. This patch highlights
that error.

Change-Id: I4db2f5b69329a0b868758a35f15ee6cfc13fa43c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66063
Reviewed-by: Hudson CI

analysis: allow critical path view to display tooltips

Change-Id: I0a155c89ed3ebdac7b4d97c2a7399d478c5d6df5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66062
Reviewed-by: Hudson CI

analysis.graph: allow workers to return additional information

This information can be displayed as tooltips or extra columns in the views.

Change-Id: Ib992ffa0d32b89c5811510e5a9a3270a1df1003d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66060
Reviewed-by: Hudson CI

tmf: Add ellipses to manage xml menu item

Change-Id: I76f0d0748a45f44fffa0774155f4b703ee598a7f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66241
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

LTTng: Add user documentation for the virtual machine analysis

Change-Id: I608fb10e85ac21017f44542a2f4ddda743f33247
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/40089
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Remove import XML analysis command

Change-Id: Ia8626d3a797caa9ed8a8942a0c7934b0e357bb3e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65142
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf : Add manager for XML analysis files

Change-Id: I48efa950f90d56e2fb23a4c7c6944a46220c0f29
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65141
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: Replace Color resource with RGBA descriptor in marker events

This avoids the marker event sources from having to manage, create and
dispose color resources.

Also adds a RGBA to Color map in the time graph color scheme object
which is shared between the time graph control and scale.

Change-Id: I168c949e2aa63c0f5e958385490dc2543ecde7a5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66046
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

common: Add NonNull external annotation to Enum.name

Because it can't be null.

Change-Id: Id87a19010a0a0c5e3daa3ff80d094cd5df660bd4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66173
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

common: Add NonNull external annotation to File.getName

Because it can't be null.

Change-Id: I81e9797e7e753a3cd04b8a580ec324f199569f71
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66172
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf : Fix get analysis modules when executing analysis in TmfTrace

Previously, all existing modules were loaded. Now, only the modules
related to this specific trace are loaded. This prevents to execute
unnecessary analysis.

Change-Id: I3f949f6973f487903fe0e83b0f9d0f7347aa8c41
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66043
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Add a test to validate an XML pattern file

Change-Id: Id2d016d8a3c93cf067110478405c06e9131339c1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62274
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add the XML Schema Definition for the pattern matching analysis

Change-Id: Iba12a35cd4e33a5302ec13727a335ccffc2d28d0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62260
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Updating to latest orbit

Change-Id: I45094085fc7e90765f287cc460f181e45909d51a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65949
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix jacoco agent not added to command line (code coverage)

It seems that tycho.testArgLine doesn't get set again by
tycho-surefire if it was set in the root properties.
I orginally defined it to nothing so that it would be defined
when running without jacoco. Instead, we can introduce a new
variable and never touch tycho.testArgLine.

Change-Id: I5f2969ad65292ad2e6fa84d3fb46bf925064981c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65953
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Fix missing about.html

See https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg12981.html

Change-Id: I5b0b4274179bdfb83bf0dce388d06b01b3812dde
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65853
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Fix dependency on Eclipse 4.5.1 instead of just 4.5

eclipse.core.resources 3.10.1 is from Eclipse 4.5.1.
There is no special need to depend on the service release instead
of the original 4.5 release.

This was noticed by trying to install Trace Compass form master
on top of Eclipse 4.5.0.

Change-Id: I22879ac99b24d8628b4e378d586564d33e0d7358
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65852
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Avoid unnecessary redraw in TmfClosestDataPointTooltipProvider

On a mouseMove event, it is only necessary to redraw (once) if the hover
highlight needs to be removed.

Change-Id: Ib14d35699ef276929ec66e84775d0350268e9717
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65907
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Increase time-out of CtfTestSuiteTest

This has been timing out intermittently and I haven't been able to
reproduce it in a way that I can diagnose the problem further. A theory
is that the build machine just gets slow sometimes (it is shared between
many projects). Increasing the time-out shouldn't hurt and if it still
happens, it will be even more suspicious.

Bug: 486209
Change-Id: Ib71f8313b02ce6152bb2eb119bc9ffa11fd44d68
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65851
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Persist sort column sorting and selection in time graph views

The settings are persisted per open trace.

Change-Id: Ic021f6f19cccee629d1a456e3abf5fd51fb34cce
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65156
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Upgrade eclipse-jarsigner-plugin to 1.1.3

This upgrade doesn't really affect our build but it's good practice
to stay current. Eventually, we could use the DMG packager for a
nicer installation on Mac.

https://projects.eclipse.org/projects/technology.cbi/releases/maven-plugins-1.1.3

Change-Id: I6b839630765551b98eb8d9bfa5cac9999b80ab44
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65486
Reviewed-by: Hudson CI

lttng: Bug 487163: Resources view traces are unsorted

When an experiment is opened, its traces are now sorted alphabetically.

Change-Id: Idae538a53182d661d066f82b676a8b3a14442c2b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65836
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

LTTng: Add developer documentation for virtual machine analysis

Change-Id: Ibbbd0680190c0a5992a7d088c4df54c460fa6341
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/40090
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: add SWTBot tests for verifying Control flow view sorting

Change-Id: I17e7803f95eca3fedbe8377b91c13a48c1a91565
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65025
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Revert "ctf: Fix slow test due to expected timeout"

This reverts commit 55d0eb8e748bcf27d4afc39f5553d419d9b2922a.

This commit broke the staging build. This will need a different
solution.

Change-Id: I53235d4155e680f6400f4e91212234812a9c5dc0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65752
Reviewed-by: Hudson CI

ctf: Fix slow test due to expected timeout

The test was looking for a possible checkbox (in 4.6) but when it
it was not there (4.5) it had to wait 50 secs for it to time out.
Instead we can set a very short timeout because it will instantly
either be there or not.

Change-Id: I05acf8844619377362accd32af7d994e050d5ec6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65747
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

releng: Add profile to disable jacoco

So that we can disable it for the Gerrit trigger and make it a bit
faster, hopefully. To disable it use
mvn clean install -Dskip-jacoco=true

Change-Id: I5ab53302df910ddeac1d2fa4afa2f2c020c85ff3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65235
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Keep focused item aligned on vertical zoom

When doing a vertical zoom with the keyboard, if the selected entry is
visible, make sure that it remains at the same vertical position.

When doing a vertical zoom with the mouse wheel, make sure that the
entry under the mouse cursor remains at the same vertical position.

When repeatedly doing a vertical zoom within a short amount of time, use
the initial event's entry and position for the subsequent alignments.

Fix the method getItemIndexAtY() to find items that are above the
visible bounds.

Change-Id: I803229c5cf5295b855d4615a6756751158b78346
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65605
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Show closest event tool tip when hovering over blank space

Show the tool tip for the closest between the next and previous event
when hovering over the blank space of a time graph entry, if the
distance to the event position is within a threshold.

Change-Id: I8a95d488e03c1d5012a1ee0bd4597f863b2ba3b6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65612
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Bug 486404: Process name is not always drawn in Resources view

Change-Id: I2e8a130e8fd22445eaa4dbf4245058dfb1896c1d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65030
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: change ITmfTraceProperties to a more generic ITmfPropertiesProvider

This allow other elements than traces to implement this interface and also
provide properties to display in the UI.

Change-Id: I11fe5bdc4825e2cc548f1d683b21a90e5fd2f3ae
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65323
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: User guide updates for missing or incorrect content

- Resources view - add filter dialog, remove arrows buttons
- Project Explorer and events table - refreshing of local traces
- Control Flow view - column sorting, updated filtering

Change-Id: I6fd28938e1abc25d26529eeecc8f2d7b3e4b20a1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65410
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: expose UTC offset in trace properties

This shows the time of boot of the system wrt UTC for
most CTF traces. Initial step towards fixing bug 484620

Change-Id: I62a934051f5d06c0e5c151743cbcc868f311e50f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65229
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

rcp: Fix icons for project explorer on Eclipse 4.6M5

All the platform icons where changed to png file types and file
extension. Since in the RCP we need to register these images for
the RCP product and there are no constants available we need to check
for gif and png file extension to support Eclipse 4.5 and 4.6.

Change-Id: I2d751df1177adc991e300ec9e12a19922c163fe9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65505
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix TestImportExportPackageWizard on Eclipse 4.6M5

ArchiveFileExportOperation doesn't include linked resources by
default anymore, we have to call setIncludeLinkedResources(true).
Because of that, the exported package did not contain the trace
files. The method doesn't exist in Eclipse 4.5 so we have to use
reflection for the time that we want to support both versions of
Eclipse.

Change-Id: Ie7216e81fd3004e362e4200946e6ce81f81aa676
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65503
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Fix StandardImportAndReadSmokeTest on Eclipse 4.6M5

The export dialog changed and doesn't include linked resources
anymore. However, there is a checkbox that displays them again.
See bug 355049

Change-Id: Ibbdf33839653127f15efd07ad72f887b6ba21697
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65424
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: no longer call overridable methods from constructors

Change-Id: I6b8e639f04e42ac840a114690a6ddbc639c5873c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63650
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Attempt to gracefully recover from a malformed packet context

If a packet context has an end time that is less than the start time
tracecompass will give an error message and refuse to read the trace.

This patch makes tracecompass log a warning instead and try to read
the trace.

Seeking should not be affected.

Bug 486670

Change-Id: I352af4c79476c73b0ced2cefd65f82bd04d6762d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65168
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: Update TmfSimpleTableViewer use of comparator generics

Update is required due to changes in ViewerComparator from Bug 483190.

Change-Id: If8cf7b0d233515907f78fa85fe6f361e0ad49612
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65401
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: annotate StructDeclaration#addField to @NonNull

This way we know that all null fields received don't exist.

Change-Id: Icd7d2280653c0fe2eb4705fcd6ef8ee950a630f3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65331
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf.tests: remove one test trace from ignored list

This was fixed by commit 8460a46d8b186d302a42d614ef6fac81056e1e2e
ctf: make parser support scoped typedefs [Bug 470846]

Change-Id: I8aab4c9bede302b9f59f61a3747e4e4ce58bdbf8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57877
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

rcp: Bug 486745: Open traces with name conflict from cmd-line correctly

Change-Id: I4cff3ef47fc52df07c7e0b4df3bab44fdc2e2344
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65378
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis.xml: Remove "throws Exception"

Replaces throws Exception with throws IOException.

Using such generic exceptions prevents calling methods from
handling true, system-generated exceptions differently than
application-generated errors.

Or, as the former lead of our former project said:
"Don't mess with Exception"

Change-Id: I61f517b8721a5e660d92b7cba7bf97c1382381af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65333
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.xml: fix potential null dereference

File#listFiles() can return null. Even though the test
"isDirectory()" and "exists()" are able to pick it up, executing
the command and null checking it is the best garanty.

Change-Id: Ic3cefdaecf3d5d88dbeaeb3f3d58689abdb05347
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65332
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

control: Support recordings snapshot for multiple sessions from menu

It has been already possible from the toolbar button.

Change-Id: I2c1122ea61cbc0168aced8b27343236090ee2ecd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65216
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

control: Bug 486586: Allow snapshots in inactive state

Change-Id: Iee0e5a53169f5d573865df4a634da900eaad71cc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65215
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Change unnecessary declaration of thrown exception to warning in tests

Change-Id: I4c5fe96c227b3cf89d26b46ded8dc318eb62060b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64410
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: remove StructDeclaration#getFields()

this exposes an internal map and can be dangerous

Change-Id: Icc1d5ecbd7d5dc5eab472b314669312ffe26a8a6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64118
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: enhance unit tests around EnumDeclaration

Change-Id: If6f6cc514e13a8dbe50738cb6a7c41cd0c47f351
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64429
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: add test for Control Flow view dialogs

Change-Id: I433af57a2a2e713bc1c74a712d7d1b927c48c838
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64119
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: bug 486434 bring analysis module source back to core plugin

Change-Id: I2ead4d309cdd8e633b2990b020bbaf05bd08775c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65116
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: remove dependency to ui element from the module source

The TmfXmlAnalysisOutputSource class is now advertised with the 'listener'
element of the analysis extension point.

Change-Id: I7ac2be77774f029e29eabd643e6fd891317bd898
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65115
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add a listener element to the analysis extension point

This element allows to add listener classes that will be registered to
the
analysis manager.

Change-Id: I65fc1949350156ec945db6c2a48020f8aec3e9f7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65114
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: remove dead store of value in XmlPresentationProvider.java

Change-Id: I50bf309c3aa38b8bf4d09ada185cb4be52708410
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64702
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Fix sonar warnings in CFV column sorting code

Change-Id: I4f4bb7e367946e9b9acb46414962722eb156eb87
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Handle compat_syscall_exit_* events correctly

The compatibility layer syscall entry events were handled correctly,
but not the corresponding exit ones.

Bug: 486351

Change-Id: I2709a406eec805a8410651972fac618dcaf27dc4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/65134
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI