tmf.core: Build a TmfAnalysisException from any type of Throwable.

Change-Id: I6b92592ff5092b2941259dcf8958a20a79fd974c
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/94242
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix BufferedRandomAccessFile

The method read(byte[]) was not overloaded and therefore reading
natively at the real file pointer, which could be different than the
buffered file pointer set at the last seek or read. The method now reads
from the buffer.

The write methods were not overloaded, and had the same issues. The real
file pointer is now synched with the buffered file pointer before the
write, and the buffered file pointer is synched with the real file
pointer after the write.

When repeatedly seeking backwards and reading, the buffer was
invalidated and filled at every iteration. The file will now position
itself to read ahead by half of the buffer size when seeking backwards.
This will improve the chance to benefit from the read buffer.

Unit tests are added.

Change-Id: If9662844818f1500f8d403b1120083892e788188
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93840
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

settings: Remove unused problem filters

Change-Id: I6f5e0c80472eef411f445c7de687ede00b66bd0e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94303
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update tracecompass features version to 3.0.0

Change-Id: Ib5a8735f2b280ef164654ecd8166b52f8e9328a9
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94176
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.ui: add a centralized registry of event styles.

This ensures that a state in the Control Flow view and the Resources
view will always be the same color. Also allows localizable help text.

Change-Id: I17cf2ad0e3bda0e254a1ee6d12df0aa96177647a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/85091
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Fix abstract time graph view end bound

Some abstract time graph view implementations set the end time bound of
the view to the state system end time + 1. This was to be able to see
the last state in the case that the last event in the trace resulted in
a state change (the time graph event begins at end time and has a
duration of 1).

However the TmfTraceManager does not allow the window range to exceed
the trace bounds. So when the view window range was changed to show the
view end bound, it immediately snapped back to the trace end time. This
can be seen by double-clicking on the time graph scale to show the full
range, or by zooming in and scrolling all the way to the end.

This effect also prevents the view from zooming out of a 1 ns window
range at the trace end time.

The end time bound can be set to the state system end time directly. The
final state can still be seen, selected and hovered for its tool tip,
although it has a 1 pixel width.

Change-Id: I6e65fc2f960c54af0c53e4725dba334ba30fe827
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93649
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix time graph scale ticks and grid lines

The time graph control depends on the time graph scale to get the tick
list of x-coordinates to use them to draw vertical grid lines. The tick
list is computed when the time graph scale is painted.

It appears that the order in which these two controls are painted is not
guaranteed. Therefore time graph control can sometimes paint grid lines
using the previous time range's tick list. With AbstractTimeGraphView
this usually gets fixed after a short delay when the zoom thread
triggers another repaint at the same window range, but not always.

This tick list in the time graph scale is no longer cached, and is
always recalculated from the current window range when requested by the
time graph control.

Another issue is that the last grid line disappears when its
corresponding tick label does not have room to draw completely. It is
now always drawn, and the tick label is simply truncated.

The calculation of the number of tick label digits for the CALENDAR time
format is fixed. It was too large and inconsistent, which could cause
grid lines to be unnecessarily far apart.

The digit width is cached so that it can be used outside of the time
graph scale's paint event.

Change-Id: Iaaa1caae8328d469700a7ad8aee726795b356930
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93620
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix some tests with Eclipse 4.7

In Preferences, the OK label changed to "Apply and Close"

Change-Id: Icfddee53a45a895a6df82edd650a5d31c2124e5f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94261
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update target file for Neon.3

Change-Id: Ie34424bafeac522d71619cbd2d46100bcedfc121
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94175
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Fix invalid since tag in several files

Change-Id: I2c61ca0faa7676861f9b1bb6419ec1a418a3ed7d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94171
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Add baseline target definition for release 2.3.0

Also update the oomph setup for that.

Change-Id: I3251ec01d3daf1b3e19e899fa0134c8ca11f207e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93796
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: Remove procname from callstack requirements

The analysis does not need the procname and it adds some overhead in a trace
with a lot of function calls. Though procname makes it prettier, it should not
prevent a user from seeing the callstack of a perfectly workable trace.

Change-Id: I3603b52f8559c40b86193d954ab94d9e65dc9bce
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/87449
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: handle enabled/disabled trace types in the Filters View

Change-Id: Ia3b1849ba5e45b1ef6fcf2b7225b604dea2c1b44
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93989
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc: Add documentation for trace type preference page

Change-Id: Iedd2a354117b64e4843f5f774ddc44d46069f24d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93244
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add SWTBot test for trace type preferences page

Change-Id: I66c293de7c9c02fa90b637048c5e452048f43fc4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93237
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add trace type preference page for trace type filtering

This patch adds a preference page to activate selected trace types. User
can only see those activated trace types when he will use the 'Select
Trace Type...' command as well as for trace import and only activated
trace types will be considered for auto-detection. Experiment types are
not taken into account.

Change-Id: Iecd6c481d6cca3adc1d7e510580c55803d9413ee
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92508
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Add waitUntil#Predicate to WaitUtils

This patch adds a waitUntil() method with a predicate for SWTBot test

Change-Id: I98b33e9a84b309eb251783b2678006866be48c76
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93738
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Fix import of ctf dependency into tmf.ui

dependency was introduced in  https://git.eclipse.org/r/92386

Change-Id: I0015b1dd19d99fdd57bc161ed7c756303131837b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/94005
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: implement readEnd for CustomXmlTrace

Change-Id: Ic4f6f7f829c503beeb0201e4be3dd4b189cc8169
Signed-off-by: Loïc Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93623
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: implement readEnd for CustomTxtTrace

Change-Id: Ieaf32d6dc66e0ae9ad0e293687a1e2882c0506ce
Signed-off-by: Loïc Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93622
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 506660: Fix zoom out from 1 ns window range in time graph

Make sure that zooming out from 1 ns window range is possible with the
Zoom Out tool bar button.

Fix double to long rounding error when zooming out.

Make the 'focused' time (selection if visible, center of previous window
range otherwise) centered in the new window range when zooming out from
1 ns window range.

Keep the selection as 'focused' time when it is exactly one of the
previous window range bounds.

Snap the window range to the time bounds when zooming out of range.

Change-Id: I4501d178acf1c1383caecc95d5bf2b3ec534e602
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93066
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.ui: Update JUL log points in common X line charts

This will allow to analyze the command flow from the user interaction to
the views being updated with the new TraceCompassLogUtils API.

Change-Id: I640061e6a8eb3c19b17ee4a7025acd52aab47cd7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93743
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Fix NPE in log arguments

Loggers should NEVER throw exceptions

Change-Id: I39f7ffd18735c6ee2919b76afaec1e1616702c30
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93809
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: Show a trace's time range in the project explorer

This helps when working on experiments with several traces
to know the trace's time range without needing to display
it completely

Change-Id: I38cb9d2cac545d0b9062eda3301244996ee1feb1
Signed-off-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92386
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

common: Fix LoggerTest on Windows

\r was making it in the stored messages. It can be ignored.

Change-Id: I1e79a876e8cc5b610b8bccee234648dbe16bbf19
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93761
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf.core: add StateSystemAnalysisModule log point

Change-Id: I5ba890533d6c6149c5bd3c4fbec72493abcaa0a3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86080
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

common: Use a builder for FlowScopeLog

The 3 available constructors for the FlowScopeLog class are hard to
differentiate because of the Object... parameter. It is error-prone, so
we use a builder instead to make clear which constructor is being
called.

Change-Id: I377f77353b3c0df2e7cbc2c0b8f326e894171f10
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/93650
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ctf: Add unscaled time getter

This allows getting the unscaled timestamp without
rounding errors.

Change-Id: I5b09dd2211169e553a37997c9f5b0cf8581667af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93339
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common.core: Introduce logger utils

This patch begins to bring notions or a defined trace format.

It provides a "blessed" way of formatting data to have analyses work
out of the box. It also provides an easy and robust way of
instrumenting without having to worry about details like
TIDs and time stamps.

The usage is reminiscent of LTTng's tracepoint API, in that
the user must supply a list of arguments in the end alternating
between key and value. It is easier to list them this way rather
than forcing a Map, however, this may throw some illegal argument
exceptions.

There are four reference implementations available:

* Scoped logging for durations

This is a try-with-resources logger that makes call stack and
call graph analysis much easier to perform.

* Flow logs for durations and inter-threads relations

This is a try-with resources logger that makes call stack and
call graph analysis much easier to perform, but also shows
inter-thread dependencies.

* Object lifecycle tracking

This allows the tracking of Objects that have notions of "disposing"

* Asynchronous message support

This allows a standardized way to track message passing as well as
asynchronouse operations.

Features missing:

* Marker events.
* Counter events
* Sampling Events

This changes the loglevel of the state system logs, as more information
is stored, it needs more bandwitdth.

Change-Id: I8320fa4246b33442fe44e3ce3935a824cd28feac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/85633
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Fix Marker Set action handling

When changing the active marker set, it didn't update the marker sources
when the opened trace is an experiment. The action only updated the
marker sources from the opened traces, but the marker sets were created
on each trace in the experiment's trace set, for the default
implementation of AbstractTimeGraphView.getTracesToBuild().

It wouldn't be good enough to update the traces using
TmfTraceManager.getTraceSet(), since we don't know the implementation of
getTracesToBuild() for each view. Also, calling
TmfTraceAdapterManager.getAdapters() on each opened trace could actually
create new adapter instances that weren't yet needed.

Instead the ConfigurableMarkerEventSource instances should handle the
TmfMarkerEventSourceUpdatedSignal, and reconfigure themselves.

Also, since the Marker Set menu items are radio, selecting a new marker
set first executes the action on the menu item that is being unchecked.
The action now only executes for the menu item that is being checked.

Change-Id: Ic8fd21b930ec29e8a619cbcedea712d4b7ee4d86
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93463
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support X11 colors in marker configuration file

Change-Id: I72bf7a3492e9325dfb914cac56cc6f4cd3d88972
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92210
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add X11 color registry

This adds a map of color name strings to RGB color values. It will allow
users to identify colors by name in dialogs, configuration files, etc.

Change-Id: I492292acfd864ebad418049e584c617c525f6106
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92209
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix a few exceptions that could happen when closing

Change-Id: Ibe66165b06a9687a1f4044585bc87db3e2afd8a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93569
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: Allow analyses to be used directly from a class

SetTrace no longer throws an NPE if there is no extension registry.

Change-Id: If82c3e1e0ba880e1a9007aa5b22572eec5440df8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93554
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

releng: update staging target for oxygen M6 builds

Change-Id: I6e91674c063d52c8d730d5fca43829cb1555fdeb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93124
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Simplify SelectElementTypeContributionItem

The class TmfTraceType already manages the list of available trace
types, including experiment types and custom trace types. Its list of
trace type helpers can be used to build the menu items.

The unused command parameters BUNDLE and ICON are removed.

Note that menu items will now be grouped by category name instead of
category id. If two different category id used the same name, they will
now be merged instead of showing two sub-menus with the same name.

The items in a category sub-menu will be sorted alphabetically.

Change-Id: I411e88ad34db66d4ec3d32d8e4e6390ca66b6c6a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/93446
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: fix @since annotations

Fix some issues in CtfTmfTrace and TmfTrace

Change-Id: I7d2c87e060bbaeb59ff7ff2fb0d1bff8b3e04f99
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93337
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: update 4.6/4.5 targets to use neon/mars EMF version

Change-Id: I57eda6b2a685027095b475bc87950a778097c031
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93145
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

timing.swtbot: add flamegraph doubleclick on row test

Change-Id: I1a9cfb265b0f84a717b48197b6b5848d85ba0333
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/84044
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Fix a test on Windows with file not being able to be deleted

The synthetic trace was being regenerated while it was already opened.
So it was being used in a "nested way" in the test. The test was just
trying to reopen the trace using the path so pass the path instead which
does not try to delete/regenerate the trace.

Change-Id: If510d366f08a9f8895e667efe370bf9c70edcc5e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/93033
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 506095: Fix NullPointerException in XML views

When the XML Time Graph View or XML XY Chart View is opened from the
Window > Show View > Other... menu, it does not have a secondaryId. This
should not cause an exception, and the view should remain blank.

Additionally, the view should then not wait for the viewInfo name to be
set, it will never happen and the build job or line chart update thread
remains stuck forever. As a consequence, the viewInfo should be
initialized before creating the view controls.

Change-Id: I0d21cbcc02505bd5d83b7fb4335bf780943fe136
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/92736
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

Revert "ctf: Remove the callsite support"

This reverts commit 73511e6797ae5d1ef5669997e21788033d1b2eee.

The keyword callsite is part of the CTF specification. Dropping support
for it was a misstep.

Change-Id: I9b4c4842c1b2333acabac072d4a35fe224cfec5a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83898
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

lami.ui: Remove previous lami charts

Only the custom charts are now used for lami

Change-Id: I6d5cda15916b32dc89e116965da63445fb2ceaa3
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90217
Reviewed-by: Hudson CI

lami.ui: Replace LAMI charts with custom charts

This patch makes the LAMI analyses use the new chart
plugin instead of their own charts.

Change-Id: Ic0bf607a68b7057b365ae2f40bb40f96895cfbaf
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78012
Reviewed-by: Hudson CI

lami: Implement a custom chart data provider

This patch adds a data model for a LAMI analysis. It also implements a data
provider into the result table.

This allows the creation of custom charts using the tmf.chart plugin

Change-Id: I1375c81c6e99538d4b2e86afb517c4014b0a8a98
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/76899
Reviewed-by: Hudson CI

xml: bug 513074 fix time graph view for events of size 1

This changes the boundaries used to get event data for XML time graph
views. Events that are the last ones and of size 1 are now displayed.

Change-Id: I04d3ead5a723ddaf03282f9f438a418662ad3404
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92277
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: Test the markers set

SWTBot test for Markers Set

Change-Id: Ic8f595d83336ce88b9c915500d7b68c409d92957
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91736
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Update user guide for configurable marker sets

Change-Id: I5a56a94dff211627db8d4e7f0ac4bd2783cdf9c2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90318
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add unit tests for configurable marker event source

Change-Id: Ibed108fb6b625163c7a2181d43fa9ad28add9781
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90317
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add XSD validation for marker configuration file

Change-Id: Id673d01fc65919cb8776dfaec2d8a15ceb2ae214
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90316
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support traces providing cycle conversion

The interface ICyclesConverter is added, and the configurable marker
event source will use it to calculate periods and offsets when the unit
is 'cycles' if the trace provides an adapter for it.

CtfTmfTrace is updated to implement this new interface.

Change-Id: I6cda33a880365f0bcc2d1d808f2164781e4f788c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84822
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Support traces providing periodic marker reference

The interface IMarkerReferenceProvider is added, and the configurable
marker event source will use it to determine the reference if the trace
provides an adapter for it.

The periodic marker configuration supports a 'referenceid' attribute
which is provided to the trace adapter.

Change-Id: Ib6feee645c58d9d6f63fa07df9a65fdce8c5597a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84820
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Make TmfTrace implement IAdaptable

This is useful to be able to use adapter interface for traces, either by
direct implementation or by registering an adapter factory.

Change-Id: Iec23a2e3025771966f3467c56843711698b03331
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/84819
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add configurable marker event source

Change-Id: I1c8f9b2ebc833063d8fa7b9b4a469b722b8bb41c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83645
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to filter-out periodic markers by index

The method isApplicable(long index) can be overridden to filter-out
markers by index, by returning false. The default implementation returns
true, filtering-out nothing.

Change-Id: Ib37043facf10aef4369f1a3701d94b975c68c9e5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83644
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add method to get marker list for all categories at once

This can be useful for marker event sources that provide multiple
categories and for which it is easier to compute all the markers at the
same time.

Change-Id: I5efcfe4444f70ef879fb6a33aa4e28b844d08095
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83643
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix Mars build

In Eclipse 4.5, StructuredViewer had
public void setFilters(ViewerFilter[] filters)
It became in 4.6
public void setFilters(ViewerFilter... filters)

So passing an array of ViewerFilter will work for both.

Change-Id: I1f3e188a78f1b738f9d41bbc05f692141f02b1bb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92392
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

xml: Use java.nio.Path instead or o.e.core.runtime

This is what is was meant to be from the start, but a wrong import went
unnoticed.

Change-Id: Iecf4794c9ed9e59a83ebd5e92af9b7ef7ef72b12
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92112
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

lttng: bug 513013: fix invalid thread access

Change-Id: I019497d3cc776b8872c6600bd7c3aa4a5d331c3e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/92204
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

releng: Use baseline target file instead of zip for Oomph

Instead of having to create a zip and pointing to it, use the
existing .target file. This requires to resolve the target first
then set it, as suggested here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500097#c7

Change-Id: I4e7b7d9b8ea8b013e24ba8c0ef760066c86251a2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77201
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

datastore: Fast return to for classic node children

When selecting next children of classic nodes, once the node's
end time is past the maximum of the range, it is no use searching
the rest of the children.

Change-Id: I7a1aba410718ea33a84b6a0b109121b0512fd284
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91758
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Rewrite some stream and list manipulations

This patch rewrites some list and stream manipulations to plain
java. It has a non-negligeable impact on performance.

Change-Id: I11881780d30f27592765140edda1af04b1a2c1e5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91757
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Add intervals without check for node read

When nodes are read from disk, we know the intervals fit into it, there
is no need to go through the code path that checks if the interval can
go in the node.

This change alone greatly reduces the performance impact of both single
and full queries for large state system, when nodes are often read from
disk.

Change-Id: If653611b00d56b604d23ddd1f6e62bb22f822da0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91756
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Keep a snapshot of the latest branch

This avoids making immutable copies of the same branch over and over.

Also use the latest branch directly in the node insertion instead of
the getter.

This change alone removes all performance impact of the datastore
when building.

Change-Id: If85ae9bded364cfd6f1243416d025df6307cf909
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91755
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Use time conditions with long

Using primitive type long instead of a generic Long for range conditions
reduces the need for boxing and unboxing time values.

This change alone reduces the performance impact of the datastore by ~2
in use cases of small size for both single and full queries. Coupled with
the patch with single queries API, it reduces the performance impact of
single queries to < 100%

Change-Id: I63ebb20b2441aff1345b733f1ffc25314e63ffd2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91754
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

datastore: Add API for single queries

When what we want is only one interval, there is no need to get them
all, we can just fast return when the one interval is found.

This change alones reduces the performance impact of the datastore by
~2x for single queries in the case of smallish traces.

This patch also adds a binary search to find the first interval to
look at.

Change-Id: I77d0ac9818f272f7d160f92666445ce2d8b3200a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91753
Reviewed-by: Hudson CI
Reviewed-by: Loic Prieur-Drevon <loic.prieur.drevon@ericsson.com>

charts: Add interactivity and signals

This patch adds a basic signal that is sent when the
selection inside a chart is updated.

Change-Id: I31e66701dfb2cf495fea4d948fe90e545485d30c
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78348
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add dialog for making a custom chart

This patch adds a dialog that allow to configure a chart
based on the possible data descriptors of a data
provider.

Change-Id: Ia790b11083ef07b49953cf9f3578eeaea7785495
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77162
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add custom bar charts

Change-Id: I050dff9ad39e269c4b890aadc4fb403689ada09a
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77161
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add custom scatter chart

Change-Id: I1ced02d5e7bb6f34bfa11a58d7dacbe2ba00f6d8
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77160
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

charts: Add abstract class for XY charts

Change-Id: I4b1ada5be47da16e4942ead2f28f0b8b5c084f30
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/77159
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Update the link to XML analysis example

secretaire.dorsal.polymtl.ca is now available only in https

Change-Id: I9bc44eea31847d2d16f8f2f249e717a19a14fd48
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/92159
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc: Document Optimize button

Fixes Bug 508946.

Change-Id: Iead742de3152c81136dc8283a00926372174e95c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91830
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: update some maven plugin versions

Change-Id: I73929804a93004eef63f1cd24851a90c4a89720e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91362
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Remove some extra lines by using SWTBotUtils

Change-Id: Iad76c781d32bd33ff4d3162d6866030db5ffcd29
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81835
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Add additional arguments to the command line

This will allow for instance to add arguments to enable logging for a
custom test suite

Change-Id: I149ee22e8d4843f596d45e476021b8ad0fba0008
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91811
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

releng: Add a test suite for all SWTbot perf tests

These tests can be run with JUL enabled to get data for UI
responsiveness.

Change-Id: I87cf69155262089dfe017db5ad4980951308224e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/80262
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

analysis: Add a few missing @RunWith(SWTBotJunit4ClassRunner.class)

So we can get screen shots when the tests fails.

Change-Id: I8e53f8767ed1c42ecfeeaa15fcd47ae7ac60fe1d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91714
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: Add missing javax.xml dependency for staging target

This fixes the missing javax.xml dependency for org.apache.xerces.
javax.xml is no longer packaged with the Eclipse RCP features but
apache.xerces still depend on it (for XML editor, etc).
If Orbit updates the dependency then we'll be able to remove it but
it might not be worth the effort at this time.

See also
https://bugs.eclipse.org/bugs/show_bug.cgi?id=467028

Change-Id: I9c1fa21efb5fa992464cae2af08641c80dde23f3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90886
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Use Eclipse 4.6 milestone builds

This will allow us to test and build using the Eclipse 4.6.3 RCs.
Also, derby can now be used from Orbit because test.performance was
updated to use “import package” instead of require-plugin. It is better
to use the one in Orbit because it is on download servers instead of
build.eclipse.org which has proven to be unreliable.

Change-Id: Ie61da4b0cec68e5071ef529993e8d9815a85b523
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91153
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix TmfTestTrace.getFullPath in Windows

The path passed as argument to Bundle.getResource(String) should not use
the backslash as separator.

Change-Id: I8efbe18b5c3f4b1a325b05d788902ae6c2e6cfde
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91655
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix deletion of supplementary files in unit tests

The trace should be disposed before attempting to delete supplementary
files, otherwise the checkpoint indexer could still be holding a file
handle to the index, and file deletion fails in Windows.

Change-Id: I81f04dfd198c9a49f1dfdce36673e532bdf8b54d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91576
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>

segStore: Introduce IContentSegment

Make TmfXmlSegment implement an IContentSegment

Change-Id: Ie6126f88fadc4c32c997b4d568b77e50ea39ec36
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/86294
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Add public trace import operation

Change-Id: Ic0f84ec5648abf8591a31042da513b35f3c927d2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/90320
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix TmfTestTrace.getFullPath()

Change getFullPath() to return an absolute path and update callers
accordingly. The internal directory is no longer a relative path from
the plug-in installation location, which allows getTrace() to work
properly when called from another plug-in.

Change-Id: I761ce633da8a64e33fe83e062478da566d5c795c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91408
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 512509: Time graph viewer initial layout is incorrect

Set an initial width hint on the Tree layout data at construction.

Change-Id: I7c7e1fe219e5b53fb0830111ea9a1d0511efe9f7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/91552
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add more checking to UstKernelSyncTest

The testOneEvent() fails spuriously. Either the wrong event is
retrieved from the trace, or the analysis module is somehow not
ready when it should be.

This extra check will allow us to determine which one of those
two causes is the problem.

Refs bug 506868.

Change-Id: Ie6646a734fcf07a21c810d15c708db3a460c8765
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/85187
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

segStore: Add a INamedSegment interface

This interface is to be implemented by any segment that has a name. This
name can be used in statistics, and other segment store views

Change-Id: Idc1ff17d9725b6ac0b1d79c04c61fedd96366278
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/82284
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Deadlock closing a trace as a signal is calling getAnalysisModules

When a trace is opened, a traceRangeUpdated signal is sent
asynchronously. Depending on when this thread starts running, the trace
might open and the user might close the trace before it starts.

-The trace cannot finish disposing before the signal is finished because
when it tries to dispose its analysis, they unregister themselves from
the signal manager, but TmfSignalManager.unregister is synchronized
-The signal cannot finish because it is waiting for the lock on the
analysis map (being iterated in the dispose thread).

Here is an illustration of it:
Thread 1 (dispose): > analysis map lock > waiting on signal manager lock
Thread 2 (signal) > signal manager lock > waiting on analysis map lock

Bug: 512394
Change-Id: I0f27aa6c976a54368f79cd885a561c6ce8ac3dba
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91427
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis.ui: Fix Export to TSV action in segment store statistics view

This adds the style SWT.SAVE to the dialog and asks the user to override
an existing file before the save. Test will be added in a subsequent
patch.

Change-Id: I4b97197c94e46cfb7f6894902012f1ef242c0ceb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91508
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix timeouts wrongly set to 2 secs

Change-Id: I371c6a51fa6aec82d7f9d35e7cfbca8b9d23902c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91500
Reviewed-by: Hudson CI

releng: Fix doc index build failure

By default, the eclipserun plugin uses Java 7 execution environment.
But we need Java 8 now for Neon.

Change-Id: Icb3592397b84ccc7cb7d0bfa4c4881bdbb1dfee4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/91428
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

timing: Cancel previous flame graph build job

Fixes bug 512195

The flame graph view was previously waiting for the previous job to
finish, waiting to acquire the lock, often in the UI thread. Now the
previous job is cancelled before acquiring the view's lock.

Change-Id: I36562822628e93560eefd26fc89cbf02d9469557
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91086
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add onFail() method for analysis

This method is executed upon failure so that analyses can make their
state coherent when failure occurs.

Change-Id: Iad689d83ffb3c508160a3a099119f8a6c11dc2a6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/90668
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Catch exceptions and gracefully fail state providers

Partially fixes 504078.

When a runtime exception occurs in a state provider, it enters
sink mode, does not read more events and fails gracefully.

Change-Id: I9c8bde9561cc2fd6d49b699b7632a4594e4ec744
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83277
Reviewed-by: Hudson CI

os.linux: Have the I/O analysis depend on TID

It uses this dependency through the aspect, but the aspect uses TID
analysis now, not the kernel analysis anymore.

Change-Id: I028a7ea98ead5023aea3113148332f837391ca54
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/91054
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Add more script documentation, examples

Change-Id: I87b8ee328055ce464c762555a5cf011fa8f70db5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/88910
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

releng: Update eclipserun update site and test-traces to latest

This helps not downloading multiple versions and saves time.

Change-Id: I71bd110d8bbbc7843670f4b48e030badca133729
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80136
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Fix some API errors with Eclipse 4.7

Adding fields is now an error but we probably want to ignore this
because it is quite restrictive

Change-Id: I0b4cea6a13a7db09e072a40f98bb91eefe718f9d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90757
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

releng: upgrade to tycho 1.0.0

useProjectSettings is now true by default so it can be removed.

See https://wiki.eclipse.org/Tycho/Release_Notes/1.0.0

Change-Id: Iff20634fe883effbfaf7575063870470316df5c9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/90453
Reviewed-by: Hudson CI
Reviewed-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-André Laperle <marc-andre.laperle@ericsson.com>