Bernd Hufmann [Thu, 28 May 2015 14:07:35 +0000 (10:07 -0400)] 
doc: add time axis alignment to user guide
Change-Id: I4cb900dbc83d0adefea0b19865d877caf411834f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48870
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 28 May 2015 12:19:52 +0000 (08:19 -0400)] 
tmf.ui: make fields static
Change-Id: Ie87294e64410656d0afaada8705e786b7a8f5a94
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48856
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 27 May 2015 19:58:50 +0000 (15:58 -0400)]
tmf: bug 468542: Fix toggle of search/filter in table using the mouse
Change-Id: I5e1f849272c9ac89e9c15564f9f6a133562fdc1d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48816
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 21 May 2015 22:11:29 +0000 (18:11 -0400)]
tmf.swtbot: add time axis alignment tests
Change-Id: I1ae6e460a2d59e07c955d9ccb98a961ffd53b0e2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48547
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 27 May 2015 17:53:45 +0000 (13:53 -0400)]
doc: describe selection of time ranges using the keyboard and toolbar
Change-Id: Ifd5141ab284a66465b6c9151699623f373771424
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48811
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 22 May 2015 19:32:39 +0000 (15:32 -0400)]
tmf: Bug 468074: Fix selection bucket index calculation
Additional fixes:
- Fix HOME and END key to ignore bucket event counts
- Fix calculation of bucket timestamp to consider half bucket offset
- Fix bounding of mouse event x-coord to the bounds of the histogram
- Fix AIOOBException on mouse hover during drag outside of bounds
- Fix some mouse events not working with single timestamp trace
- Fix some mouse events not working when range has no events
- Fix tooltip bucket range string
Change-Id: Ie89dd6b50ab03e8eeeb7ec8e2addc449945af3e7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48496
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 21 May 2015 22:10:01 +0000 (18:10 -0400)]
tmf.swtbot: Introduce SWTBotSash
This allows testing time alignment, it shall be proposed to SWTBot to
be mainlined.
Change-Id: I64229211179a4438ca354497bacdda6af5972042
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48546
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 20 May 2015 19:28:05 +0000 (15:28 -0400)]
tmf: Bug 467751: Partial workaround for XY chart concurrency issue
This change will remove the usage of the TmfUIRefreshHandler which
delays the clearing of the chart.
However, it is still not thread-safe and it might fail. To fix it
correctly, the whole API of XY charts would have to looked at and
this won't be done for Mars.
Change-Id: Ib838864fd8fb7086391b44f0b3dbf0558617f5f2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48320
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 1 May 2015 01:43:12 +0000 (21:43 -0400)]
tmf.swtbot: add swtbot test for gzipped import
Change-Id: I743830381774801be33699076bb510e735529fef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48271
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Tue, 14 Apr 2015 19:17:47 +0000 (15:17 -0400)] 
tmf: Add support for importing Gzip (non-Tar)
Change-Id: I25271514449ecbfb7da2f56ee3036949b077ec07
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48552
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 26 May 2015 17:04:14 +0000 (13:04 -0400)]
control: Bug 468358: Display syscall names for LTTng 2.6 support
Change-Id: I55a0b49d9dfbb1947ff7f27bc92fd304d11dcdec
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48670
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 20 May 2015 18:00:51 +0000 (14:00 -0400)] 
ctf: Fix truncated packet header timestamps in synthetic trace generator
Change-Id: I813b6b8f08aca15fc944ab14d80b065b1d52e0d6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48315
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Tue, 19 May 2015 21:12:05 +0000 (17:12 -0400)]
tmf: Fix IllegalStateException in HistogramDataModel
It should be allowed to have a last bucket set to 0 in the histogram
data model. This can happen if all trace events have the same timestamp.
The histogram time range is fixed to display even if the start and end
times are equal, as long as there is at least one event in the model.
The scaling is updated to make sure that these single-timestamp events
are spread over the whole width of the histogram. The scaled model will
have a bucket duration of 0 when it represents a single timestamp.
Change-Id: I5341aa6a158a3b4c1b3d4edee982ed67558e8a51
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48224
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 18 May 2015 02:49:24 +0000 (22:49 -0400)]
ctf: Introduce LostEventDeclaration singleton
Move constants from EventDeclaration to IEventDeclaration.
this removes some package cycles but breaks the API.
Change-Id: If20f7927dd878f2719e84fec6656dd7f55bc72e7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48040
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 18 May 2015 02:25:59 +0000 (22:25 -0400)]
ctf: internalize utils
Make utils internal. It makes no sense for this utils class to
be part of the API.
Change-Id: Ie4dfbfe3f807c04db3607c88819243550685c292
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48039
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 24 Apr 2015 20:28:38 +0000 (16:28 -0400)]
ctf: Make Events use IComposite instead of Structured definitions
Baby steps towards a more general API.
Change-Id: I38af394a23b31ecbf8bad45005dce5d9042b9378
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46462
Reviewed-by: Hudson CI
Matthew Khouzam [Mon, 18 May 2015 01:31:57 +0000 (21:31 -0400)]
ctf: do not append strings in StringBuilder.append() and avoid dead store
Clean up code during the process
Change-Id: If8017ce7bbec20a8a6542f2aaa30affa5f502059
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48034
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 1 May 2015 17:25:14 +0000 (13:25 -0400)] 
lttng: Avoid exposing internal class in shared tests
The VirtualMachineExperiment is internal, the shared test
utilities, which are made public, should not expose this
concept. Use a TmfExperiment, which is a public TMF concept
instead.
Change-Id: Id02891b77abf45ffc95e3c212ce62f759178e493
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46961
Patrick Tasse [Fri, 15 May 2015 16:00:23 +0000 (12:00 -0400)]
tmf: Fix set focus on SWT Chart viewers
Views should give focus to the SWT chart control on setFocus().
The SWT chart control should give focus to the plot area on setFocus().
The SWT chart control should give focus to the plot area on mouse down.
Change-Id: Ic442d7c75c834c281de2c37d0c01363cd319bf27
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47980
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 19 May 2015 16:04:02 +0000 (12:04 -0400)]
ctf: fix windows regression
In windows, the bitbuffer reads the filechannel. This advances the
position. It needs to be flip()ed to reset reading. This problem will
be obvious when we do CI in windows.
Change-Id: Id1cbf581c993038c54d8aa6fd3a62a77e17f17e3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48199
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 19 May 2015 16:02:44 +0000 (12:02 -0400)]
ctf: fix missing @since
Change-Id: Iaeb6ffc45b46382426e2987473e9351180c21190
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48198
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Tue, 19 May 2015 16:14:25 +0000 (12:14 -0400)]
LTTng control: Comment out test for machine address in LTTng control tests
Apparently, the address string was changed on hudson from localhost
to hipp3.
Change-Id: I3bca52dfe570e67f96993cd40474568f0e6c2970
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48200
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 14 May 2015 20:13:18 +0000 (16:13 -0400)]
tmf: Use OSString for the supplementary files folder property
On Windows, getLocationURI().getPath() returns a string that
starts with "/C:/...". This does not get parsed correctly by
utilities like java.nio.file.Path.
Using getLocation().toOSString() instead solves this problem.
Change-Id: I7c5d6d43cd21fd9c0021105884f61fb32bd133d5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47932
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 15 May 2015 22:37:12 +0000 (18:37 -0400)]
tmf: Fix XY viewer first pixel value and NaN when pixel range is 0
Change-Id: Ib73197ded6885bec9f84b4fde37b094f7feaf14a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48004
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 24 Nov 2014 19:03:09 +0000 (14:03 -0500)]
ctf: fix performance issue with fighting optimisations
The struct flatener will effectively override the byte array optimisation,
this fix will not flatten byte arrays.
Change-Id: I74d76261cc178bd4ab3fac16f749495a481ebfd3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36954
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Patrick Tasse [Fri, 10 Apr 2015 17:07:29 +0000 (13:07 -0400)]
doc: Minor corrections to Generic State System section
Change-Id: I9af4dd3c27f30f6e4ed478b7d6be9498f67674be
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/45676
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 18 May 2015 20:07:06 +0000 (16:07 -0400)]
lttng: Update for latest org.eclipse.remote API
IRemoteConnectionType#getCapabilities was removed, and replaced
with more direct capability-querying methods.
Change-Id: I5b14ab63320c2c0949d0d89a60fa7a2850f66bf3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/48106
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 15 May 2015 19:51:52 +0000 (15:51 -0400)]
ctf: remove field list from constructor of StructDefinition
This makes no sense to have as structs have the field list internally.
Moreover this leads to more complicated and error prone struct initialization.
It also hides potential bugs in the tests. As highlighted in CTFEventDefinitionTest
Change-Id: I25bf18bf9be23fb2af17f52de9cf677bea1b4833
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47992
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 15 May 2015 10:56:33 +0000 (06:56 -0400)]
tmf: Update mouse drag for xy charts to work with time aligmment
Change-Id: I6d94c4922bddae43ff9bcee3dfea118c7be446cf
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47957
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 15 May 2015 01:23:37 +0000 (21:23 -0400)]
tmf: Update calculation of offset and available width in XY chart
During window range updates the window start and end time of the
xy chart viewer used to be inconsistent with the corresponding
x-Series values. This lead to incorrect values when calculating
the point offset and available width for the time alignment during
the period of inconsistency. With this patch the offset and width
is calculated using the first and last time in the x-Series array.
Change-Id: I70eee0c08777c4b6797e2d6bbc41dd19fff05f64
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47944
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 15 May 2015 18:06:12 +0000 (14:06 -0400)]
lttng: Disable spuriously failing Partial State System tests
The partial state system is in very bad shape and not used at all.
Until some energy is put into improving its implementation and
testing, it should not be depended upon.
To make matters worse, one of its tests is failing randomly on
Hudson. Since it is not in a supported state at the moment, I
suggest disabling these tests until we improve the PSS.
Change-Id: I592598670b2f2a122c8f638b264502a48dae177c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47991
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 24 Apr 2015 20:32:34 +0000 (16:32 -0400)]
ctf: replace Defintion with IDefinition in IDefinitionScope
Change-Id: I06a73afd3a97633f4355828be0c10cf0dd7ad2e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46461
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 14 May 2015 15:33:40 +0000 (11:33 -0400)]
tmf: Fix calculation of time axis offset
Calculate the time axis offset based on the control sizes instead of
using the sash weight ratios which can introduce small rounding errors.
Change-Id: Iff8deabd45981913e5209b9d2d4f33b922a5d6d4
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47923
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 13 May 2015 19:44:13 +0000 (15:44 -0400)]
tmf: Fix calculation of sash weights in performAlign
This ensures that the sash width is taken into account when calculating
the sash weights when trying to align to a specific offset.
There can still be some drifting by 1 pixel, but this is caused by
integer trimming in the computations inside SashForm and SashLayout.
Change-Id: I742dc99e90e3eb4c9f95b1bac3da286f3187af3e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47884
Reviewed-by: Hudson CI
Bernd Hufmann [Wed, 13 May 2015 19:58:13 +0000 (15:58 -0400)]
lttng: Make sure that time alignment signal is sent in CPU Usage view
Change-Id: I5efa35104ba3cc3112cc82c5afd4b50632deb883
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47886
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 13 May 2015 19:57:46 +0000 (15:57 -0400)]
tmf: Don't subtract of 1 when getting the pixel coordinate from xAxis
For small time ranges this subtraction caused invalid coordinates which
lead to invalid time alignment when zooming in to very small time range
Also, make sure that getPixelCoordinate is only called when Y-values
are abailable when calculating the the point area offset.
Change-Id: Iaa623a406a91ac94e681bf610169892ee8149555
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47885
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 13 May 2015 14:32:13 +0000 (10:32 -0400)]
tmf: Fix calculation of available alignment width in TimeGraphCombo
Before the fix the vertical scroll bar was not considered when
calculating the avalible alignment width.
To observe the impact of the incorrect aligment value open just
HistogramView and ControlFlowView for a kernel trace without the fix.
Then the right margin of the Histogram view is not correct.
Change-Id: Ia54e2c3f03fcc22def4706b778518353515c7897
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47852
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 13 May 2015 10:50:58 +0000 (06:50 -0400)]
tmf: Set window start and end time of TmfTimeViewer in one method.
Now both values have to be set at the same time instead of calling
2 set methods.
Change-Id: I8b76dfdf9d6d5c4d4e00b440b8ae493307e5bd7e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47812
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 12 May 2015 18:57:54 +0000 (14:57 -0400)]
tmf: Set selection begin and end time of TmfTimeViewer in one method.
Now both values have to be set at the same time instead of calling
2 set methods.
Change-Id: I66d7e564609d83cba7f85bcad3649c39e34cc0eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47762
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 12 May 2015 18:44:20 +0000 (14:44 -0400)]
tmf: Set selection end time when opening XY chart views
Change-Id: I7b283f4492c00bc0a0fc6e716bd78aacf2751a4a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47760
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Tue, 12 May 2015 18:31:58 +0000 (14:31 -0400)]
Update default weight for the SashForm in time-aligned views
Change-Id: Ie345adad7836116e38a18d4b08d6ab1071e298cc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47759
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 29 Apr 2015 14:40:53 +0000 (10:40 -0400)]
tmf.core: Iterate over values or entries in a map iterator
Change-Id: Ia1ca10bc9bc0af48167417071585dd91c5bc2def
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46790
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 29 Apr 2015 15:13:35 +0000 (11:13 -0400)]
Tmf.Ui: fix Multithreaded correctness - Call to static DateFormat
The problem has been very well explained here:
http://fahdshariff.blogspot.ca/2010/08/dateformat-with-multiple-threads.html
As this code may be used in multi-threaded environments, not making it thread
safe will result in sporadically mangled dates. This patch fixes it by
synchronizing each access with the list of all items. More performance would
be had by using a threadlocal scheme where setting the timezone resets the
structure, but the legibility of the class would greatly suffer.
Change-Id: If8e9b118b3db15a2a0c088d4ebb2fa7c20839885
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46792
Reviewed-by: Hudson CI
Alexis Cabana-Loriaux [Wed, 6 May 2015 17:00:43 +0000 (13:00 -0400)] 
lttng: Remove unnecessary String object creation
Change-Id: I984c3218ebe2cff37b5596f53c2bb2d642f1bfd4
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47353
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexis Cabana-Loriaux [Wed, 6 May 2015 14:55:58 +0000 (10:55 -0400)]
gdbtrace: Change instantiation of Integer argument
Change-Id: Ib0bf057a4fd858271da1ea332e7ce94c3df72493
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47318
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Thu, 7 May 2015 22:25:18 +0000 (18:25 -0400)] 
tmf: Remove nullcheck before an instanceof
Change-Id: Ia1f5b9d7c77046bb6baa7c8950dbe8acd000ab5e
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47504
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Fri, 8 May 2015 13:41:57 +0000 (09:41 -0400)]
Use equals and equalsNullable method instead of ==
Change-Id: I3dcc6c0a60f88b0ffcf92dd6f3d17a831403dbb8
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47535
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Tue, 5 May 2015 21:46:51 +0000 (17:46 -0400)]
pcap: Replace a null-check by a NonNullUtils function in ConversionHelper
Change-Id: I41aaaa5bdcd7cbe849dcfc096350c91663763ac4
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47226
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Tue, 5 May 2015 21:55:06 +0000 (17:55 -0400)]
lttng: Remove redundant null check by marking generateSessionConfig() @NonNull
Change-Id: I96e6536b44d45c0bf02fb675f14c86bfd016644e
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47227
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Fri, 8 May 2015 21:42:06 +0000 (17:42 -0400)]
tmf: Remove repeated conditional test
Change-Id: Ia77d9ed5463e790a4526625e8f111946c470d891
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47537
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 11 May 2015 20:04:17 +0000 (16:04 -0400)]
Bump target sequence number to pick up Mars M7
Change-Id: Iab76273eb5573cac436da167f9b404b1b6472a0d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47663
Reviewed-by: Hudson CI
Bernd Hufmann [Tue, 5 May 2015 13:12:56 +0000 (09:12 -0400)]
tmf: Adjust xAxis range after mouse drag operation in XY chart viewer
This will provide correct values for x-Axis alignment.
Change-Id: Ic98423582b6c361f1fefc79e837dc919aaaad038
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47178
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 4 May 2015 15:24:56 +0000 (11:24 -0400)]
tmf: Align the time-axis for time range histogram
Change-Id: Ie1dfb34e9ffdbe881bb477622398dce44546529d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47077
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 6 May 2015 21:02:47 +0000 (17:02 -0400)]
tmf: Allow shift key to extend selection in time graph
- Extend the selection range when shift key is pressed while pressing
left or right keys.
- Extend the selection range when shift key is pressed while running the
next event, previous event, follow arrow fwd, follow arrow bwd actions.
- Update status line when the above actions modify the selection.
- Make sure the selection end time is visible when modifying the
selection range.
- Show status line when time graph control has focus with mouse outside
of the control bounds, but without displaying the cursor time.
- Highlight the selected state at the selection end time instead of the
selection start time.
- Remove the margin factor that made 'ensure visible' change the time
range when the selection was near the left or right margin.
Change-Id: Iee1dbbbc56e052de1a48bc638355e0c7dc126c2a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47381
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 6 May 2015 18:06:17 +0000 (14:06 -0400)]
tmf: Allow negative time range selection
This patch allows the selection end time to be lower than the selection
start time, better representing the user selection.
It will help to correctly update the end boundary using atomic
operations (keyboard or button) that extend a selection to the left of
the selection start.
The status line message delta is updated to allow a negative value.
Change-Id: I5228441cb049487783d4b0fdcba7ef766077677f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47380
Matthew Khouzam [Wed, 22 Apr 2015 17:05:43 +0000 (13:05 -0400)]
tmf.ui: add percent of selection to timechart view
This allows us to know how much time is being used by one entry in a timechart.
Applies to Control flow view, resource view and the call stack view
Change-Id: If7052553473ca53929aafaba7fc5831883e4e087
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46271
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Mon, 4 May 2015 14:55:06 +0000 (10:55 -0400)]
tmf: Add sash for time range histogram and time controls
Change-Id: I127751cc998e56cd47afae7922099e2861028e61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47075
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 27 Apr 2015 20:44:11 +0000 (16:44 -0400)]
tmf.ui: make histogram use entire range of plot area
This feature will help view alignment but has an issue with beat
aliasing due to sampling periods not being harmonics.
Change-Id: Iff033f90f68e0614a9f56a402400b9385108107d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46593
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Thu, 7 May 2015 22:37:10 +0000 (18:37 -0400)]
tmf: Fix time scale not visible at first in Control Flow view (GTK3)
Bug 466791
Change-Id: Ide2431eb9a48f5430e04f53bd3d76c28c03577d3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47505
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 8 May 2015 19:59:48 +0000 (15:59 -0400)]
ctf: Provide a Maven property to specify a ctf-testsuite commit to use
Instead of automatically pulling all changes from ctf-testsuite,
which may break our builds unexpectedly, we'll define a commit
to use in the plugin's pom.xml.
We can regularly update this pointer to pull in newer versions
of the test suite.
The property can also be overridden on the command-line, for
example using:
mvn clean verify -DctfTestSuiteCommit=master
will use ctf-testsuite's master branch.
Change-Id: I06b8e11f12fec16d9c011f0f2a80b083fcadd8de
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47554
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
France Lapointe Nguyen [Thu, 7 May 2015 21:00:11 +0000 (17:00 -0400)]
tmf: Synchronize initialization methods of static fields
Change-Id: Iedc625fb00e3f9745c03f3bea233c12bc5b9ca26
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47355
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 7 May 2015 19:32:50 +0000 (15:32 -0400)]
tmf: Fix bad width value when timegraph views are smaller than time axis offset
Change-Id: I2e2a4361e0ce1fb1857e4f0be7e781c56ead438c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47485
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 6 May 2015 21:28:36 +0000 (17:28 -0400)]
tmf: Fix regression of XML analysis combined with custom text parser not working
bug: 466641
Change-Id: I9c6ea6014e6f25f73e52ed182b6abc2ab2394a17
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47382
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 7 May 2015 21:33:38 +0000 (17:33 -0400)]
ctf: Allow mixing unspecified stream IDs with ID 0
If an event does not specify a stream ID, we will assign it to
stream with ID 0. This means they will be put in the same stream
as the events specifically defining stream 0.
A corrolary is that if a stream does not specify it's id, it too
is assigned to 0.
However, the trace must not define any stream IDs other than 0.
This behaviour matches the one of Babeltrace.
Change-Id: I0628acaa8566dde0a3659fe56d5a8e903c6feb26
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45687
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
France Lapointe Nguyen [Thu, 7 May 2015 18:04:09 +0000 (14:04 -0400)]
tmf: Remove 2 redundant nullcheck in TmfEventsTable by using local copy
Change-Id: I5e0fb8f084afa7ef07f573c877fb2b8b24af0493
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47224
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 6 May 2015 17:43:30 +0000 (13:43 -0400)]
tmf: Fix status line not updating if trace editor is reused
The status line showing the delta of the selection range was not
updating if the trace editor was opened using a bookmark or was restored
following a restart of Eclipse.
Change-Id: I826b21209cfa329d5df99f077e9f3342950eae74
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47379
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 7 May 2015 01:46:21 +0000 (21:46 -0400)]
histogram: reflow comments
Change-Id: I79e439e5bb03c4e35d3985b20a810f50714922e7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47399
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Thu, 7 May 2015 14:16:02 +0000 (10:16 -0400)]
tmf.ui: reflow events table
Change-Id: Ia36fd20caa4f1f38d34de2299f1a58dbe537b639
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47448
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Wed, 29 Apr 2015 20:40:57 +0000 (16:40 -0400)]
tmf: Align the time-axis for MemoryUsageView, XmlXYView (TmfChartViews)
Change-Id: I22480ae2d4adc3b223a68dd9a859b2a3fb2b32c8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46819
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 29 Apr 2015 18:29:01 +0000 (14:29 -0400)]
tmf: Align the time-axis for the CPU usage view
Change-Id: I4eef728afc1092ee0fe9b340af97bf4345aa2d2b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46811
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 29 Apr 2015 18:28:27 +0000 (14:28 -0400)]
tmf: Align the time-axis of time chart views
This patch introduces a logic for time-axis alignment across view. The
time chart based views use this new mechanism as a first implementation.
Change-Id: I31a05b686c8028b8f3e0643afa7aa540c9165cdf
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46810
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 19:25:06 +0000 (15:25 -0400)]
lttng: Remove capital letter in package name
Rename lttng2.control.core.relayd.lttngviewerCommands to
.commands. Package names should not contain capital letters.
Change-Id: I250f9a72b2ea966e0c3e3e6568d87cab5a77dc9e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46378
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 1 May 2015 22:02:23 +0000 (18:02 -0400)]
Remove unneed null checks
A recent JDT update seems to have extended the null flow analysis
to consider the case where assigning an Integer from an int makes
it effectively non-null.
This points out that we were doing some redundant null checks.
Change-Id: Ie222b519f02e45584ae4f47381025fd28a8f6423
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46967
Reviewed-by: Hudson CI
Alexandre Montplaisir [Wed, 6 May 2015 19:34:54 +0000 (15:34 -0400)]
Remove the Eclipse 4.4 target file
A recent change in org.eclipse.remote.core requires Eclipse 4.5.
As such, Trace Compass now also requires 4.5.
Change-Id: I8a71bc98123a7137a75cfcc4f20a8dfd21fde4a1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47369
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 5 May 2015 02:56:48 +0000 (22:56 -0400)]
common: Add a test for BufferedBlockingQueue's iterator contents
Also changed the test string to something more easily debuggable.
Change-Id: I760574b01e77709b5238e5e5ea019981fa79d45f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47116
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
France Lapointe Nguyen [Tue, 5 May 2015 17:49:57 +0000 (13:49 -0400)]
tmf.ui: Remove AOOBE in GraphNode when given an empty list
Change-Id: Ic870af87fe73fd4a9b9eceb3f818aaaabde21ac2
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47201
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 5 May 2015 02:32:00 +0000 (22:32 -0400)]
common: Fix flaky BufferedBlockingQueue test
The test testing concurrent insertion/removals/iterations
incorrectly assumed that all elements send to the queue would
show up in the iterator.
This is a known limitation of BBQ's iterator(), and is documented
in its Javadoc. The elements present in the queue at the time the
iterator is created will be either seen by the iterator OR consumed
by the consumer.
We cannot assume anything with regards to the iterator's contents.
A separate (sequential) test for the iterator's contents will be
provied.
Change-Id: I3d281ca1ad4a81e69f02363b52942990424dd57c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47115
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 17:25:19 +0000 (13:25 -0400)]
os.linux: Re-organize the KernelAnalysisModule
Bring the KernelAnalysis up to speed with regards to naming
conventions and public/internal separation:
- Rename KernelAnalysis to KernelAnalysisModule
- Move KernelStateProvider to internal package
- Move KernelStateProviderTest from lttng2 to os.linux plugin
- Remove direct references to KernelStateProvider in
lttng2.kernel.core.tests, extend the analysis module instead
- Expose the internal package to the test plugin
Change-Id: I8a7baaacdc8a31c033e0fd8ae1650f34fd5232ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46373
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 22 Apr 2015 18:37:58 +0000 (14:37 -0400)]
tmf.core: move AbstractTmfStateProvider to new BufferedBlockingQueue
This yeilds a performance boost, especially on slower io systems.
Change-Id: I04dd89d2237c80bd07c00514fd83f0d4f31e13dc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46279
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Tue, 21 Apr 2015 22:27:34 +0000 (18:27 -0400)]
ss: Move ThreadedHistoryTreeBackend to new BufferedBlockingQueue
This should yield a significant performance boost on state system generation.
Especially on slower IO devices.
Change-Id: Ie414270194e9622be7106dc6c0b9ccc7050f49aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46215
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Tue, 21 Apr 2015 18:36:43 +0000 (14:36 -0400)]
common: Add test suite for the BufferedBlockingQueue
Change-Id: Ibc27385a75faeb47586443530fb68fe848979946
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46206
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 21 Apr 2015 02:08:05 +0000 (22:08 -0400)]
common: Introduce a generic BufferedBlockingQueue
The BufferedBlockingQueue (nicknamed "BBQ") is a wrapper around
a standard ArrayBlockingQueue, which accumulates elements in a
separate Collection before putting them in the actual Queue.
This allows a producing and a consuming threads to not block each
other as much when they are producing and consuming at the same
time.
An identified use case is the ThreadedHistoryTreeProvider, and
perhaps eventually the AbstractTmfStateProvider too.
Change-Id: I010547d7914c4c377bf1c85f4f830bff0aa8740f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46148
Reviewed-by: Hudson CI
Marc-Andre Laperle [Thu, 30 Apr 2015 17:16:15 +0000 (13:16 -0400)]
Upgrade eclipse-jarsigner-plugin to 1.1.2-SNAPSHOT to fix build failures
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=464947
Change-Id: I684d7bcc278a14ae5d1467c0574567804cd96ac1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 30 Apr 2015 00:59:07 +0000 (20:59 -0400)]
ctf: clean up CTFStreamOutputWriter.java
Merge if statements
Preserve exceptions
Throw exception on deletion failure as the trace would be unreadable
Change-Id: I77f23e5bca82be26b831a38ea5add385586e20f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46831
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 30 Apr 2015 01:13:35 +0000 (21:13 -0400)]
tmf.ui: fix modifier order in TmfCommonXLineChartViewer
Change-Id: I050bcec1eac37a56b535085da278840437bb3160
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46832
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 28 Apr 2015 14:13:37 +0000 (10:13 -0400)]
tmf.ctf.ui: test invalid trace validation (Bug 464329)
Change-Id: I28fd7b41ff4777e43dbdcbfd013020f8a256fe87
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46685
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 28 Apr 2015 20:39:32 +0000 (16:39 -0400)]
tmf.ui: make trace errors use JFace MessageDialogs
Change-Id: I244c437f874a5b0caf6c2e38997fea384433f598
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46716
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 27 Apr 2015 19:00:08 +0000 (15:00 -0400)]
tmf: Fix value of time offset in XY chart viewer being wrong for a while
Right after calling setWindowStartTime/setWindowEndTime, the value of
getTimeOffset was wrong until setTimeOffset was called later, in a data
building thread for example.
Since the time offset is deduced from the start time (startTime - 1), we can
remove this field and setter. This means that the time offset will always be
consistent with the start time. Similarly, the window duration can be deduced
(startTime - endTime) therefore we can remove this setting and field as well.
An example of how this bug can manifest itself is inside a resize listener.
If both windowStartTime and timeOffset are used to calculate the position of a
value on the chart, since the timeOffset can be inconsistent, the position
would be wrong.
Change-Id: If59a9d2c0dfc24245949f8ba693dd89e6498820f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46591
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 13 Apr 2015 18:24:38 +0000 (14:24 -0400)]
ctf: introduce a CTF writer for copying packets of an input CTF trace
Change-Id: I0cb39fba1b28d6a6e816c2278fe1d6d859b7a797
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45832
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 19:36:07 +0000 (15:36 -0400)]
lttng: Remove RSE-specific workaround utility class
This class provided workarounds for an RSE-related bug.
Since we do not use RSE anymore, this class is now unused.
Change-Id: Ia206ca869faece7611cdffcce01233b2004ce9d9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46379
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 23 Apr 2015 17:34:11 +0000 (13:34 -0400)]
lttng: Update package and file names in lttng2.ust.core
Harmonize the naming of the the UST memory analysis files and
packages.
Also renamed the "core.trace.callstack" package to just
"core.callstack". It is not specific to the trace package, and
its not an analysis module either (the Callstack is a public
TMF concept).
Change-Id: I0f2d085801a522f62bba09ae623f55043af24a03
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/46374
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 24 Apr 2015 13:26:16 +0000 (09:26 -0400)]
ctf: simplify logic for CTF validation
Change-Id: I2282dd6865adc78af423395ee776a9a749e96734
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46433
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 23 Apr 2015 15:06:26 +0000 (11:06 -0400)]
ctf: add unit tests for CtfTmfTrace.validate() method (Bug 464329)
Change-Id: I2fcb5e4260159603e08a0597fc7ec723dc2b3b16
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46351
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 23 Apr 2015 18:13:49 +0000 (14:13 -0400)]
ctf: disable failing test for newly added trace in ctf-testsuite
Disable it till it's fixed.
Change-Id: I8d31f54bbe9cb3cf75f2636ac532db04bafc0f28
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46376
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Sat, 11 Apr 2015 03:31:51 +0000 (23:31 -0400)]
ctf.core: add populate indexes and fix seek last event
Add much needed documentation to goToLastEvent. It is
not as trivial as one would think.
Change-Id: Ia2834df70f583430afc1a7046993809c9262a690
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45689
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 16 Apr 2015 03:03:11 +0000 (23:03 -0400)]
ctf.core: introducing ICTFPacketDescriptor
This is the interface of the "StreamInputPacketIndexEntry".
The documentation is also slightly expanded.
Change-Id: Ic02762ab90c0bf69766c7bcf90ddd2207e7e12f6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45929
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 21 Apr 2015 19:59:56 +0000 (15:59 -0400)]
CTF: Enhance CTF validation for invalid CTF traces (Bug 464329)
The CTF validation has been updated to do first a weak validation
to determine if the directory is actually a CTF trace. After that
a full validation is done. If the full validation fails and the
weak validation was successful a TraceValidationStatus with
severity warning and confidence of 1 is returned.
The automatic trace type detection has been updated so that the
special case above is acounted for.
With these updates the trace is imported as CTF trace however, the
use is notified that with a proper error message in case the full
validation failed.
Change-Id: Ia9b798b34c7af122d3b7684e91b114b38b656cef
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46202
Reviewed-by: Hudson CI
Matthew Khouzam [Mon, 20 Apr 2015 22:30:57 +0000 (18:30 -0400)]
ctf: rename CTFReaderException to CTFException
CTFIOExceptions are now only thrown by *Readers and not types or other
Change-Id: Id352ef121d3c94b4004e6c5fbe70c282bd131261
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46134
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 20 Apr 2015 18:19:24 +0000 (14:19 -0400)]
Revert "ss: accelerate state system creation by 25% by coalescing intervals"
This reverts commit
2ce551cccdac4096d3efd910f11e3fabe3c51856.
The commit is causing incoherent interval exceptions. A rework should be available soon.
Change-Id: I2e0d091d81e032b0f2e6ee65251a7c58b6320db4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46120
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 10 Apr 2015 17:25:21 +0000 (13:25 -0400)]
tmf: update ITmfEvent.getType().getName() to be getName()
This could yield a performance boost
Also, substitute TmfUml2dSyncLoader's getType().toString()
with getName() as it is being used to get the event name
Change-Id: Ide3cb3f0a97f86d99f2e358f608dac107c730bef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45675
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
This page took 0.086535 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
