rcp: add o.e.remote.jsch.core/ui plugins to the RCP feature

Change-Id: Ice402afafdd96d2a4061a47774a34af44bbddcb0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69622
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Fix use of deprecated SWTBot API

Also bump the target sequence numbers to that people get the latest
SWTBot.

Change-Id: Ia615d6642849a97c3e18f49a29ec134b0e11151e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69638
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

swtbot: Add SWTBot tests for collapsible event table header bar

Change-Id: I53e6d536b8995ed02190c22a4b9fa7d1eb59a32b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68583
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Update javadoc for TmfTestHelper#executeAnalysis

Change-Id: I015e918b56a8c4607ba0606ba3c768fecc7f433f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69092
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Remove "Analysis" from localized analysis names

As discussed in the March 18th project meeting, localized
analysis names should be aligned and not end with "Analysis".

Change-Id: I726dba212ef8bc50be49c5c5d52ad3ede580369c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69070
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Mark ITmfStateSystem#queryOngoingState as @NonNull

Just like querySingleState, an ongoing state cannot be null
if the passed attribute is valid. At worst the value can be a
NullStateValue.

Change-Id: I138ce6d0d62a0cb45706117fd4d0e4bdf8e8fc58
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68815
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Add a new StreamUtils class

We often use Iterable in our APIs, due its minimal behavior
exposition. Unfortunately, there is no Iterable.stream() method,
the official way is done using StreamSupport and the corresponding
spliterator.

Since this is a very commonly used pattern, we can introduce a
small utility method that will make it less verbose.

At the same time, we can move the StreamFlattener into the new
utils class.

Change-Id: Ia4fed4f8a5da56f08ac133eb10efae970004e511
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68563
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.linux: Move ThreadPriorityAspect to the event.aspect package

Also move the related logic from KernelThreadInformationProvider
to the aspect itself.

Change-Id: I9dbf5854e3b8057fc5cb5dd147040e4b1a63cf68
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68561
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Disable live tracing feature

The Live Tracing feature is quite limited and error prone. Some
of the shortcomings are documented in bug 486728. Since there are no
short term plans to improve this in Neon, perhaps it is better to
disable this for now.

Change-Id: Iaf6cab29ce55fde58296aab9935d220eee29a297
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69285
Reviewed-by: Hudson CI
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

swtbot: Stabilize FilterColorEditorTest

A condition is added that waits for the image at the specified bounds
to have changed when compared to a specified current image. This ensures
that the cell has painted with required changes following user input.

ImageHelper now implements hashCode() and equals().

Change-Id: I444ab78f074ebd5c28f8b4aea4927b1c01558486
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69076
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Make TmfEventsTable#PackColumns return a value

This allows extending classes to know whether the pack actually happened
or if it was fast returned. The quick return shows that the columns have
already been packed. If the method does pack the columns, we know that it
was done the first time (on a new trace open) or after. This can allow
extending classes to have a hook to a location where the columns have
been initialized as they are not yet in the consutructor or in "init".

Change-Id: Ia4f3ab76e144d937bb5a8eb5e7597c9e99b3114f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69469
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.linux: Add per cpu thread 0 modeling

The current model handle thread 0 as a normal thread which is incorrect
since it is the idle or swapper thread and can be active concurently on
multiple CPUs.

This commit adds this concept to the state system and the control flow
view by using a special thread attribute name of "0_X" where X is the
CPU number.

Change-Id: I476927be378482751ee523fac77bbf4d260da54a
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69089
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

os.linux: Fix CPU state when Softirq is interrupted

This patch makes the cpu the aggregate of the PROCESS, all SOFTIRQs
and all IRQs. The process now does a rigourous check of every state
in the CPU. This can be later replaced with a virtual or aggregate entry
if deemed necessary.

This patch fixes bug 481855.

Change-Id: I1fd368362daf269c12cc4f12f459c5a1e404e420
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68002
Reviewed-by: Hudson CI

Add Trace Compass 1.2.1 API baseline

Change-Id: I62d2c5471ffdae199013ea016d0d10d79bfe2152
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69455
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Skip CopyToClipboardTest tests when running GTK3 and Eclipse 4.5

These tests will never work in Eclipse 4.5.x because there was a bug
in SWT that only got fixed in 4.6.0. See bug 486302.

Change-Id: I78d9b95970bf3b99b07108e98d046f8d6dd58b94
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69395
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

swtbot: Stabilize use of SWTBotUtils.maximizeTable()

When Ctrl+M is pressed, the resize and layout of the workbench part does
not necessarily occur immediately. For tests that depend on the part
being maximized, the method should block until the resize has occurred.

So far, this issue was only seen when SWTKeyboardStrategy is used.
SWT strategy posts events to SWT and this differs from the AWT strategy.
But the solution in this patch offers an additional safety that is
beneficial to all keyboard strategies.

Change-Id: I3afac9314a82c319064accca1fce00c1dbeb893e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69075
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix SWTException in TimeGraphMarkerAxis

The zoom thread can call setMarkers() while the view containing the time
graph has been closed in the meantime, causing a SWTException: Widget is
disposed.

Change-Id: I586b3835fdee958e5e7c558f000954a3de5db616
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/69282
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix task state unknown with Linux >= 4.1

The control flow view displays the task state as WAIT_UNKNOWN with
newer kernels. This is caused by a new task state value. The mask is
adjusted to fit this new value.

The fix is backward compatible.

Change-Id: I568dd51cd597ab64819cc6a83a3c6f06ec859489
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67377
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Fix new null warnings

Recent 4.6 JDT emits null warnings in a few more places.
Some un-annotated generic types are now implied to be nullable.

Change-Id: I37349ba28ce6d88a60cb44c5df7d4f8f5d7c439c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68227
Reviewed-by: Hudson CI

releng: Use org.eclipse.remote plugins instead of the feature

The top-level feature now includes the doc.isv plugin, which
in turn depends on all org.eclipse.remote features (serial,
telnet, etc.) which we don't need.

Depend directly on the plugins instead.

Change-Id: Iac7eb44d75b0db46549cdc6d3cfe027e504a95bc
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69298
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Add missing eclipse.ui.trace dependency

We used to get this dependency through o.e.remote.ui but
they don't depend on it anymore so we don't get it.

Change-Id: I9b2f4b7df5b571871b6757fb8afdd8855082ab65
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69284

Add git-review configuration to repository

Add .gitreview to enable the use of the git-review plugin to interact
with Gerrit. Documentation on this plugin can be found at:

  https://github.com/openstack-infra/git-review

Change-Id: I8240a5baf7e1171b932896a6615131453b55adad
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/69173
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Update version numbers to at least the versions in stable-1.2

Change-Id: Ibd2898b5f67bcddb0ecafd44e43344ad7884c4a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/69215
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Delete project at the end of ControlViewTest

So that the test can run twice in a row.

Change-Id: I4382c991c3add7f8fe53fae14963f65ce446e15a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68860
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis : Abstract the latency statistics analysis

Change-Id: I452cf2f165ea74522dbd3cb98547ad2784324a73
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67841
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis : Remove checkNull() in Segment store statistic viewer

Previously, if the view was called and the trace is null, an exception
was raised. Now, if the trace is null, the view will do nothing. This situation
happens when using this viewer with XML views, the trace may still be null
when the viewer is updated.

Change-Id: I5f3e7dac7ef93e8b0cf795d7219278aad3fa9c90
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68228
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ss: no longer have a strings section in the HTNodes

The state systems nodes had a string section to allow for faster seeks
on the state system file if the entire interval was not loaded to memory.
This is never the case and it adds an extra integer to each non-integer state
as well as extra (but well tested) logic.

This patch makes the state sytem store each interval sequentially on a
given node.

Expect minimal performance difference, however, the size of the state system
may shrink a bit (approx 5%).

Change-Id: I01bc8594b7944fad97b6c9b715b848b6afa39913
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68404
Reviewed-by: Hudson CI

ss: Add unit tests for state values

Change-Id: Ibc7da569fcb3cd2920170a1d28bb48dc6497fe7f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67908
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Remove dependency to version of testtraces

Change-Id: I920211c5453452f2b7c49b60732b7c82f055f20a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69025
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

releng: Build for Neon (4.6) by default

As we are approaching the Neon release, we should compile and test
against Neon as our primary focus.

Change-Id: Ifdf3a1a8cdb700e0a2b98f3d519480face9b61b8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68848
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

common: Annotate Integer.valueOf() as @NonNull

It always returns a new, or existing, Integer object.

Change-Id: Ia37b0fb93780131ce2e7369fb69add515f698e49
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68814
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate Stream.map() and .filter()

Those common methods return (continue) a non-null stream.

Change-Id: Ic570291f15ce1be3274973ab45d6f65a93f244ef
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68665
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate StreamSupport

All methods in StreamSupport return a new Stream, so they can
all be @NonNull.

Change-Id: I734beaf39c5373858cabc93e3947dd22e9c0529e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68562
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 489971: Premature processing of payload in custom parser

Change-Id: Ifc49df1f2a40171bf285d600244350fb5da4e1a5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68817
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

control: Bug 489857: Fix live mode support for LTTng 2.4

Live streaming was added in 2.4.x. Since we can't retrieve whether
a session is live or not from a 2.4.x node, we copy the information
over from the session information at session creation time.

Note that this information gets lost when the user presses the refresh
button or restarts or Trace Compass.

For LTTng 2.5.0 and later it's possible to retrieve this information.
So we don't need copy this at creation time. This will make sure that
the session is recognized as live after a Trace Compass restart or a
refresh.

Change-Id: I4f07e0502de9c858a614946640305fbbcc8c27f6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68685
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Fix some tests's copyright header

I did not write any of this code.

Change-Id: Ic688309ee0eff9dfcb6aaed05ab01ada32b0019e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68854
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ss: add unit tests for state value types in backends

Change-Id: I3b33478e62331cc6b58d551db3597ae8cdbc892c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68097
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

ss: Add a package-info file to backend unit tests

Change-Id: I29b2b13cb32468fa4c4484c89360eb0eaf08076f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68096
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

releng: Targets updates for Mars.2 and 4.6M6

- Update 4.5 target with final Mars.2 update sites, use
non-composite where possible as they should not change (speeds up
dependency resolution)
- Update staging (4.6) target to not use the simrel update site, as
per recommendation by simrel team. Update update sites to latest
miletones; this required to fix the product dependencies. Luckily
those work with the 4.5 target too.

Change-Id: I39db87c315e7ee94a33c8b6c99b45ab86c81b1ad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68843
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

releng: Update outdated maven plugins

Change-Id: I1fc1f569bfc0a124f76fcdd5703e26be1d9a1295
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68828
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

os.linux: Rename the "kernelanalysis" package to just "kernel"

Long due change that was previously withheld to not break the API.
This aligns the naming with the other internal packages, which
were already renamed.

Change-Id: I9a0b3354e7018fa67f5baf7eb8a8522e1553f881
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68559
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Add missing package exports

Change-Id: I145fbf655c015a9ca46ee1d4e2c963f5a734deeb
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68558
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Update user guide for collapsible event table header bar

Change-Id: I45dfb1828398728bc85cdb0befa2bdf51b4b14db
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68496
Reviewed-by: Hudson CI

tmf: Fix Select Next/Previous Marker navigation

Because the markers are sorted by time, when navigating to the next or
previous marker, the marker start time should always be visible.

The action should not rely on the 'ensureVisible' implementation of the
method setSelectionRangeNotify(), as this method will ensure that the
end time of the selection will be made visible when the start time has
not changed. This causes problems if there are two markers with the same
start time but the end time of the second is out of visible range. Since
the window range is modified, the resulting marker list may no longer
include the marker that should have been next in the navigation order.

Change-Id: I434d454d7411f8a00bf58406ad7acc3128472de7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67643
Reviewed-by: Hudson CI

tmf: Support horizontal scroll with mouse wheel in time graph

Horizontal scroll can now be performed using Shift+MouseWheel while over
the time graph control state area.

MouseWheel over the time scale, marker axis and horizontal scroll bar
will now perform horizontal scroll, while Ctrl+MouseWheel over those
same controls will now perform horizontal zoom.

Table of MouseWheel actions:

modifier:      None       Shift      Ctrl     Shift+Ctrl
time scale     hScroll    hScroll    hZoom    hZoom
time graph     vScroll    hScroll    hZoom    vZoom
marker axis    hScroll    hScroll    hZoom    hZoom
h.scrollbar    hScroll    hScroll    hZoom    hZoom
v.scrollbar    vScroll    vScroll    vScroll  vScroll
outside (Win)  vScroll    vScroll    vScroll  vScroll

Change-Id: I0e48dd37b121b934ef872509aa721506876ca199
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68464
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add collapsible event table header bar with applied filter labels

- The manual toggling of the event table header mode (search/filter) is
removed.

- When a search filter is applied, the header row icon is changed to a
"Add as Filter" icon. Tool tip support is added for this icon. Clicking
the icon will apply the search as a filter, and clear the search filter.

- Ctrl+Enter shortcut can be used to trigger the 'Add as Filter' action.
It can also be used instead of Enter while in a header cell 'search'
text editor to apply the regex immediately as a filter instead of as a
search filter.

- The 'Show Filter Bar' and 'Show Search Bar' actions in the header row
context menu are removed, and are replaced with the 'Add as Filter'
action when there is a search filter applied.

- If search filters are currently applied on multiple columns, they will
each be applied as separate filters.

- The 'Apply Preset Filter...' and 'Collapse Events' actions now add a
filter to the currently applied filters instead of replacing them.

- Implement TmfFilterObjectNode so that any external filter object can
be included in the filter tree model.

- The collapse filter is handled separately from other filters. It must
be invoked only on events which first match every other applied filter.
This allows for filtered events to be collapsed even if they are not
contiguous as unfiltered events.

- Implement TmfCollapseFilter.toString().

- Implement TmfEventsTableHeader. This is a header bar composite
displayed above the event table when any filter is applied.

- The header bar has one label for every filter that is currently
applied. The label name describes the filter. If the filter was created
from the table search/filter row, then clicking the label will set the
table highlighting to this label's regex (if no search filter is
currently applied).

- Clicking the 'remove' icon on any label will remove this particular
filter. If no filter remains, the header bar will be hidden.

- Pressing the Delete key will clear all filter highlighting (if no
search filter is currently applied).

- When the header bar is visible, clicking its background or collapse
icon will toggle its collapsed/expanded state to save space. Each filter
label name will be set as a tool tip for the smaller label.

- A NullPointerException is fixed when cancelling a search before its
event request has been created.

Change-Id: I40cc3e3389f1ce43145e2a6025ed1c2a99d029e8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67928
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Move the HistoryTreeTest class to a new package

The o.e.t.s.c.t.backend package only contains classes for backend tests

Change-Id: I838b242102a1d5fc2ea3ce5271499cba191fa455
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68095
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

tmf : Add latency density view for the pattern analysis

Change-Id: Iedc781b8d8d5ae6a22eb699270e540f4826be38b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67840
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add latency scatter graph view for the pattern analysis

Change-Id: I44ccdf56c3b769e2f0d74dc26e7fe2f1eab568ea
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67839
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add latency table view for the pattern analysis

Change-Id: I3e652767dc8e53dc2eb95c27e159f8350e939eaf
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67478
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Update user guide for time graph marker axis

Change-Id: Ic3ca210994cf1d690f566d0703fc51e57e55371f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68465
Reviewed-by: Hudson CI

tmf : Introduce the modules for the XML pattern analysis

This patch introduces the XmlPatternAnalysis and its sub-modules

Change-Id: If27ed6816316752c405f14a31b9b91dcfad877c7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65750
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

os.linux: make SoftIrqs support being raised while executing.

In order to do this, statevalues are now bitmasks. Many more checks
at SoftIrq Raise, Entry and Exit handlers now take into account if
there are other SoftIrqs running and will retain their state.

Fixes part 2 of bug 381497

Change-Id: I2f109d1e4e3a227c10dcdf8f54df7b42c7776d4a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66259
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis : Introduce ISegmentListener

This patch add a listener for segments creation

Change-Id: I1da2cf3f6f91599ef4fc1a92f05306e90db0dc03
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67195
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

ctf: Increase ReadAllTraces test timeout to 1 minute

This test often times out on Hudson, we can increase it
to a more permissive amount.

Change-Id: Ib0c09bc157803b1b19ff213af2a804ee32458247
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68595
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis : Introduce buildAnalysisSegments() in Segment Store analysis

This abstract method helps the analysis decide how the segment store
will be built.

For instance, the segment store could be built using a request or using
segments generated by a prerequisite analysis.

Change-Id: I68c6b5d35ff71d8c06c5b4881bcbce25404b5581
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64592
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Fix ust memory analysis help text display

When the analysis cannot be executed due to missing requirements, the
user can request the help text to get the reason why. However, this
was not working and caused an exception because the requirements are
only instantiated when the trace is open.

Change-Id: I43ca26b964467711bea10bf7ed52eba2988e3fd9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68236
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Introduce a default lttng ust event layout

Change-Id: Ibd7d1813b920b08f7a003850247ab088cd9276fc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68234
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add the ID to the analysis property

This property is useful when developing data-driven views for existing
analyses.

Change-Id: I72fc0287c719326fe3a4de73cccafbfcffc490e9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67823
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

common: Add annotations to HashMultimap#create methods

The returned HashMultimap is always @NonNull.

Change-Id: Ic6be32944771b175101c202d0d16780ba3372d0d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68360
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: make Critical path listen to thread selected signal instead of selection listener

This patch greatly simplifies the critical path parameter provider.
Now it will listen to a TmfThreadSelectedSignal instead of listenning to an
action on the control flow view. This will decouple the critical path from the
control flow view, instead allowing anything generating the signal the opportunity
to run a critical path analysis on a given thread and trace.

Change-Id: Ifb7f1fe2d5f81a8127ceab93b262cc9c0bbdd0e5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68099
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

linux.ui: Add context menu to Control Flow View to follow a thread

The command to follow a thread generates a TmfThreadSelectedSignal. To
see the context menu, one must right click on a thread entry in the control
flow view. More follow action locations can be:

 * the events table
 * the resources view, on an event
 * the filters view
 * the critical flow view

Change-Id: Ib74eb67f98c514f29fde689c47c2cb42c90868db
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66665
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.core: Add cpu and thread to trace context

This patch allows to see what the last selected cpu and thread were
for a given trace. The cpu and thread are stores in a LinuxTraceContext.

To do this, a default method is introduced to ITmfTrace (createTraceContext).
This method is overridden by IKernelTrace to make LinuxTraceContext instead of
the regular TmfTraceContexts. The LinuxTrace Context has the CPU and Thread ID
information. An important thing to note is that if two kernel traces have the same
hostID they both get the signal. This is by design.

Change-Id: I25f044ec05fbd69acf93009861b464506327d616
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66667
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ss: Add benchmarks for the threaded history tree

This adds a new benchmark for the threaded history tree backend. It benchmarks
the insertion of intervals in the state system, single, full queries and
history range queries.

Change-Id: I4ac8eea4a6979c4f70b6d584b26ad3fc92ae4900
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66891
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Remove unneeded checkNotNull() calls

With the introduction of Java 8 type annotations and external
@NonNull annotations, some of our checkNotNull() checks are no
longer needed, we can simply remove them.

Change-Id: I00b39d7428e042ae2d93b15d37dda5cbd50f52c2
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68101
Reviewed-by: Hudson CI

tmf: Add unit tests for PeriodicMarkerEventSource

Change-Id: I38e8fb35f6a9f27c75a69e641819feb8c097a176
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68254
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 488806: Mouse scroll with count of zero not handled correctly

Change-Id: I11e9b5261b687b0095e29e2f7cb35a3507a18591
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67639
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: update user guide for importing traces as experiment from control

Change-Id: I8040ae89b4c1d5c9b5119ec316518386f26ed707
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67995
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Fix intermittent MemoryUsageViewTest failure

It is possible that a thread gets added to the memory usage chart
before the process name is determined. Once the process name is
determined, a new series is added to the chart but the old one is not
deleted. Not only this fails the test because the chart contains too
many series, but it shows the wrong information to the user.

To reproduce the issue, you can add a Thread.sleep(5000) in
UstMemoryStateProvider around line 222, before the process name gets
added to the state system.

Change-Id: I95631758e0fdffbc094a3adb923b7019841a4a60
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68312
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: update user guide for importing traces as experiment

Change-Id: Ie3efa0d4c2cf73fc4ef9b8cf07933af95eabf430
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67994
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Use a symbol provider to locate symbols

Contributed symbol provider extension point.
Contributed BasicSymbolProvider to symbol provider extension point.
Switched CallStackView to symbol provider.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=487978
Change-Id: Ic40c272c2dbc0074fc170e9ff0d2ee0e9f230559
Signed-off-by: Robert Kiss <robert.kiss@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67442
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf.ui: RemoteFetchLogWizardRemotePage replace size()>0 with !isEmpty()

Change-Id: Ic689934ff852f2464cd98a710697ffee75d096d6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68247
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

control: Add SwtBot tests for importing as experiment

The following test cases are added:
- import without experiment
- create experiment when importing a kernel trace
- create experiment during import with experiment name validation

Utility methods are added to SwtBotUtils to create an experiment and
to clear the experiment folder.

Change-Id: I68f7a1e350a87cb98b40389f0f4d2b7bf2f741d5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68163
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: Import as experiment only when checkbox is enabled

Change-Id: I31d6e0008017a86e9ef8d47861e3083330130a2d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68162
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SwtBot tests for importing as experiment

The following test cases are added:
- create experiment when importing from directory
- create experiment when importing from archive
- create experiment during import with experiment name validation

Utility methods are added to SwtBotUtils to create an experiment and
to clear the experiment folder.

Change-Id: I3fc5f83efc811f267cfc31a48c603915c9d74646
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68083
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate Pattern.compile()

Both variants of this method return a new Pattern object, so it
can be annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

Change-Id: Ia6b862f56b1ebc65fe1bdc1b2dcf6875e3afd36e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68107
Reviewed-by: Hudson CI

common: Annotate TreeMultimap.create()

All variants of this method return a new map, so it can be
annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

While at it, rewrote some comparator definitions in more succinct
lambda expressions.

Change-Id: Ic7a78eb38b9cf3fd2b8e79ab385d73c5d4cc2961
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68106
Reviewed-by: Hudson CI

common: Annotate HashBasedTable.create()

All variants of this method return a new table, so it can be
annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

Change-Id: I6aca62e89b0fba51fd2b0ad047ae4582b7807ecb
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68105
Reviewed-by: Hudson CI

Fix simple Javadoc warnings

Change-Id: I4e5189d3c9b788377aac398979260bc2c0907cc4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68102

os.analysis: Fix default thread state when syscall are not traced

The current behavior is to assign sys_clone to a new thread where the parent's
system call is unknown. When system calls are not traced, the sys_clone exit
event does not occurs, and therefore the thread stays in syscall state, which
is incorrect. In fact, a thread should not enter the system call state when no
syscalls are traced.

For this reason, this patch does not speculate about the state of the
parent, and the child inherit whatever value is set for the parent.

Change-Id: Ic4a3ea8cab7d487a8effe3df282e134292ff8ec1
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68076
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Move icon and label text into ITmfProjectModelElement

A series of "else if (instance of ...)" checks is usually better
served by good ol' polymorphism. Move the class-aware logic present
in TmfNavigatorLabelProvider into each class and add corresponding
methods in the interface.

This aligns with the recently-added getStyler() method, which is
defined in the element classes and simply called by the label provider.

Also move everything icon-reading-related to a new class, so that
there is no circular dependencies between TmfNavigatorLabelProvider
and the project element classes.

Change-Id: I0d78dd5342b13272a42b11e7ca0619225e1beed5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67694
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ss: Add common unit tests for state history backends

Change-Id: I21b08b85dfbe14f5ff99c5459a4cb10006fbb483
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64391
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Set ITmfTraceWithPreDefinedEvents to @NonNull

Somehow the @NonNullByDefault did not account for the generic type in <> so
there were still warnings generated for this method.

Change-Id: I3dcce938001311462c8833c3f61b15511b305dc0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68012
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ss: Bug 484776: Incorrect end time in HistoryTree

The ThreadedHistoryTreeBackend now keeps track of its own end time that
includes the end time of any interval that is in the interval queue.
This ensures that the history tree is closed with the correct end time.

The HistoryTree no longer updates its end time when initializing new
empty nodes. This ensures that the end time is never greater than the
real end time.

Change-Id: I8ff41d14f54ec1a33b8e22e81a21871f0cbf7ea0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64015
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: add per-cpu cpu usage to analysis

Query with a set of desired cpus, or an empty set for everything.
This allows the analyses to filter on a per-cpu basis. The cpu
analysis now can be queried as follows:

This example has 4 cpus named, 0 to 3

module.getCpuUsageInRange( {}, tStart, tEnd) will get all cpus.

module.getCpuUsageInRange( {0,1,2,3}, tStart, tEnd) returns the same.

module.getCpuUsageInRange( {0}, tStart, tEnd) will return a subset
of the previous queries, affecting only CPU 0.

Note that this affects the totals too, the total is calculated on the fly.

Change-Id: Ie6a606763f4331aeef06b2916a7f98d9c73fc9d5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65418
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

analysis.os: introduce cpu and thread signals

Change-Id: I480c034098f00dc1a6108945458e08911634ac14
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65594
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.os: Make the CPU usage state provider use the increment method

Change-Id: If6fed23d4656a7cb233f002e1321ea4d7ac5852f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66945
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

releng: Update to test-traces 1.3.0

Includes a new LTTng kernel trace with many threads.

Change-Id: Ic99610771b863d7faadc142f192e7c92844754b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67844
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: introduce ISegmentStoreProvider

This is an interface extraction from AbstractSegmentStoreAnalysisModule
that reduces the coupling. Now analyses no longer need to be dependent
on events and event requests to generate segments. This open the door
for segments being generated from other sources, such as, but not
limited
to:

* State systems
* Other segment stores
* Environment variables
* Aspects
* Concepts
* Flat data files.
* ...

Change-Id: If95f97d6d98752414747d262c542200f807539ab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65597
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

linux.ui: Add CPU entries under Resources View aggregated IRQ entries

This adds CPU entries under the root IRQ entries in the resource view.

They look like this at the moment.

SOFT_IRQ 1 Timer: ------------[rrrrrrr|xx|xxxxx|xx]
......CPU 0     : -------------[rrrrrrrrr|xxxxx]
......CPU 1     : ------------[rrrrrrr|xx]
......CPU 2     : ---------------------[rrrrrrr|xx]

This implements the solution suggested in bug 381497

Change-Id: Ie0c9e9e505d4fb66a39579a0891620373e4d1e00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67453
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

ss: Add utility method to increment an attribute by a value

This new utility method is useful for analysis who need to increment
values of an attribute by a value that is not 1.

This can replace ITmfStateSystemBuilder#incrementAttribute().

Change-Id: I19037dda4c417d44e8f0aacc017545f921d18ff6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66944
Reviewed-by: Hudson CI

lttng: Help stabilize some TimeGraphs tests

When opening the filter dialog for the Control Flow view, it is possible
that view is not populated yet. When this is the case, the controls in
the dialog are disabled.

To fix this, the test now waits until the "timegraphview is ready".
But it was not sufficient to simply call the existing condition. The
isDirty method of AbstractTimeGraphView does not cover the case where
the view is completely empty and nothing has been scheduled to be drawn
yet (Zoom Thread).

To help with this, the isDirty method was improved to cover more cases.
The time range of the time graph control has to match the window time,
which covers the case that the zoom thread has not started but the view
is about to update itself. There was also a race between the time that
the time range is set on the time graph control and the time that the
zoom thread is created; this was addressed by using the dirty counter to
guard this section.

As a future improvement, the filter dialog could be augmented to handle
the Control Flow view being updated while the dialog is up. This is
beyond the scope of stabilizing the test.

To reproduce this failure before the patch, insert a Thread.sleep(5000)
in ControlFlowView.buildEventList, in the while loop. This will delay
the entry list being built, which will increase the duration of the view
being completely empty and not considered dirty yet.

Change-Id: I94038436608f6e1b384b0f90a43bddd08d3651c6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66785
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Revert "Revert "ctf: Fix slow test due to expected timeout""

This reverts commit 1ae81c23b427deeec3266e4755e9122ddcd0cf81.

This almost worked before but it needed to use withMnemonic not
withLabel!

Original message:
The test was looking for a possible checkbox (in 4.6) but when it it was
not there (4.5) it had to wait 50 secs for it to time out. Instead we
can set a very short timeout because it will instantly either be there
or not.

Change-Id: I84f6db70a323611b1adb93c6d9b55801bbeb7444
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67782
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: fix timestamp normalization clamping

This patch fixes a behavior issue with timestamps. Offsetting and
normalizing timestamps no longer overflows, nor does it throw
arithmetic exceptions.

This is done by using a saturated add and mult method from TmfTimestamp.
The saturated math should have a negligeable impact on performance.

Change-Id: I8f6fc7fc930586897923bb8510574ec4c4c668b3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67501
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc : Remove documentation for 'Import XML analysis'

Change-Id: I72cdfdd7e8219d3cc8bed530685d10ac9a2a0efe
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67566
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc : Add documentation for XML analyses manager

Change-Id: Ie3a603e813ebd94023d4d93fd6a210b96d5af47e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67565
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

linux: introduce execution contexts in resources view

The original implementation made sense only one single core systems. An
IRQ and softirq would block the whole system and not just a single core.

This patch adds the notion of execution contexts to the interrupts. The
interrupts are moved under the CPU to show the true execution stack.
Then the model is a much truer representation of the kernel.

In order to maintain aggregate information in the resources view (total
IRQs and such), the notion of AggregateEntries and AggregateIterators
are introduced.

This allows better understanding of the current state of the system as
the resources view now shows what the state of each processor is.

Expect a _SLIGHT_ performance degradation during the building of the
state system as an additional lookup is required for each interrupt
event.

This updates the state system model so the testvalues are updated and
the generator is updated to work again.

Starts to fix bugs: bug 381497 and bug 481855

Change-Id: I2f0f2093344f51caaf08500181cf90400a081f7c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65609
Reviewed-by: Hudson CI

Force check remote updates when checking for new plugin versions

Without the -U option, the plugin versions could be cached from a
while ago. This partly explains why the Hudson build would not
display the new updates. (Also the proxy settings had to be fixed)

Change-Id: Ib17d14d058b5d8f1894c61448fd3192972630291
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67721
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

statesystem : Add a default compareTo() for segments

Implements a default compareTo() in ISegment. The comparison will be
based on the start and the end of the segment. Subclasses could extend
this default behaviour if needed.
Also, the interface become Comparable<@NonNull ISegment>.

Change-Id: Ib58e0ba80c0151d127254c8b87eafec57e624566
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67620
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

rcptt: Update README.md file

Change-Id: If671d62e5dbbb3288e3fa0aa972995dfd88cf9eb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67703
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>