git.efficios.com Git - deliverable/tracecompass.git/log

releng: Targets updates for Mars.2 and 4.6M6

- Update 4.5 target with final Mars.2 update sites, use
non-composite where possible as they should not change (speeds up
dependency resolution)
- Update staging (4.6) target to not use the simrel update site, as
per recommendation by simrel team. Update update sites to latest
miletones; this required to fix the product dependencies. Luckily
those work with the 4.5 target too.

Change-Id: I39db87c315e7ee94a33c8b6c99b45ab86c81b1ad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68843
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

releng: Update outdated maven plugins

Change-Id: I1fc1f569bfc0a124f76fcdd5703e26be1d9a1295
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68828
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

os.linux: Rename the "kernelanalysis" package to just "kernel"

Long due change that was previously withheld to not break the API.
This aligns the naming with the other internal packages, which
were already renamed.

Change-Id: I9a0b3354e7018fa67f5baf7eb8a8522e1553f881
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68559
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Add missing package exports

Change-Id: I145fbf655c015a9ca46ee1d4e2c963f5a734deeb
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68558
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Update user guide for collapsible event table header bar

Change-Id: I45dfb1828398728bc85cdb0befa2bdf51b4b14db
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68496
Reviewed-by: Hudson CI

tmf: Fix Select Next/Previous Marker navigation

Because the markers are sorted by time, when navigating to the next or
previous marker, the marker start time should always be visible.

The action should not rely on the 'ensureVisible' implementation of the
method setSelectionRangeNotify(), as this method will ensure that the
end time of the selection will be made visible when the start time has
not changed. This causes problems if there are two markers with the same
start time but the end time of the second is out of visible range. Since
the window range is modified, the resulting marker list may no longer
include the marker that should have been next in the navigation order.

Change-Id: I434d454d7411f8a00bf58406ad7acc3128472de7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67643
Reviewed-by: Hudson CI

tmf: Support horizontal scroll with mouse wheel in time graph

Horizontal scroll can now be performed using Shift+MouseWheel while over
the time graph control state area.

MouseWheel over the time scale, marker axis and horizontal scroll bar
will now perform horizontal scroll, while Ctrl+MouseWheel over those
same controls will now perform horizontal zoom.

Table of MouseWheel actions:

modifier:      None       Shift      Ctrl     Shift+Ctrl
time scale     hScroll    hScroll    hZoom    hZoom
time graph     vScroll    hScroll    hZoom    vZoom
marker axis    hScroll    hScroll    hZoom    hZoom
h.scrollbar    hScroll    hScroll    hZoom    hZoom
v.scrollbar    vScroll    vScroll    vScroll  vScroll
outside (Win)  vScroll    vScroll    vScroll  vScroll

Change-Id: I0e48dd37b121b934ef872509aa721506876ca199
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68464
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add collapsible event table header bar with applied filter labels

- The manual toggling of the event table header mode (search/filter) is
removed.

- When a search filter is applied, the header row icon is changed to a
"Add as Filter" icon. Tool tip support is added for this icon. Clicking
the icon will apply the search as a filter, and clear the search filter.

- Ctrl+Enter shortcut can be used to trigger the 'Add as Filter' action.
It can also be used instead of Enter while in a header cell 'search'
text editor to apply the regex immediately as a filter instead of as a
search filter.

- The 'Show Filter Bar' and 'Show Search Bar' actions in the header row
context menu are removed, and are replaced with the 'Add as Filter'
action when there is a search filter applied.

- If search filters are currently applied on multiple columns, they will
each be applied as separate filters.

- The 'Apply Preset Filter...' and 'Collapse Events' actions now add a
filter to the currently applied filters instead of replacing them.

- Implement TmfFilterObjectNode so that any external filter object can
be included in the filter tree model.

- The collapse filter is handled separately from other filters. It must
be invoked only on events which first match every other applied filter.
This allows for filtered events to be collapsed even if they are not
contiguous as unfiltered events.

- Implement TmfCollapseFilter.toString().

- Implement TmfEventsTableHeader. This is a header bar composite
displayed above the event table when any filter is applied.

- The header bar has one label for every filter that is currently
applied. The label name describes the filter. If the filter was created
from the table search/filter row, then clicking the label will set the
table highlighting to this label's regex (if no search filter is
currently applied).

- Clicking the 'remove' icon on any label will remove this particular
filter. If no filter remains, the header bar will be hidden.

- Pressing the Delete key will clear all filter highlighting (if no
search filter is currently applied).

- When the header bar is visible, clicking its background or collapse
icon will toggle its collapsed/expanded state to save space. Each filter
label name will be set as a tool tip for the smaller label.

- A NullPointerException is fixed when cancelling a search before its
event request has been created.

Change-Id: I40cc3e3389f1ce43145e2a6025ed1c2a99d029e8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67928
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Move the HistoryTreeTest class to a new package

The o.e.t.s.c.t.backend package only contains classes for backend tests

Change-Id: I838b242102a1d5fc2ea3ce5271499cba191fa455
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68095
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

tmf : Add latency density view for the pattern analysis

Change-Id: Iedc781b8d8d5ae6a22eb699270e540f4826be38b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67840
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add latency scatter graph view for the pattern analysis

Change-Id: I44ccdf56c3b769e2f0d74dc26e7fe2f1eab568ea
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67839
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add latency table view for the pattern analysis

Change-Id: I3e652767dc8e53dc2eb95c27e159f8350e939eaf
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67478
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

doc: Update user guide for time graph marker axis

Change-Id: Ic3ca210994cf1d690f566d0703fc51e57e55371f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68465
Reviewed-by: Hudson CI

tmf : Introduce the modules for the XML pattern analysis

This patch introduces the XmlPatternAnalysis and its sub-modules

Change-Id: If27ed6816316752c405f14a31b9b91dcfad877c7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65750
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

os.linux: make SoftIrqs support being raised while executing.

In order to do this, statevalues are now bitmasks. Many more checks
at SoftIrq Raise, Entry and Exit handlers now take into account if
there are other SoftIrqs running and will retain their state.

Fixes part 2 of bug 381497

Change-Id: I2f109d1e4e3a227c10dcdf8f54df7b42c7776d4a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66259
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis : Introduce ISegmentListener

This patch add a listener for segments creation

Change-Id: I1da2cf3f6f91599ef4fc1a92f05306e90db0dc03
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67195
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

ctf: Increase ReadAllTraces test timeout to 1 minute

This test often times out on Hudson, we can increase it
to a more permissive amount.

Change-Id: Ib0c09bc157803b1b19ff213af2a804ee32458247
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68595
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis : Introduce buildAnalysisSegments() in Segment Store analysis

This abstract method helps the analysis decide how the segment store
will be built.

For instance, the segment store could be built using a request or using
segments generated by a prerequisite analysis.

Change-Id: I68c6b5d35ff71d8c06c5b4881bcbce25404b5581
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64592
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Fix ust memory analysis help text display

When the analysis cannot be executed due to missing requirements, the
user can request the help text to get the reason why. However, this
was not working and caused an exception because the requirements are
only instantiated when the trace is open.

Change-Id: I43ca26b964467711bea10bf7ed52eba2988e3fd9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68236
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Introduce a default lttng ust event layout

Change-Id: Ibd7d1813b920b08f7a003850247ab088cd9276fc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68234
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add the ID to the analysis property

This property is useful when developing data-driven views for existing
analyses.

Change-Id: I72fc0287c719326fe3a4de73cccafbfcffc490e9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67823
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

common: Add annotations to HashMultimap#create methods

The returned HashMultimap is always @NonNull.

Change-Id: Ic6be32944771b175101c202d0d16780ba3372d0d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68360
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: make Critical path listen to thread selected signal instead of selection listener

This patch greatly simplifies the critical path parameter provider.
Now it will listen to a TmfThreadSelectedSignal instead of listenning to an
action on the control flow view. This will decouple the critical path from the
control flow view, instead allowing anything generating the signal the opportunity
to run a critical path analysis on a given thread and trace.

Change-Id: Ifb7f1fe2d5f81a8127ceab93b262cc9c0bbdd0e5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68099
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

linux.ui: Add context menu to Control Flow View to follow a thread

The command to follow a thread generates a TmfThreadSelectedSignal. To
see the context menu, one must right click on a thread entry in the control
flow view. More follow action locations can be:

* the events table
* the resources view, on an event
* the filters view
* the critical flow view

Change-Id: Ib74eb67f98c514f29fde689c47c2cb42c90868db
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66665
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.core: Add cpu and thread to trace context

This patch allows to see what the last selected cpu and thread were
for a given trace. The cpu and thread are stores in a LinuxTraceContext.

To do this, a default method is introduced to ITmfTrace (createTraceContext).
This method is overridden by IKernelTrace to make LinuxTraceContext instead of
the regular TmfTraceContexts. The LinuxTrace Context has the CPU and Thread ID
information. An important thing to note is that if two kernel traces have the same
hostID they both get the signal. This is by design.

Change-Id: I25f044ec05fbd69acf93009861b464506327d616
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66667
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

ss: Add benchmarks for the threaded history tree

This adds a new benchmark for the threaded history tree backend. It benchmarks
the insertion of intervals in the state system, single, full queries and
history range queries.

Change-Id: I4ac8eea4a6979c4f70b6d584b26ad3fc92ae4900
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66891
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Remove unneeded checkNotNull() calls

With the introduction of Java 8 type annotations and external
@NonNull annotations, some of our checkNotNull() checks are no
longer needed, we can simply remove them.

Change-Id: I00b39d7428e042ae2d93b15d37dda5cbd50f52c2
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68101
Reviewed-by: Hudson CI

tmf: Add unit tests for PeriodicMarkerEventSource

Change-Id: I38e8fb35f6a9f27c75a69e641819feb8c097a176
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68254
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 488806: Mouse scroll with count of zero not handled correctly

Change-Id: I11e9b5261b687b0095e29e2f7cb35a3507a18591
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67639
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: update user guide for importing traces as experiment from control

Change-Id: I8040ae89b4c1d5c9b5119ec316518386f26ed707
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67995
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Fix intermittent MemoryUsageViewTest failure

It is possible that a thread gets added to the memory usage chart
before the process name is determined. Once the process name is
determined, a new series is added to the chart but the old one is not
deleted. Not only this fails the test because the chart contains too
many series, but it shows the wrong information to the user.

To reproduce the issue, you can add a Thread.sleep(5000) in
UstMemoryStateProvider around line 222, before the process name gets
added to the state system.

Change-Id: I95631758e0fdffbc094a3adb923b7019841a4a60
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68312
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: update user guide for importing traces as experiment

Change-Id: Ie3efa0d4c2cf73fc4ef9b8cf07933af95eabf430
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67994
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Use a symbol provider to locate symbols

Contributed symbol provider extension point.
Contributed BasicSymbolProvider to symbol provider extension point.
Switched CallStackView to symbol provider.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=487978
Change-Id: Ic40c272c2dbc0074fc170e9ff0d2ee0e9f230559
Signed-off-by: Robert Kiss <robert.kiss@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67442
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf.ui: RemoteFetchLogWizardRemotePage replace size()>0 with !isEmpty()

Change-Id: Ic689934ff852f2464cd98a710697ffee75d096d6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68247
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

control: Add SwtBot tests for importing as experiment

The following test cases are added:
- import without experiment
- create experiment when importing a kernel trace
- create experiment during import with experiment name validation

Utility methods are added to SwtBotUtils to create an experiment and
to clear the experiment folder.

Change-Id: I68f7a1e350a87cb98b40389f0f4d2b7bf2f741d5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68163
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: Import as experiment only when checkbox is enabled

Change-Id: I31d6e0008017a86e9ef8d47861e3083330130a2d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68162
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SwtBot tests for importing as experiment

The following test cases are added:
- create experiment when importing from directory
- create experiment when importing from archive
- create experiment during import with experiment name validation

Utility methods are added to SwtBotUtils to create an experiment and
to clear the experiment folder.

Change-Id: I3fc5f83efc811f267cfc31a48c603915c9d74646
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68083
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

common: Annotate Pattern.compile()

Both variants of this method return a new Pattern object, so it
can be annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

Change-Id: Ia6b862f56b1ebc65fe1bdc1b2dcf6875e3afd36e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68107
Reviewed-by: Hudson CI

common: Annotate TreeMultimap.create()

All variants of this method return a new map, so it can be
annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

While at it, rewrote some comparator definitions in more succinct
lambda expressions.

Change-Id: Ic7a78eb38b9cf3fd2b8e79ab385d73c5d4cc2961
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68106
Reviewed-by: Hudson CI

common: Annotate HashBasedTable.create()

All variants of this method return a new table, so it can be
annotated @NonNull.

Remove now-unnecessary checkNotNull() checks where this was called.

Change-Id: I6aca62e89b0fba51fd2b0ad047ae4582b7807ecb
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68105
Reviewed-by: Hudson CI

Fix simple Javadoc warnings

Change-Id: I4e5189d3c9b788377aac398979260bc2c0907cc4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/68102

os.analysis: Fix default thread state when syscall are not traced

The current behavior is to assign sys_clone to a new thread where the parent's
system call is unknown. When system calls are not traced, the sys_clone exit
event does not occurs, and therefore the thread stays in syscall state, which
is incorrect. In fact, a thread should not enter the system call state when no
syscalls are traced.

For this reason, this patch does not speculate about the state of the
parent, and the child inherit whatever value is set for the parent.

Change-Id: Ic4a3ea8cab7d487a8effe3df282e134292ff8ec1
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68076
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Move icon and label text into ITmfProjectModelElement

A series of "else if (instance of ...)" checks is usually better
served by good ol' polymorphism. Move the class-aware logic present
in TmfNavigatorLabelProvider into each class and add corresponding
methods in the interface.

This aligns with the recently-added getStyler() method, which is
defined in the element classes and simply called by the label provider.

Also move everything icon-reading-related to a new class, so that
there is no circular dependencies between TmfNavigatorLabelProvider
and the project element classes.

Change-Id: I0d78dd5342b13272a42b11e7ca0619225e1beed5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67694
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ss: Add common unit tests for state history backends

Change-Id: I21b08b85dfbe14f5ff99c5459a4cb10006fbb483
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64391
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: Set ITmfTraceWithPreDefinedEvents to @NonNull

Somehow the @NonNullByDefault did not account for the generic type in <> so
there were still warnings generated for this method.

Change-Id: I3dcce938001311462c8833c3f61b15511b305dc0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/68012
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ss: Bug 484776: Incorrect end time in HistoryTree

The ThreadedHistoryTreeBackend now keeps track of its own end time that
includes the end time of any interval that is in the interval queue.
This ensures that the history tree is closed with the correct end time.

The HistoryTree no longer updates its end time when initializing new
empty nodes. This ensures that the end time is never greater than the
real end time.

Change-Id: I8ff41d14f54ec1a33b8e22e81a21871f0cbf7ea0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64015
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: add per-cpu cpu usage to analysis

Query with a set of desired cpus, or an empty set for everything.
This allows the analyses to filter on a per-cpu basis. The cpu
analysis now can be queried as follows:

This example has 4 cpus named, 0 to 3

module.getCpuUsageInRange( {}, tStart, tEnd) will get all cpus.

module.getCpuUsageInRange( {0,1,2,3}, tStart, tEnd) returns the same.

module.getCpuUsageInRange( {0}, tStart, tEnd) will return a subset
of the previous queries, affecting only CPU 0.

Note that this affects the totals too, the total is calculated on the fly.

Change-Id: Ie6a606763f4331aeef06b2916a7f98d9c73fc9d5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65418
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

analysis.os: introduce cpu and thread signals

Change-Id: I480c034098f00dc1a6108945458e08911634ac14
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65594
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis.os: Make the CPU usage state provider use the increment method

Change-Id: If6fed23d4656a7cb233f002e1321ea4d7ac5852f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66945
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

releng: Update to test-traces 1.3.0

Includes a new LTTng kernel trace with many threads.

Change-Id: Ic99610771b863d7faadc142f192e7c92844754b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67844
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: introduce ISegmentStoreProvider

This is an interface extraction from AbstractSegmentStoreAnalysisModule
that reduces the coupling. Now analyses no longer need to be dependent
on events and event requests to generate segments. This open the door
for segments being generated from other sources, such as, but not
limited
to:

* State systems
* Other segment stores
* Environment variables
* Aspects
* Concepts
* Flat data files.
* ...

Change-Id: If95f97d6d98752414747d262c542200f807539ab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65597
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

linux.ui: Add CPU entries under Resources View aggregated IRQ entries

This adds CPU entries under the root IRQ entries in the resource view.

They look like this at the moment.

SOFT_IRQ 1 Timer: ------------[rrrrrrr|xx|xxxxx|xx]
......CPU 0     : -------------[rrrrrrrrr|xxxxx]
......CPU 1     : ------------[rrrrrrr|xx]
......CPU 2     : ---------------------[rrrrrrr|xx]

This implements the solution suggested in bug 381497

Change-Id: Ie0c9e9e505d4fb66a39579a0891620373e4d1e00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67453
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

ss: Add utility method to increment an attribute by a value

This new utility method is useful for analysis who need to increment
values of an attribute by a value that is not 1.

This can replace ITmfStateSystemBuilder#incrementAttribute().

Change-Id: I19037dda4c417d44e8f0aacc017545f921d18ff6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66944
Reviewed-by: Hudson CI

lttng: Help stabilize some TimeGraphs tests

When opening the filter dialog for the Control Flow view, it is possible
that view is not populated yet. When this is the case, the controls in
the dialog are disabled.

To fix this, the test now waits until the "timegraphview is ready".
But it was not sufficient to simply call the existing condition. The
isDirty method of AbstractTimeGraphView does not cover the case where
the view is completely empty and nothing has been scheduled to be drawn
yet (Zoom Thread).

To help with this, the isDirty method was improved to cover more cases.
The time range of the time graph control has to match the window time,
which covers the case that the zoom thread has not started but the view
is about to update itself. There was also a race between the time that
the time range is set on the time graph control and the time that the
zoom thread is created; this was addressed by using the dirty counter to
guard this section.

As a future improvement, the filter dialog could be augmented to handle
the Control Flow view being updated while the dialog is up. This is
beyond the scope of stabilizing the test.

To reproduce this failure before the patch, insert a Thread.sleep(5000)
in ControlFlowView.buildEventList, in the while loop. This will delay
the entry list being built, which will increase the duration of the view
being completely empty and not considered dirty yet.

Change-Id: I94038436608f6e1b384b0f90a43bddd08d3651c6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66785
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Revert "Revert "ctf: Fix slow test due to expected timeout""

This reverts commit 1ae81c23b427deeec3266e4755e9122ddcd0cf81.

This almost worked before but it needed to use withMnemonic not
withLabel!

Original message:
The test was looking for a possible checkbox (in 4.6) but when it it was
not there (4.5) it had to wait 50 secs for it to time out. Instead we
can set a very short timeout because it will instantly either be there
or not.

Change-Id: I84f6db70a323611b1adb93c6d9b55801bbeb7444
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67782
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: fix timestamp normalization clamping

This patch fixes a behavior issue with timestamps. Offsetting and
normalizing timestamps no longer overflows, nor does it throw
arithmetic exceptions.

This is done by using a saturated add and mult method from TmfTimestamp.
The saturated math should have a negligeable impact on performance.

Change-Id: I8f6fc7fc930586897923bb8510574ec4c4c668b3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67501
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc : Remove documentation for 'Import XML analysis'

Change-Id: I72cdfdd7e8219d3cc8bed530685d10ac9a2a0efe
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67566
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

doc : Add documentation for XML analyses manager

Change-Id: Ie3a603e813ebd94023d4d93fd6a210b96d5af47e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67565
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

linux: introduce execution contexts in resources view

The original implementation made sense only one single core systems. An
IRQ and softirq would block the whole system and not just a single core.

This patch adds the notion of execution contexts to the interrupts. The
interrupts are moved under the CPU to show the true execution stack.
Then the model is a much truer representation of the kernel.

In order to maintain aggregate information in the resources view (total
IRQs and such), the notion of AggregateEntries and AggregateIterators
are introduced.

This allows better understanding of the current state of the system as
the resources view now shows what the state of each processor is.

Expect a _SLIGHT_ performance degradation during the building of the
state system as an additional lookup is required for each interrupt
event.

This updates the state system model so the testvalues are updated and
the generator is updated to work again.

Starts to fix bugs: bug 381497 and bug 481855

Change-Id: I2f0f2093344f51caaf08500181cf90400a081f7c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/65609
Reviewed-by: Hudson CI

Force check remote updates when checking for new plugin versions

Without the -U option, the plugin versions could be cached from a
while ago. This partly explains why the Hudson build would not
display the new updates. (Also the proxy settings had to be fixed)

Change-Id: Ib17d14d058b5d8f1894c61448fd3192972630291
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67721
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

statesystem : Add a default compareTo() for segments

Implements a default compareTo() in ISegment. The comparison will be
based on the start and the end of the segment. Subclasses could extend
this default behaviour if needed.
Also, the interface become Comparable<@NonNull ISegment>.

Change-Id: Ib58e0ba80c0151d127254c8b87eafec57e624566
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67620
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

rcptt: Update README.md file

Change-Id: If671d62e5dbbb3288e3fa0aa972995dfd88cf9eb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67703
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

releng: Update README.md for Maven 3.3

Change-Id: I7e8f4e576f002204fa917b08a7ceb99651ee7e74
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67705
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

os.tests: introduce test cases for the kernel analysis module

It changes the current tests to use this notion of test case that will be used
to add unit tests for kernel analysis.

Change-Id: I1ccf0c68c48507a0948b29100058f0091e1a758b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67628
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

os.tests: Move aspects to the kernel trace stub

Change-Id: If23a66bb009b6d556c7db7eaa80412a9a5c577f1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67626
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

os.tests: Add a kernel stub trace class and use that in unit tests

This allows to define an event layout for unit tests instead of taking the
default one, which might not permit to test everything.

This is a first step to do exhaustive unit testing of the kernel analysis

Change-Id: I6ecd85c959bf2e4c4c853deda94a0277a1e4610d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/67623
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

analysis : Rename getResults() to getSegmentStore()

This patch rename getResults to getSegmentStore() in
AbstractSegmentStoreAnalysisModule

Change-Id: I92a0b3a8149db8001c21cbd4e181ba1d37e5e3c2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67193
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Move initialization steps of modules into analysisReady() method

This method will set the module available and set whether the
initialization succeeded or not.

Change-Id: I6988bfdced259f6b92d318edd09652e3d72e8a5d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67286
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Make waitForInitialization() return a boolean

waitForInitialization() should return a boolean that will indicate
wether the initialization went well or not. If true, there should be
state systems available.

Change-Id: Id9d053322ff86c93dedb8c0897924fa31720ebfe
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67285
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : add waitForInitialization() to ITmfAnalysisModuleWithStateSystem

Change-Id: Id6fc4792446dbec8e9cabe43ff743a596d23f1c0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65749
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Clean up tmf.ui.project.model

Cleanup the ITmfProjectModelElement hierarchy:

* Make all fields in the abstract class private, replace accesses with
  the getter methods.
  This also has the advantage of giving us the right type, for elements
  that override for example the getResource() return type.

* Make refreshChildren() abstract, the great majority of the
  implementations should handle it. It's easy to "forget" to override
  a method, while you can't forget an abstract method.

* Remove addChild() and removeChild() from the interface. Ideally
  these should be only called by the owners themselves.

* The "parent.addChild(this)" pattern is quite bad. It muddles the
  ownership, and calls "this" in a constructor, which is bad practice.
  Have the parents add the child to themselves after they create it.

* Implement hasChildren() as a default interface method.

* Have getChildren() return an ImmutableList copy of the original
  list. Callers shouldn't be modifying it!

Change-Id: Ie2e8129bef447ecbdce9add0e8cf9bd28ba36783
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67387
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.all: use ITmfTimestamp#toNanos when possible

The new helper replaces a longer line of

timestamp.normalize(0, ITmfTimestamp.NANO_SCALE).getValue()
with
timestamp.toNanos();

It also can run faster as it has a quick exit on a match of
scales, this saves an object allocation.

Change-Id: Ic3c307944082aef38be4525e4c2d3547237b6d88
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67091
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

linux: make KernelStateProvider handle aggregate prev_states of sched_switch

Use an if statement instead of a switch to check individual bits in the
prev_state bitmask.

fixes bug 486515

An example would be any state of EXIT_TRACE where it is two bits,
EXIT_ZOMBIE and EXIT_DEAD that are active. In the previous implementation
the state would be UNKNOWN, but now it would correctly show DEAD (null).

Change-Id: Ia9372e4d196e3a87a1e902753803a87ecafb3b33
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65139
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>

control: support creating of experiments when importing a trace session

The remote import wizard that is used to import LTTng session has been
updated to to create an experiment using all successfully imported
traces. Unrecognized traces won't be added to the experiment.
Traces that are skipped during the import (name conflict) are not
added to the experiment.

The name of the experiment is by default session root directory or
session name if the session doesn't use the default session path.
The user has the possibility to change the experiment name.

Change-Id: I6a6013511237ceb308fe25bdc42ec342a13ab72d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67178
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Create experiment when importing traces import trace wizard

Using the standard import wizard it's now possible to create an
experiment using all successfully imported traces. Unrecognized
traces won't be added to the experiment. Traces that are skipped
during the import (name conflict) are not added to the experiment.

The name of the experiment is by default the root folder when importing
from a directory. Or the archive name when importing from archive.
The user has the possibility to change the experiment name.

The option to create an experiment is persisted so that the checkbox
is selected/deselect when reopening the import wizard.

Change-Id: I06b15419ebd90983865c770d7a771bc5d190cc39
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67168
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common.core: Annotate Status#OK_STATUS and Status#CANCEL_STATUS

The two statuses are assigned to a new value and are final.
This should help remove some checkNotNulls.

Change-Id: Ia42832140b0d5bc33f8eea2b66121e9182e587cd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67341
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.core: Introduce ITmfTimestamp#toNanos

This method can be used to quickly convert an ITmfTimestamp to a
long using nanoseconds. This should reduce code re-use but also
accelerate the fast path as it saves object creation and avoid
errors in copy pasted code chunks.

Change-Id: I402c419fe2d579cf5e7e07b258665adbf8af8f8b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67090
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Allow null messages in Activator logging helpers

A very common message is e.getMessage(), which is not technically
guaranteed to be non-null, it would depend on the exception.

Allow the log messages to be null, we can convert them to empty
strings as needed.

Change-Id: I34695fd96368837547e8f74841668cb0b5c0c9a8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67183
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: extract operation for creating an experiment

This operation can be reused later on.

Change-Id: Ife31591f94656195837e4b788b0b99d16ac77ebf
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67167
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: extract SelectTracesOperation from SelectTracesWizardPage

This is done so that it can be reused later on.

Change-Id: I14118e459827bb8f37fb96aa54090ff08295a23d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67166
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Fix null annotation error on Eclipse 4.5.x

getAnalysisModuleOfClass returns a Nullable module, this nullable should
be kept all the way to the Optional returned by findFirst. In 4.5.x,
this works correctly and the result of findFirst cannot be assigned to
an Optional<@NonNull>, hence the error. In 4.6, the @Nullable is lost
along the way and the result of findFirst can be assigned without error
to an Optional<@NonNull>.

Change-Id: If544f9372e2132f5796074f197a7ae01679fe1da
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67355
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Annotate Guava's ImmutableMultimap.of()

All variants of the .of() method return a new multimap, so they
are necessarily @NonNull.

The parameters can also be marked @NonNull, because the map
doesn't support null keys or values, just like ImmutableMap.

Change-Id: I959449e609fe44b6571cca861ee40168583eb4f6
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67182
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Annotate (Guava) Ordering.compound()

Ordering.compound() creates a new CompoundOrdering, so if it
does return it will return a @NonNull value.

Change-Id: I39579bc4dc3373f882c769e7ae7ad6f89f1054c7
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67188
Reviewed-by: Hudson CI

analysis.timing: Add missing @Nullable annotations

The updateTableModel() method supports null parameters, we just need
to add missing @Nullable annotations to fix a compilation warning.

Also annotate CompletableFuture.supplyAsync() methods, they return
a new CompletableFuture, so its return can be @NonNull.

Change-Id: Ieef346b03d0e676c19c4f8cea3568870fc852e37
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67187
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: fix regression in trace type detection

Patch 281def4 moved the trace type detection to tmf.core. With this
change the traces that validate with confidence 0 for more than one
trace type will have a trace type set that is first in the list.
Before previous patch the trace type was not set if the confidence
was 0.

Change-Id: I2fb3dbd933ae673ce54569356f190c19a7d72d49
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67346
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Register CallStackView contextMenu

Register the CallStackView/TreeViewer/contextMenu to allow contribution
to it from extension points.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=488120
Change-Id: I65fddedf968bd1a9c621e588dc77426ace67f485
Signed-off-by: Robert Kiss <robert.kiss@gmail.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/67032
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: use a null backend for the kernel analysis benchmark

This adds a benchmark that does not save the state system to disk. It
allows to benchmark only the analysis (and the reading of the events).

Change-Id: I271064111a4c55cf3010c66b3c9c6998d2444a27
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66853
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

common: Annotate some methods in Guava Iterators

The various versions of the following methods:

Iterators.cycle()
Iterators.concat()

always return a new iterator, and as such can be marked @NonNull.

Change-Id: I4e766ebbe5035d5dac6d59218c1a29b626e54ea5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67181
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Annotate Integer.toString()

All variants of Integer.toString() return a new, real String.
It can be marked @NonNull.

Change-Id: I15633360b831087f7216d00588fec09f0dfcfdd0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/66209
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make timechart select the right time range when being opened

The timechart now shows the window range if opened after a trace is opened

Change-Id: I743303ca674d5a51e1cc6f7719657a43320422c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46287
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Bug 488042: TmfStatisticsModule returns null in @NonNull interface

Change-Id: I65f1d5fb0176b57182abdd01a4e7f3e533097812
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66850
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

ss: Fix typo in package name

Change-Id: If3db5852ec370597613b6d4825e0ce95e9f82fbd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67100
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

common: Annotate Optional.get() as @NonNull

Optional.get() throws an exception if the value is null, so if the
method returns the value is necessarily @NonNull.

Change-Id: I25cea786763b567b8f7cafcb5a4119f0d359a48b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/67099
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: move trace type detection utility to tmf.core

and have the UI utility call this method. But doing this the trace
type detection can be run independently from the UI.

Change-Id: I6ec3043791647773a7768f4117f1dcdef2211e32
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/66530
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

statesystem: Fix a condition to get the average node usage

Change-Id: Ib52dac782e49a17c13e5105043d09feec93ce228
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/66947
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Add collapse, expand and hide category buttons on marker axis

Change-Id: If5b6552e8dd350ee0b1655643c8fa5153244ede6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66777
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Preserve order of marker categories

Some marker event sources can have a logical order to the list of marker
categories they return in IMarkerEventSource.getMarkerCategories(). This
order should be preserved, so the categories should not be sorted
alphabetically.

Change-Id: I0423b391271fdd0803aba6bd357d7482938aad4b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66541
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add time graph marker axis for marker labels

The marker labels are moved from the time graph scale to this bottom
axis.

There is one row of markers per marker category. Only the visible
categories with at least one computed marker are shown.

Clicking on a marker label sets the time selection to its time or range.

Mouse wheel over the marker axis can be used to zoom horizontally.

Change-Id: I7caf8168abd27fa9dac9e4729a4c1303775a81e6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/66355
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>