tmf: Annotate methods in ITmfEventField

Some methods in ITmfEventField can be annotated @NonNull to make
their usage easier.

getValue() and getField() should eventually be marked @Nullable,
but this will be a much larger undertaking, as most analysis
modules currently just get fields and values without even
checking them...

Change-Id: I564c6d067a62239cde5c67350ea709315bfe89f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51212
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix flaky ImportAndReadSmokeTest test

In this test, it was possible for SWTBotUtils.openEditor to timeout
because it would not find the right Tree and it would wait for a
TreeItem forever. Instead, we can use the SWTBot from the view to narrow
down where the Tree is searched and it returns the right one. I saw this
test being flaky on Windows.

Change-Id: I44e98b6e88d795fd8b0d38b75ad0506e849af4b5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51535
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix StandardImportGzipTraceTest failing when running from RunAllSWTBotTests

StandardImportGzipTraceTest should delete its test project. Otherwise, other
tests using the same project name "Tracing" will fail to run. Also fix path
in TmfTestTrace for the test to work.

Change-Id: I908e9aaded2b47762ee07b36384257545d680300
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51534
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bring back the API filter for UnsortedPropertySheetPage

PropertySheetPage is marked @noextend, but arguably should not be.
See bug 109617.

I'm pretty sure we had such filter at some point, but it seems to
have been lost, and I could not find any references to it in the
git tree.

Change-Id: If373e480267fd311992a94965635d57ea5100e5c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51532
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

pcap: Fix pcap tests skipped when running from RunAllCoreTests

Change-Id: Ic28140a87d6417081d345640d9f2fe9ddc5b6c8c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51526
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Add a timeout to ExperimentSyncTest

Under certain configurations, the testDjangoExperimentSync() can
deadlock and throw "GC overhead limit exceeded" errors. Add a
timeout to this test suite to catch this problem.

Change-Id: Ib90b16c680158aa0ad896e9fca4ed23efd09f726
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51518
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Increase RCP version number to 2.0

Change-Id: I8b6f2125cdfa0c3acd5114297b07b7cb703f8ad9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51132
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix FunctionNameMapperTest failing when running from RunAllCoreTests

Change-Id: I2270bd713c89c895c153ba96f482eea8bb49e755
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51449
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Fix SessionConfigGeneratorTest failing when running from RunAllCoreTests

Change-Id: Iae9ca0699e83149fe9952bd3b550e38649fcd5e4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51448
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: bug 471966: Fix file handle leak in CTF

If something goes wrong in the CTFStreamInputReader constructor or one
of its calls, the file handles in this class are not closed. This is
because the object is not fully constructed yet therefore the caller of
the constructor cannot close it.

Change-Id: Ie03164888711dd49d7b30ce5d774b4e4cdef9228
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51426
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Make custom trace output column name @NonNull

Change-Id: Ibe9600a9b80833a860c361320d5d755d148e2711
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/51302
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: support devices that are stored as enumerations Bug 471685

Enums are actually more precise than ints, so let's keep that data.
A side effect is that this will support floating point devices, but
the information will be cropped to an integer level.

Change-Id: I61c1d98ed63bd18ff1d64ffea5b1f7a9da9c8d7a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51306
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix parent version number for alltests

Change-Id: I6a6d60c625ddcd2366fdaa5e37a451ec8e7e011e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51417
Reviewed-by: Hudson CI

tmf: Fix TmfEventsTable leaked

Every time a trace was opened and closed, a TmfEventsTable is leaked (along
with others). Because its context menus are not disposed, the Display keeps a
reference to the menus which hold a reference to the table through menu
listeners.

Change-Id: I7e4bb1497282d33edb0844c85796e6e6ad145e0b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51359
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix context resource leak in raw event viewer

Change-Id: I20dfb3f921d260771efee4b69abaa8d90ec9c44f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49466
Reviewed-by: Hudson CI

tmf: Add support for blending sub-pixel events in time graph

This allows for many short time events mapping to the same pixel to be
blended in together instead of drawing only the first one and discarding
the remaining. This functionality is optional and off by default.

The Time Chart view is updated to use this scheme to allow the
highlighted ticks from a color settings filter to be noticeable even if
the time event is not the first event of that pixel.

Change-Id: I316f044157cef50f6744d128c3661964b97f09c1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/51068
Reviewed-by: Hudson CI
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
(cherry picked from commit 37a507dca88f92e040df4d860191a88224fca382)
Reviewed-on: https://git.eclipse.org/r/51344

tmf: Dispose clipboard after Copy to Clipboard operation

Change-Id: Icc6ee4b8de1a936ef86c61f0e8b5b9e6afb0de71
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50633
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 470851: Trace time range should include lost event end time

Change-Id: I273cf79f93f0718a30226d65e1558a7696ed3253
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50754
Reviewed-by: Hudson CI

tmf: Mark ITmfSourceLookup#getCallsite as @Nullable

Any event that implements ITmfSourceLookup may return null to
indicate there is no specific call site information for this
event.

Clarify this by marking the method @Nullable, which ensures this
case is handled gracefully.

Change-Id: I2c38e879bea8d90fb3a19aa7d16f6d6566cccb2c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/50311
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 470830: Incorrect lost event count in histogram

Change-Id: I19a8b3455b50c0ad17a013ce6b3e6fb0a9b870ce
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50738
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Bug 470754: Incorrect time range in CTF Lost Event

Change-Id: Ibdabcf68999cd4f801018c167364bfadf33d3edd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50683
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Really make lttng kernel event matching package internal

Simply renaming the package with 'internal' in the name did not make it
internal.

Change-Id: I4cbaae0df9e4f691600294e895077d952cbdea74
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/51083
Reviewed-by: Hudson CI

releng: Bump versions of parent modules

To make it clearer that this is targetting 2.0.0 release, bump the parent
modules to 2.0.0. We technically don't need to do that but it's less confusing
to see 2.0.0 when building from the top level.

Change-Id: Ie0b407ce726df749351dfba8aa0efdc9aa58b75a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51069
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

Update usage of IAdaptable#getAdapter

Generics were added to the APIs of IAdaptable and related
classes. Update our usage of these methods, as suggested in
http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg11590.html

Change-Id: I8fb374869567b5c2b7421b4773998c60e9fcc468
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43472
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 470741: Missing lost events in scaled histogram buckets

Change-Id: I8cf2c1a977845c9a60026178940bb09e75206b4c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50659
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Introduce SegmentStore plugin

Unlike the State System, which assigns single states to attributes,
the Segment Store is a database interface for storing segments that
may overlap each other. It is closer in intent to a spatial database.

Just like state system backends, we provide an interface that can be
implemented in different ways. A first basic in-memory implementation
is provided.

Change-Id: I20a4a27b66ae005e8a22070752d8cc0a132a36f5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/50308
Reviewed-by: Hudson CI

common: Concurrency fixes in TraceCompassActivator

The TraceCompassActivator class (which can be used as base for any
Activator in every plugin) tracks all the loaded activators in a map.

Add a bit of synchronization to make sure this map cannot be victim
of unexpected concurrent accesses.

Change-Id: Ia94899dfb140a5bf740e3cc6343f6d43579dd777
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/50752
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix missing @since's and bump corresponding versions

Some API changes were introduced since the 1.0 release, this
patch bumps the verion numbers where appropriate and fixes
the @since annotations.

Change-Id: Ib0ce9860d1c05b94fb074972c817dfec736beace
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50309
Reviewed-by: Hudson CI

tmf: Fix SWTException in TmfEventsTable

The table can get disposed while the event request is being processed.
Attempting to get the display from the table will throw an exception.
Getting the display from the workbench will avoid this exception.

Change-Id: Id68b34be403c30359c8e56e88e2d894779804214
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49260
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

rcp: bug 471162: Add Error Log view to RCP

This makes it easier for users to understand when things go wrong and for
reporting issues. It will also help us while testing the RCP because we will
notice more easily when errors happen. This would have probably helped finding
bug 469809 earlier.

Change-Id: I2a6e7a752f9b53667ec58045ddb2406085ff2391
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50387
Reviewed-by: Hudson CI

Use o.e.test and jdt.annotation from Eclipse 4.5

Also fix use of deprecated junit constructor. This is because o.e.test
*includes* org.junit and the Eclipse 4.5 repo only has junit 4.12 which
introduced the deprecation.

Change-Id: Id17e904674509a3a551f253f8b6927f023ba935c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50905
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Build using non-staging Eclipse 4.5 target

Since staging will become Eclipse 4.6 (Neon) we should switch to building using
a more stable 4.5 target (for now).

Change-Id: I8bcfde64f769510150dc3517b9931521522efdbc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50904
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf.ui: introduce TmfSimpleTableViewer

A helper for jface tables with sortable columns. It provides the
following features:
 - Sortable columns
 - Movable columns
 - Resizable columns
 - Tracking last clicked columns

Change-Id: I3a7f6037891153022904a53563d223c4bf805816
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41994
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

swtbot: Add Copy to Clipboard tests

Change-Id: I18e7f8a633918856dc934483c4c1aac41955912d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50653
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: make parser support scoped typedefs [Bug 470846]

This is important if you want to have a root typedef struct for instance.

Change-Id: I9aff6a1049605f98cb1e16015b6170ea9801b9e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50055
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: update postfix expression to accept chained CTF expressions [Bug 470846]

This updates the grammar to support absolute referencing

Change-Id: I952e846abc3bdcecdd40bc9e9dc9716bdefa9adb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49961
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: validate if metadata endianness is inconsistent.

Change-Id: Ide73b0344e9aaf0058b6501d003f0e64f978fd2a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46431
Reviewed-by: Hudson CI
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

rcp: Build proper .app on Mac

Otherwise, the rcp doesn't start when building against Eclipse 4.5

Change-Id: I49773d350ad966f47e94a4da5892bf4135bda4f4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50669
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

swtbot: Add event table column header menu tests

Change-Id: I6f6391bc138c80731707b96d1e16c75e539211ee
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50297
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf.ui : Only update chart if not disposed

To fix a SWT error (widget is disposed) when chart is closed while the
trace is still loading.

Change-Id: I44015f742908395e68c30a3824bcdfb509a07d4c
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49923
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: adjust jacoco report path to new folder structure

Change-Id: I182b8523651a914608e47a71803a0d9efc0e7d4a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50463
Reviewed-by: Hudson CI

releng: Use SWTBot snapshot build

This is necessary for us to consume a fix and a new feature required for
https://git.eclipse.org/r/#/c/50297/

Change-Id: Ieecad5c61d01ee7fcef6e50cc0642a6d5c19a5cf
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50526
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Set keyboard layout in SWTBot tests

Depending on the locale of the system, some tests like testKeyboardLeftRight would fail with a NPE.

Change-Id: If39e8faedffb8629b5cfd2b6e44a8bbd80b9990e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50470
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui : Only update populated chart

Check that there is at least one point in a chart to avoid AOOB

Change-Id: Id56153b4548a5ef713b1b0caf89976f3b0e348d6
Signed-off-by: France Lapointe Nguyen <francelap@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49924
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: add two benchmarks for TmfStatisticsModule

Change-Id: I932e095ee83aa4b0224963cfc8e4cd61dfbfda82
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49675
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Update sync_settings.sh for the new directory layout

Change-Id: I4a80162f3cb196608df9bfce5fa84bba3431f2d9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Update README to reflect new plugin organization

The components are easier to describe now that they are in
proper sub-directories.

Also updated the plugins.svg file to components.svg, and it
now displays the dependency graph between actual components.

Change-Id: Ia15cfa46cf2531e5a6f2c86396666eff51e49d66
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

doc: Move the examples plugin to the doc/ directory

Change-Id: I9546d2febb09c416f9031fd1c2ac4d57726a2e60
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Create and populate new "releng" sub-directory

Release-related plugins, like *.target/ and *.releng-site/ can
now be found inside a releng/ top-level directory.

The *.alltests/ and *.testing/ plugins have also been moved there,
it's not obvious where these should go, but this should be a
reasonable place.

Change-Id: I7c42040cc6801dacb5a88ef6cff57ab11c541ff9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Move plugins to their own sub-directory

Change-Id: I63bc2b18ab7ee041c166690aed181b2b1cb57563
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

analysis: Move plugins to their own sub-directory

The "analysis" component can host all analyses that do not
depend on a specific trace type.

Change-Id: I52b196e0e9ecae7e98593d5c3143996d923020dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Move plugins to their own sub-directory

Change-Id: I7a2ec6fb8489f0f337a6f6d7e543bfb248e6383f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Move plugins to their own sub-directory

Change-Id: I5eac1d897c78cec439ff951fec7582c1d5cd0045
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

rcp: Move plugins to their own sub-directory

Also moved the definition of the "build-rcp" Maven profile
into the RCP Parent's pom.xml, and updated the README.

Change-Id: I5c5f471ba1bbb6236cd549db3b12035682ee3039
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

statesystem: Move plugins to their own sub-directory

Change-Id: I64e398caf208278063f87a88c5925d463dcc13b1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

common: Move plugins to their own sub-directory

Change-Id: I98b57351b5aff035ddbf80449513190baa3f1d41
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

gdbtrace: Move plugins to their own sub-directory

Change-Id: I6ef8d281b2de8d4097af519279100536b794865d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

pcap: Move plugins to their own sub-directory

The "alltests" plugin won't be able to find the pcap test
traces, but this will be rectified once that plugin is also
moved to a sub-directory (we will be able to have a relative
path that works for everyone).

Change-Id: Ic9c3644abfa5d97622769d23a855521e2d5c9371
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

btf: Move the plugins to their own sub-directory

Change-Id: I4f5eed6c1da0b33081706ad9bc890c94817f7355
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

common: Generalize the BufferedBlockingQueue's concurrent test

Provide a general concurrency test method, which can then be
used to try various combinations of producer, consumer, and
observer threads.

Change-Id: Ia7c47a44be45e7810800c70493ffe9357277ae3f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/48217
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

doc: Update user guide for changes to event table

- Copy to Clipboard
- Hiding columns from header context menu
- Update default TMF and LTTng kernel columns

Change-Id: Ibe81141881bbbaef1efc02fa321f8a41488d5f69
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50208
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

rcp: Fix icon paths for new Tycho

This fixes the FileNotFoundExceptions since the upgrade to Tycho 0.23.0

Change-Id: I51960399c3ed3a321342360892986a10b3a73fa6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50226
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Bug 468867: Time graph listener notifier interference from ext sync

Change-Id: I2099016a56c4a13ce1661c6a84d8168486be15a0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/50146
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Bug 452415: Remember last location for Open Trace

Change-Id: Iffe079c1d292705c624701853c7374b602463ff1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/50106
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Revert "tmf: Bug 468867: Time graph listener notifier interference from ext sync"

This reverts commit 3ad34c5d3fbfeee1eeeda5c4fe2afa02d3bc6b2a.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=468867#c4 .

Change-Id: Ia8815c6ca51172ce9166324fc1833361e7b58317
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/50142
Reviewed-by: Hudson CI

tmf: Add Copy to Clipboard in TmfEventsTable

Change-Id: Ic2ca73787e294ba69fcaa4b111e5a21ff66bb9a1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49834
Reviewed-by: Hudson CI

ctf: make magic numbers optional

Change-Id: If86103a84c939e551889359e3d669c5a3cabb8c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49962
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf.core: Make childTypeError return an exception instead of throwing it.

This makes return analysis easier for the jdt

Change-Id: I2c5ea78b9ef27de8e146cbb0a322fe84d458d379
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49777
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make hiding column menu in the displayed order

Change-Id: Ibd9622e89ecb615c279e66f7dcca925500f8f049
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49518
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Bug 469809: Invalid thread access closing editors in non-UI thread

Change-Id: Ia692b41efe429b96c995ba7bf7ed749d25ceff12
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49949
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix synchronization between raw viewer and event table

The selected event can now be kept in synchronization even after using
the raw viewer scroll bar.

Change-Id: I1924cd65d79279266842c1bd4f7697e1c3bdbbef
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49456
Reviewed-by: Hudson CI

tmf: Periodically refresh raw viewer while scroll bar is dragged

Change-Id: Ifd5b3a4f751a75b223cf498defb23a1118c2c260
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49394
Reviewed-by: Hudson CI

tmf: Periodically refresh virtual table while scroll bar is dragged

Change-Id: I9f0f93fa37c53f73cab6e203e6af0945a4fb58fb
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49138
Reviewed-by: Hudson CI

tmf: Bug 468867: Time graph listener notifier interference from ext sync

Change-Id: Ibf072ff1bcd322dedcd3479cb2d08d051c332d50
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49009
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Bug 469644: Clear axises of chart when trace is closed

It should be investigated if people would rather have NO axises
when they are cleared.

Change-Id: I566ba5abe15ad9cc5f7f2df5ed7ed74589e1cebb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49049
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Upgrade to Tycho 0.23.0

This fixes bug 453474.

Change-Id: Ib6e74caf59f0c23c6ce8e2f683963a1f6e1eafe9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/45680
Reviewed-by: Hudson CI

Add a new target to specify the API baseline

Eclipse 4.5 now offers specifying API baselines using target files.
This is much more simple than having to install and maintain a
separate Eclipse installation!

Add a new .target, under a baseline/ directory (to not confuse them
with "real" targets listing build dependencies) which we can use
for setting the API baseline.

Change-Id: Ie83d6ee09de00d102a735da99cd50118c5efd1f5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/48703
Reviewed-by: Hudson CI

ctf: Fix location ratio handling in CtfTmfTrace

In getLocationRatio(), the provided location timestamp can be used
directly instead of requiring a context seek. Incidentally, the context
used in the current implementation was leaking as it was not disposed.

The total time range used for the ratio calculation should be based on
the trace start and end time (timestamp of first and last event). Using
the iterator range can result in Infinity ratio when the iterator has
only read a single event so far.

In seekEvent(double), the total time range used should also be based on
the trace start and end time. The trace getCurrentStartTime() and
getCurrentEndTime() methods use the packet start and end times which do
not necessarily match actual trace event timestamps.

Change-Id: Ic8bfcdebbd5c388a4048815d01124434e4c82ba6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49556
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Fix incorrect location in CtfTmfContext after seek

After seeking by timestamp, the context location should be set to the
exact timestamp of the event, not the specified timestamp.

After seeking to the start of the trace, the context location should be
set to the exact timestamp of the first event, not to 0. This was a
regression introduced when the CtfLocation was made final.

Change-Id: I5d34653aede7afd5b5fef1baead532a8b1640fa7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49555
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Fix CtfIterator current event and location after seek

If an iterator has equal current and previous location (like it does
after the current event has been read once), the seek will not update
the current event even if it does not match the seek location. Then the
current event and current location of the iterator can return arbitrary
values that do not correspond with the seek location.

This can happen if the iterator instance is recycled for a different
context, which only happens when the iterator manager is full due to 100
concurrent contexts for the same trace, which probably can only happen
if there is a context leak, as the iterator is removed from the iterator
manager when it is disposed.

Change-Id: Ifd67b2c866955f424e11172b8e6fc27a35ad676a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49554
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add color preferences for event raw viewer highlight and selection

The color settings can be changed in Window > Preferences > General >
Appearance > Colors and Fonts > Tracing.

Descriptions are added for all the Tracing font and color preferences.

The default trace event table font is changed to the system font instead
of the dialog font, which more accurately reflects the widget default.

Change-Id: Ia422655c2acd4b15b7ee9b01e07e80bbce5ea900
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49409
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Bug 469655: Virtual table column resize not working on Linux

Change-Id: I1186cb17a83a78210e85db06d763ceea7e8960cc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49696
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: make columns hideable.

Change-Id: Ia23182dc74f05fac21570a718758e050b8881155
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48704
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: make StructDeclarationFlattener more NonNull

Change-Id: Ife73c0f117b2269b3a01a17d3931c0220e46de17
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49558
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Bump target sequence number to pick up fix in o.e.remote

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=461520#c10

Change-Id: I5173d6d33229d3831c155335cd0606d3cf3ecbe6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49545
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: make GzipFile call super.finalize()

Change-Id: I5cbffffb23a1d06134295bb17d5fa3fa5329d9f6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48897
Reviewed-by: Hudson CI

tmf: delete unnecessary equals() and hashCode() methods for singleton

Change-Id: Idef63f478feced1ae3480c356f6f207c695b4f81
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Reviewed-on: https://git.eclipse.org/r/47225
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

swtbot: Fix ControlFlowViewTest

If the test host burps for a minimum of 400 ms between the 5th and the
6th click of the "Follow CPU Fwd" button, the test will fail because the
wait condition for the time range returns immediately since the 6th
selected event is a change of process that has the same timestamp as the
5th selected event and the listener notifier has timed out due to the
host delay, updating the trace manager with the selection time of the
5th selected event, and then the following assert on the tree selection
fails because the selected entry change event is still stuck in the new
listener notifier for another 400 ms.

A new condition is created to wait until the tree selection equals the
expected value, instead of using an assertion.

Additionally, the tests are updated to use the new click(int) with
modifier methods in SWTBot, allowing the test of range selection using
tool bar buttons while the SHIFT key is pressed.

Change-Id: Ic607d063b13248bd5ab91a87861ce3dad8a2b286
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/49259
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Upgrade jarsigner to final 1.1.2 release

Change-Id: I8b143dfed54739a250ef5da46851c8542d54aba9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49417
Reviewed-by: Hudson CI

Fix file leak in Gzip support

Change-Id: Ie14143f5be809a8c7e54fc7bc5f7f639d6da4ece
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49269
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ui: GzipEntry remove magic numbers

Change-Id: I30db829944632f20923401f4f3e0724e4ca7c8e7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48898
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: clarify exception handling in ImportTraceWizardPage

Also avoid an NPE that doesn't happen yet because of validation, not design.

Change-Id: I4a1e5918dea4343250150952974f9286c3ccb177
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48896
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: add char position of parse errors in metadata

Change-Id: I927df5890e459c65f43570b6188d11787f3cd8f1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48959
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Use latest Orbit repo

See
http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg11952.html

Change-Id: I0193cd2468bda3f6fc083d589ca412e3b49943e8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49123
Reviewed-by: Hudson CI

Bump target sequence number to pick up new API changes from o.e.remote

Change-Id: Idda226b54e013663ca37b9806e4933ee008abfdb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/49104
Reviewed-by: Hudson CI

lttng: Add Lttng27EventLayout

This new layout provides the VTIds and pid namespace Inodes on
"sched_process_fork" and "statedump_process_state" events.

Change-Id: If27a0585f38ef690eff8222a69207d9daecf2a41
Signed-off-by: Sebastien Lorrain <sebastien.lorrain01@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47474
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

swtbot: Add Control Flow view tests

Tests involving shift-clicking a tool bar button are commented out until
this is supported by the SWTBot framework.

Change-Id: I82071d50828db282a0f5f8afa4b8974b9daf83c1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/48502
Reviewed-by: Hudson CI

doc: add time axis alignment to user guide

Change-Id: I4cb900dbc83d0adefea0b19865d877caf411834f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48870
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: make fields static

Change-Id: Ie87294e64410656d0afaada8705e786b7a8f5a94
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48856
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: bug 468542: Fix toggle of search/filter in table using the mouse

Change-Id: I5e1f849272c9ac89e9c15564f9f6a133562fdc1d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/48816
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>