From c674f5cd3f900c5b12996ea5188ff818fe9eb6bc Mon Sep 17 00:00:00 2001 From: Jiong Wang Date: Tue, 11 Aug 2015 22:12:41 +0100 Subject: [PATCH] [AArch64] Improve BFD overflow warning message for -fpic 2015-08-11 Jiong Wang bfd/ * elfnn-aarch64.c (elfNN_aarch64_relocate_section): Improve warning message for R_AARCH64_LD64_GOTPAGE_LO15/R_AARCH64_LD32_GOTPAGE_LO14. --- bfd/ChangeLog | 5 +++++ bfd/elfnn-aarch64.c | 13 +++++++++++++ 2 files changed, 18 insertions(+) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 4b70d83254..1e02625a0f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2015-08-11 Jiong Wang + + * elfnn-aarch64.c (elfNN_aarch64_relocate_section): Improve warning + message for R_AARCH64_LD64_GOTPAGE_LO15/R_AARCH64_LD32_GOTPAGE_LO14. + 2015-08-11 Jiong Wang * elfnn-aarch64.c (IS_AARCH64_TLS_RELAX_RELOC): New. diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c index 1796ecd775..fe10be60fe 100644 --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -5802,6 +5802,9 @@ elfNN_aarch64_relocate_section (bfd *output_bfd, if (r != bfd_reloc_ok && r != bfd_reloc_continue) { + bfd_reloc_code_real_type real_r_type + = elfNN_aarch64_bfd_reloc_from_type (r_type); + switch (r) { case bfd_reloc_overflow: @@ -5809,6 +5812,16 @@ elfNN_aarch64_relocate_section (bfd *output_bfd, (info, (h ? &h->root : NULL), name, howto->name, (bfd_vma) 0, input_bfd, input_section, rel->r_offset)) return FALSE; + if (real_r_type == BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15 + || real_r_type == BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14) + { + (*info->callbacks->warning) + (info, + _("Too many GOT entries for -fpic, " + "please recompile with -fPIC"), + name, input_bfd, input_section, rel->r_offset); + return FALSE; + } break; case bfd_reloc_undefined: -- 2.34.1