From 754dd2b00f2bd3f2d7aaacdb27375bc6faf1458e Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 8 Oct 2014 11:25:31 +0800 Subject: [PATCH] Enable qTStatus packet in case it is disabled Nowadays, we are using command "tstatus" to send a packet to GDBserver in order to check the connection. However, on the target doesn't support tracepoint, the following error is emitted before sending any packet to GDBserver. tstatus^M Trace can not be run on this target.^M (gdb) FAIL: gdb.server/server-kill.exp: tstatus qTStatus is disabled after receiving the empty reply during connecting to the remote target. When the test executes command "tstatus" again, remote_get_trace_status returns -1 at the very beginning, and no RSP packet is sent out. This patch is to enable qTStatus packet again. gdb/testsuite: 2014-10-11 Yao Qi * gdb.server/server-kill.exp: Execute command "set remote trace-status-packet on" before "tstatus". --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.server/server-kill.exp | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 14e2d5c085..348adffaac 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-10-11 Yao Qi + + * gdb.server/server-kill.exp: Execute command + "set remote trace-status-packet on" before "tstatus". + 2014-10-11 Yao Qi * gdb.server/server-kill.c: Include sys/types.h and unistd.h. diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 83c11f2d0d..53d8e9a07c 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -52,6 +52,11 @@ if {$server_pid == "" } { remote_exec target "kill -9 $server_pid" +# Enable trace status packet which is disabled after the connection +# if the remote target doesn't support tracepoint at all. Otherwise, +# no RSP packet is sent out. +gdb_test_no_output "set remote trace-status-packet on" + # Force GDB to talk with GDBserver, so that we can get the # "connection closed" error. gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected\.: Connection reset by peer\.} -- 2.34.1