From 0a94b7d080e5ea371c360caf87c0a42a43a23b6c Mon Sep 17 00:00:00 2001 From: Jean-Christian Kouame Date: Fri, 4 Dec 2015 13:03:55 -0500 Subject: [PATCH] tmf : use of StringBuilder.append() instead of String operator + Change-Id: I062c411af568289f5c17a279953703d720109119 Signed-off-by: Jean-Christian Kouame Reviewed-on: https://git.eclipse.org/r/62015 Reviewed-by: Hudson CI Reviewed-by: Matthew Khouzam Tested-by: Bernd Hufmann Reviewed-by: Bernd Hufmann --- .../views/filter/FilterTreeLabelProvider.java | 48 +++++++++---------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/filter/FilterTreeLabelProvider.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/filter/FilterTreeLabelProvider.java index c211d3c669..bbabe58b75 100644 --- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/filter/FilterTreeLabelProvider.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/filter/FilterTreeLabelProvider.java @@ -69,65 +69,65 @@ public class FilterTreeLabelProvider implements ILabelProvider { @Override public String getText(Object element) { - String label = null; + StringBuilder label = new StringBuilder(); if (element instanceof TmfFilterNode) { TmfFilterNode node = (TmfFilterNode) element; - label = node.getNodeName() + ' ' + (node.getFilterName() != null && + label.append(node.getNodeName()).append(' ').append(node.getFilterName() != null && !node.getFilterName().isEmpty() ? node.getFilterName() : Messages.FilterTreeLabelProvider_FilterNameHint); } else if (element instanceof TmfFilterTraceTypeNode) { TmfFilterTraceTypeNode node = (TmfFilterTraceTypeNode) element; - label = "WITH " + node.getNodeName() + ' ' + (node.getName() != null ? node.getName() : Messages.FilterTreeLabelProvider_TraceTypeHint); //$NON-NLS-1$ + label.append("WITH ").append(node.getNodeName()).append(' ').append((node.getName() != null ? node.getName() : Messages.FilterTreeLabelProvider_TraceTypeHint)); //$NON-NLS-1$ } else if (element instanceof TmfFilterAndNode) { TmfFilterAndNode node = (TmfFilterAndNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + node.getNodeName(); + label.append((node.isNot() ? NOT : EMPTY_STRING)).append(node.getNodeName()); } else if (element instanceof TmfFilterOrNode) { TmfFilterOrNode node = (TmfFilterOrNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + node.getNodeName(); + label.append(node.isNot() ? NOT : EMPTY_STRING).append(node.getNodeName()); } else if (element instanceof TmfFilterContainsNode) { TmfFilterContainsNode node = (TmfFilterContainsNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + - (node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + - ' ' + node.getNodeName() + - (node.getValue() != null ? SPACE_QUOTE + node.getValue() + QUOTE : EMPTY_STRING); + label.append(node.isNot() ? NOT : EMPTY_STRING) + .append(node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + .append(' ').append(node.getNodeName()).append(node.getValue() != null ? + new StringBuilder().append(SPACE_QUOTE).append(node.getValue()).append(QUOTE).toString() : EMPTY_STRING); } else if (element instanceof TmfFilterEqualsNode) { TmfFilterEqualsNode node = (TmfFilterEqualsNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + - (node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + - ' ' + node.getNodeName() + - (node.getValue() != null ? SPACE_QUOTE + node.getValue() + QUOTE : EMPTY_STRING); + label.append(node.isNot() ? NOT : EMPTY_STRING) + .append(node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + .append(' ').append(node.getNodeName()) + .append(node.getValue() != null ? new StringBuilder().append(SPACE_QUOTE).append(node.getValue()).append(QUOTE).toString() : EMPTY_STRING); } else if (element instanceof TmfFilterMatchesNode) { TmfFilterMatchesNode node = (TmfFilterMatchesNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + - (node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + - ' ' + node.getNodeName() + - (node.getRegex() != null ? SPACE_QUOTE + node.getRegex() + QUOTE : EMPTY_STRING); + label.append(node.isNot() ? NOT : EMPTY_STRING) + .append(node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + .append(' ').append(node.getNodeName()) + .append(node.getRegex() != null ? new StringBuilder().append(SPACE_QUOTE).append(node.getRegex()).append(QUOTE).toString() : EMPTY_STRING); } else if (element instanceof TmfFilterCompareNode) { TmfFilterCompareNode node = (TmfFilterCompareNode) element; - label = (node.isNot() ? NOT : EMPTY_STRING) + - (node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + - (node.getResult() < 0 ? " <" : (node.getResult() > 0 ? " >" : " =")) + //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ - (node.getType() == Type.ALPHA ? SPACE_QUOTE : node.getType() == Type.TIMESTAMP ? " [" : ' ') + //$NON-NLS-1$ - (node.hasValidValue() ? node.getValue() : Messages.FilterTreeLabelProvider_ValueHint) + - (node.getType() == Type.ALPHA ? '\"' : node.getType() == Type.TIMESTAMP ? ']' : EMPTY_STRING); + label.append(node.isNot() ? NOT : EMPTY_STRING) + .append(node.getEventAspect() != null ? node.getAspectLabel(false) : Messages.FilterTreeLabelProvider_AspectHint) + .append(node.getResult() < 0 ? " <" : (node.getResult() > 0 ? " >" : " =")) //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ + .append(node.getType() == Type.ALPHA ? SPACE_QUOTE : node.getType() == Type.TIMESTAMP ? " [" : ' ') //$NON-NLS-1$ + .append(node.hasValidValue() ? node.getValue() : Messages.FilterTreeLabelProvider_ValueHint) + .append(node.getType() == Type.ALPHA ? '\"' : node.getType() == Type.TIMESTAMP ? ']' : EMPTY_STRING); } - return label; + return label.toString(); } } -- 2.34.1