From 42618bb1ae8916b344db45fba6cff3cfc61b97bf Mon Sep 17 00:00:00 2001 From: Jean-Christian Kouame Date: Wed, 30 Sep 2015 10:14:03 -0400 Subject: [PATCH] tmf: Avoid duplicate literals in GraphNode The string literals have been extracted into a constant variable Change-Id: I4f48ca60faac42186bba26f9f9513993409d2bbe Signed-off-by: Jean-Christian Kouame Reviewed-on: https://git.eclipse.org/r/57085 Reviewed-by: Alexandre Montplaisir Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann Tested-by: Bernd Hufmann --- .../tracecompass/tmf/ui/views/uml2sd/core/GraphNode.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/GraphNode.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/GraphNode.java index 20cf9770ac..d8aa8f7b73 100755 --- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/GraphNode.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/views/uml2sd/core/GraphNode.java @@ -33,6 +33,7 @@ import org.eclipse.tracecompass.tmf.ui.views.uml2sd.preferences.SDViewPref; */ public abstract class GraphNode { + private static final String UI_DELIMITER = "*****************************\n"; //$NON-NLS-1$ // ------------------------------------------------------------------------ // Attributes // ------------------------------------------------------------------------ @@ -504,7 +505,7 @@ public abstract class GraphNode { return; } if(TmfUiTracer.isIndexTraced()) { - TmfUiTracer.traceIndex("*****************************\n"); //$NON-NLS-1$ + TmfUiTracer.traceIndex(UI_DELIMITER); TmfUiTracer.traceIndex("Visible area position in virtual screen (x,y)= " + x + " " + y + "\n\n"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ } @@ -616,7 +617,7 @@ public abstract class GraphNode { } if (TmfUiTracer.isIndexTraced()) { - TmfUiTracer.traceIndex("*****************************\n"); //$NON-NLS-1$ + TmfUiTracer.traceIndex(UI_DELIMITER); } } @@ -666,7 +667,7 @@ public abstract class GraphNode { } if (TmfUiTracer.isDisplayTraced()) { - TmfUiTracer.traceDisplay("*****************************\n"); //$NON-NLS-1$ + TmfUiTracer.traceDisplay(UI_DELIMITER); } int arrayStep = 1; @@ -688,7 +689,7 @@ public abstract class GraphNode { } } if (TmfUiTracer.isDisplayTraced()) { - TmfUiTracer.traceDisplay("*****************************\n"); //$NON-NLS-1$ + TmfUiTracer.traceDisplay(UI_DELIMITER); } } -- 2.34.1