From 4dfd44fec48f3c9d76d491522bf51917755c1377 Mon Sep 17 00:00:00 2001 From: Matthew Khouzam Date: Wed, 27 Jan 2016 22:43:58 -0500 Subject: [PATCH] analysis.xml: Remove "throws Exception" Replaces throws Exception with throws IOException. Using such generic exceptions prevents calling methods from handling true, system-generated exceptions differently than application-generated errors. Or, as the former lead of our former project said: "Don't mess with Exception" Change-Id: I61f517b8721a5e660d92b7cba7bf97c1382381af Signed-off-by: Matthew Khouzam Reviewed-on: https://git.eclipse.org/r/65333 Reviewed-by: Hudson CI Reviewed-by: Genevieve Bastien Tested-by: Genevieve Bastien --- .../tmf/analysis/xml/core/module/XmlAnalysisModuleSource.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/tmf/analysis/xml/core/module/XmlAnalysisModuleSource.java b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/tmf/analysis/xml/core/module/XmlAnalysisModuleSource.java index 8d9c942ae0..13d4626e49 100644 --- a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/tmf/analysis/xml/core/module/XmlAnalysisModuleSource.java +++ b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/tmf/analysis/xml/core/module/XmlAnalysisModuleSource.java @@ -126,7 +126,7 @@ public class XmlAnalysisModuleSource implements IAnalysisModuleSource { SafeRunner.run(new ISafeRunnable() { @Override - public void run() throws Exception { + public void run() throws IOException { if (name != null) { Bundle bundle = Platform.getBundle(name); if (bundle != null) { -- 2.34.1