From ba3fb998cec1f7bf05915d34d8c19e7c126f5517 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Tue, 16 Aug 2022 09:48:56 -0400
Subject: [PATCH] tests/src.ctf.fs: add CTF 2 tests for no stream class, no
 trace class

During development, we hit some crashes when the trace metadata did not
specify any data stream class fragment (with and without an explicit
trace class fragment).  Add tests for that.

Change-Id: Ic8ce4c7a2ae78b2f484a86e5b1306b7eae606528
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
---
 .../ctf-traces/2/fail/meta-no-stream-cls/metadata  |  9 +++++++++
 .../fail/meta-no-trace-cls-no-stream-cls/metadata  |  5 +++++
 tests/plugins/src.ctf.fs/fail/test_fail            | 14 +++++++++++++-
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 tests/data/ctf-traces/2/fail/meta-no-stream-cls/metadata
 create mode 100644 tests/data/ctf-traces/2/fail/meta-no-trace-cls-no-stream-cls/metadata

diff --git a/tests/data/ctf-traces/2/fail/meta-no-stream-cls/metadata b/tests/data/ctf-traces/2/fail/meta-no-stream-cls/metadata
new file mode 100644
index 000000000..33af695c9
--- /dev/null
+++ b/tests/data/ctf-traces/2/fail/meta-no-stream-cls/metadata
@@ -0,0 +1,9 @@
+
+{
+  "type": "preamble",
+  "version": 2
+}
+
+{
+  "type": "trace-class"
+}
diff --git a/tests/data/ctf-traces/2/fail/meta-no-trace-cls-no-stream-cls/metadata b/tests/data/ctf-traces/2/fail/meta-no-trace-cls-no-stream-cls/metadata
new file mode 100644
index 000000000..ab212ea4e
--- /dev/null
+++ b/tests/data/ctf-traces/2/fail/meta-no-trace-cls-no-stream-cls/metadata
@@ -0,0 +1,5 @@
+
+{
+  "type": "preamble",
+  "version": 2
+}
diff --git a/tests/plugins/src.ctf.fs/fail/test_fail b/tests/plugins/src.ctf.fs/fail/test_fail
index 0b9b5d929..9c940f517 100755
--- a/tests/plugins/src.ctf.fs/fail/test_fail
+++ b/tests/plugins/src.ctf.fs/fail/test_fail
@@ -84,7 +84,7 @@ test_fail() {
 	done
 }
 
-plan_tests 24
+plan_tests 40
 
 test_fail \
 	"invalid-packet-size/trace" \
@@ -104,4 +104,16 @@ test_fail \
 	"/dev/null" \
 	"^  At line 3 in metadata stream: syntax error, unexpected CTF_RSBRAC: token=\"]\""
 
+test_fail \
+	"meta-no-trace-cls-no-stream-cls" \
+	2 \
+	"/dev/null" \
+	"Missing data stream class fragment in metadata stream."
+
+test_fail \
+	"meta-no-trace-cls-no-stream-cls" \
+	2 \
+	"/dev/null" \
+	"Missing data stream class fragment in metadata stream."
+
 rm -f "${stdout_file}" "${stderr_file}"
-- 
2.34.1