From bced2679001b45d51f3c11af784a78d13899a43c Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Thu, 26 Nov 2015 17:50:01 -0500 Subject: [PATCH] tmf: log error before displaying message Otherwise the error is logged only after the dialog is closed. This is not a problem for normal use but for automated tests it can be tricky since we can stop the test before closing the dialog and still look for errors. Change-Id: I1579fa166af2fbe5cd55fdb82b92d976171deaf6 Signed-off-by: Jonathan Rajotte Reviewed-on: https://git.eclipse.org/r/61066 Reviewed-by: Hudson CI Reviewed-by: Marc-Andre Laperle Tested-by: Marc-Andre Laperle --- .../eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java index 893713fea6..23484f460c 100644 --- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/project/model/TraceUtils.java @@ -50,8 +50,8 @@ public class TraceUtils { @Override public void run() { final Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell(); - MessageDialog.openError(shell, boxTitle, errorMsg); Activator.getDefault().logError(errorMsg); + MessageDialog.openError(shell, boxTitle, errorMsg); } }); } -- 2.34.1