X-Git-Url: http://git.efficios.com/?p=argpar.git;a=blobdiff_plain;f=argpar%2Fargpar.c;h=9112e4c359b8a4bfaeae625ae6bc7cebd8b1c406;hp=f324d7fb130355a42ef07583cfcd520f09f2e324;hb=9e2c879bb10c35749cab090dbc89161698caf4e5;hpb=f3ab5ca1c03d5ae622ac53b7c1da30ebd21db199

diff --git a/argpar/argpar.c b/argpar/argpar.c
index f324d7f..9112e4c 100644
--- a/argpar/argpar.c
+++ b/argpar/argpar.c
@@ -55,12 +55,18 @@ struct argpar_iter {
 	int non_opt_index;
 
 	/*
-	 * Current character of the current short option group: if it's
-	 * not `NULL`, the parser is in within a short option group,
-	 * therefore it must resume there in the next
-	 * argpar_iter_next() call.
+	 * Current character within the current short option group: if
+	 * it's not `NULL`, the parser is within a short option group,
+	 * therefore it must resume there in the next argpar_iter_next()
+	 * call.
 	 */
-	const char *short_opt_ch;
+	const char *short_opt_group_ch;
+
+	/* Temporary character buffer which only grows */
+	struct {
+		size_t size;
+		char *data;
+	} tmp_buf;
 };
 
 /* Base parsing item */
@@ -247,79 +253,6 @@ end:
 	return;
 }
 
-static
-bool push_item(struct argpar_item_array * const array,
-		const struct argpar_item * const item)
-{
-	bool success;
-
-	ARGPAR_ASSERT(array);
-	ARGPAR_ASSERT(item);
-
-	if (array->n_items == array->n_alloc) {
-		const unsigned int new_n_alloc = array->n_alloc * 2;
-		const struct argpar_item ** const new_items =
-			ARGPAR_REALLOC(array->items, const struct argpar_item *,
-				new_n_alloc);
-		if (!new_items) {
-			success = false;
-			goto end;
-		}
-
-		array->n_alloc = new_n_alloc;
-		array->items = new_items;
-	}
-
-	array->items[array->n_items] = item;
-	array->n_items++;
-	success = true;
-
-end:
-	return success;
-}
-
-static
-void destroy_item_array(struct argpar_item_array * const array)
-{
-	if (array) {
-		unsigned int i;
-
-		for (i = 0; i < array->n_items; i++) {
-			argpar_item_destroy(array->items[i]);
-		}
-
-		free(array->items);
-		free(array);
-	}
-}
-
-static
-struct argpar_item_array *create_item_array(void)
-{
-	struct argpar_item_array *ret;
-	const int initial_size = 10;
-
-	ret = ARGPAR_ZALLOC(struct argpar_item_array);
-	if (!ret) {
-		goto end;
-	}
-
-	ret->items = ARGPAR_CALLOC(const struct argpar_item *, initial_size);
-	if (!ret->items) {
-		goto error;
-	}
-
-	ret->n_alloc = initial_size;
-	goto end;
-
-error:
-	destroy_item_array(ret);
-	ret = NULL;
-
-end:
-	return ret;
-}
-
 static
 struct argpar_item_opt *create_opt_item(
 		const struct argpar_opt_descr * const descr,
@@ -400,13 +333,13 @@ enum parse_orig_arg_opt_ret {
 	PARSE_ORIG_ARG_OPT_RET_OK,
 	PARSE_ORIG_ARG_OPT_RET_ERROR_UNKNOWN_OPT = -1,
 	PARSE_ORIG_ARG_OPT_RET_ERROR_MISSING_OPT_ARG = -2,
-	PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG = -3,
 	PARSE_ORIG_ARG_OPT_RET_ERROR_UNEXPECTED_OPT_ARG = -4,
 	PARSE_ORIG_ARG_OPT_RET_ERROR_MEMORY = -5,
 };
 
 static
-enum parse_orig_arg_opt_ret parse_short_opts(const char * const short_opts,
+enum parse_orig_arg_opt_ret parse_short_opt_group(
+		const char * const short_opt_group,
 		const char * const next_orig_arg,
 		const struct argpar_opt_descr * const descrs,
 		struct argpar_iter * const iter,
@@ -418,29 +351,25 @@ enum parse_orig_arg_opt_ret parse_short_opts(const char * const short_opts,
 	const struct argpar_opt_descr *descr;
 	struct argpar_item_opt *opt_item;
 
-	if (strlen(short_opts) == 0) {
-		try_append_string_printf(error, "Invalid argument");
-		ret = PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG;
-		goto error;
-	}
+	ARGPAR_ASSERT(strlen(short_opt_group) != 0);
 
-	if (!iter->short_opt_ch) {
-		iter->short_opt_ch = short_opts;
+	if (!iter->short_opt_group_ch) {
+		iter->short_opt_group_ch = short_opt_group;
 	}
 
 	/* Find corresponding option descriptor */
-	descr = find_descr(descrs, *iter->short_opt_ch, NULL);
+	descr = find_descr(descrs, *iter->short_opt_group_ch, NULL);
 	if (!descr) {
 		try_append_string_printf(error, "Unknown option `-%c`",
-			*iter->short_opt_ch);
+			*iter->short_opt_group_ch);
 		ret = PARSE_ORIG_ARG_OPT_RET_ERROR_UNKNOWN_OPT;
 		goto error;
 	}
 
 	if (descr->with_arg) {
-		if (iter->short_opt_ch[1]) {
+		if (iter->short_opt_group_ch[1]) {
 			/* `-oarg` form */
-			opt_arg = &iter->short_opt_ch[1];
+			opt_arg = &iter->short_opt_group_ch[1];
 		} else {
 			/* `-o arg` form */
 			opt_arg = next_orig_arg;
@@ -451,11 +380,11 @@ enum parse_orig_arg_opt_ret parse_short_opts(const char * const short_opts,
 		 * We accept `-o ''` (empty option argument), but not
 		 * `-o` alone if an option argument is expected.
 		 */
-		if (!opt_arg || (iter->short_opt_ch[1] &&
+		if (!opt_arg || (iter->short_opt_group_ch[1] &&
 				strlen(opt_arg) == 0)) {
 			try_append_string_printf(error,
 				"Missing required argument for option `-%c`",
-				*iter->short_opt_ch);
+				*iter->short_opt_group_ch);
 			used_next_orig_arg = false;
 			ret = PARSE_ORIG_ARG_OPT_RET_ERROR_MISSING_OPT_ARG;
 			goto error;
@@ -470,11 +399,11 @@ enum parse_orig_arg_opt_ret parse_short_opts(const char * const short_opts,
 	}
 
 	*item = &opt_item->base;
-	iter->short_opt_ch++;
+	iter->short_opt_group_ch++;
 
-	if (descr->with_arg || !*iter->short_opt_ch) {
+	if (descr->with_arg || !*iter->short_opt_group_ch) {
 		/* Option has an argument: no more options */
-		iter->short_opt_ch = NULL;
+		iter->short_opt_group_ch = NULL;
 
 		if (used_next_orig_arg) {
 			iter->i += 2;
@@ -499,7 +428,6 @@ enum parse_orig_arg_opt_ret parse_long_opt(const char * const long_opt_arg,
 		struct argpar_iter * const iter,
 		char ** const error, struct argpar_item ** const item)
 {
-	const size_t max_len = 127;
 	enum parse_orig_arg_opt_ret ret = PARSE_ORIG_ARG_OPT_RET_OK;
 	const struct argpar_opt_descr *descr;
 	struct argpar_item_opt *opt_item;
@@ -511,17 +439,10 @@ enum parse_orig_arg_opt_ret parse_long_opt(const char * const long_opt_arg,
 	/* Position of first `=`, if any */
 	const char *eq_pos;
 
-	/* Buffer holding option name when `long_opt_arg` contains `=` */
-	char buf[max_len + 1];
-
 	/* Option name */
 	const char *long_opt_name = long_opt_arg;
 
-	if (strlen(long_opt_arg) == 0) {
-		try_append_string_printf(error, "Invalid argument");
-		ret = PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG;
-		goto error;
-	}
+	ARGPAR_ASSERT(strlen(long_opt_arg) != 0);
 
 	/* Find the first `=` in original argument */
 	eq_pos = strchr(long_opt_arg, '=');
@@ -529,16 +450,19 @@ enum parse_orig_arg_opt_ret parse_long_opt(const char * const long_opt_arg,
 		const size_t long_opt_name_size = eq_pos - long_opt_arg;
 
 		/* Isolate the option name */
-		if (long_opt_name_size > max_len) {
-			try_append_string_printf(error,
-				"Invalid argument `--%s`", long_opt_arg);
-			ret = PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG;
-			goto error;
+		while (long_opt_name_size > iter->tmp_buf.size - 1) {
+			iter->tmp_buf.size *= 2;
+			iter->tmp_buf.data = ARGPAR_REALLOC(iter->tmp_buf.data,
+				char, iter->tmp_buf.size);
+			if (!iter->tmp_buf.data) {
+				ret = PARSE_ORIG_ARG_OPT_RET_ERROR_MEMORY;
+				goto error;
+			}
 		}
 
-		memcpy(buf, long_opt_arg, long_opt_name_size);
-		buf[long_opt_name_size] = '\0';
-		long_opt_name = buf;
+		memcpy(iter->tmp_buf.data, long_opt_arg, long_opt_name_size);
+		iter->tmp_buf.data[long_opt_name_size] = '\0';
+		long_opt_name = iter->tmp_buf.data;
 	}
 
 	/* Find corresponding option descriptor */
@@ -618,7 +542,7 @@ enum parse_orig_arg_opt_ret parse_orig_arg_opt(const char * const orig_arg,
 			next_orig_arg, descrs, iter, error, item);
 	} else {
 		/* Short option */
-		ret = parse_short_opts(&orig_arg[1],
+		ret = parse_short_opt_group(&orig_arg[1],
 			next_orig_arg, descrs, iter, error, item);
 	}
 
@@ -658,7 +582,7 @@ struct argpar_iter *argpar_iter_create(const unsigned int argc,
 		const char * const * const argv,
 		const struct argpar_opt_descr * const descrs)
 {
-	struct argpar_iter * const iter = ARGPAR_ZALLOC(struct argpar_iter);
+	struct argpar_iter *iter = ARGPAR_ZALLOC(struct argpar_iter);
 
 	if (!iter) {
 		goto end;
@@ -667,6 +591,13 @@ struct argpar_iter *argpar_iter_create(const unsigned int argc,
 	iter->argc = argc;
 	iter->argv = argv;
 	iter->descrs = descrs;
+	iter->tmp_buf.size = 128;
+	iter->tmp_buf.data = ARGPAR_CALLOC(char, iter->tmp_buf.size);
+	if (!iter->tmp_buf.data) {
+		argpar_iter_destroy(iter);
+		iter = NULL;
+		goto end;
+	}
 
 end:
 	return iter;
@@ -675,7 +606,10 @@ end:
 ARGPAR_HIDDEN
 void argpar_iter_destroy(struct argpar_iter * const iter)
 {
-	free(iter);
+	if (iter) {
+		free(iter->tmp_buf.data);
+		free(iter);
+	}
 }
 
 ARGPAR_HIDDEN
@@ -703,9 +637,10 @@ enum argpar_iter_next_status argpar_iter_next(
 	next_orig_arg =
 		iter->i < (iter->argc - 1) ? iter->argv[iter->i + 1] : NULL;
 
-	if (orig_arg[0] != '-') {
+	if (strcmp(orig_arg, "-") == 0 || strcmp(orig_arg, "--") == 0 ||
+			orig_arg[0] != '-') {
 		/* Non-option argument */
-		struct argpar_item_non_opt * const non_opt_item =
+		const struct argpar_item_non_opt * const non_opt_item =
 			create_non_opt_item(orig_arg, iter->i,
 				iter->non_opt_index);
 
@@ -731,7 +666,6 @@ enum argpar_iter_next_status argpar_iter_next(
 		break;
 	case PARSE_ORIG_ARG_OPT_RET_ERROR_UNKNOWN_OPT:
 	case PARSE_ORIG_ARG_OPT_RET_ERROR_MISSING_OPT_ARG:
-	case PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG:
 	case PARSE_ORIG_ARG_OPT_RET_ERROR_UNEXPECTED_OPT_ARG:
 		try_prepend_while_parsing_arg_to_error(error, iter->i,
 			orig_arg);
@@ -743,9 +677,6 @@ enum argpar_iter_next_status argpar_iter_next(
 		case PARSE_ORIG_ARG_OPT_RET_ERROR_MISSING_OPT_ARG:
 			status = ARGPAR_ITER_NEXT_STATUS_ERROR_MISSING_OPT_ARG;
 			break;
-		case PARSE_ORIG_ARG_OPT_RET_ERROR_INVALID_ARG:
-			status = ARGPAR_ITER_NEXT_STATUS_ERROR_INVALID_ARG;
-			break;
 		case PARSE_ORIG_ARG_OPT_RET_ERROR_UNEXPECTED_OPT_ARG:
 			status = ARGPAR_ITER_NEXT_STATUS_ERROR_UNEXPECTED_OPT_ARG;
 			break;
@@ -771,89 +702,3 @@ unsigned int argpar_iter_ingested_orig_args(
 {
 	return iter->i;
 }
-
-ARGPAR_HIDDEN
-struct argpar_parse_ret argpar_parse(const unsigned int argc,
-		const char * const * const argv,
-		const struct argpar_opt_descr * const descrs,
-		const bool fail_on_unknown_opt)
-{
-	struct argpar_parse_ret parse_ret = { 0 };
-	const struct argpar_item *item = NULL;
-	struct argpar_iter *iter = NULL;
-
-	parse_ret.items = create_item_array();
-	if (!parse_ret.items) {
-		parse_ret.error = strdup("Failed to create items array.");
-		ARGPAR_ASSERT(parse_ret.error);
-		goto error;
-	}
-
-	iter = argpar_iter_create(argc, argv, descrs);
-	if (!iter) {
-		parse_ret.error = strdup("Failed to create argpar iter.");
-		ARGPAR_ASSERT(parse_ret.error);
-		goto error;
-	}
-
-	while (true) {
-		const enum argpar_iter_next_status status =
-			argpar_iter_next(iter, &item, &parse_ret.error);
-
-		switch (status) {
-		case ARGPAR_ITER_NEXT_STATUS_ERROR_MISSING_OPT_ARG:
-		case ARGPAR_ITER_NEXT_STATUS_ERROR_INVALID_ARG:
-		case ARGPAR_ITER_NEXT_STATUS_ERROR_UNEXPECTED_OPT_ARG:
-		case ARGPAR_ITER_NEXT_STATUS_ERROR_MEMORY:
-			goto error;
-		case ARGPAR_ITER_NEXT_STATUS_ERROR_UNKNOWN_OPT:
-			if (fail_on_unknown_opt) {
-				parse_ret.ingested_orig_args =
-					argpar_iter_ingested_orig_args(iter);
-				goto error;
-			}
-
-			free(parse_ret.error);
-			parse_ret.error = NULL;
-			goto success;
-		case ARGPAR_ITER_NEXT_STATUS_END:
-			goto success;
-		default:
-			ARGPAR_ASSERT(status == ARGPAR_ITER_NEXT_STATUS_OK);
-			break;
-		}
-
-		if (!push_item(parse_ret.items, item)) {
-			goto error;
-		}
-
-		item = NULL;
-	}
-
-success:
-	ARGPAR_ASSERT(!parse_ret.error);
-	parse_ret.ingested_orig_args = argpar_iter_ingested_orig_args(iter);
-	goto end;
-
-error:
-	ARGPAR_ASSERT(parse_ret.error);
-
-	/* That's how we indicate that an error occurred */
-	destroy_item_array(parse_ret.items);
-	parse_ret.items = NULL;
-
-end:
-	argpar_iter_destroy(iter);
-	argpar_item_destroy(item);
-	return parse_ret;
-}
-
-ARGPAR_HIDDEN
-void argpar_parse_ret_fini(struct argpar_parse_ret * const ret)
-{
-	ARGPAR_ASSERT(ret);
-	destroy_item_array(ret->items);
-	ret->items = NULL;
-	free(ret->error);
-	ret->error = NULL;
-}