From 1ae22b5e8335dfe14b805404a16b90817f1a99e1 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sun, 15 Mar 2020 15:36:10 -0400 Subject: [PATCH] Add format attributes to functions with format strings Compiling with -Wsuggest-attribute=format shows that these functions could use a format attribute, which helps the compiler validate format strings. This patch adds them. Signed-off-by: Simon Marchi Change-Id: I2884d13b08d9ea67680289e59fb40ebdfecdc3d4 --- argpar/argpar.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/argpar/argpar.c b/argpar/argpar.c index b8b7c63..13f6681 100644 --- a/argpar/argpar.c +++ b/argpar/argpar.c @@ -35,7 +35,13 @@ #define ARGPAR_ASSERT(_cond) assert(_cond) -static +#ifdef __MINGW_PRINTF_FORMAT +# define ARGPAR_PRINTF_FORMAT __MINGW_PRINTF_FORMAT +#else +# define ARGPAR_PRINTF_FORMAT printf +#endif + +static __attribute__((format(ARGPAR_PRINTF_FORMAT, 1, 0))) char *argpar_vasprintf(const char *fmt, va_list args) { int len1, len2; @@ -65,7 +71,7 @@ end: } -static +static __attribute__((format(ARGPAR_PRINTF_FORMAT, 1, 2))) char *argpar_asprintf(const char *fmt, ...) { va_list args; @@ -78,7 +84,7 @@ char *argpar_asprintf(const char *fmt, ...) return str; } -static +static __attribute__((format(ARGPAR_PRINTF_FORMAT, 2, 3))) bool argpar_string_append_printf(char **str, const char *fmt, ...) { char *new_str = NULL; -- 2.34.1