[babeltrace.git] / src / plugins / ctf / lttng-live / data-stream.c

/*
 * Copyright 2019 Francis Deslauriers <francis.deslauriers@efficios.com>
 * Copyright 2016 - Philippe Proulx <pproulx@efficios.com>
 * Copyright 2016 - Jérémie Galarneau <jeremie.galarneau@efficios.com>
 * Copyright 2010-2011 - EfficiOS Inc. and Linux Foundation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

#define BT_COMP_LOG_SELF_COMP self_comp
#define BT_LOG_OUTPUT_LEVEL log_level
#define BT_LOG_TAG "PLUGIN/SRC.CTF.LTTNG-LIVE/DS"
#include "plugins/comp-logging.h"

#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>
#include <stdbool.h>
#include <glib.h>
#include <inttypes.h>
#include "compat/mman.h"
#include <babeltrace2/babeltrace.h>
#include "../common/msg-iter/msg-iter.h"
#include "common/assert.h"

#include "data-stream.h"

#define STREAM_NAME_PREFIX	"stream-"

static
enum bt_msg_iter_medium_status medop_request_bytes(
		size_t request_sz, uint8_t **buffer_addr,
		size_t *buffer_sz, void *data)
{
	enum bt_msg_iter_medium_status status =
		BT_MSG_ITER_MEDIUM_STATUS_OK;
	struct lttng_live_stream_iterator *stream = data;
	struct lttng_live_trace *trace = stream->trace;
	struct lttng_live_session *session = trace->session;
	struct lttng_live_msg_iter *live_msg_iter = session->lttng_live_msg_iter;
	uint64_t recv_len = 0;
	uint64_t len_left;
	uint64_t read_len;

	len_left = stream->base_offset + stream->len - stream->offset;
	if (!len_left) {
		stream->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA;
		status = BT_MSG_ITER_MEDIUM_STATUS_AGAIN;
		return status;
	}
	read_len = MIN(request_sz, stream->buflen);
	read_len = MIN(read_len, len_left);
	status = lttng_live_get_stream_bytes(live_msg_iter,
			stream, stream->buf, stream->offset,
			read_len, &recv_len);
	*buffer_addr = stream->buf;
	*buffer_sz = recv_len;
	stream->offset += recv_len;
	return status;
}

static
bt_stream *medop_borrow_stream(bt_stream_class *stream_class,
		int64_t stream_id, void *data)
{
	struct lttng_live_stream_iterator *lttng_live_stream = data;
	bt_logging_level log_level = lttng_live_stream->log_level;
	bt_self_component *self_comp = lttng_live_stream->self_comp;

	if (!lttng_live_stream->stream) {
		uint64_t stream_class_id = bt_stream_class_get_id(stream_class);

		BT_COMP_LOGI("Creating stream %s (ID: %" PRIu64 ") out of stream "
			"class %" PRId64, lttng_live_stream->name->str,
			stream_id, stream_class_id);

		if (stream_id < 0) {
			/*
			 * No stream instance ID in the stream. It's possible
			 * to encounter this situation with older version of
			 * LTTng. In these cases, use the viewer_stream_id that
			 * is unique for a live viewer session.
			 */
			lttng_live_stream->stream = bt_stream_create_with_id(
				stream_class, lttng_live_stream->trace->trace,
				lttng_live_stream->viewer_stream_id);
		} else {
			lttng_live_stream->stream = bt_stream_create_with_id(
				stream_class, lttng_live_stream->trace->trace,
				(uint64_t) stream_id);
		}

		if (!lttng_live_stream->stream) {
			BT_COMP_LOGE("Cannot create stream %s (stream class ID "
				"%" PRId64 ", stream ID %" PRIu64 ")",
				lttng_live_stream->name->str,
				stream_class_id, stream_id);
			goto end;
		}

		bt_stream_set_name(lttng_live_stream->stream,
			lttng_live_stream->name->str);
	}

end:
	return lttng_live_stream->stream;
}

static struct bt_msg_iter_medium_ops medops = {
	.request_bytes = medop_request_bytes,
	.seek = NULL,
	.borrow_stream = medop_borrow_stream,
};

BT_HIDDEN
enum lttng_live_iterator_status lttng_live_lazy_msg_init(
		struct lttng_live_session *session)
{
	struct lttng_live_component *lttng_live =
		session->lttng_live_msg_iter->lttng_live_comp;
	uint64_t trace_idx, stream_iter_idx;
	bt_logging_level log_level = session->log_level;
	bt_self_component *self_comp = session->self_comp;

	if (!session->lazy_stream_msg_init) {
		return LTTNG_LIVE_ITERATOR_STATUS_OK;
	}

	for (trace_idx = 0; trace_idx < session->traces->len; trace_idx++) {
		struct lttng_live_trace *trace =
			g_ptr_array_index(session->traces, trace_idx);

		for (stream_iter_idx = 0;
				stream_iter_idx < trace->stream_iterators->len;
				stream_iter_idx++) {
			struct ctf_trace_class *ctf_tc;
			struct lttng_live_stream_iterator *stream_iter =
				g_ptr_array_index(trace->stream_iterators,
						stream_iter_idx);

			if (stream_iter->msg_iter) {
				continue;
			}
			ctf_tc = ctf_metadata_decoder_borrow_ctf_trace_class(
						trace->metadata->decoder);
			stream_iter->msg_iter = bt_msg_iter_create(ctf_tc,
					lttng_live->max_query_size, medops,
					stream_iter, log_level, self_comp);
			if (!stream_iter->msg_iter) {
				goto error;
			}
		}
	}

	session->lazy_stream_msg_init = false;

	return LTTNG_LIVE_ITERATOR_STATUS_OK;

error:
	return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
}

BT_HIDDEN
struct lttng_live_stream_iterator *lttng_live_stream_iterator_create(
		struct lttng_live_session *session,
		uint64_t ctf_trace_id,
		uint64_t stream_id)
{
	struct lttng_live_stream_iterator *stream_iter;
	struct lttng_live_component *lttng_live;
	struct lttng_live_trace *trace;
	bt_logging_level log_level;
	bt_self_component *self_comp;

	BT_ASSERT(session);
	BT_ASSERT(session->lttng_live_msg_iter);
	BT_ASSERT(session->lttng_live_msg_iter->lttng_live_comp);
	log_level = session->log_level;
	self_comp = session->self_comp;

	lttng_live = session->lttng_live_msg_iter->lttng_live_comp;

	stream_iter = g_new0(struct lttng_live_stream_iterator, 1);
	if (!stream_iter) {
		goto error;
	}

	stream_iter->log_level = log_level;
	stream_iter->self_comp = self_comp;
	trace = lttng_live_borrow_trace(session, ctf_trace_id);
	if (!trace) {
		goto error;
	}

	stream_iter->trace = trace;
	stream_iter->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA;
	stream_iter->viewer_stream_id = stream_id;
	stream_iter->ctf_stream_class_id = -1ULL;
	stream_iter->last_inactivity_ts = INT64_MIN;

	if (trace->trace) {
		struct ctf_trace_class *ctf_tc =
			ctf_metadata_decoder_borrow_ctf_trace_class(
					trace->metadata->decoder);
		BT_ASSERT(!stream_iter->msg_iter);
		stream_iter->msg_iter = bt_msg_iter_create(ctf_tc,
				lttng_live->max_query_size, medops,
				stream_iter, log_level, self_comp);
		if (!stream_iter->msg_iter) {
			goto error;
		}
	}
	stream_iter->buf = g_new0(uint8_t, lttng_live->max_query_size);
	if (!stream_iter->buf) {
		goto error;
	}

	stream_iter->buflen = lttng_live->max_query_size;
	stream_iter->name = g_string_new(NULL);
	if (!stream_iter->name) {
		goto error;
	}

	g_string_printf(stream_iter->name, STREAM_NAME_PREFIX "%" PRIu64,
			stream_iter->viewer_stream_id);
	g_ptr_array_add(trace->stream_iterators, stream_iter);

	/* Track the number of active stream iterator. */
	session->lttng_live_msg_iter->active_stream_iter++;

	goto end;
error:
	lttng_live_stream_iterator_destroy(stream_iter);
	stream_iter = NULL;
end:
	return stream_iter;
}

BT_HIDDEN
void lttng_live_stream_iterator_destroy(
		struct lttng_live_stream_iterator *stream_iter)
{
	if (!stream_iter) {
		return;
	}

	if (stream_iter->stream) {
		BT_STREAM_PUT_REF_AND_RESET(stream_iter->stream);
	}

	if (stream_iter->msg_iter) {
		bt_msg_iter_destroy(stream_iter->msg_iter);
	}
	if (stream_iter->buf) {
		g_free(stream_iter->buf);
	}
	if (stream_iter->name) {
		g_string_free(stream_iter->name, TRUE);
	}

	bt_message_put_ref(stream_iter->current_msg);

	/* Track the number of active stream iterator. */
	stream_iter->trace->session->lttng_live_msg_iter->active_stream_iter--;

	/*
	 * Ensure we poke the trace metadata in the future, which is
	 * required to release the metadata reference on the trace.
	 */
	stream_iter->trace->new_metadata_needed = true;
	g_free(stream_iter);
}
Commit	Line	Data
7cdc2bab	1	/*
14f28187	2	* Copyright 2019 Francis Deslauriers <francis.deslauriers@efficios.com>
7cdc2bab MD	3	* Copyright 2016 - Philippe Proulx <pproulx@efficios.com>
	4	* Copyright 2016 - Jérémie Galarneau <jeremie.galarneau@efficios.com>
	5	* Copyright 2010-2011 - EfficiOS Inc. and Linux Foundation
	6	*
	7	* Permission is hereby granted, free of charge, to any person obtaining a copy
	8	* of this software and associated documentation files (the "Software"), to deal
	9	* in the Software without restriction, including without limitation the rights
	10	* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
	11	* copies of the Software, and to permit persons to whom the Software is
	12	* furnished to do so, subject to the following conditions:
	13	*
	14	* The above copyright notice and this permission notice shall be included in
	15	* all copies or substantial portions of the Software.
	16	*
	17	* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	18	* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	19	* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
	20	* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	21	* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
	22	* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
	23	* SOFTWARE.
	24	*/
	25
2ece7dd0	26	#define BT_COMP_LOG_SELF_COMP self_comp
c01594de	27	#define BT_LOG_OUTPUT_LEVEL log_level
350ad6c1	28	#define BT_LOG_TAG "PLUGIN/SRC.CTF.LTTNG-LIVE/DS"
2ece7dd0	29	#include "plugins/comp-logging.h"
020bc26f	30
7cdc2bab MD	31	#include <stdio.h>
	32	#include <stdint.h>
	33	#include <stdlib.h>
	34	#include <stdbool.h>
	35	#include <glib.h>
	36	#include <inttypes.h>
578e048b	37	#include "compat/mman.h"
3fadfbc0	38	#include <babeltrace2/babeltrace.h>
d6e69534	39	#include "../common/msg-iter/msg-iter.h"
578e048b	40	#include "common/assert.h"
7cdc2bab	41
087bc060	42	#include "data-stream.h"
7cdc2bab	43
14f28187 FD	44	#define STREAM_NAME_PREFIX "stream-"
14f28187 FD	45
7cdc2bab	46	static
d6e69534	47	enum bt_msg_iter_medium_status medop_request_bytes(
7cdc2bab MD	48	size_t request_sz, uint8_t **buffer_addr,
	49	size_t buffer_sz, void data)
	50	{
d6e69534 PP	51	enum bt_msg_iter_medium_status status =
d6e69534 PP	52	BT_MSG_ITER_MEDIUM_STATUS_OK;
7cdc2bab MD	53	struct lttng_live_stream_iterator *stream = data;
	54	struct lttng_live_trace *trace = stream->trace;
	55	struct lttng_live_session *session = trace->session;
14f28187	56	struct lttng_live_msg_iter *live_msg_iter = session->lttng_live_msg_iter;
7cdc2bab MD	57	uint64_t recv_len = 0;
	58	uint64_t len_left;
	59	uint64_t read_len;
7cdc2bab MD	60
	61	len_left = stream->base_offset + stream->len - stream->offset;
	62	if (!len_left) {
	63	stream->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA;
d6e69534	64	status = BT_MSG_ITER_MEDIUM_STATUS_AGAIN;
7cdc2bab MD	65	return status;
	66	}
	67	read_len = MIN(request_sz, stream->buflen);
	68	read_len = MIN(read_len, len_left);
14f28187	69	status = lttng_live_get_stream_bytes(live_msg_iter,
7cdc2bab MD	70	stream, stream->buf, stream->offset,
7cdc2bab MD	71	read_len, &recv_len);
7cdc2bab MD	72	*buffer_addr = stream->buf;
	73	*buffer_sz = recv_len;
	74	stream->offset += recv_len;
	75	return status;
	76	}
	77
	78	static
14f28187 FD	79	bt_stream medop_borrow_stream(bt_stream_class stream_class,
14f28187 FD	80	int64_t stream_id, void *data)
7cdc2bab MD	81	{
7cdc2bab MD	82	struct lttng_live_stream_iterator *lttng_live_stream = data;
c01594de	83	bt_logging_level log_level = lttng_live_stream->log_level;
2ece7dd0	84	bt_self_component *self_comp = lttng_live_stream->self_comp;
7cdc2bab MD	85
7cdc2bab MD	86	if (!lttng_live_stream->stream) {
14f28187	87	uint64_t stream_class_id = bt_stream_class_get_id(stream_class);
b92735af	88
2ece7dd0	89	BT_COMP_LOGI("Creating stream %s (ID: %" PRIu64 ") out of stream "
14f28187 FD	90	"class %" PRId64, lttng_live_stream->name->str,
14f28187 FD	91	stream_id, stream_class_id);
b92735af	92
14f28187 FD	93	if (stream_id < 0) {
	94	/*
	95	* No stream instance ID in the stream. It's possible
	96	* to encounter this situation with older version of
	97	* LTTng. In these cases, use the viewer_stream_id that
	98	* is unique for a live viewer session.
	99	*/
	100	lttng_live_stream->stream = bt_stream_create_with_id(
	101	stream_class, lttng_live_stream->trace->trace,
	102	lttng_live_stream->viewer_stream_id);
b92735af	103	} else {
14f28187 FD	104	lttng_live_stream->stream = bt_stream_create_with_id(
	105	stream_class, lttng_live_stream->trace->trace,
	106	(uint64_t) stream_id);
b92735af	107	}
7cdc2bab	108
7cdc2bab	109	if (!lttng_live_stream->stream) {
2ece7dd0	110	BT_COMP_LOGE("Cannot create stream %s (stream class ID "
14f28187 FD	111	"%" PRId64 ", stream ID %" PRIu64 ")",
	112	lttng_live_stream->name->str,
	113	stream_class_id, stream_id);
b80991f6	114	goto end;
7cdc2bab	115	}
b80991f6	116
14f28187 FD	117	bt_stream_set_name(lttng_live_stream->stream,
14f28187 FD	118	lttng_live_stream->name->str);
7cdc2bab MD	119	}
7cdc2bab MD	120
b80991f6	121	end:
7cdc2bab MD	122	return lttng_live_stream->stream;
	123	}
	124
d6e69534	125	static struct bt_msg_iter_medium_ops medops = {
7cdc2bab	126	.request_bytes = medop_request_bytes,
14f28187 FD	127	.seek = NULL,
14f28187 FD	128	.borrow_stream = medop_borrow_stream,
7cdc2bab MD	129	};
	130
	131	BT_HIDDEN
14f28187	132	enum lttng_live_iterator_status lttng_live_lazy_msg_init(
7cdc2bab MD	133	struct lttng_live_session *session)
7cdc2bab MD	134	{
14f28187 FD	135	struct lttng_live_component *lttng_live =
	136	session->lttng_live_msg_iter->lttng_live_comp;
	137	uint64_t trace_idx, stream_iter_idx;
c01594de	138	bt_logging_level log_level = session->log_level;
2ece7dd0	139	bt_self_component *self_comp = session->self_comp;
7cdc2bab	140
d6e69534	141	if (!session->lazy_stream_msg_init) {
14f28187	142	return LTTNG_LIVE_ITERATOR_STATUS_OK;
7cdc2bab MD	143	}
7cdc2bab MD	144
14f28187 FD	145	for (trace_idx = 0; trace_idx < session->traces->len; trace_idx++) {
	146	struct lttng_live_trace *trace =
	147	g_ptr_array_index(session->traces, trace_idx);
	148
	149	for (stream_iter_idx = 0;
	150	stream_iter_idx < trace->stream_iterators->len;
	151	stream_iter_idx++) {
	152	struct ctf_trace_class *ctf_tc;
	153	struct lttng_live_stream_iterator *stream_iter =
	154	g_ptr_array_index(trace->stream_iterators,
	155	stream_iter_idx);
7cdc2bab	156
14f28187	157	if (stream_iter->msg_iter) {
7cdc2bab MD	158	continue;
7cdc2bab MD	159	}
14f28187 FD	160	ctf_tc = ctf_metadata_decoder_borrow_ctf_trace_class(
	161	trace->metadata->decoder);
	162	stream_iter->msg_iter = bt_msg_iter_create(ctf_tc,
7cdc2bab	163	lttng_live->max_query_size, medops,
2ece7dd0	164	stream_iter, log_level, self_comp);
14f28187	165	if (!stream_iter->msg_iter) {
7cdc2bab MD	166	goto error;
	167	}
	168	}
	169	}
	170
d6e69534	171	session->lazy_stream_msg_init = false;
7cdc2bab	172
14f28187	173	return LTTNG_LIVE_ITERATOR_STATUS_OK;
7cdc2bab MD	174
7cdc2bab MD	175	error:
14f28187	176	return LTTNG_LIVE_ITERATOR_STATUS_ERROR;
7cdc2bab MD	177	}
	178
	179	BT_HIDDEN
	180	struct lttng_live_stream_iterator *lttng_live_stream_iterator_create(
	181	struct lttng_live_session *session,
	182	uint64_t ctf_trace_id,
	183	uint64_t stream_id)
	184	{
14f28187 FD	185	struct lttng_live_stream_iterator *stream_iter;
14f28187 FD	186	struct lttng_live_component *lttng_live;
7cdc2bab	187	struct lttng_live_trace *trace;
c01594de	188	bt_logging_level log_level;
2ece7dd0	189	bt_self_component *self_comp;
7cdc2bab	190
14f28187 FD	191	BT_ASSERT(session);
	192	BT_ASSERT(session->lttng_live_msg_iter);
	193	BT_ASSERT(session->lttng_live_msg_iter->lttng_live_comp);
c01594de	194	log_level = session->log_level;
2ece7dd0	195	self_comp = session->self_comp;
14f28187 FD	196
	197	lttng_live = session->lttng_live_msg_iter->lttng_live_comp;
	198
	199	stream_iter = g_new0(struct lttng_live_stream_iterator, 1);
	200	if (!stream_iter) {
	201	goto error;
	202	}
	203
c01594de	204	stream_iter->log_level = log_level;
2ece7dd0	205	stream_iter->self_comp = self_comp;
14f28187	206	trace = lttng_live_borrow_trace(session, ctf_trace_id);
7cdc2bab MD	207	if (!trace) {
	208	goto error;
	209	}
	210
14f28187 FD	211	stream_iter->trace = trace;
	212	stream_iter->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA;
	213	stream_iter->viewer_stream_id = stream_id;
	214	stream_iter->ctf_stream_class_id = -1ULL;
	215	stream_iter->last_inactivity_ts = INT64_MIN;
7cdc2bab MD	216
7cdc2bab MD	217	if (trace->trace) {
14f28187 FD	218	struct ctf_trace_class *ctf_tc =
	219	ctf_metadata_decoder_borrow_ctf_trace_class(
	220	trace->metadata->decoder);
	221	BT_ASSERT(!stream_iter->msg_iter);
	222	stream_iter->msg_iter = bt_msg_iter_create(ctf_tc,
7cdc2bab	223	lttng_live->max_query_size, medops,
2ece7dd0	224	stream_iter, log_level, self_comp);
14f28187	225	if (!stream_iter->msg_iter) {
7cdc2bab MD	226	goto error;
	227	}
	228	}
14f28187 FD	229	stream_iter->buf = g_new0(uint8_t, lttng_live->max_query_size);
	230	if (!stream_iter->buf) {
	231	goto error;
	232	}
7cdc2bab	233
14f28187 FD	234	stream_iter->buflen = lttng_live->max_query_size;
	235	stream_iter->name = g_string_new(NULL);
	236	if (!stream_iter->name) {
	237	goto error;
	238	}
	239
	240	g_string_printf(stream_iter->name, STREAM_NAME_PREFIX "%" PRIu64,
	241	stream_iter->viewer_stream_id);
	242	g_ptr_array_add(trace->stream_iterators, stream_iter);
7cdc2bab	243
14f28187 FD	244	/* Track the number of active stream iterator. */
14f28187 FD	245	session->lttng_live_msg_iter->active_stream_iter++;
7cdc2bab MD	246
	247	goto end;
	248	error:
14f28187 FD	249	lttng_live_stream_iterator_destroy(stream_iter);
14f28187 FD	250	stream_iter = NULL;
7cdc2bab	251	end:
14f28187	252	return stream_iter;
7cdc2bab MD	253	}
	254
	255	BT_HIDDEN
14f28187 FD	256	void lttng_live_stream_iterator_destroy(
14f28187 FD	257	struct lttng_live_stream_iterator *stream_iter)
7cdc2bab	258	{
14f28187	259	if (!stream_iter) {
7cdc2bab MD	260	return;
	261	}
	262
14f28187 FD	263	if (stream_iter->stream) {
14f28187 FD	264	BT_STREAM_PUT_REF_AND_RESET(stream_iter->stream);
7cdc2bab MD	265	}
7cdc2bab MD	266
14f28187 FD	267	if (stream_iter->msg_iter) {
14f28187 FD	268	bt_msg_iter_destroy(stream_iter->msg_iter);
7cdc2bab	269	}
14f28187 FD	270	if (stream_iter->buf) {
	271	g_free(stream_iter->buf);
	272	}
	273	if (stream_iter->name) {
	274	g_string_free(stream_iter->name, TRUE);
	275	}
	276
	277	bt_message_put_ref(stream_iter->current_msg);
	278
	279	/* Track the number of active stream iterator. */
	280	stream_iter->trace->session->lttng_live_msg_iter->active_stream_iter--;
	281
7cdc2bab MD	282	/*
	283	* Ensure we poke the trace metadata in the future, which is
	284	* required to release the metadata reference on the trace.
	285	*/
14f28187 FD	286	stream_iter->trace->new_metadata_needed = true;
14f28187 FD	287	g_free(stream_iter);
7cdc2bab	288	}