Fix: handle EINTR return value for bt_posix_fallocate
[babeltrace.git] / formats / ctf / ctf.c
index 69917f7fb5d9cfc8dcaf246128f77d93557d7c6d..9cb19f4dc323159be1da0bb8e4b00b3526577ffd 100644 (file)
  *
  * The above copyright notice and this permission notice shall be included in
  * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
  */
 
 #include <babeltrace/format.h>
@@ -25,8 +33,9 @@
 #include <babeltrace/ctf/events-internal.h>
 #include <babeltrace/trace-handle-internal.h>
 #include <babeltrace/context-internal.h>
-#include <babeltrace/uuid.h>
+#include <babeltrace/compat/uuid.h>
 #include <babeltrace/endian.h>
+#include <babeltrace/ctf/ctf-index.h>
 #include <inttypes.h>
 #include <stdio.h>
 #include <sys/mman.h>
 #include "metadata/ctf-parser.h"
 #include "metadata/ctf-ast.h"
 #include "events-private.h"
-#include "memstream.h"
+#include <babeltrace/compat/memstream.h>
+#include <babeltrace/compat/fcntl.h>
+
+#define LOG2_CHAR_BIT  3
+
+/*
+ * Length of first attempt at mapping a packet header, in bits.
+ */
+#define DEFAULT_HEADER_LEN     (getpagesize() * CHAR_BIT)
 
 /*
- * We currently simply map a page to read the packet header and packet
- * context to get the packet length and content length. (in bits)
+ * Lenght of packet to write, in bits.
  */
-#define MAX_PACKET_HEADER_LEN  (getpagesize() * CHAR_BIT)
 #define WRITE_PACKET_LEN       (getpagesize() * 8 * CHAR_BIT)
 
 #ifndef min
 
 #define NSEC_PER_SEC 1000000000ULL
 
+#define INDEX_PATH "./index/%s.idx"
+
 int opt_clock_cycles,
        opt_clock_seconds,
        opt_clock_date,
        opt_clock_gmt;
 
 uint64_t opt_clock_offset;
+uint64_t opt_clock_offset_ns;
 
 extern int yydebug;
 
+/*
+ * TODO: babeltrace_ctf_console_output ensures that we only print
+ * discarded events when ctf-text plugin is used. Should be cleaned up
+ * with the plugin system redesign.
+ */
+int babeltrace_ctf_console_output;
+
 static
-struct trace_descriptor *ctf_open_trace(const char *path, int flags,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+struct bt_trace_descriptor *ctf_open_trace(const char *path, int flags,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence),
                FILE *metadata_fp);
 static
-struct trace_descriptor *ctf_open_mmap_trace(
-               struct mmap_stream_list *mmap_list,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+struct bt_trace_descriptor *ctf_open_mmap_trace(
+               struct bt_mmap_stream_list *mmap_list,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence),
                FILE *metadata_fp);
 static
-void ctf_set_context(struct trace_descriptor *descriptor,
+void ctf_set_context(struct bt_trace_descriptor *descriptor,
                struct bt_context *ctx);
 static
-void ctf_set_handle(struct trace_descriptor *descriptor,
+void ctf_set_handle(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle);
 
 static
-void ctf_close_trace(struct trace_descriptor *descriptor);
+int ctf_close_trace(struct bt_trace_descriptor *descriptor);
 static
-uint64_t ctf_timestamp_begin(struct trace_descriptor *descriptor,
+uint64_t ctf_timestamp_begin(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle, enum bt_clock_type type);
 static
-uint64_t ctf_timestamp_end(struct trace_descriptor *descriptor,
+uint64_t ctf_timestamp_end(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle, enum bt_clock_type type);
 static
-int ctf_convert_index_timestamp(struct trace_descriptor *tdp);
+int ctf_convert_index_timestamp(struct bt_trace_descriptor *tdp);
 
 static
 rw_dispatch read_dispatch_table[] = {
@@ -121,7 +146,7 @@ rw_dispatch write_dispatch_table[] = {
 };
 
 static
-struct format ctf_format = {
+struct bt_format ctf_format = {
        .open_trace = ctf_open_trace,
        .open_mmap_trace = ctf_open_mmap_trace,
        .close_trace = ctf_close_trace,
@@ -133,7 +158,7 @@ struct format ctf_format = {
 };
 
 static
-uint64_t ctf_timestamp_begin(struct trace_descriptor *descriptor,
+uint64_t ctf_timestamp_begin(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle, enum bt_clock_type type)
 {
        struct ctf_trace *tin;
@@ -164,26 +189,24 @@ uint64_t ctf_timestamp_begin(struct trace_descriptor *descriptor,
                                        parent);
                        stream_pos = &cfs->pos;
 
-                       if (!stream_pos->packet_real_index)
+                       if (!stream_pos->packet_index)
                                goto error;
 
-                       if (stream_pos->packet_real_index->len <= 0)
+                       if (stream_pos->packet_index->len <= 0)
                                continue;
 
+                       index = &g_array_index(stream_pos->packet_index,
+                                       struct packet_index,
+                                       stream_pos->packet_index->len - 1);
                        if (type == BT_CLOCK_REAL) {
-                               index = &g_array_index(stream_pos->packet_real_index,
-                                               struct packet_index,
-                                               stream_pos->packet_real_index->len - 1);
+                               if (index->ts_real.timestamp_begin < begin)
+                                       begin = index->ts_real.timestamp_begin;
                        } else if (type == BT_CLOCK_CYCLES) {
-                               index = &g_array_index(stream_pos->packet_cycles_index,
-                                               struct packet_index,
-                                               stream_pos->packet_real_index->len - 1);
-
+                               if (index->ts_cycles.timestamp_begin < begin)
+                                       begin = index->ts_cycles.timestamp_begin;
                        } else {
                                goto error;
                        }
-                       if (index->timestamp_begin < begin)
-                               begin = index->timestamp_begin;
                }
        }
 
@@ -194,7 +217,7 @@ error:
 }
 
 static
-uint64_t ctf_timestamp_end(struct trace_descriptor *descriptor,
+uint64_t ctf_timestamp_end(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle, enum bt_clock_type type)
 {
        struct ctf_trace *tin;
@@ -225,26 +248,24 @@ uint64_t ctf_timestamp_end(struct trace_descriptor *descriptor,
                                        parent);
                        stream_pos = &cfs->pos;
 
-                       if (!stream_pos->packet_real_index)
+                       if (!stream_pos->packet_index)
                                goto error;
 
-                       if (stream_pos->packet_real_index->len <= 0)
+                       if (stream_pos->packet_index->len <= 0)
                                continue;
 
+                       index = &g_array_index(stream_pos->packet_index,
+                                       struct packet_index,
+                                       stream_pos->packet_index->len - 1);
                        if (type == BT_CLOCK_REAL) {
-                               index = &g_array_index(stream_pos->packet_real_index,
-                                               struct packet_index,
-                                               stream_pos->packet_real_index->len - 1);
+                               if (index->ts_real.timestamp_end > end)
+                                       end = index->ts_real.timestamp_end;
                        } else if (type == BT_CLOCK_CYCLES) {
-                               index = &g_array_index(stream_pos->packet_cycles_index,
-                                               struct packet_index,
-                                               stream_pos->packet_real_index->len - 1);
-
+                               if (index->ts_cycles.timestamp_end > end)
+                                       end = index->ts_cycles.timestamp_end;
                        } else {
                                goto error;
                        }
-                       if (index->timestamp_end > end)
-                               end = index->timestamp_end;
                }
        }
 
@@ -266,10 +287,7 @@ void ctf_update_timestamp(struct ctf_stream_definition *stream,
        uint64_t oldval, newval, updateval;
 
        if (unlikely(integer_declaration->len == 64)) {
-               stream->prev_cycles_timestamp = stream->cycles_timestamp;
                stream->cycles_timestamp = integer_definition->value._unsigned;
-               stream->prev_real_timestamp = ctf_get_real_timestamp(stream,
-                               stream->prev_cycles_timestamp);
                stream->real_timestamp = ctf_get_real_timestamp(stream,
                                stream->cycles_timestamp);
                return;
@@ -285,12 +303,9 @@ void ctf_update_timestamp(struct ctf_stream_definition *stream,
        updateval = stream->cycles_timestamp;
        updateval &= ~((1ULL << integer_declaration->len) - 1);
        updateval += newval;
-       stream->prev_cycles_timestamp = stream->cycles_timestamp;
        stream->cycles_timestamp = updateval;
 
        /* convert to real timestamp */
-       stream->prev_real_timestamp = ctf_get_real_timestamp(stream,
-                       stream->prev_cycles_timestamp);
        stream->real_timestamp = ctf_get_real_timestamp(stream,
                        stream->cycles_timestamp);
 }
@@ -299,6 +314,7 @@ void ctf_update_timestamp(struct ctf_stream_definition *stream,
  * Print timestamp, rescaling clock frequency to nanoseconds and
  * applying offsets as needed (unix time).
  */
+static
 void ctf_print_timestamp_real(FILE *fp,
                        struct ctf_stream_definition *stream,
                        uint64_t timestamp)
@@ -307,6 +323,9 @@ void ctf_print_timestamp_real(FILE *fp,
 
        ts_nsec = timestamp;
 
+       /* Add command-line offset in ns*/
+        ts_nsec += opt_clock_offset_ns;
+
        /* Add command-line offset */
        ts_sec += opt_clock_offset;
 
@@ -363,6 +382,7 @@ end:
 /*
  * Print timestamp, in cycles
  */
+static
 void ctf_print_timestamp_cycles(FILE *fp,
                struct ctf_stream_definition *stream,
                uint64_t timestamp)
@@ -382,7 +402,65 @@ void ctf_print_timestamp(FILE *fp,
 }
 
 static
-int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream)
+void print_uuid(FILE *fp, unsigned char *uuid)
+{
+       int i;
+
+       for (i = 0; i < BABELTRACE_UUID_LEN; i++)
+               fprintf(fp, "%x", (unsigned int) uuid[i]);
+}
+
+/*
+ * Discarded events can be either:
+ * - discarded after end of previous buffer due to buffer full:
+ *     happened within range: [ prev_timestamp_end, timestamp_begin ]
+ * - discarded within current buffer due to either event too large or
+ *   nested wrap-around:
+ *     happened within range: [ timestamp_begin, timestamp_end ]
+ *
+ * Given we have discarded counters of those two types merged into the
+ * events_discarded counter, we need to use the union of those ranges:
+ *   [ prev_timestamp_end, timestamp_end ]
+ */
+static
+void ctf_print_discarded(FILE *fp, struct ctf_stream_definition *stream)
+{
+       if (!stream->events_discarded || !babeltrace_ctf_console_output) {
+               return;
+       }
+       fflush(stdout);
+       fprintf(fp, "[warning] Tracer discarded %" PRIu64 " events between [",
+               stream->events_discarded);
+       if (opt_clock_cycles) {
+               ctf_print_timestamp(fp, stream,
+                               stream->prev.cycles.end);
+               fprintf(fp, "] and [");
+               ctf_print_timestamp(fp, stream,
+                               stream->current.cycles.end);
+       } else {
+               ctf_print_timestamp(fp, stream,
+                               stream->prev.real.end);
+               fprintf(fp, "] and [");
+               ctf_print_timestamp(fp, stream,
+                               stream->current.real.end);
+       }
+       fprintf(fp, "] in trace UUID ");
+       print_uuid(fp, stream->stream_class->trace->uuid);
+       if (stream->stream_class->trace->parent.path[0])
+               fprintf(fp, ", at path: \"%s\"",
+                       stream->stream_class->trace->parent.path);
+
+       fprintf(fp, ", within stream id %" PRIu64, stream->stream_id);
+       if (stream->path[0])
+               fprintf(fp, ", at relative path: \"%s\"", stream->path);
+       fprintf(fp, ". ");
+       fprintf(fp, "You should consider recording a new trace with larger "
+               "buffers or with fewer events enabled.\n");
+       fflush(fp);
+}
+
+static
+int ctf_read_event(struct bt_stream_pos *ppos, struct ctf_stream_definition *stream)
 {
        struct ctf_stream_pos *pos =
                container_of(ppos, struct ctf_stream_pos, parent);
@@ -406,32 +484,45 @@ int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream
         */
        if (unlikely(pos->offset == EOF))
                return EOF;
+
+       /* Stream is inactive for now (live reading). */
+       if (unlikely(pos->content_size == 0))
+               return EAGAIN;
+
+       /*
+        * Packet seeked to by ctf_pos_get_event() only contains
+        * headers, no event. Consider stream as inactive (live
+        * reading).
+        */
+       if (unlikely(pos->data_offset == pos->content_size))
+               return EAGAIN;
+
        assert(pos->offset < pos->content_size);
 
        /* Read event header */
        if (likely(stream->stream_event_header)) {
                struct definition_integer *integer_definition;
-               struct definition *variant;
+               struct bt_definition *variant;
 
                ret = generic_rw(ppos, &stream->stream_event_header->p);
                if (unlikely(ret))
                        goto error;
                /* lookup event id */
-               integer_definition = lookup_integer(&stream->stream_event_header->p, "id", FALSE);
+               integer_definition = bt_lookup_integer(&stream->stream_event_header->p, "id", FALSE);
                if (integer_definition) {
                        id = integer_definition->value._unsigned;
                } else {
                        struct definition_enum *enum_definition;
 
-                       enum_definition = lookup_enum(&stream->stream_event_header->p, "id", FALSE);
+                       enum_definition = bt_lookup_enum(&stream->stream_event_header->p, "id", FALSE);
                        if (enum_definition) {
                                id = enum_definition->integer->value._unsigned;
                        }
                }
 
-               variant = lookup_variant(&stream->stream_event_header->p, "v");
+               variant = bt_lookup_variant(&stream->stream_event_header->p, "v");
                if (variant) {
-                       integer_definition = lookup_integer(variant, "id", FALSE);
+                       integer_definition = bt_lookup_integer(variant, "id", FALSE);
                        if (integer_definition) {
                                id = integer_definition->value._unsigned;
                        }
@@ -440,13 +531,13 @@ int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream
 
                /* lookup timestamp */
                stream->has_timestamp = 0;
-               integer_definition = lookup_integer(&stream->stream_event_header->p, "timestamp", FALSE);
+               integer_definition = bt_lookup_integer(&stream->stream_event_header->p, "timestamp", FALSE);
                if (integer_definition) {
                        ctf_update_timestamp(stream, integer_definition);
                        stream->has_timestamp = 1;
                } else {
                        if (variant) {
-                               integer_definition = lookup_integer(variant, "timestamp", FALSE);
+                               integer_definition = bt_lookup_integer(variant, "timestamp", FALSE);
                                if (integer_definition) {
                                        ctf_update_timestamp(stream, integer_definition);
                                        stream->has_timestamp = 1;
@@ -486,15 +577,20 @@ int ctf_read_event(struct stream_pos *ppos, struct ctf_stream_definition *stream
                        goto error;
        }
 
+       if (pos->last_offset == pos->offset) {
+               fprintf(stderr, "[error] Invalid 0 byte event encountered.\n");
+               return -EINVAL;
+       }
+
        return 0;
 
 error:
-       fprintf(stderr, "[error] Unexpected end of stream. Either the trace data stream is corrupted or metadata description does not match data layout.\n");
+       fprintf(stderr, "[error] Unexpected end of packet. Either the trace data stream is corrupted or metadata description does not match data layout.\n");
        return ret;
 }
 
 static
-int ctf_write_event(struct stream_pos *pos, struct ctf_stream_definition *stream)
+int ctf_write_event(struct bt_stream_pos *pos, struct ctf_stream_definition *stream)
 {
        struct ctf_stream_declaration *stream_class = stream->stream_class;
        struct ctf_event_definition *event;
@@ -548,77 +644,236 @@ error:
        return ret;
 }
 
-void ctf_init_pos(struct ctf_stream_pos *pos, int fd, int open_flags)
+/*
+ * One side-effect of this function is to unmap pos mmap base if one is
+ * mapped.
+ */
+static
+int find_data_offset(struct ctf_stream_pos *pos,
+               struct ctf_file_stream *file_stream,
+               struct packet_index *packet_index)
 {
-       pos->fd = fd;
-       pos->mmap_offset = 0;
-       pos->packet_size = 0;
-       pos->content_size = 0;
-       pos->content_size_loc = NULL;
+       uint64_t packet_map_len = DEFAULT_HEADER_LEN, tmp_map_len;
+       struct stat filestats;
+       size_t filesize;
+       int ret;
+
+       pos = &file_stream->pos;
+
+       ret = fstat(pos->fd, &filestats);
+       if (ret < 0)
+               return ret;
+       filesize = filestats.st_size;
+
+       /* Deal with empty files */
+       if (!filesize) {
+               return 0;
+       }
+
+begin:
+       if (filesize - pos->mmap_offset < (packet_map_len >> LOG2_CHAR_BIT)) {
+               packet_map_len = (filesize - pos->mmap_offset) << LOG2_CHAR_BIT;
+       }
+
+       if (pos->base_mma) {
+               /* unmap old base */
+               ret = munmap_align(pos->base_mma);
+               if (ret) {
+                       fprintf(stderr, "[error] Unable to unmap old base: %s.\n",
+                                       strerror(errno));
+                       return ret;
+               }
+               pos->base_mma = NULL;
+       }
+       /* map new base. Need mapping length from header. */
+       pos->base_mma = mmap_align(packet_map_len >> LOG2_CHAR_BIT, PROT_READ,
+                       MAP_PRIVATE, pos->fd, pos->mmap_offset);
+       assert(pos->base_mma != MAP_FAILED);
+
+       pos->content_size = packet_map_len;
+       pos->packet_size = packet_map_len;
+       pos->offset = 0;        /* Position of the packet header */
+
+       /* update trace_packet_header and stream_packet_context */
+       if (pos->prot == PROT_READ && file_stream->parent.trace_packet_header) {
+               /* Read packet header */
+               ret = generic_rw(&pos->parent, &file_stream->parent.trace_packet_header->p);
+               if (ret) {
+                       if (ret == -EFAULT)
+                               goto retry;
+               }
+       }
+       if (pos->prot == PROT_READ && file_stream->parent.stream_packet_context) {
+               /* Read packet context */
+               ret = generic_rw(&pos->parent, &file_stream->parent.stream_packet_context->p);
+               if (ret) {
+                       if (ret == -EFAULT)
+                               goto retry;
+               }
+       }
+       packet_index->data_offset = pos->offset;
+
+       /* unmap old base */
+       ret = munmap_align(pos->base_mma);
+       if (ret) {
+               fprintf(stderr, "[error] Unable to unmap old base: %s.\n",
+                               strerror(errno));
+               return ret;
+       }
        pos->base_mma = NULL;
-       pos->offset = 0;
-       pos->dummy = false;
-       pos->cur_index = 0;
-       pos->packet_real_index = NULL;
-       if (fd >= 0)
-               pos->packet_cycles_index = g_array_new(FALSE, TRUE,
-                                               sizeof(struct packet_index));
-       else
-               pos->packet_cycles_index = NULL;
+
+       return 0;
+
+       /* Retry with larger mapping */
+retry:
+       if (packet_map_len == ((filesize - pos->mmap_offset) << LOG2_CHAR_BIT)) {
+               /*
+                * Reached EOF, but still expecting header/context data.
+                */
+               fprintf(stderr, "[error] Reached end of file, but still expecting header or context fields.\n");
+               return -EFAULT;
+       }
+       /* Double the mapping len, and retry */
+       tmp_map_len = packet_map_len << 1;
+       if (tmp_map_len >> 1 != packet_map_len) {
+               /* Overflow */
+               fprintf(stderr, "[error] Packet mapping length overflow\n");
+               return -EFAULT;
+       }
+       packet_map_len = tmp_map_len;
+       goto begin;
+}
+
+
+int ctf_init_pos(struct ctf_stream_pos *pos, struct bt_trace_descriptor *trace,
+               int fd, int open_flags)
+{
+       pos->fd = fd;
+       if (fd >= 0) {
+               pos->packet_index = g_array_new(FALSE, TRUE,
+                               sizeof(struct packet_index));
+       } else {
+               pos->packet_index = NULL;
+       }
        switch (open_flags & O_ACCMODE) {
        case O_RDONLY:
                pos->prot = PROT_READ;
                pos->flags = MAP_PRIVATE;
                pos->parent.rw_table = read_dispatch_table;
                pos->parent.event_cb = ctf_read_event;
+               pos->parent.trace = trace;
                break;
        case O_RDWR:
-               pos->prot = PROT_WRITE; /* Write has priority */
+               pos->prot = PROT_READ | PROT_WRITE;
                pos->flags = MAP_SHARED;
                pos->parent.rw_table = write_dispatch_table;
                pos->parent.event_cb = ctf_write_event;
+               pos->parent.trace = trace;
                if (fd >= 0)
                        ctf_packet_seek(&pos->parent, 0, SEEK_SET);     /* position for write */
                break;
        default:
                assert(0);
        }
+       return 0;
 }
 
-void ctf_fini_pos(struct ctf_stream_pos *pos)
+int ctf_fini_pos(struct ctf_stream_pos *pos)
 {
-       int ret;
-
-       if (pos->prot == PROT_WRITE && pos->content_size_loc)
+       if ((pos->prot & PROT_WRITE) && pos->content_size_loc)
                *pos->content_size_loc = pos->offset;
        if (pos->base_mma) {
+               int ret;
+
                /* unmap old base */
                ret = munmap_align(pos->base_mma);
                if (ret) {
                        fprintf(stderr, "[error] Unable to unmap old base: %s.\n",
                                strerror(errno));
-                       assert(0);
+                       return -1;
                }
        }
-       (void) g_array_free(pos->packet_cycles_index, TRUE);
-       (void) g_array_free(pos->packet_real_index, TRUE);
+       if (pos->packet_index)
+               (void) g_array_free(pos->packet_index, TRUE);
+       return 0;
+}
+
+void ctf_update_current_packet_index(struct ctf_stream_definition *stream,
+               struct packet_index *prev_index,
+               struct packet_index *cur_index)
+{
+       uint64_t events_discarded_diff;
+
+       /* Update packet index time information */
+
+       /* Current packet begin/end */
+       stream->current.real.begin =
+               cur_index->ts_real.timestamp_begin;
+       stream->current.cycles.begin =
+               cur_index->ts_cycles.timestamp_begin;
+       stream->current.real.end =
+               cur_index->ts_real.timestamp_end;
+       stream->current.cycles.end =
+               cur_index->ts_cycles.timestamp_end;
+
+       /* Update packet index discarded event information */
+       events_discarded_diff = cur_index->events_discarded;
+       if (prev_index) {
+               /* Previous packet begin/end */
+               stream->prev.cycles.begin =
+                       prev_index->ts_cycles.timestamp_begin;
+               stream->prev.real.begin =
+                       prev_index->ts_real.timestamp_begin;
+               stream->prev.cycles.end =
+                       prev_index->ts_cycles.timestamp_end;
+               stream->prev.real.end =
+                       prev_index->ts_real.timestamp_end;
+
+               events_discarded_diff -= prev_index->events_discarded;
+               /*
+                * Deal with 32-bit wrap-around if the tracer provided a
+                * 32-bit field.
+                */
+               if (prev_index->events_discarded_len == 32) {
+                       events_discarded_diff = (uint32_t) events_discarded_diff;
+               }
+       } else {
+               /*
+                * First packet: use current packet info as limits for
+                * previous packet.
+                */
+               stream->prev.cycles.begin =
+                       stream->prev.cycles.end =
+                               stream->current.cycles.begin;
+               stream->prev.real.begin =
+                       stream->prev.real.end =
+                               stream->current.real.begin;
+       }
+       stream->events_discarded = events_discarded_diff;
 }
 
 /*
  * for SEEK_CUR: go to next packet.
- * for SEEK_POS: go to packet numer (index).
+ * for SEEK_SET: go to packet numer (index).
  */
-void ctf_packet_seek(struct stream_pos *stream_pos, size_t index, int whence)
+void ctf_packet_seek(struct bt_stream_pos *stream_pos, size_t index, int whence)
 {
        struct ctf_stream_pos *pos =
                container_of(stream_pos, struct ctf_stream_pos, parent);
        struct ctf_file_stream *file_stream =
                container_of(pos, struct ctf_file_stream, pos);
        int ret;
-       off_t off;
-       struct packet_index *packet_index;
+       struct packet_index *packet_index, *prev_index;
+
+       switch (whence) {
+       case SEEK_CUR:
+       case SEEK_SET:  /* Fall-through */
+               break;  /* OK */
+       default:
+               assert(0);
+       }
 
-       if (pos->prot == PROT_WRITE && pos->content_size_loc)
+       if ((pos->prot & PROT_WRITE) && pos->content_size_loc)
                *pos->content_size_loc = pos->offset;
 
        if (pos->base_mma) {
@@ -636,11 +891,11 @@ void ctf_packet_seek(struct stream_pos *stream_pos, size_t index, int whence)
         * The caller should never ask for ctf_move_pos across packets,
         * except to get exactly at the beginning of the next packet.
         */
-       if (pos->prot == PROT_WRITE) {
+       if (pos->prot & PROT_WRITE) {
                switch (whence) {
                case SEEK_CUR:
                        /* The writer will add padding */
-                       pos->mmap_offset += WRITE_PACKET_LEN / CHAR_BIT;
+                       pos->mmap_offset += pos->packet_size / CHAR_BIT;
                        break;
                case SEEK_SET:
                        assert(index == 0);     /* only seek supported for now */
@@ -651,126 +906,84 @@ void ctf_packet_seek(struct stream_pos *stream_pos, size_t index, int whence)
                }
                pos->content_size = -1U;        /* Unknown at this point */
                pos->packet_size = WRITE_PACKET_LEN;
-               off = posix_fallocate(pos->fd, pos->mmap_offset,
-                                     pos->packet_size / CHAR_BIT);
-               assert(off >= 0);
+               do {
+                       ret = bt_posix_fallocate(pos->fd, pos->mmap_offset,
+                                             pos->packet_size / CHAR_BIT);
+               } while (ret == EINTR);
+               assert(ret == 0);
                pos->offset = 0;
        } else {
        read_next_packet:
                switch (whence) {
                case SEEK_CUR:
                {
-                       uint64_t events_discarded_diff;
-
                        if (pos->offset == EOF) {
                                return;
                        }
-                       /* For printing discarded event count */
-                       packet_index = &g_array_index(pos->packet_cycles_index,
-                                       struct packet_index, pos->cur_index);
-                       file_stream->parent.prev_cycles_timestamp_end =
-                               packet_index->timestamp_end;
-                       file_stream->parent.prev_cycles_timestamp =
-                               packet_index->timestamp_begin;
-
-                       packet_index = &g_array_index(pos->packet_real_index,
-                                       struct packet_index, pos->cur_index);
-                       file_stream->parent.prev_real_timestamp_end =
-                                               packet_index->timestamp_end;
-                       file_stream->parent.prev_real_timestamp =
-                               packet_index->timestamp_begin;
-
-                       events_discarded_diff = packet_index->events_discarded;
-                       if (pos->cur_index > 0) {
-                               packet_index = &g_array_index(pos->packet_real_index,
-                                               struct packet_index,
-                                               pos->cur_index - 1);
-                               events_discarded_diff -= packet_index->events_discarded;
-                               /*
-                                * Deal with 32-bit wrap-around if the
-                                * tracer provided a 32-bit field.
-                                */
-                               if (packet_index->events_discarded_len == 32) {
-                                       events_discarded_diff = (uint32_t) events_discarded_diff;
-                               }
-                       }
-                       file_stream->parent.events_discarded = events_discarded_diff;
-                       file_stream->parent.prev_real_timestamp = file_stream->parent.real_timestamp;
-                       file_stream->parent.prev_cycles_timestamp = file_stream->parent.cycles_timestamp;
+                       assert(pos->cur_index < pos->packet_index->len);
                        /* The reader will expect us to skip padding */
                        ++pos->cur_index;
                        break;
                }
                case SEEK_SET:
+                       if (index >= pos->packet_index->len) {
+                               pos->offset = EOF;
+                               return;
+                       }
                        pos->cur_index = index;
-                       file_stream->parent.prev_real_timestamp = 0;
-                       file_stream->parent.prev_real_timestamp_end = 0;
-                       file_stream->parent.prev_cycles_timestamp = 0;
-                       file_stream->parent.prev_cycles_timestamp_end = 0;
                        break;
                default:
                        assert(0);
                }
-               if (pos->cur_index >= pos->packet_real_index->len) {
-                       /*
-                        * When a stream reaches the end of the
-                        * file, we need to show the number of
-                        * events discarded ourselves, because
-                        * there is no next event scheduled to
-                        * be printed in the output.
-                        */
-                       if (file_stream->parent.events_discarded) {
-                               /*
-                                * We need to check if we are in trace
-                                * read or called from packet indexing.
-                                * In this last case, the collection is
-                                * not there, so we cannot print the
-                                * timestamps.
-                                */
-                               if ((&file_stream->parent)->stream_class->trace->collection) {
-                                       fflush(stdout);
-                                       fprintf(stderr, "[warning] Tracer discarded %" PRIu64 " events at end of stream between [",
-                                                       file_stream->parent.events_discarded);
-                                       if (opt_clock_cycles) {
-                                               ctf_print_timestamp(stderr,
-                                                               &file_stream->parent,
-                                                               file_stream->parent.prev_cycles_timestamp);
-                                               fprintf(stderr, "] and [");
-                                               ctf_print_timestamp(stderr, &file_stream->parent,
-                                                               file_stream->parent.prev_cycles_timestamp_end);
-                                       } else {
-                                               ctf_print_timestamp(stderr,
-                                                               &file_stream->parent,
-                                                               file_stream->parent.prev_real_timestamp);
-                                               fprintf(stderr, "] and [");
-                                               ctf_print_timestamp(stderr, &file_stream->parent,
-                                                               file_stream->parent.prev_real_timestamp_end);
-                                       }
-                                       fprintf(stderr, "]. You should consider recording a new trace with larger buffers or with fewer events enabled.\n");
-                                       fflush(stderr);
-                               }
-                               file_stream->parent.events_discarded = 0;
-                       }
+
+               packet_index = &g_array_index(pos->packet_index,
+                               struct packet_index, pos->cur_index);
+               if (pos->cur_index > 0) {
+                       prev_index = &g_array_index(pos->packet_index,
+                                       struct packet_index,
+                                       pos->cur_index - 1);
+               } else {
+                       prev_index = NULL;
+               }
+               ctf_update_current_packet_index(&file_stream->parent,
+                               prev_index, packet_index);
+
+               if (pos->cur_index >= pos->packet_index->len) {
                        pos->offset = EOF;
                        return;
                }
-               packet_index = &g_array_index(pos->packet_cycles_index,
-                               struct packet_index,
-                               pos->cur_index);
-               file_stream->parent.cycles_timestamp = packet_index->timestamp_begin;
 
-               packet_index = &g_array_index(pos->packet_real_index,
+               /*
+                * We need to check if we are in trace read or called
+                * from packet indexing.  In this last case, the
+                * collection is not there, so we cannot print the
+                * timestamps.
+                */
+               if ((&file_stream->parent)->stream_class->trace->parent.collection) {
+                       ctf_print_discarded(stderr, &file_stream->parent);
+               }
+
+               packet_index = &g_array_index(pos->packet_index,
                                struct packet_index,
                                pos->cur_index);
-               file_stream->parent.real_timestamp = packet_index->timestamp_begin;
-               pos->mmap_offset = packet_index->offset;
+               file_stream->parent.cycles_timestamp = packet_index->ts_cycles.timestamp_begin;
+
+               file_stream->parent.real_timestamp = packet_index->ts_real.timestamp_begin;
 
                /* Lookup context/packet size in index */
+               if (packet_index->data_offset == -1) {
+                       ret = find_data_offset(pos, file_stream, packet_index);
+                       if (ret < 0) {
+                               return;
+                       }
+               }
                pos->content_size = packet_index->content_size;
                pos->packet_size = packet_index->packet_size;
-               if (packet_index->data_offset < packet_index->content_size) {
+               pos->mmap_offset = packet_index->offset;
+               pos->data_offset = packet_index->data_offset;
+               if (pos->data_offset < packet_index->content_size) {
                        pos->offset = 0;        /* will read headers */
-               } else if (packet_index->data_offset == packet_index->content_size) {
+               } else if (pos->data_offset == packet_index->content_size) {
                        /* empty packet */
                        pos->offset = packet_index->data_offset;
                        whence = SEEK_CUR;
@@ -790,12 +1003,14 @@ void ctf_packet_seek(struct stream_pos *stream_pos, size_t index, int whence)
        }
 
        /* update trace_packet_header and stream_packet_context */
-       if (pos->prot != PROT_WRITE && file_stream->parent.trace_packet_header) {
+       if (!(pos->prot & PROT_WRITE) &&
+               file_stream->parent.trace_packet_header) {
                /* Read packet header */
                ret = generic_rw(&pos->parent, &file_stream->parent.trace_packet_header->p);
                assert(!ret);
        }
-       if (pos->prot != PROT_WRITE && file_stream->parent.stream_packet_context) {
+       if (!(pos->prot & PROT_WRITE) &&
+               file_stream->parent.stream_packet_context) {
                /* Read packet context */
                ret = generic_rw(&pos->parent, &file_stream->parent.stream_packet_context->p);
                assert(!ret);
@@ -855,7 +1070,7 @@ warning:
 }
 
 static
-int ctf_open_trace_metadata_packet_read(struct ctf_trace *td, FILE *in,
+int ctf_trace_metadata_packet_read(struct ctf_trace *td, FILE *in,
                                        FILE *out)
 {
        struct metadata_packet_header header;
@@ -896,10 +1111,13 @@ int ctf_open_trace_metadata_packet_read(struct ctf_trace *td, FILE *in,
                memcpy(td->uuid, header.uuid, sizeof(header.uuid));
                CTF_TRACE_SET_FIELD(td, uuid);
        } else {
-               if (babeltrace_uuid_compare(header.uuid, td->uuid))
+               if (bt_uuid_compare(header.uuid, td->uuid))
                        return -EINVAL;
        }
 
+       if ((header.content_size / CHAR_BIT) < header_sizeof(header))
+               return -EINVAL;
+
        toread = (header.content_size / CHAR_BIT) - header_sizeof(header);
 
        for (;;) {
@@ -942,11 +1160,11 @@ read_padding:
 }
 
 static
-int ctf_open_trace_metadata_stream_read(struct ctf_trace *td, FILE **fp,
+int ctf_trace_metadata_stream_read(struct ctf_trace *td, FILE **fp,
                                        char **buf)
 {
        FILE *in, *out;
-       size_t size;
+       size_t size, buflen;
        int ret;
 
        in = *fp;
@@ -961,7 +1179,7 @@ int ctf_open_trace_metadata_stream_read(struct ctf_trace *td, FILE **fp,
                return -errno;
        }
        for (;;) {
-               ret = ctf_open_trace_metadata_packet_read(td, in, out);
+               ret = ctf_trace_metadata_packet_read(td, in, out);
                if (ret) {
                        break;
                }
@@ -973,13 +1191,27 @@ int ctf_open_trace_metadata_stream_read(struct ctf_trace *td, FILE **fp,
        /* close to flush the buffer */
        ret = babeltrace_close_memstream(buf, &size, out);
        if (ret < 0) {
+               int closeret;
+
                perror("babeltrace_flush_memstream");
-               fclose(in);
-               return -errno;
+               ret = -errno;
+               closeret = fclose(in);
+               if (closeret) {
+                       perror("Error in fclose");
+               }
+               return ret;
+       }
+       ret = fclose(in);
+       if (ret) {
+               perror("Error in fclose");
        }
-       fclose(in);
        /* open for reading */
-       *fp = babeltrace_fmemopen(*buf, strlen(*buf), "rb");
+       buflen = strlen(*buf);
+       if (!buflen) {
+               *fp = NULL;
+               return -ENOENT;
+       }
+       *fp = babeltrace_fmemopen(*buf, buflen, "rb");
        if (!*fp) {
                perror("Metadata fmemopen");
                return -errno;
@@ -988,35 +1220,27 @@ int ctf_open_trace_metadata_stream_read(struct ctf_trace *td, FILE **fp,
 }
 
 static
-int ctf_open_trace_metadata_read(struct ctf_trace *td,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
-                       int whence), FILE *metadata_fp)
+int ctf_trace_metadata_read(struct ctf_trace *td, FILE *metadata_fp,
+               struct ctf_scanner *scanner, int append)
 {
-       struct ctf_scanner *scanner;
        struct ctf_file_stream *metadata_stream;
        FILE *fp;
        char *buf = NULL;
-       int ret = 0;
+       int ret = 0, closeret;
 
        metadata_stream = g_new0(struct ctf_file_stream, 1);
        metadata_stream->pos.last_offset = LAST_OFFSET_POISON;
 
-       if (packet_seek) {
-               metadata_stream->pos.packet_seek = packet_seek;
-       } else {
-               fprintf(stderr, "[error] packet_seek function undefined.\n");
-               ret = -1;
-               goto end_stream;
-       }
-
        if (metadata_fp) {
                fp = metadata_fp;
+               metadata_stream->pos.fd = -1;
        } else {
                td->metadata = &metadata_stream->parent;
                metadata_stream->pos.fd = openat(td->dirfd, "metadata", O_RDONLY);
                if (metadata_stream->pos.fd < 0) {
                        fprintf(stderr, "Unable to open metadata.\n");
-                       return metadata_stream->pos.fd;
+                       ret = -1;
+                       goto end_free;
                }
 
                fp = fdopen(metadata_stream->pos.fd, "r");
@@ -1026,38 +1250,39 @@ int ctf_open_trace_metadata_read(struct ctf_trace *td,
                        ret = -errno;
                        goto end_stream;
                }
+               /* fd now belongs to fp */
+               metadata_stream->pos.fd = -1;
        }
        if (babeltrace_debug)
                yydebug = 1;
 
        if (packet_metadata(td, fp)) {
-               ret = ctf_open_trace_metadata_stream_read(td, &fp, &buf);
-               if (ret)
-                       goto end_packet_read;
+               ret = ctf_trace_metadata_stream_read(td, &fp, &buf);
+               if (ret) {
+                       goto end;
+               }
+               td->metadata_string = buf;
+               td->metadata_packetized = 1;
        } else {
-               unsigned int major, minor;
-               ssize_t nr_items;
-
-               td->byte_order = BYTE_ORDER;
-
-               /* Check text-only metadata header and version */
-               nr_items = fscanf(fp, "/* CTF %u.%u", &major, &minor);
-               if (nr_items < 2)
-                       fprintf(stderr, "[warning] Ill-shapen or missing \"/* CTF x.y\" header for text-only metadata.\n");
-               if (check_version(major, minor) < 0) {
-                       ret = -EINVAL;
-                       goto end_packet_read;
+               if (!append) {
+                       unsigned int major, minor;
+                       ssize_t nr_items;
+
+                       td->byte_order = BYTE_ORDER;
+
+                       /* Check text-only metadata header and version */
+                       nr_items = fscanf(fp, "/* CTF %10u.%10u", &major, &minor);
+                       if (nr_items < 2)
+                               fprintf(stderr, "[warning] Ill-shapen or missing \"/* CTF x.y\" header for text-only metadata.\n");
+                       if (check_version(major, minor) < 0) {
+                               ret = -EINVAL;
+                               goto end;
+                       }
+                       rewind(fp);
                }
-               rewind(fp);
        }
 
-       scanner = ctf_scanner_alloc(fp);
-       if (!scanner) {
-               fprintf(stderr, "[error] Error allocating scanner\n");
-               ret = -ENOMEM;
-               goto end_scanner_alloc;
-       }
-       ret = ctf_scanner_append_ast(scanner);
+       ret = ctf_scanner_append_ast(scanner, fp);
        if (ret) {
                fprintf(stderr, "[error] Error creating AST\n");
                goto end;
@@ -1083,14 +1308,20 @@ int ctf_open_trace_metadata_read(struct ctf_trace *td,
                goto end;
        }
 end:
-       ctf_scanner_free(scanner);
-end_scanner_alloc:
-end_packet_read:
-       if (fp)
-               fclose(fp);
-       free(buf);
+       if (fp) {
+               closeret = fclose(fp);
+               if (closeret) {
+                       perror("Error on fclose");
+               }
+       }
 end_stream:
-       close(metadata_stream->pos.fd);
+       if (metadata_stream->pos.fd >= 0) {
+               closeret = close(metadata_stream->pos.fd);
+               if (closeret) {
+                       perror("Error on metadata stream fd close");
+               }
+       }
+end_free:
        if (ret)
                g_free(metadata_stream);
        return ret;
@@ -1104,7 +1335,7 @@ struct ctf_event_definition *create_event_definitions(struct ctf_trace *td,
        struct ctf_event_definition *stream_event = g_new0(struct ctf_event_definition, 1);
 
        if (event->context_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        event->context_decl->p.definition_new(&event->context_decl->p,
                                stream->parent_def_scope, 0, 0, "event.context");
                if (!definition) {
@@ -1115,7 +1346,7 @@ struct ctf_event_definition *create_event_definitions(struct ctf_trace *td,
                stream->parent_def_scope = stream_event->event_context->p.scope;
        }
        if (event->fields_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        event->fields_decl->p.definition_new(&event->fields_decl->p,
                                stream->parent_def_scope, 0, 0, "event.fields");
                if (!definition) {
@@ -1130,12 +1361,44 @@ struct ctf_event_definition *create_event_definitions(struct ctf_trace *td,
 
 error:
        if (stream_event->event_fields)
-               definition_unref(&stream_event->event_fields->p);
+               bt_definition_unref(&stream_event->event_fields->p);
        if (stream_event->event_context)
-               definition_unref(&stream_event->event_context->p);
+               bt_definition_unref(&stream_event->event_context->p);
+       fprintf(stderr, "[error] Unable to create event definition for event \"%s\".\n",
+               g_quark_to_string(event->name));
        return NULL;
 }
 
+static
+int copy_event_declarations_stream_class_to_stream(struct ctf_trace *td,
+               struct ctf_stream_declaration *stream_class,
+               struct ctf_stream_definition *stream)
+{
+       size_t def_size, class_size, i;
+       int ret = 0;
+
+       def_size = stream->events_by_id->len;
+       class_size = stream_class->events_by_id->len;
+
+       g_ptr_array_set_size(stream->events_by_id, class_size);
+       for (i = def_size; i < class_size; i++) {
+               struct ctf_event_declaration *event =
+                       g_ptr_array_index(stream_class->events_by_id, i);
+               struct ctf_event_definition *stream_event;
+
+               if (!event)
+                       continue;
+               stream_event = create_event_definitions(td, stream, event);
+               if (!stream_event) {
+                       ret = -EINVAL;
+                       goto error;
+               }
+               g_ptr_array_index(stream->events_by_id, i) = stream_event;
+       }
+error:
+       return ret;
+}
+
 static
 int create_stream_definitions(struct ctf_trace *td, struct ctf_stream_definition *stream)
 {
@@ -1149,7 +1412,7 @@ int create_stream_definitions(struct ctf_trace *td, struct ctf_stream_definition
        stream_class = stream->stream_class;
 
        if (stream_class->packet_context_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        stream_class->packet_context_decl->p.definition_new(&stream_class->packet_context_decl->p,
                                stream->parent_def_scope, 0, 0, "stream.packet.context");
                if (!definition) {
@@ -1161,7 +1424,7 @@ int create_stream_definitions(struct ctf_trace *td, struct ctf_stream_definition
                stream->parent_def_scope = stream->stream_packet_context->p.scope;
        }
        if (stream_class->event_header_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        stream_class->event_header_decl->p.definition_new(&stream_class->event_header_decl->p,
                                stream->parent_def_scope, 0, 0, "stream.event.header");
                if (!definition) {
@@ -1173,7 +1436,7 @@ int create_stream_definitions(struct ctf_trace *td, struct ctf_stream_definition
                stream->parent_def_scope = stream->stream_event_header->p.scope;
        }
        if (stream_class->event_context_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        stream_class->event_context_decl->p.definition_new(&stream_class->event_context_decl->p,
                                stream->parent_def_scope, 0, 0, "stream.event.context");
                if (!definition) {
@@ -1185,18 +1448,10 @@ int create_stream_definitions(struct ctf_trace *td, struct ctf_stream_definition
                stream->parent_def_scope = stream->stream_event_context->p.scope;
        }
        stream->events_by_id = g_ptr_array_new();
-       g_ptr_array_set_size(stream->events_by_id, stream_class->events_by_id->len);
-       for (i = 0; i < stream->events_by_id->len; i++) {
-               struct ctf_event_declaration *event = g_ptr_array_index(stream_class->events_by_id, i);
-               struct ctf_event_definition *stream_event;
-
-               if (!event)
-                       continue;
-               stream_event = create_event_definitions(td, stream, event);
-               if (!stream_event)
-                       goto error_event;
-               g_ptr_array_index(stream->events_by_id, i) = stream_event;
-       }
+       ret = copy_event_declarations_stream_class_to_stream(td,
+                       stream_class, stream);
+       if (ret)
+               goto error_event;
        return 0;
 
 error_event:
@@ -1208,241 +1463,344 @@ error_event:
        g_ptr_array_free(stream->events_by_id, TRUE);
 error:
        if (stream->stream_event_context)
-               definition_unref(&stream->stream_event_context->p);
+               bt_definition_unref(&stream->stream_event_context->p);
        if (stream->stream_event_header)
-               definition_unref(&stream->stream_event_header->p);
+               bt_definition_unref(&stream->stream_event_header->p);
        if (stream->stream_packet_context)
-               definition_unref(&stream->stream_packet_context->p);
+               bt_definition_unref(&stream->stream_packet_context->p);
+       fprintf(stderr, "[error] Unable to create stream (%" PRIu64 ") definitions: %s\n",
+               stream_class->stream_id, strerror(-ret));
        return ret;
 }
 
-
 static
-int create_stream_packet_index(struct ctf_trace *td,
-                              struct ctf_file_stream *file_stream)
+int stream_assign_class(struct ctf_trace *td,
+               struct ctf_file_stream *file_stream,
+               uint64_t stream_id)
 {
        struct ctf_stream_declaration *stream;
-       int len_index;
-       struct ctf_stream_pos *pos;
-       struct stat filestats;
-       struct packet_index packet_index;
-       int first_packet = 1;
        int ret;
 
-       pos = &file_stream->pos;
-
-       ret = fstat(pos->fd, &filestats);
-       if (ret < 0)
-               return ret;
-
-       if (filestats.st_size < MAX_PACKET_HEADER_LEN / CHAR_BIT)
+       file_stream->parent.stream_id = stream_id;
+       if (stream_id >= td->streams->len) {
+               fprintf(stderr, "[error] Stream %" PRIu64 " is not declared in metadata.\n", stream_id);
                return -EINVAL;
+       }
+       stream = g_ptr_array_index(td->streams, stream_id);
+       if (!stream) {
+               fprintf(stderr, "[error] Stream %" PRIu64 " is not declared in metadata.\n", stream_id);
+               return -EINVAL;
+       }
+       file_stream->parent.stream_class = stream;
+       ret = create_stream_definitions(td, &file_stream->parent);
+       if (ret)
+               return ret;
+       return 0;
+}
 
-       for (pos->mmap_offset = 0; pos->mmap_offset < filestats.st_size; ) {
-               uint64_t stream_id = 0;
-
-               if (pos->base_mma) {
-                       /* unmap old base */
-                       ret = munmap_align(pos->base_mma);
-                       if (ret) {
-                               fprintf(stderr, "[error] Unable to unmap old base: %s.\n",
-                                       strerror(errno));
-                               return ret;
-                       }
-                       pos->base_mma = NULL;
-               }
-               /* map new base. Need mapping length from header. */
-               pos->base_mma = mmap_align(MAX_PACKET_HEADER_LEN / CHAR_BIT, PROT_READ,
-                                MAP_PRIVATE, pos->fd, pos->mmap_offset);
-               assert(pos->base_mma != MAP_FAILED);
-               pos->content_size = MAX_PACKET_HEADER_LEN;      /* Unknown at this point */
-               pos->packet_size = MAX_PACKET_HEADER_LEN;       /* Unknown at this point */
-               pos->offset = 0;        /* Position of the packet header */
-
-               packet_index.offset = pos->mmap_offset;
-               packet_index.content_size = 0;
-               packet_index.packet_size = 0;
-               packet_index.timestamp_begin = 0;
-               packet_index.timestamp_end = 0;
-               packet_index.events_discarded = 0;
-
-               /* read and check header, set stream id (and check) */
-               if (file_stream->parent.trace_packet_header) {
-                       /* Read packet header */
-                       ret = generic_rw(&pos->parent, &file_stream->parent.trace_packet_header->p);
-                       if (ret)
-                               return ret;
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("magic"));
-                       if (len_index >= 0) {
-                               struct definition *field;
-                               uint64_t magic;
-
-                               field = struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
-                               magic = get_unsigned_int(field);
-                               if (magic != CTF_MAGIC) {
-                                       fprintf(stderr, "[error] Invalid magic number 0x%" PRIX64 " at packet %u (file offset %zd).\n",
-                                                       magic,
-                                                       file_stream->pos.packet_cycles_index->len,
-                                                       (ssize_t) pos->mmap_offset);
-                                       return -EINVAL;
-                               }
-                       }
-
-                       /* check uuid */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("uuid"));
-                       if (len_index >= 0) {
-                               struct definition_array *defarray;
-                               struct definition *field;
-                               uint64_t i;
-                               uint8_t uuidval[BABELTRACE_UUID_LEN];
-
-                               field = struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
-                               assert(field->declaration->id == CTF_TYPE_ARRAY);
-                               defarray = container_of(field, struct definition_array, p);
-                               assert(array_len(defarray) == BABELTRACE_UUID_LEN);
-
-                               for (i = 0; i < BABELTRACE_UUID_LEN; i++) {
-                                       struct definition *elem;
+static
+int create_stream_one_packet_index(struct ctf_stream_pos *pos,
+                       struct ctf_trace *td,
+                       struct ctf_file_stream *file_stream,
+                       size_t filesize)
+{
+       struct packet_index packet_index;
+       uint64_t stream_id = 0;
+       uint64_t packet_map_len = DEFAULT_HEADER_LEN, tmp_map_len;
+       int first_packet = 0;
+       int len_index;
+       int ret;
 
-                                       elem = array_index(defarray, i);
-                                       uuidval[i] = get_unsigned_int(elem);
-                               }
-                               ret = babeltrace_uuid_compare(td->uuid, uuidval);
-                               if (ret) {
-                                       fprintf(stderr, "[error] Unique Universal Identifiers do not match.\n");
-                                       return -EINVAL;
-                               }
-                       }
+begin:
+       if (!pos->mmap_offset) {
+               first_packet = 1;
+       }
 
+       if (filesize - pos->mmap_offset < (packet_map_len >> LOG2_CHAR_BIT)) {
+               packet_map_len = (filesize - pos->mmap_offset) << LOG2_CHAR_BIT;
+       }
 
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("stream_id"));
-                       if (len_index >= 0) {
-                               struct definition *field;
-
-                               field = struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
-                               stream_id = get_unsigned_int(field);
-                       }
+       if (pos->base_mma) {
+               /* unmap old base */
+               ret = munmap_align(pos->base_mma);
+               if (ret) {
+                       fprintf(stderr, "[error] Unable to unmap old base: %s.\n",
+                               strerror(errno));
+                       return ret;
                }
-
-               if (!first_packet && file_stream->parent.stream_id != stream_id) {
-                       fprintf(stderr, "[error] Stream ID is changing within a stream.\n");
-                       return -EINVAL;
+               pos->base_mma = NULL;
+       }
+       /* map new base. Need mapping length from header. */
+       pos->base_mma = mmap_align(packet_map_len >> LOG2_CHAR_BIT, PROT_READ,
+                        MAP_PRIVATE, pos->fd, pos->mmap_offset);
+       assert(pos->base_mma != MAP_FAILED);
+       /*
+        * Use current mapping size as temporary content and packet
+        * size.
+        */
+       pos->content_size = packet_map_len;
+       pos->packet_size = packet_map_len;
+       pos->offset = 0;        /* Position of the packet header */
+
+       packet_index.offset = pos->mmap_offset;
+       packet_index.content_size = 0;
+       packet_index.packet_size = 0;
+       packet_index.ts_real.timestamp_begin = 0;
+       packet_index.ts_real.timestamp_end = 0;
+       packet_index.ts_cycles.timestamp_begin = 0;
+       packet_index.ts_cycles.timestamp_end = 0;
+       packet_index.events_discarded = 0;
+       packet_index.events_discarded_len = 0;
+
+       /* read and check header, set stream id (and check) */
+       if (file_stream->parent.trace_packet_header) {
+               /* Read packet header */
+               ret = generic_rw(&pos->parent, &file_stream->parent.trace_packet_header->p);
+               if (ret) {
+                       if (ret == -EFAULT)
+                               goto retry;
+                       fprintf(stderr, "[error] Unable to read packet header: %s\n", strerror(-ret));
+                       return ret;
                }
-               if (first_packet) {
-                       file_stream->parent.stream_id = stream_id;
-                       if (stream_id >= td->streams->len) {
-                               fprintf(stderr, "[error] Stream %" PRIu64 " is not declared in metadata.\n", stream_id);
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("magic"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
+                       uint64_t magic;
+
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
+                       magic = bt_get_unsigned_int(field);
+                       if (magic != CTF_MAGIC) {
+                               fprintf(stderr, "[error] Invalid magic number 0x%" PRIX64 " at packet %u (file offset %zd).\n",
+                                               magic,
+                                               file_stream->pos.packet_index->len,
+                                               (ssize_t) pos->mmap_offset);
                                return -EINVAL;
                        }
-                       stream = g_ptr_array_index(td->streams, stream_id);
-                       if (!stream) {
-                               fprintf(stderr, "[error] Stream %" PRIu64 " is not declared in metadata.\n", stream_id);
-                               return -EINVAL;
-                       }
-                       file_stream->parent.stream_class = stream;
-                       ret = create_stream_definitions(td, &file_stream->parent);
-                       if (ret)
-                               return ret;
                }
-               first_packet = 0;
 
-               if (file_stream->parent.stream_packet_context) {
-                       /* Read packet context */
-                       ret = generic_rw(&pos->parent, &file_stream->parent.stream_packet_context->p);
-                       if (ret)
-                               return ret;
-                       /* read content size from header */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("content_size"));
-                       if (len_index >= 0) {
-                               struct definition *field;
+               /* check uuid */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("uuid"));
+               if (len_index >= 0) {
+                       struct definition_array *defarray;
+                       struct bt_definition *field;
+                       uint64_t i;
+                       uint8_t uuidval[BABELTRACE_UUID_LEN];
 
-                               field = struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
-                               packet_index.content_size = get_unsigned_int(field);
-                       } else {
-                               /* Use file size for packet size */
-                               packet_index.content_size = filestats.st_size * CHAR_BIT;
-                       }
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
+                       assert(field->declaration->id == CTF_TYPE_ARRAY);
+                       defarray = container_of(field, struct definition_array, p);
+                       assert(bt_array_len(defarray) == BABELTRACE_UUID_LEN);
 
-                       /* read packet size from header */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("packet_size"));
-                       if (len_index >= 0) {
-                               struct definition *field;
+                       for (i = 0; i < BABELTRACE_UUID_LEN; i++) {
+                               struct bt_definition *elem;
 
-                               field = struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
-                               packet_index.packet_size = get_unsigned_int(field);
-                       } else {
-                               /* Use content size if non-zero, else file size */
-                               packet_index.packet_size = packet_index.content_size ? : filestats.st_size * CHAR_BIT;
+                               elem = bt_array_index(defarray, i);
+                               uuidval[i] = bt_get_unsigned_int(elem);
                        }
-
-                       /* read timestamp begin from header */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("timestamp_begin"));
-                       if (len_index >= 0) {
-                               struct definition *field;
-
-                               field = struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
-                               packet_index.timestamp_begin = get_unsigned_int(field);
-                               if (file_stream->parent.stream_class->trace->collection) {
-                                       packet_index.timestamp_begin =
-                                               ctf_get_real_timestamp(
-                                                       &file_stream->parent,
-                                                       packet_index.timestamp_begin);
-                               }
+                       ret = bt_uuid_compare(td->uuid, uuidval);
+                       if (ret) {
+                               fprintf(stderr, "[error] Unique Universal Identifiers do not match.\n");
+                               return -EINVAL;
                        }
+               }
 
-                       /* read timestamp end from header */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("timestamp_end"));
-                       if (len_index >= 0) {
-                               struct definition *field;
-
-                               field = struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
-                               packet_index.timestamp_end = get_unsigned_int(field);
-                               if (file_stream->parent.stream_class->trace->collection) {
-                                       packet_index.timestamp_end =
-                                               ctf_get_real_timestamp(
-                                                       &file_stream->parent,
-                                                       packet_index.timestamp_end);
-                               }
-                       }
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.trace_packet_header->declaration, g_quark_from_static_string("stream_id"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
 
-                       /* read events discarded from header */
-                       len_index = struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("events_discarded"));
-                       if (len_index >= 0) {
-                               struct definition *field;
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.trace_packet_header, len_index);
+                       stream_id = bt_get_unsigned_int(field);
+               }
+       }
 
-                               field = struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
-                               packet_index.events_discarded = get_unsigned_int(field);
-                               packet_index.events_discarded_len = get_int_len(field);
-                       }
+       if (!first_packet && file_stream->parent.stream_id != stream_id) {
+               fprintf(stderr, "[error] Stream ID is changing within a stream: expecting %" PRIu64 ", but packet has %" PRIu64 "\n",
+                       stream_id,
+                       file_stream->parent.stream_id);
+               return -EINVAL;
+       }
+       if (first_packet) {
+               ret = stream_assign_class(td, file_stream, stream_id);
+               if (ret)
+                       return ret;
+       }
+
+       if (file_stream->parent.stream_packet_context) {
+               /* Read packet context */
+               ret = generic_rw(&pos->parent, &file_stream->parent.stream_packet_context->p);
+               if (ret) {
+                       if (ret == -EFAULT)
+                               goto retry;
+                       fprintf(stderr, "[error] Unable to read packet context: %s\n", strerror(-ret));
+                       return ret;
+               }
+               /* read packet size from header */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("packet_size"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
+
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
+                       packet_index.packet_size = bt_get_unsigned_int(field);
                } else {
                        /* Use file size for packet size */
-                       packet_index.content_size = filestats.st_size * CHAR_BIT;
-                       /* Use content size if non-zero, else file size */
-                       packet_index.packet_size = packet_index.content_size ? : filestats.st_size * CHAR_BIT;
+                       packet_index.packet_size = filesize * CHAR_BIT;
                }
 
-               /* Validate content size and packet size values */
-               if (packet_index.content_size > packet_index.packet_size) {
-                       fprintf(stderr, "[error] Content size (%" PRIu64 " bits) is larger than packet size (%" PRIu64 " bits).\n",
-                               packet_index.content_size, packet_index.packet_size);
-                       return -EINVAL;
+               /* read content size from header */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("content_size"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
+
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
+                       packet_index.content_size = bt_get_unsigned_int(field);
+               } else {
+                       /* Use packet size if non-zero, else file size */
+                       packet_index.content_size = packet_index.packet_size ? : filesize * CHAR_BIT;
                }
 
-               if (packet_index.packet_size > ((uint64_t)filestats.st_size - packet_index.offset) * CHAR_BIT) {
-                       fprintf(stderr, "[error] Packet size (%" PRIu64 " bits) is larger than remaining file size (%" PRIu64 " bits).\n",
-                               packet_index.packet_size, ((uint64_t)filestats.st_size - packet_index.offset) * CHAR_BIT);
-                       return -EINVAL;
+               /* read timestamp begin from header */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("timestamp_begin"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
+
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
+                       packet_index.ts_cycles.timestamp_begin = bt_get_unsigned_int(field);
+                       if (file_stream->parent.stream_class->trace->parent.collection) {
+                               packet_index.ts_real.timestamp_begin =
+                                       ctf_get_real_timestamp(
+                                               &file_stream->parent,
+                                               packet_index.ts_cycles.timestamp_begin);
+                       }
                }
 
-               /* Save position after header and context */
-               packet_index.data_offset = pos->offset;
+               /* read timestamp end from header */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("timestamp_end"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
+
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
+                       packet_index.ts_cycles.timestamp_end = bt_get_unsigned_int(field);
+                       if (file_stream->parent.stream_class->trace->parent.collection) {
+                               packet_index.ts_real.timestamp_end =
+                                       ctf_get_real_timestamp(
+                                               &file_stream->parent,
+                                               packet_index.ts_cycles.timestamp_end);
+                       }
+               }
 
-               /* add index to packet array */
-               g_array_append_val(file_stream->pos.packet_cycles_index, packet_index);
+               /* read events discarded from header */
+               len_index = bt_struct_declaration_lookup_field_index(file_stream->parent.stream_packet_context->declaration, g_quark_from_static_string("events_discarded"));
+               if (len_index >= 0) {
+                       struct bt_definition *field;
 
-               pos->mmap_offset += packet_index.packet_size / CHAR_BIT;
+                       field = bt_struct_definition_get_field_from_index(file_stream->parent.stream_packet_context, len_index);
+                       packet_index.events_discarded = bt_get_unsigned_int(field);
+                       packet_index.events_discarded_len = bt_get_int_len(field);
+               }
+       } else {
+               /* Use file size for packet size */
+               packet_index.packet_size = filesize * CHAR_BIT;
+               /* Use packet size if non-zero, else file size */
+               packet_index.content_size = packet_index.packet_size ? : filesize * CHAR_BIT;
+       }
+
+       /* Validate content size and packet size values */
+       if (packet_index.content_size > packet_index.packet_size) {
+               fprintf(stderr, "[error] Content size (%" PRIu64 " bits) is larger than packet size (%" PRIu64 " bits).\n",
+                       packet_index.content_size, packet_index.packet_size);
+               return -EINVAL;
+       }
+
+       if (packet_index.packet_size > ((uint64_t) filesize - packet_index.offset) * CHAR_BIT) {
+               fprintf(stderr, "[error] Packet size (%" PRIu64 " bits) is larger than remaining file size (%" PRIu64 " bits).\n",
+                       packet_index.packet_size, ((uint64_t) filesize - packet_index.offset) * CHAR_BIT);
+               return -EINVAL;
+       }
+
+       if (packet_index.content_size < pos->offset) {
+               fprintf(stderr, "[error] Invalid CTF stream: content size is smaller than packet headers.\n");
+               return -EINVAL;
        }
 
+       if ((packet_index.packet_size >> LOG2_CHAR_BIT) == 0) {
+               fprintf(stderr, "[error] Invalid CTF stream: packet size needs to be at least one byte\n");
+               return -EINVAL;
+       }
+
+       /* Save position after header and context */
+       packet_index.data_offset = pos->offset;
+
+       /* add index to packet array */
+       g_array_append_val(file_stream->pos.packet_index, packet_index);
+
+       pos->mmap_offset += packet_index.packet_size >> LOG2_CHAR_BIT;
+
+       return 0;
+
+       /* Retry with larger mapping */
+retry:
+       if (packet_map_len == ((filesize - pos->mmap_offset) << LOG2_CHAR_BIT)) {
+               /*
+                * Reached EOF, but still expecting header/context data.
+                */
+               fprintf(stderr, "[error] Reached end of file, but still expecting header or context fields.\n");
+               return -EFAULT;
+       }
+       /* Double the mapping len, and retry */
+       tmp_map_len = packet_map_len << 1;
+       if (tmp_map_len >> 1 != packet_map_len) {
+               /* Overflow */
+               fprintf(stderr, "[error] Packet mapping length overflow\n");
+               return -EFAULT;
+       }
+       packet_map_len = tmp_map_len;
+       goto begin;
+}
+
+static
+int create_stream_packet_index(struct ctf_trace *td,
+                       struct ctf_file_stream *file_stream)
+{
+       struct ctf_stream_pos *pos;
+       struct stat filestats;
+       int ret;
+
+       pos = &file_stream->pos;
+
+       ret = fstat(pos->fd, &filestats);
+       if (ret < 0)
+               return ret;
+
+       /* Deal with empty files */
+       if (!filestats.st_size) {
+               if (file_stream->parent.trace_packet_header
+                               || file_stream->parent.stream_packet_context) {
+                       /*
+                        * We expect a trace packet header and/or stream packet
+                        * context. Since a trace needs to have at least one
+                        * packet, empty files are therefore not accepted.
+                        */
+                       fprintf(stderr, "[error] Encountered an empty file, but expecting a trace packet header.\n");
+                       return -EINVAL;
+               } else {
+                       /*
+                        * Without trace packet header nor stream packet
+                        * context, a one-packet trace can indeed be empty. This
+                        * is only valid if there is only one stream class: 0.
+                        */
+                       ret = stream_assign_class(td, file_stream, 0);
+                       if (ret)
+                               return ret;
+                       return 0;
+               }
+       }
+
+       for (pos->mmap_offset = 0; pos->mmap_offset < filestats.st_size; ) {
+               ret = create_stream_one_packet_index(pos, td, file_stream,
+                       filestats.st_size);
+               if (ret)
+                       return ret;
+       }
        return 0;
 }
 
@@ -1452,7 +1810,7 @@ int create_trace_definitions(struct ctf_trace *td, struct ctf_stream_definition
        int ret;
 
        if (td->packet_header_decl) {
-               struct definition *definition =
+               struct bt_definition *definition =
                        td->packet_header_decl->p.definition_new(&td->packet_header_decl->p,
                                stream->parent_def_scope, 0, 0, "trace.packet.header");
                if (!definition) {
@@ -1467,6 +1825,109 @@ int create_trace_definitions(struct ctf_trace *td, struct ctf_stream_definition
        return 0;
 
 error:
+       fprintf(stderr, "[error] Unable to create trace definitions: %s\n", strerror(-ret));
+       return ret;
+}
+
+static
+int import_stream_packet_index(struct ctf_trace *td,
+               struct ctf_file_stream *file_stream)
+{
+       struct ctf_stream_pos *pos;
+       struct ctf_packet_index *ctf_index = NULL;
+       struct ctf_packet_index_file_hdr index_hdr;
+       struct packet_index index;
+       uint32_t packet_index_len;
+       int ret = 0;
+       int first_packet = 1;
+       size_t len;
+
+       pos = &file_stream->pos;
+
+       len = fread(&index_hdr, sizeof(index_hdr), 1, pos->index_fp);
+       if (len != 1) {
+               perror("read index file header");
+               goto error;
+       }
+
+       /* Check the index header */
+       if (be32toh(index_hdr.magic) != CTF_INDEX_MAGIC) {
+               fprintf(stderr, "[error] wrong index magic\n");
+               ret = -1;
+               goto error;
+       }
+       if (be32toh(index_hdr.index_major) != CTF_INDEX_MAJOR) {
+               fprintf(stderr, "[error] Incompatible index file %" PRIu32
+                               ".%" PRIu32 ", supported %d.%d\n",
+                               be32toh(index_hdr.index_major),
+                               be32toh(index_hdr.index_minor), CTF_INDEX_MAJOR,
+                               CTF_INDEX_MINOR);
+               ret = -1;
+               goto error;
+       }
+       packet_index_len = be32toh(index_hdr.packet_index_len);
+       if (packet_index_len == 0) {
+               fprintf(stderr, "[error] Packet index length cannot be 0.\n");
+               ret = -1;
+               goto error;
+       }
+       /*
+        * Allocate the index length found in header, not internal
+        * representation.
+        */
+       ctf_index = g_malloc0(packet_index_len);
+       while (fread(ctf_index, packet_index_len, 1,
+                       pos->index_fp) == 1) {
+               uint64_t stream_id;
+               struct ctf_stream_declaration *stream = NULL;
+
+               memset(&index, 0, sizeof(index));
+               index.offset = be64toh(ctf_index->offset);
+               index.packet_size = be64toh(ctf_index->packet_size);
+               index.content_size = be64toh(ctf_index->content_size);
+               index.ts_cycles.timestamp_begin = be64toh(ctf_index->timestamp_begin);
+               index.ts_cycles.timestamp_end = be64toh(ctf_index->timestamp_end);
+               index.events_discarded = be64toh(ctf_index->events_discarded);
+               index.events_discarded_len = 64;
+               index.data_offset = -1;
+               stream_id = be64toh(ctf_index->stream_id);
+
+               if (!first_packet) {
+                       /* add index to packet array */
+                       g_array_append_val(file_stream->pos.packet_index, index);
+                       continue;
+               }
+
+               file_stream->parent.stream_id = stream_id;
+               if (stream_id < td->streams->len) {
+                       stream = g_ptr_array_index(td->streams, stream_id);
+               }
+               if (!stream) {
+                       fprintf(stderr, "[error] Stream %" PRIu64
+                                       " is not declared in metadata.\n",
+                                       stream_id);
+                       ret = -EINVAL;
+                       goto error;
+               }
+               file_stream->parent.stream_class = stream;
+               ret = create_stream_definitions(td, &file_stream->parent);
+               if (ret)
+                       goto error;
+               first_packet = 0;
+               /* add index to packet array */
+               g_array_append_val(file_stream->pos.packet_index, index);
+       }
+
+       /* Index containing only the header. */
+       if (!file_stream->parent.stream_class) {
+               ret = -1;
+               goto error;
+       }
+
+       ret = 0;
+
+error:
+       g_free(ctf_index);
        return ret;
 }
 
@@ -1476,12 +1937,13 @@ error:
  */
 static
 int ctf_open_file_stream_read(struct ctf_trace *td, const char *path, int flags,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence))
 {
-       int ret, fd;
+       int ret, fd, closeret;
        struct ctf_file_stream *file_stream;
        struct stat statbuf;
+       char *index_name;
 
        fd = openat(td->dirfd, path, flags);
        if (fd < 0) {
@@ -1497,13 +1959,26 @@ int ctf_open_file_stream_read(struct ctf_trace *td, const char *path, int flags,
                goto fstat_error;
        }
        if (S_ISDIR(statbuf.st_mode)) {
-               fprintf(stderr, "[warning] Skipping directory '%s' found in trace\n", path);
+               if (strncmp(path, "index", 5) != 0) {
+                       fprintf(stderr, "[warning] Skipping directory '%s' "
+                                       "found in trace\n", path);
+               }
                ret = 0;
                goto fd_is_dir_ok;
        }
+       if (!statbuf.st_size) {
+               /** Skip empty files. */
+               ret = 0;
+               goto fd_is_empty_file;
+       }
 
        file_stream = g_new0(struct ctf_file_stream, 1);
        file_stream->pos.last_offset = LAST_OFFSET_POISON;
+       file_stream->pos.fd = -1;
+       file_stream->pos.index_fp = NULL;
+
+       strncpy(file_stream->parent.path, path, PATH_MAX);
+       file_stream->parent.path[PATH_MAX - 1] = '\0';
 
        if (packet_seek) {
                file_stream->pos.packet_seek = packet_seek;
@@ -1513,31 +1988,89 @@ int ctf_open_file_stream_read(struct ctf_trace *td, const char *path, int flags,
                goto error_def;
        }
 
-       ctf_init_pos(&file_stream->pos, fd, flags);
+       ret = ctf_init_pos(&file_stream->pos, &td->parent, fd, flags);
+       if (ret)
+               goto error_def;
        ret = create_trace_definitions(td, &file_stream->parent);
        if (ret)
                goto error_def;
        /*
-        * For now, only a single slock is supported.
+        * For now, only a single clock per trace is supported.
         */
-       file_stream->parent.current_clock = td->single_clock;
-       ret = create_stream_packet_index(td, file_stream);
-       if (ret)
-               goto error_index;
+       file_stream->parent.current_clock = td->parent.single_clock;
+
+       /*
+        * Allocate the index name for this stream and try to open it.
+        */
+       index_name = malloc((strlen(path) + sizeof(INDEX_PATH)) * sizeof(char));
+       if (!index_name) {
+               fprintf(stderr, "[error] Cannot allocate index filename\n");
+               ret = -ENOMEM;
+               goto error_def;
+       }
+       snprintf(index_name, strlen(path) + sizeof(INDEX_PATH),
+                       INDEX_PATH, path);
+
+       if (bt_faccessat(td->dirfd, td->parent.path, index_name, O_RDONLY, 0) < 0) {
+               ret = create_stream_packet_index(td, file_stream);
+               if (ret) {
+                       fprintf(stderr, "[error] Stream index creation error.\n");
+                       goto error_index;
+               }
+       } else {
+               ret = openat(td->dirfd, index_name, flags);
+               if (ret < 0) {
+                       perror("Index file openat()");
+                       ret = -1;
+                       goto error_free;
+               }
+               file_stream->pos.index_fp = fdopen(ret, "r");
+               if (!file_stream->pos.index_fp) {
+                       perror("fdopen() error");
+                       goto error_free;
+               }
+               ret = import_stream_packet_index(td, file_stream);
+               if (ret) {
+                       ret = -1;
+                       goto error_index;
+               }
+               ret = fclose(file_stream->pos.index_fp);
+               if (ret < 0) {
+                       perror("close index");
+                       goto error_free;
+               }
+       }
+       free(index_name);
+
        /* Add stream file to stream class */
        g_ptr_array_add(file_stream->parent.stream_class->streams,
                        &file_stream->parent);
        return 0;
 
 error_index:
+       if (file_stream->pos.index_fp) {
+               ret = fclose(file_stream->pos.index_fp);
+               if (ret < 0) {
+                       perror("close index");
+               }
+       }
        if (file_stream->parent.trace_packet_header)
-               definition_unref(&file_stream->parent.trace_packet_header->p);
+               bt_definition_unref(&file_stream->parent.trace_packet_header->p);
+error_free:
+       free(index_name);
 error_def:
-       ctf_fini_pos(&file_stream->pos);
+       closeret = ctf_fini_pos(&file_stream->pos);
+       if (closeret) {
+               fprintf(stderr, "Error on ctf_fini_pos\n");
+       }
        g_free(file_stream);
+fd_is_empty_file:
 fd_is_dir_ok:
 fstat_error:
-       close(fd);
+       closeret = close(fd);
+       if (closeret) {
+               perror("Error on fd close");
+       }
 error:
        return ret;
 }
@@ -1545,13 +2078,15 @@ error:
 static
 int ctf_open_trace_read(struct ctf_trace *td,
                const char *path, int flags,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence), FILE *metadata_fp)
 {
-       int ret;
+       struct ctf_scanner *scanner;
+       int ret, closeret;
        struct dirent *dirent;
        struct dirent *diriter;
        size_t dirent_len;
+       char *ext;
 
        td->flags = flags;
 
@@ -1570,15 +2105,26 @@ int ctf_open_trace_read(struct ctf_trace *td,
                ret = -errno;
                goto error_dirfd;
        }
-       strncpy(td->path, path, sizeof(td->path));
-       td->path[sizeof(td->path) - 1] = '\0';
+       strncpy(td->parent.path, path, sizeof(td->parent.path));
+       td->parent.path[sizeof(td->parent.path) - 1] = '\0';
 
        /*
         * Keep the metadata file separate.
+        * Keep scanner object local to the open. We don't support
+        * incremental metadata append for on-disk traces.
         */
-
-       ret = ctf_open_trace_metadata_read(td, packet_seek, metadata_fp);
+       scanner = ctf_scanner_alloc();
+       if (!scanner) {
+               fprintf(stderr, "[error] Error allocating scanner\n");
+               ret = -ENOMEM;
+               goto error_metadata;
+       }
+       ret = ctf_trace_metadata_read(td, metadata_fp, scanner, 0);
+       ctf_scanner_free(scanner);
        if (ret) {
+               if (ret == -ENOENT) {
+                       fprintf(stderr, "[warning] Empty metadata.\n");
+               }
                fprintf(stderr, "[warning] Unable to open trace metadata for path \"%s\".\n", path);
                goto error_metadata;
        }
@@ -1607,6 +2153,13 @@ int ctf_open_trace_read(struct ctf_trace *td,
                                || !strcmp(diriter->d_name, "..")
                                || !strcmp(diriter->d_name, "metadata"))
                        continue;
+
+               /* Ignore index files : *.idx */
+               ext = strrchr(diriter->d_name, '.');
+               if (ext && (!strcmp(ext, ".idx"))) {
+                       continue;
+               }
+
                ret = ctf_open_file_stream_read(td, diriter->d_name,
                                        flags, packet_seek);
                if (ret) {
@@ -1621,9 +2174,15 @@ int ctf_open_trace_read(struct ctf_trace *td,
 readdir_error:
        free(dirent);
 error_metadata:
-       close(td->dirfd);
+       closeret = close(td->dirfd);
+       if (closeret) {
+               perror("Error on fd close");
+       }
 error_dirfd:
-       closedir(td->dir);
+       closeret = closedir(td->dir);
+       if (closeret) {
+               perror("Error on closedir");
+       }
 error:
        return ret;
 }
@@ -1634,8 +2193,8 @@ error:
  * since the index creation read it entirely.
  */
 static
-struct trace_descriptor *ctf_open_trace(const char *path, int flags,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+struct bt_trace_descriptor *ctf_open_trace(const char *path, int flags,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence), FILE *metadata_fp)
 {
        struct ctf_trace *td;
@@ -1673,9 +2232,9 @@ error:
        return NULL;
 }
 
-
+static
 void ctf_init_mmap_pos(struct ctf_stream_pos *pos,
-               struct mmap_stream *mmap_info)
+               struct bt_mmap_stream *mmap_info)
 {
        pos->mmap_offset = 0;
        pos->packet_size = 0;
@@ -1686,23 +2245,28 @@ void ctf_init_mmap_pos(struct ctf_stream_pos *pos,
        pos->offset = 0;
        pos->dummy = false;
        pos->cur_index = 0;
-       pos->packet_cycles_index = NULL;
-       pos->packet_real_index = NULL;
        pos->prot = PROT_READ;
        pos->flags = MAP_PRIVATE;
        pos->parent.rw_table = read_dispatch_table;
        pos->parent.event_cb = ctf_read_event;
+       pos->priv = mmap_info->priv;
+       pos->packet_index = g_array_new(FALSE, TRUE,
+                       sizeof(struct packet_index));
 }
 
 static
 int prepare_mmap_stream_definition(struct ctf_trace *td,
-               struct ctf_file_stream *file_stream)
+               struct ctf_file_stream *file_stream,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
+                       int whence))
 {
        struct ctf_stream_declaration *stream;
-       uint64_t stream_id = 0;
+       uint64_t stream_id;
        int ret;
 
-       file_stream->parent.stream_id = stream_id;
+       /* Ask for the first packet to get the stream_id. */
+       packet_seek(&file_stream->pos.parent, 0, SEEK_SET);
+       stream_id = file_stream->parent.stream_id;
        if (stream_id >= td->streams->len) {
                fprintf(stderr, "[error] Stream %" PRIu64 " is not declared "
                                "in metadata.\n", stream_id);
@@ -1724,14 +2288,15 @@ end:
 
 static
 int ctf_open_mmap_stream_read(struct ctf_trace *td,
-               struct mmap_stream *mmap_info,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+               struct bt_mmap_stream *mmap_info,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence))
 {
        int ret;
        struct ctf_file_stream *file_stream;
 
        file_stream = g_new0(struct ctf_file_stream, 1);
+       file_stream->parent.stream_id = -1ULL;
        file_stream->pos.last_offset = LAST_OFFSET_POISON;
        ctf_init_mmap_pos(&file_stream->pos, mmap_info);
 
@@ -1742,10 +2307,15 @@ int ctf_open_mmap_stream_read(struct ctf_trace *td,
                goto error_def;
        }
 
-       ret = prepare_mmap_stream_definition(td, file_stream);
+       ret = prepare_mmap_stream_definition(td, file_stream, packet_seek);
        if (ret)
                goto error_index;
 
+       /*
+        * For now, only a single clock per trace is supported.
+        */
+       file_stream->parent.current_clock = td->parent.single_clock;
+
        /* Add stream file to stream class */
        g_ptr_array_add(file_stream->parent.stream_class->streams,
                        &file_stream->parent);
@@ -1753,23 +2323,33 @@ int ctf_open_mmap_stream_read(struct ctf_trace *td,
 
 error_index:
        if (file_stream->parent.trace_packet_header)
-               definition_unref(&file_stream->parent.trace_packet_header->p);
+               bt_definition_unref(&file_stream->parent.trace_packet_header->p);
 error_def:
        g_free(file_stream);
        return ret;
 }
 
+static
 int ctf_open_mmap_trace_read(struct ctf_trace *td,
-               struct mmap_stream_list *mmap_list,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+               struct bt_mmap_stream_list *mmap_list,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence),
                FILE *metadata_fp)
 {
        int ret;
-       struct mmap_stream *mmap_info;
+       struct bt_mmap_stream *mmap_info;
 
-       ret = ctf_open_trace_metadata_read(td, ctf_packet_seek, metadata_fp);
+       td->scanner = ctf_scanner_alloc();
+       if (!td->scanner) {
+               fprintf(stderr, "[error] Error allocating scanner\n");
+               ret = -ENOMEM;
+               goto error;
+       }
+       ret = ctf_trace_metadata_read(td, metadata_fp, td->scanner, 0);
        if (ret) {
+               if (ret == -ENOENT) {
+                       fprintf(stderr, "[warning] Empty metadata.\n");
+               }
                goto error;
        }
 
@@ -1784,17 +2364,17 @@ int ctf_open_mmap_trace_read(struct ctf_trace *td,
                        goto error;
                }
        }
-
        return 0;
 
 error:
+       ctf_scanner_free(td->scanner);
        return ret;
 }
 
 static
-struct trace_descriptor *ctf_open_mmap_trace(
-               struct mmap_stream_list *mmap_list,
-               void (*packet_seek)(struct stream_pos *pos, size_t index,
+struct bt_trace_descriptor *ctf_open_mmap_trace(
+               struct bt_mmap_stream_list *mmap_list,
+               void (*packet_seek)(struct bt_stream_pos *pos, size_t index,
                        int whence),
                FILE *metadata_fp)
 {
@@ -1811,6 +2391,7 @@ struct trace_descriptor *ctf_open_mmap_trace(
                goto error;
        }
        td = g_new0(struct ctf_trace, 1);
+       td->dirfd = -1;
        ret = ctf_open_mmap_trace_read(td, mmap_list, packet_seek, metadata_fp);
        if (ret)
                goto error_free;
@@ -1823,8 +2404,43 @@ error:
        return NULL;
 }
 
+int ctf_append_trace_metadata(struct bt_trace_descriptor *tdp,
+               FILE *metadata_fp)
+{
+       struct ctf_trace *td = container_of(tdp, struct ctf_trace, parent);
+       int i, j;
+       int ret;
+
+       if (!td->scanner)
+               return -EINVAL;
+       ret = ctf_trace_metadata_read(td, metadata_fp, td->scanner, 1);
+       if (ret)
+               return ret;
+       /* for each stream_class */
+       for (i = 0; i < td->streams->len; i++) {
+               struct ctf_stream_declaration *stream_class;
+
+               stream_class = g_ptr_array_index(td->streams, i);
+               if (!stream_class)
+                       continue;
+               /* for each stream */
+               for (j = 0; j < stream_class->streams->len; j++) {
+                       struct ctf_stream_definition *stream;
+
+                       stream = g_ptr_array_index(stream_class->streams, j);
+                       if (!stream)
+                               continue;
+                       ret = copy_event_declarations_stream_class_to_stream(td,
+                               stream_class, stream);
+                       if (ret)
+                               return ret;
+               }
+       }
+       return 0;
+}
+
 static
-int ctf_convert_index_timestamp(struct trace_descriptor *tdp)
+int ctf_convert_index_timestamp(struct bt_trace_descriptor *tdp)
 {
        int i, j, k;
        struct ctf_trace *td = container_of(tdp, struct ctf_trace, parent);
@@ -1848,28 +2464,20 @@ int ctf_convert_index_timestamp(struct trace_descriptor *tdp)
                        cfs = container_of(stream, struct ctf_file_stream,
                                        parent);
                        stream_pos = &cfs->pos;
-                       stream_pos->packet_real_index = g_array_new(FALSE, TRUE,
-                                       sizeof(struct packet_index));
-
-                       if (!stream_pos->packet_cycles_index)
+                       if (!stream_pos->packet_index)
                                continue;
 
-                       for (k = 0; k < stream_pos->packet_cycles_index->len; k++) {
+                       for (k = 0; k < stream_pos->packet_index->len; k++) {
                                struct packet_index *index;
-                               struct packet_index new_index;
 
-                               index = &g_array_index(stream_pos->packet_cycles_index,
+                               index = &g_array_index(stream_pos->packet_index,
                                                struct packet_index, k);
-                               memcpy(&new_index, index,
-                                               sizeof(struct packet_index));
-                               new_index.timestamp_begin =
+                               index->ts_real.timestamp_begin =
                                        ctf_get_real_timestamp(stream,
-                                                       index->timestamp_begin);
-                               new_index.timestamp_end =
+                                                       index->ts_cycles.timestamp_begin);
+                               index->ts_real.timestamp_end =
                                        ctf_get_real_timestamp(stream,
-                                                       index->timestamp_end);
-                               g_array_append_val(stream_pos->packet_real_index,
-                                               new_index);
+                                                       index->ts_cycles.timestamp_end);
                        }
                }
        }
@@ -1877,19 +2485,34 @@ int ctf_convert_index_timestamp(struct trace_descriptor *tdp)
 }
 
 static
-void ctf_close_file_stream(struct ctf_file_stream *file_stream)
+int ctf_close_file_stream(struct ctf_file_stream *file_stream)
 {
-       ctf_fini_pos(&file_stream->pos);
-       close(file_stream->pos.fd);
+       int ret;
+
+       ret = ctf_fini_pos(&file_stream->pos);
+       if (ret) {
+               fprintf(stderr, "Error on ctf_fini_pos\n");
+               return -1;
+       }
+       if (file_stream->pos.fd >= 0) {
+               ret = close(file_stream->pos.fd);
+               if (ret) {
+                       perror("Error closing file fd");
+                       return -1;
+               }
+       }
+       return 0;
 }
 
 static
-void ctf_close_trace(struct trace_descriptor *tdp)
+int ctf_close_trace(struct bt_trace_descriptor *tdp)
 {
        struct ctf_trace *td = container_of(tdp, struct ctf_trace, parent);
-       int i;
+       int ret;
 
        if (td->streams) {
+               int i;
+
                for (i = 0; i < td->streams->len; i++) {
                        struct ctf_stream_declaration *stream;
                        int j;
@@ -1899,59 +2522,56 @@ void ctf_close_trace(struct trace_descriptor *tdp)
                                continue;
                        for (j = 0; j < stream->streams->len; j++) {
                                struct ctf_file_stream *file_stream;
-                               file_stream = container_of(g_ptr_array_index(stream->streams, j), struct ctf_file_stream, parent);
-                               ctf_close_file_stream(file_stream);
+                               file_stream = container_of(g_ptr_array_index(stream->streams, j),
+                                               struct ctf_file_stream, parent);
+                               ret = ctf_close_file_stream(file_stream);
+                               if (ret)
+                                       return ret;
                        }
-
                }
-               g_ptr_array_free(td->streams, TRUE);
        }
-
-       if (td->event_declarations) {
-               for (i = 0; i < td->event_declarations->len; i++) {
-                       struct bt_ctf_event_decl *event;
-
-                       event = g_ptr_array_index(td->event_declarations, i);
-                       if (event->context_decl)
-                               g_ptr_array_free(event->context_decl, TRUE);
-                       if (event->fields_decl)
-                               g_ptr_array_free(event->fields_decl, TRUE);
-                       if (event->packet_header_decl)
-                               g_ptr_array_free(event->packet_header_decl, TRUE);
-                       if (event->event_context_decl)
-                               g_ptr_array_free(event->event_context_decl, TRUE);
-                       if (event->event_header_decl)
-                               g_ptr_array_free(event->event_header_decl, TRUE);
-                       if (event->packet_context_decl)
-                               g_ptr_array_free(event->packet_context_decl, TRUE);
-                       g_free(event);
+       ctf_destroy_metadata(td);
+       ctf_scanner_free(td->scanner);
+       if (td->dirfd >= 0) {
+               ret = close(td->dirfd);
+               if (ret) {
+                       perror("Error closing dirfd");
+                       return ret;
                }
-               g_ptr_array_free(td->event_declarations, TRUE);
        }
-       closedir(td->dir);
+       if (td->dir) {
+               ret = closedir(td->dir);
+               if (ret) {
+                       perror("Error closedir");
+                       return ret;
+               }
+       }
+       free(td->metadata_string);
        g_free(td);
+       return 0;
 }
 
 static
-void ctf_set_context(struct trace_descriptor *descriptor,
+void ctf_set_context(struct bt_trace_descriptor *descriptor,
                struct bt_context *ctx)
 {
        struct ctf_trace *td = container_of(descriptor, struct ctf_trace,
                        parent);
 
-       td->ctx = ctx;
+       td->parent.ctx = ctx;
 }
 
 static
-void ctf_set_handle(struct trace_descriptor *descriptor,
+void ctf_set_handle(struct bt_trace_descriptor *descriptor,
                struct bt_trace_handle *handle)
 {
        struct ctf_trace *td = container_of(descriptor, struct ctf_trace,
                        parent);
 
-       td->handle = handle;
+       td->parent.handle = handle;
 }
 
+static
 void __attribute__((constructor)) ctf_init(void)
 {
        int ret;
@@ -1961,4 +2581,8 @@ void __attribute__((constructor)) ctf_init(void)
        assert(!ret);
 }
 
-/* TODO: finalize */
+static
+void __attribute__((destructor)) ctf_exit(void)
+{
+       bt_unregister_format(&ctf_format);
+}
This page took 0.053728 seconds and 4 git commands to generate.