#include <inttypes.h>
#include <endian.h>
#include <errno.h>
-#include <babeltrace/babeltrace.h>
+#include <babeltrace/babeltrace-internal.h>
#include <babeltrace/list.h>
#include <babeltrace/types.h>
#include <babeltrace/ctf/metadata.h>
assert(node->u.unary_expression.link == UNARY_LINK_UNKNOWN);
assert(i == 0);
src_string = node->u.unary_expression.u.string;
- ret = uuid_parse(node->u.unary_expression.u.string, *uuid);
+ ret = uuid_parse(src_string, *uuid);
}
return ret;
}
/* TYPEDEC_NESTED */
+ if (!nested_declaration) {
+ fprintf(fd, "[error] %s: nested type is unknown.\n", __func__);
+ return NULL;
+ }
+
/* create array/sequence, pass nested_declaration as child. */
if (cds_list_empty(&node_type_declarator->u.type_declarator.u.nested.length)) {
fprintf(fd, "[error] %s: expecting length field reference or value.\n", __func__);
fprintf(fd, "[error] %s: unable to find struct field declaration type\n", __func__);
return -EINVAL;
}
+
+ /* Check if field with same name already exists */
+ if (struct_declaration_lookup_field_index(struct_declaration, field_name) >= 0) {
+ fprintf(fd, "[error] %s: duplicate field %s in struct\n", __func__, g_quark_to_string(field_name));
+ return -EINVAL;
+ }
+
struct_declaration_add_field(struct_declaration,
g_quark_to_string(field_name),
field_declaration);
fprintf(fd, "[error] %s: unable to find variant field declaration type\n", __func__);
return -EINVAL;
}
+
+ if (untagged_variant_declaration_get_field_from_tag(untagged_variant_declaration, field_name) != NULL) {
+ fprintf(fd, "[error] %s: duplicate field %s in variant\n", __func__, g_quark_to_string(field_name));
+ return -EINVAL;
+ }
+
+
untagged_variant_declaration_add_field(untagged_variant_declaration,
g_quark_to_string(field_name),
field_declaration);
return 0;
error:
- type_declaration->declaration_free(type_declaration);
+ if (type_declaration) {
+ type_declaration->declaration_free(type_declaration);
+ }
return err;
}
ret = ctf_struct_declaration_list_visit(fd, depth + 1, iter,
struct_declaration, trace);
if (ret)
- goto error;
+ goto error_free_declaration;
}
if (name) {
ret = register_struct_declaration(g_quark_from_string(name),
}
return &struct_declaration->p;
}
-error:
+error_free_declaration:
struct_declaration->p.declaration_free(&struct_declaration->p);
+error:
return NULL;
}
struct ctf_trace *trace)
{
struct ctf_node *expression;
- uint64_t alignment, size;
+ uint64_t alignment = 1, size = 0;
int byte_order = trace->byte_order;
int signedness = 0;
int has_alignment = 0, has_size = 0;
else if (!strcmp(s_right, "ASCII")
|| !strcmp(s_right, "ascii"))
encoding = CTF_STRING_ASCII;
+ else if (!strcmp(s_right, "none"))
+ encoding = CTF_STRING_NONE;
else {
fprintf(fd, "[error] %s: unknown string encoding \"%s\"\n", __func__, s_right);
g_free(s_right);
struct ctf_trace *trace)
{
struct ctf_node *expression;
- uint64_t alignment, exp_dig, mant_dig, byte_order = trace->byte_order;
+ uint64_t alignment = 1, exp_dig = 0, mant_dig = 0,
+ byte_order = trace->byte_order;
int has_alignment = 0, has_exp_dig = 0, has_mant_dig = 0;
struct declaration_float *float_declaration;
int ret = 0;
struct ctf_node *iter;
struct ctf_event *event;
- struct definition_scope *parent_def_scope;
event = g_new0(struct ctf_event, 1);
event->declaration_scope = new_declaration_scope(parent_declaration_scope);
g_hash_table_insert(event->stream->event_quark_to_id,
(gpointer)(unsigned long) event->name,
&event->id);
- parent_def_scope = event->stream->definition_scope;
- if (event->context_decl) {
- struct definition *definition =
- event->context_decl->p.definition_new(&event->context_decl->p,
- parent_def_scope, 0, 0, "event.context");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- event->context = container_of(definition,
- struct definition_struct, p);
- parent_def_scope = event->context->p.scope;
- }
- if (event->fields_decl) {
- struct definition *definition =
- event->fields_decl->p.definition_new(&event->fields_decl->p,
- parent_def_scope, 0, 0, "event.fields");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- event->fields = container_of(definition,
- struct definition_struct, p);
- parent_def_scope = event->fields->p.scope;
- }
return 0;
error:
- if (event->context)
- definition_unref(&event->context->p);
- if (event->fields)
- definition_unref(&event->fields->p);
if (event->fields_decl)
declaration_unref(&event->fields_decl->p);
if (event->context_decl)
int ret = 0;
struct ctf_node *iter;
struct ctf_stream_class *stream;
- struct definition_scope *parent_def_scope;
stream = g_new0(struct ctf_stream_class, 1);
stream->declaration_scope = new_declaration_scope(parent_declaration_scope);
stream->events_by_id = g_ptr_array_new();
stream->event_quark_to_id = g_hash_table_new(g_direct_hash, g_direct_equal);
- stream->files = g_ptr_array_new();
+ stream->streams = g_ptr_array_new();
if (node) {
cds_list_for_each_entry(iter, &node->u.stream.declaration_list, siblings) {
ret = ctf_stream_declaration_visit(fd, depth + 1, iter, stream, trace);
if (trace->streams->len <= stream->stream_id)
g_ptr_array_set_size(trace->streams, stream->stream_id + 1);
g_ptr_array_index(trace->streams, stream->stream_id) = stream;
-
- parent_def_scope = trace->definition_scope;
- if (stream->packet_context_decl) {
- struct definition *definition =
- stream->packet_context_decl->p.definition_new(&stream->packet_context_decl->p,
- parent_def_scope, 0, 0, "stream.packet.context");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- stream->packet_context = container_of(definition,
- struct definition_struct, p);
- parent_def_scope = stream->packet_context->p.scope;
- }
- if (stream->event_header_decl) {
- struct definition *definition =
- stream->event_header_decl->p.definition_new(&stream->event_header_decl->p,
- parent_def_scope, 0, 0, "stream.event.header");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- stream->event_header =
- container_of(definition, struct definition_struct, p);
- parent_def_scope = stream->event_header->p.scope;
- }
- if (stream->event_context_decl) {
- struct definition *definition =
- stream->event_context_decl->p.definition_new(&stream->event_context_decl->p,
- parent_def_scope, 0, 0, "stream.event.context");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- stream->event_context =
- container_of(definition, struct definition_struct, p);
- parent_def_scope = stream->event_context->p.scope;
- }
- stream->definition_scope = parent_def_scope;
+ stream->trace = trace;
return 0;
error:
- if (stream->event_context)
- definition_unref(&stream->event_context->p);
- if (stream->event_header)
- definition_unref(&stream->event_header->p);
- if (stream->packet_context)
- definition_unref(&stream->packet_context->p);
if (stream->event_header_decl)
declaration_unref(&stream->event_header_decl->p);
if (stream->event_context_decl)
declaration_unref(&stream->event_context_decl->p);
if (stream->packet_context_decl)
declaration_unref(&stream->packet_context_decl->p);
- g_ptr_array_free(stream->files, TRUE);
+ g_ptr_array_free(stream->streams, TRUE);
g_ptr_array_free(stream->events_by_id, TRUE);
g_hash_table_destroy(stream->event_quark_to_id);
free_declaration_scope(stream->declaration_scope);
ret = -EPERM;
goto error;
} else {
- trace->byte_order = byte_order;
+ if (byte_order != trace->byte_order) {
+ trace->byte_order = byte_order;
+ /*
+ * We need to restart
+ * construction of the
+ * intermediate representation.
+ */
+ trace->field_mask = 0;
+ CTF_TRACE_SET_FIELD(trace, byte_order);
+ ret = -EINTR;
+ goto error;
+ }
}
CTF_TRACE_SET_FIELD(trace, byte_order);
} else if (!strcmp(left, "packet.header")) {
static
int ctf_trace_visit(FILE *fd, int depth, struct ctf_node *node, struct ctf_trace *trace)
{
- struct definition_scope *parent_def_scope;
int ret = 0;
struct ctf_node *iter;
goto error;
}
- parent_def_scope = NULL;
- if (trace->packet_header_decl) {
- struct definition *definition =
- trace->packet_header_decl->p.definition_new(&trace->packet_header_decl->p,
- parent_def_scope, 0, 0, "trace.packet.header");
- if (!definition) {
- ret = -EINVAL;
- goto error;
- }
- trace->packet_header =
- container_of(definition, struct definition_struct, p);
- parent_def_scope = trace->packet_header->p.scope;
- }
- trace->definition_scope = parent_def_scope;
-
if (!CTF_TRACE_FIELD_IS_SET(trace, byte_order)) {
/* check that the packet header contains a "magic" field */
- if (!trace->packet_header
+ if (!trace->packet_header_decl
|| struct_declaration_lookup_field_index(trace->packet_header_decl, g_quark_from_static_string("magic")) < 0) {
ret = -EPERM;
fprintf(fd, "[error] %s: missing both byte_order and packet header magic number in trace declaration\n", __func__);
return 0;
error:
- if (trace->packet_header)
- definition_unref(&trace->packet_header->p);
- if (trace->packet_header_decl)
+ if (trace->packet_header_decl) {
declaration_unref(&trace->packet_header_decl->p);
+ trace->packet_header_decl = NULL;
+ }
g_ptr_array_free(trace->streams, TRUE);
free_declaration_scope(trace->declaration_scope);
+ trace->declaration_scope = NULL;
return ret;
}
struct ctf_node *iter;
printf_verbose("CTF visitor: metadata construction... ");
- trace->root_declaration_scope = new_declaration_scope(NULL);
trace->byte_order = byte_order;
+retry:
+ trace->root_declaration_scope = new_declaration_scope(NULL);
+
switch (node->type) {
case NODE_ROOT:
cds_list_for_each_entry(iter, &node->u.root.declaration_list,
}
cds_list_for_each_entry(iter, &node->u.root.trace, siblings) {
ret = ctf_trace_visit(fd, depth + 1, iter, trace);
+ if (ret == -EINTR) {
+ free_declaration_scope(trace->root_declaration_scope);
+ /*
+ * Need to restart creation of type
+ * definitions, aliases and
+ * trace header declarations.
+ */
+ goto retry;
+ }
if (ret) {
fprintf(fd, "[error] %s: trace declaration error\n", __func__);
goto error;
projects / babeltrace.git / blobdiff