lib: open trace error handling fix
[babeltrace.git] / lib / context.c
index 36efc9d0c9fc451bd88b598077335739aed4d336..3cbafa07c5ba6b09e6af94653d480accda2038f2 100644 (file)
 
 #include <babeltrace/babeltrace.h>
 #include <babeltrace/context.h>
+#include <babeltrace/context-internal.h>
+#include <babeltrace/trace-handle.h>
+#include <babeltrace/trace-handle-internal.h>
+#include <babeltrace/trace-collection.h>
+#include <babeltrace/format.h>
 #include <stdlib.h>
 
-struct bt_context *bt_context_create(struct trace_collection *tc)
+#include <fts.h>
+#include <fcntl.h> /* For O_RDONLY */
+
+/* TODO ybrosseau: should be hidden in the CTF format */
+#include <babeltrace/ctf/types.h> /* for ctf_move_pos_slow */
+
+#include <glib.h>
+
+struct bt_context *bt_context_create(void)
 {
        struct bt_context *ctx;
 
-       ctx = calloc(1, sizeof(struct bt_context));
-       if (ctx == NULL) {
-               perror("allocating context");
-               goto error;
-       }
-
-       ctx->tc = tc;
+       ctx = g_new0(struct bt_context, 1);
        ctx->refcount = 1;
+       /* Negative handle id are errors. */
+       ctx->last_trace_handle_id = 0;
+
+       /* Instanciate the trace handle container */
+       ctx->trace_handles = g_hash_table_new_full(g_direct_hash,
+                               g_direct_equal, NULL,
+                               (GDestroyNotify) bt_trace_handle_destroy);
+
+       ctx->tc = g_new0(struct trace_collection, 1);
+       init_trace_collection(ctx->tc);
 
        return ctx;
+}
 
-error:
-       return NULL;
+int bt_context_add_trace(struct bt_context *ctx, const char *path,
+               const char *format_str)
+{
+       struct trace_descriptor *td;
+       struct format *fmt;
+       struct bt_trace_handle *handle;
+
+       fmt = bt_lookup_format(g_quark_from_string(format_str));
+       td = fmt->open_trace(path, O_RDONLY,
+                            ctf_move_pos_slow, NULL);
+       if (!td) {
+               fprintf(stderr, "[error] [Context] Cannot open_trace of the format %s .\n\n",
+                               path);
+               return -1;
+       }
+
+       /* Create an handle for the trace */
+       handle = bt_trace_handle_create(ctx);
+       if (handle < 0) {
+               fprintf(stderr, "[error] [Context] Creating trace handle %s .\n\n",
+                               path);
+               return -1;
+       }
+       handle->format = fmt;
+       handle->td = td;
+       strncpy(handle->path, path, PATH_MAX);
+       handle->path[PATH_MAX - 1] = '\0';
+
+       /* Add new handle to container */
+       g_hash_table_insert(ctx->trace_handles,
+               (gpointer) (unsigned long) handle->id,
+               handle);
+       return trace_collection_add(ctx->tc, td);
 }
 
-int bt_context_destroy(struct bt_context *ctx)
+/*
+ * Unable to open toplevel: failure.
+ * Unable to open some subdirectory or file: warn and continue;
+ */
+int bt_context_add_traces_recursive(struct bt_context *ctx, const char *path,
+               const char *format_str)
 {
-       if (ctx) {
-               if (ctx->refcount >= 1)
-                       goto ctx_used;
+       FTS *tree;
+       FTSENT *node;
+       GArray *trace_ids;
+       char lpath[PATH_MAX];
+       char * const paths[2] = { lpath, NULL };
+       int ret;
+
+       /*
+        * Need to copy path, because fts_open can change it.
+        * It is the pointer array, not the strings, that are constant.
+        */
+       strncpy(lpath, path, PATH_MAX);
+       lpath[PATH_MAX - 1] = '\0';
+
+       tree = fts_open(paths, FTS_NOCHDIR | FTS_LOGICAL, 0);
+       if (tree == NULL) {
+               fprintf(stderr, "[error] [Context] Cannot traverse \"%s\" for reading.\n",
+                               path);
+               return -EINVAL;
+       }
+
+       trace_ids = g_array_new(FALSE, TRUE, sizeof(int));
 
-               free(ctx);
+       while ((node = fts_read(tree))) {
+               int dirfd, metafd;
+
+               if (!(node->fts_info & FTS_D))
+                       continue;
+
+               dirfd = open(node->fts_accpath, 0);
+               if (dirfd < 0) {
+                       fprintf(stderr, "[error] [Context] Unable to open trace "
+                               "directory file descriptor.\n");
+                       ret = dirfd;
+                       goto error;
+               }
+               metafd = openat(dirfd, "metadata", O_RDONLY);
+               if (metafd < 0) {
+                       ret = close(dirfd);
+                       if (ret < 0) {
+                               perror("close");
+                               goto error;
+                       }
+               } else {
+                       int trace_id;
+
+                       ret = close(metafd);
+                       if (ret < 0) {
+                               perror("close");
+                               goto error;
+                       }
+                       ret = close(dirfd);
+                       if (ret < 0) {
+                               perror("close");
+                               goto error;
+                       }
+
+                       trace_id = bt_context_add_trace(ctx,
+                               node->fts_accpath, format_str);
+                       if (trace_id < 0) {
+                               fprintf(stderr, "[error] [Context] opening trace \"%s\" from %s "
+                                       "for reading.\n", node->fts_accpath, path);
+                               ret = trace_id;
+                               goto error;
+                       }
+                       g_array_append_val(trace_ids, trace_id);
+               }
        }
+
+       g_array_free(trace_ids, TRUE);
        return 0;
 
-ctx_used:
-       return -1;
+error:
+       return ret;
 }
 
-int bt_context_get(struct bt_context *ctx)
+void bt_context_remove_trace(struct bt_context *ctx, int handle_id)
 {
-       if (!ctx)
-               return -1;
-       ctx->refcount++;
-       return 0;
+       struct bt_trace_handle *handle;
+
+       handle = g_hash_table_lookup(ctx->trace_handles,
+               (gpointer) (unsigned long) handle_id);
+       assert(handle != NULL);
+
+       /* Remove from containers */
+       trace_collection_remove(ctx->tc, handle->td);
+       g_hash_table_remove(ctx->trace_handles,
+               (gpointer) (unsigned long) handle_id);
+
+       /* Close the trace */
+       handle->format->close_trace(handle->td);
+
+       /* Destory the handle */
+       bt_trace_handle_destroy(handle);
 }
 
-int bt_context_put(struct bt_context *ctx)
+static
+void bt_context_destroy(struct bt_context *ctx)
 {
-       if (!ctx)
-               return -1;
+       finalize_trace_collection(ctx->tc);
+
+       /* Remote all traces. The g_hash_table_destroy will call
+        * bt_trace_handle_destroy on each elements.
+        */
+       g_hash_table_destroy(ctx->trace_handles);
 
+       /* ctx->tc should always be valid */
+       assert(ctx->tc != NULL);
+       g_free(ctx->tc);
+       g_free(ctx);
+}
+
+void bt_context_get(struct bt_context *ctx)
+{
+       ctx->refcount++;
+}
+
+void bt_context_put(struct bt_context *ctx)
+{
        ctx->refcount--;
        if (ctx->refcount == 0)
-               return bt_context_destroy(ctx);
-       return 0;
+               bt_context_destroy(ctx);
 }
This page took 0.025003 seconds and 4 git commands to generate.