Rename bt_ctf_X -> bt_X, maintain backward compat. for pre-2.0 CTF writer

[babeltrace.git] / lib / ctf-ir / utils.c

diff --git a/lib/ctf-ir/utils.c b/lib/ctf-ir/utils.c
index c83b50d9916376968ad546b8d8eabfbb28b50011..12daedbd9105d787c35d5b8ea262c175ebfbdc55 100644 (file)
--- a/lib/ctf-ir/utils.c
+++ b/lib/ctf-ir/utils.c
@@ -26,7 +26,10 @@
  * SOFTWARE.
  */
 
-#include <string.h>
+#define BT_LOG_TAG "CTF-IR-UTILS"
+#include <babeltrace/lib-logging-internal.h>
+
+#include <assert.h>
 #include <stdlib.h>
 #include <glib.h>
 #include <babeltrace/ctf-ir/utils.h>
@@ -40,21 +43,21 @@ const char * const reserved_keywords_str[] = {"align", "callsite",
 
 static GHashTable *reserved_keywords_set;
 static int init_done;
-static int global_data_refcount;
 
-static __attribute__((constructor))
-void trace_init(void)
+static
+void try_init_reserved_keywords(void)
 {
        size_t i;
        const size_t reserved_keywords_count =
                sizeof(reserved_keywords_str) / sizeof(char *);
 
-       global_data_refcount++;
-       if (init_done) {
+       if (reserved_keywords_set) {
                return;
        }
 
        reserved_keywords_set = g_hash_table_new(g_direct_hash, g_direct_equal);
+       assert(reserved_keywords_set);
+
        for (i = 0; i < reserved_keywords_count; i++) {
                gpointer quark = GINT_TO_POINTER(g_quark_from_string(
                        reserved_keywords_str[i]));
@@ -68,24 +71,33 @@ void trace_init(void)
 static __attribute__((destructor))
 void trace_finalize(void)
 {
-       if (--global_data_refcount == 0) {
+       if (reserved_keywords_set) {
                g_hash_table_destroy(reserved_keywords_set);
        }
 }
 
-int bt_ctf_validate_identifier(const char *input_string)
+int bt_validate_identifier(const char *input_string)
 {
        int ret = 0;
        char *string = NULL;
        char *save_ptr, *token;
 
-       if (!input_string || input_string[0] == '\0') {
+       if (!input_string) {
+               BT_LOGV_STR("Invalid parameter: input string is NULL.");
+               ret = -1;
+               goto end;
+       }
+
+       try_init_reserved_keywords();
+
+       if (input_string[0] == '\0') {
                ret = -1;
                goto end;
        }
 
        string = strdup(input_string);
        if (!string) {
+               BT_LOGE("strdup() failed.");
                ret = -1;
                goto end;
        }
@@ -106,7 +118,7 @@ end:
        return ret;
 }
 
-bt_bool bt_ctf_identifier_is_valid(const char *identifier)
+bt_bool bt_identifier_is_valid(const char *identifier)
 {
-       return bt_ctf_validate_identifier(identifier);
+       return bt_validate_identifier(identifier);
 }