Fix: use of file pointer after fclose()

[babeltrace.git] / plugins / ctf / common / metadata / decoder.c

diff --git a/plugins/ctf/common/metadata/decoder.c b/plugins/ctf/common/metadata/decoder.c
index 8837da7769e168019a7dd22dbb2ad1db136ccbae..559820b350e953e9e077d6539a842f4910674f4b 100644 (file)
--- a/plugins/ctf/common/metadata/decoder.c
+++ b/plugins/ctf/common/metadata/decoder.c
@@ -33,7 +33,7 @@
 
 #define TSDL_MAGIC     0x75d11d57
 
-BT_HIDDEN
+extern
 int yydebug;
 
 struct ctf_metadata_decoder {
@@ -41,6 +41,7 @@ struct ctf_metadata_decoder {
        uint8_t uuid[16];
        bool is_uuid_set;
        int bo;
+       struct ctf_metadata_decoder_config config;
 };
 
 struct packet_header {
@@ -290,6 +291,13 @@ int ctf_metadata_decoder_packetized_file_stream_to_buf_with_mdec(
 
        /* Close stream, which also flushes the buffer */
        ret = bt_close_memstream(buf, &size, out_fp);
+       /*
+        * See fclose(3). Further access to out_fp after both success
+        * and error, even through another bt_close_memstream(), results
+        * in undefined behavior. Nullify out_fp to ensure we don't
+        * fclose it twice on error.
+        */
+       out_fp = NULL;
        if (ret < 0) {
                BT_LOGE("Cannot close memory stream: %s: mdec-addr=%p",
                        strerror(errno), mdec);
@@ -327,22 +335,33 @@ int ctf_metadata_decoder_packetized_file_stream_to_buf(
 
 BT_HIDDEN
 struct ctf_metadata_decoder *ctf_metadata_decoder_create(
-               int64_t clock_class_offset_ns, const char *name)
+               const struct ctf_metadata_decoder_config *config,
+               const char *name)
 {
        struct ctf_metadata_decoder *mdec =
                g_new0(struct ctf_metadata_decoder, 1);
+       struct ctf_metadata_decoder_config default_config = {
+               .clock_class_offset_s = 0,
+               .clock_class_offset_ns = 0,
+       };
+
+       if (!config) {
+               config = &default_config;
+       }
 
        BT_LOGD("Creating CTF metadata decoder: "
+               "clock-class-offset-s=%" PRId64 ", "
                "clock-class-offset-ns=%" PRId64 ", name=\"%s\"",
-               clock_class_offset_ns, name);
+               config->clock_class_offset_s, config->clock_class_offset_ns,
+               name);
 
        if (!mdec) {
                BT_LOGE_STR("Failed to allocate one CTF metadata decoder.");
                goto end;
        }
 
-       mdec->visitor = ctf_visitor_generate_ir_create(clock_class_offset_ns,
-                       name);
+       mdec->config = *config;
+       mdec->visitor = ctf_visitor_generate_ir_create(config, name);
        if (!mdec->visitor) {
                BT_LOGE("Failed to create a CTF IR metadata AST visitor: "
                        "mdec-addr=%p", mdec);
@@ -351,9 +370,12 @@ struct ctf_metadata_decoder *ctf_metadata_decoder_create(
                goto end;
        }
 
-       BT_LOGD("Created CTF metadata decoder: "
-               "clock-class-offset-ns=%" PRId64 ", name=\"%s\", addr=%p",
-               clock_class_offset_ns, name, mdec);
+       BT_LOGD("Creating CTF metadata decoder: "
+               "clock-class-offset-s=%" PRId64 ", "
+               "clock-class-offset-ns=%" PRId64 ", "
+               "name=\"%s\", addr=%p",
+               config->clock_class_offset_s, config->clock_class_offset_ns,
+               name, mdec);
 
 end:
        return mdec;
@@ -416,6 +438,12 @@ enum ctf_metadata_decoder_status ctf_metadata_decoder_decode(
 
                BT_LOGD("Metadata stream is plain text: mdec-addr=%p", mdec);
 
+               if (init_pos < 0) {
+                       BT_LOGE_ERRNO("Failed to get current file position", ".");
+                       status = CTF_METADATA_DECODER_STATUS_ERROR;
+                       goto end;
+               }
+
                /* Check text-only metadata header and version */
                nr_items = fscanf(fp, "/* CTF %10u.%10u", &major, &minor);
                if (nr_items < 2) {