*/
#include <babeltrace/common-internal.h>
-#include <babeltrace/ctf-ir/packet.h>
-#include <babeltrace/ctf-ir/clock-class.h>
-#include <babeltrace/ctf-ir/stream.h>
-#include <babeltrace/ctf-ir/fields.h>
-#include <babeltrace/graph/private-port.h>
-#include <babeltrace/graph/private-component.h>
-#include <babeltrace/graph/private-component-source.h>
-#include <babeltrace/graph/private-notification-iterator.h>
-#include <babeltrace/graph/component.h>
-#include <babeltrace/graph/notification-iterator.h>
-#include <babeltrace/graph/clock-class-priority-map.h>
+#include <babeltrace/babeltrace.h>
#include <plugins-common.h>
#include <glib.h>
-#include <assert.h>
+#include <babeltrace/assert-internal.h>
#include <inttypes.h>
#include <stdbool.h>
#include "fs.h"
#include "data-stream-file.h"
#include "file.h"
#include "../common/metadata/decoder.h"
+#include "../common/notif-iter/notif-iter.h"
+#include "../common/utils/utils.h"
#include "query.h"
#define BT_LOG_TAG "PLUGIN-CTF-FS-SRC"
#include "logging.h"
-BT_HIDDEN
-bool ctf_fs_debug;
-
static
int notif_iter_data_set_current_ds_file(struct ctf_fs_notif_iter_data *notif_iter_data)
{
struct ctf_fs_ds_file_info *ds_file_info;
int ret = 0;
- assert(notif_iter_data->ds_file_info_index <
+ BT_ASSERT(notif_iter_data->ds_file_info_index <
notif_iter_data->ds_file_group->ds_file_infos->len);
ds_file_info = g_ptr_array_index(
notif_iter_data->ds_file_group->ds_file_infos,
ctf_fs_ds_file_destroy(notif_iter_data->ds_file);
notif_iter_data->ds_file = ctf_fs_ds_file_create(
notif_iter_data->ds_file_group->ctf_fs_trace,
+ notif_iter_data->notif_iter,
notif_iter_data->ds_file_group->stream,
ds_file_info->path->str);
if (!notif_iter_data->ds_file) {
}
ctf_fs_ds_file_destroy(notif_iter_data->ds_file);
+
+ if (notif_iter_data->notif_iter) {
+ bt_notif_iter_destroy(notif_iter_data->notif_iter);
+ }
+
g_free(notif_iter_data);
}
-struct bt_notification_iterator_next_return ctf_fs_iterator_next(
- struct bt_private_notification_iterator *iterator)
+struct bt_notification_iterator_next_method_return ctf_fs_iterator_next(
+ struct bt_private_connection_private_notification_iterator *iterator)
{
- struct bt_notification_iterator_next_return next_ret;
+ struct bt_notification_iterator_next_method_return next_ret;
struct ctf_fs_notif_iter_data *notif_iter_data =
- bt_private_notification_iterator_get_user_data(iterator);
+ bt_private_connection_private_notification_iterator_get_user_data(iterator);
int ret;
- assert(notif_iter_data->ds_file);
+ BT_ASSERT(notif_iter_data->ds_file);
next_ret = ctf_fs_ds_file_next(notif_iter_data->ds_file);
- if (next_ret.status == BT_NOTIFICATION_ITERATOR_STATUS_END) {
- assert(!next_ret.notification);
+
+ if (next_ret.status == BT_NOTIFICATION_ITERATOR_STATUS_OK &&
+ bt_notification_get_type(next_ret.notification) ==
+ BT_NOTIFICATION_TYPE_STREAM_BEGIN) {
+ if (notif_iter_data->skip_stream_begin_notifs) {
+ /*
+ * We already emitted a
+ * BT_NOTIFICATION_TYPE_STREAM_BEGIN
+ * notification: skip this one, get a new one.
+ */
+ BT_PUT(next_ret.notification);
+ next_ret = ctf_fs_ds_file_next(notif_iter_data->ds_file);
+ BT_ASSERT(next_ret.status != BT_NOTIFICATION_ITERATOR_STATUS_END);
+ goto end;
+ } else {
+ /*
+ * First BT_NOTIFICATION_TYPE_STREAM_BEGIN
+ * notification: skip all following.
+ */
+ notif_iter_data->skip_stream_begin_notifs = true;
+ goto end;
+ }
+ }
+
+ if (next_ret.status == BT_NOTIFICATION_ITERATOR_STATUS_OK &&
+ bt_notification_get_type(next_ret.notification) ==
+ BT_NOTIFICATION_TYPE_STREAM_END) {
notif_iter_data->ds_file_info_index++;
if (notif_iter_data->ds_file_info_index ==
notif_iter_data->ds_file_group->ds_file_infos->len) {
/*
* No more stream files to read: we reached the
- * real end.
+ * real end. Emit this
+ * BT_NOTIFICATION_TYPE_STREAM_END notification.
+ * The next time ctf_fs_iterator_next() is
+ * called for this notification iterator,
+ * ctf_fs_ds_file_next() will return
+ * BT_NOTIFICATION_ITERATOR_STATUS_END().
*/
goto end;
}
+ BT_PUT(next_ret.notification);
+ bt_notif_iter_reset(notif_iter_data->notif_iter);
+
/*
* Open and start reading the next stream file within
* our stream file group.
next_ret = ctf_fs_ds_file_next(notif_iter_data->ds_file);
/*
- * We should not get BT_NOTIFICATION_ITERATOR_STATUS_END
- * with a brand new stream file because empty stream
- * files are not even part of stream file groups, which
- * means we're sure to get at least one pair of "packet
- * begin" and "packet end" notifications in the case of
- * a single, empty packet.
+ * If we get a notification, we expect to get a
+ * BT_NOTIFICATION_TYPE_STREAM_BEGIN notification
+ * because the iterator's state machine emits one before
+ * even requesting the first block of data from the
+ * medium. Skip this notification because we're not
+ * really starting a new stream here, and try getting a
+ * new notification (which, if it works, is a
+ * BT_NOTIFICATION_TYPE_PACKET_BEGIN one). We're sure to
+ * get at least one pair of
+ * BT_NOTIFICATION_TYPE_PACKET_BEGIN and
+ * BT_NOTIFICATION_TYPE_PACKET_END notifications in the
+ * case of a single, empty packet. We know there's at
+ * least one packet because the stream file group does
+ * not contain empty stream files.
*/
- assert(next_ret.status != BT_NOTIFICATION_ITERATOR_STATUS_END);
+ BT_ASSERT(notif_iter_data->skip_stream_begin_notifs);
+
+ if (next_ret.status == BT_NOTIFICATION_ITERATOR_STATUS_OK) {
+ BT_ASSERT(bt_notification_get_type(next_ret.notification) ==
+ BT_NOTIFICATION_TYPE_STREAM_BEGIN);
+ BT_PUT(next_ret.notification);
+ next_ret = ctf_fs_ds_file_next(notif_iter_data->ds_file);
+ BT_ASSERT(next_ret.status != BT_NOTIFICATION_ITERATOR_STATUS_END);
+ }
}
end:
return next_ret;
}
-void ctf_fs_iterator_finalize(struct bt_private_notification_iterator *it)
+void ctf_fs_iterator_finalize(struct bt_private_connection_private_notification_iterator *it)
{
void *notif_iter_data =
- bt_private_notification_iterator_get_user_data(it);
+ bt_private_connection_private_notification_iterator_get_user_data(it);
ctf_fs_notif_iter_data_destroy(notif_iter_data);
}
enum bt_notification_iterator_status ctf_fs_iterator_init(
- struct bt_private_notification_iterator *it,
+ struct bt_private_connection_private_notification_iterator *it,
struct bt_private_port *port)
{
struct ctf_fs_port_data *port_data;
goto error;
}
+ notif_iter_data->notif_iter = bt_notif_iter_create(
+ port_data->ds_file_group->ctf_fs_trace->metadata->trace,
+ bt_common_get_page_size() * 8,
+ ctf_fs_ds_file_medops, NULL);
+ if (!notif_iter_data->notif_iter) {
+ BT_LOGE_STR("Cannot create a CTF notification iterator.");
+ ret = BT_NOTIFICATION_ITERATOR_STATUS_NOMEM;
+ goto error;
+ }
+
notif_iter_data->ds_file_group = port_data->ds_file_group;
iret = notif_iter_data_set_current_ds_file(notif_iter_data);
if (iret) {
goto error;
}
- ret = bt_private_notification_iterator_set_user_data(it, notif_iter_data);
- if (ret) {
+ ret = bt_private_connection_private_notification_iterator_set_user_data(it, notif_iter_data);
+ if (ret != BT_NOTIFICATION_ITERATOR_STATUS_OK) {
goto error;
}
goto end;
error:
- (void) bt_private_notification_iterator_set_user_data(it, NULL);
-
- if (ret == BT_NOTIFICATION_ITERATOR_STATUS_OK) {
- ret = BT_NOTIFICATION_ITERATOR_STATUS_ERROR;
- }
+ (void) bt_private_connection_private_notification_iterator_set_user_data(it, NULL);
end:
ctf_fs_notif_iter_data_destroy(notif_iter_data);
g_free(port_data);
}
+static
+GString *get_stream_instance_unique_name(
+ struct ctf_fs_ds_file_group *ds_file_group)
+{
+ GString *name;
+ struct ctf_fs_ds_file_info *ds_file_info;
+
+ name = g_string_new(NULL);
+ if (!name) {
+ goto end;
+ }
+
+ /*
+ * If there's more than one stream file in the stream file
+ * group, the first (earliest) stream file's path is used as
+ * the stream's unique name.
+ */
+ BT_ASSERT(ds_file_group->ds_file_infos->len > 0);
+ ds_file_info = g_ptr_array_index(ds_file_group->ds_file_infos, 0);
+ g_string_assign(name, ds_file_info->path->str);
+
+end:
+ return name;
+}
+
static
int create_one_port_for_trace(struct ctf_fs_component *ctf_fs,
struct ctf_fs_trace *ctf_fs_trace,
int ret = 0;
struct ctf_fs_port_data *port_data = NULL;
GString *port_name = NULL;
- struct ctf_fs_ds_file_info *ds_file_info =
- g_ptr_array_index(ds_file_group->ds_file_infos, 0);
- port_name = g_string_new(NULL);
+ port_name = get_stream_instance_unique_name(ds_file_group);
if (!port_name) {
goto error;
}
- /*
- * Assign the name for the new output port. If there's more than
- * one stream file in the stream file group, the first
- * (earliest) stream file's path is used.
- */
- assert(ds_file_group->ds_file_infos->len > 0);
- ds_file_info = g_ptr_array_index(ds_file_group->ds_file_infos, 0);
- g_string_assign(port_name, ds_file_info->path->str);
BT_LOGD("Creating one port named `%s`", port_name->str);
/* Create output port for this file */
return ret;
}
+static
uint64_t get_packet_header_stream_instance_id(struct ctf_fs_trace *ctf_fs_trace,
- struct bt_ctf_field *packet_header_field)
+ struct bt_field *packet_header_field)
{
- struct bt_ctf_field *stream_instance_id_field = NULL;
+ struct bt_field *stream_instance_id_field = NULL;
uint64_t stream_instance_id = -1ULL;
int ret;
goto end;
}
- stream_instance_id_field = bt_ctf_field_structure_get_field_by_name(
+ stream_instance_id_field = bt_field_structure_borrow_field_by_name(
packet_header_field, "stream_instance_id");
if (!stream_instance_id_field) {
goto end;
}
- ret = bt_ctf_field_unsigned_integer_get_value(stream_instance_id_field,
+ ret = bt_field_integer_unsigned_get_value(stream_instance_id_field,
&stream_instance_id);
if (ret) {
stream_instance_id = -1ULL;
}
end:
- bt_put(stream_instance_id_field);
return stream_instance_id;
}
-struct bt_ctf_stream_class *stream_class_from_packet_header(
- struct ctf_fs_trace *ctf_fs_trace,
- struct bt_ctf_field *packet_header_field)
-{
- struct bt_ctf_field *stream_id_field = NULL;
- struct bt_ctf_stream_class *stream_class = NULL;
- uint64_t stream_id = -1ULL;
- int ret;
-
- if (!packet_header_field) {
- goto single_stream_class;
- }
-
- stream_id_field = bt_ctf_field_structure_get_field_by_name(
- packet_header_field, "stream_id");
- if (!stream_id_field) {
- goto end;
- }
-
- ret = bt_ctf_field_unsigned_integer_get_value(stream_id_field,
- &stream_id);
- if (ret) {
- stream_id = -1ULL;
- }
-
- if (stream_id == -1ULL) {
-single_stream_class:
- /* Single stream class */
- if (bt_ctf_trace_get_stream_class_count(
- ctf_fs_trace->metadata->trace) == 0) {
- goto end;
- }
-
- stream_class = bt_ctf_trace_get_stream_class_by_index(
- ctf_fs_trace->metadata->trace, 0);
- } else {
- stream_class = bt_ctf_trace_get_stream_class_by_id(
- ctf_fs_trace->metadata->trace, stream_id);
- }
-
-end:
- bt_put(stream_id_field);
- return stream_class;
-}
-
uint64_t get_packet_context_timestamp_begin_ns(
struct ctf_fs_trace *ctf_fs_trace,
- struct bt_ctf_field *packet_context_field)
+ struct bt_field *packet_context_field)
{
int ret;
- struct bt_ctf_field *timestamp_begin_field = NULL;
- struct bt_ctf_field_type *timestamp_begin_ft = NULL;
+ struct bt_field *timestamp_begin_field = NULL;
+ struct bt_field_type *timestamp_begin_ft = NULL;
uint64_t timestamp_begin_raw_value = -1ULL;
uint64_t timestamp_begin_ns = -1ULL;
int64_t timestamp_begin_ns_signed;
- struct bt_ctf_clock_class *timestamp_begin_clock_class = NULL;
- struct bt_ctf_clock_value *clock_value = NULL;
+ struct bt_clock_class *timestamp_begin_clock_class = NULL;
if (!packet_context_field) {
goto end;
}
- timestamp_begin_field = bt_ctf_field_structure_get_field_by_name(
+ timestamp_begin_field = bt_field_structure_borrow_field_by_name(
packet_context_field, "timestamp_begin");
if (!timestamp_begin_field) {
goto end;
}
- timestamp_begin_ft = bt_ctf_field_get_type(timestamp_begin_field);
- assert(timestamp_begin_ft);
+ timestamp_begin_ft = bt_field_borrow_type(timestamp_begin_field);
+ BT_ASSERT(timestamp_begin_ft);
timestamp_begin_clock_class =
- bt_ctf_field_type_integer_get_mapped_clock_class(timestamp_begin_ft);
+ bt_field_type_integer_borrow_mapped_clock_class(timestamp_begin_ft);
if (!timestamp_begin_clock_class) {
goto end;
}
- ret = bt_ctf_field_unsigned_integer_get_value(timestamp_begin_field,
+ ret = bt_field_integer_unsigned_get_value(timestamp_begin_field,
×tamp_begin_raw_value);
if (ret) {
goto end;
}
- clock_value = bt_ctf_clock_value_create(timestamp_begin_clock_class,
- timestamp_begin_raw_value);
- if (!clock_value) {
- goto end;
- }
-
- ret = bt_ctf_clock_value_get_value_ns_from_epoch(clock_value,
- ×tamp_begin_ns_signed);
+ ret = bt_clock_class_cycles_to_ns(timestamp_begin_clock_class,
+ timestamp_begin_raw_value, ×tamp_begin_ns_signed);
if (ret) {
goto end;
}
timestamp_begin_ns = (uint64_t) timestamp_begin_ns_signed;
end:
- bt_put(timestamp_begin_field);
- bt_put(timestamp_begin_ft);
- bt_put(timestamp_begin_clock_class);
- bt_put(clock_value);
return timestamp_begin_ns;
}
}
bt_put(ds_file_group->stream);
+ bt_put(ds_file_group->stream_class);
g_free(ds_file_group);
}
static
struct ctf_fs_ds_file_group *ctf_fs_ds_file_group_create(
struct ctf_fs_trace *ctf_fs_trace,
- struct bt_ctf_stream_class *stream_class,
+ struct bt_stream_class *stream_class,
uint64_t stream_instance_id)
{
struct ctf_fs_ds_file_group *ds_file_group;
- assert(stream_class);
ds_file_group = g_new0(struct ctf_fs_ds_file_group, 1);
if (!ds_file_group) {
goto error;
goto error;
}
- if (stream_instance_id == -1ULL) {
- ds_file_group->stream = bt_ctf_stream_create(
- stream_class, NULL);
- } else {
- ds_file_group->stream = bt_ctf_stream_create_with_id(
- stream_class, NULL, stream_instance_id);
- }
-
- if (!ds_file_group->stream) {
- goto error;
- }
-
+ ds_file_group->stream_id = stream_instance_id;
+ BT_ASSERT(stream_class);
+ ds_file_group->stream_class = bt_get(stream_class);
ds_file_group->ctf_fs_trace = ctf_fs_trace;
-
goto end;
error:
return ds_file_group;
}
+/* Replace by g_ptr_array_insert when we depend on glib >= 2.40. */
+static
+void array_insert(GPtrArray *array, gpointer element, size_t pos)
+{
+ size_t original_array_len = array->len;
+
+ /* Allocate an unused element at the end of the array. */
+ g_ptr_array_add(array, NULL);
+
+ /* If we are not inserting at the end, move the elements by one. */
+ if (pos < original_array_len) {
+ memmove(&(array->pdata[pos + 1]),
+ &(array->pdata[pos]),
+ (original_array_len - pos) * sizeof(gpointer));
+ }
+
+ /* Insert the value and bump the array len */
+ array->pdata[pos] = element;
+}
+
static
int ctf_fs_ds_file_group_add_ds_file_info(
struct ctf_fs_ds_file_group *ds_file_group,
}
}
- if (i == ds_file_group->ds_file_infos->len) {
- /* Append instead */
- i = -1;
- }
-
- g_ptr_array_insert(ds_file_group->ds_file_infos, i, ds_file_info);
+ array_insert(ds_file_group->ds_file_infos, ds_file_info, i);
ds_file_info = NULL;
goto end;
int add_ds_file_to_ds_file_group(struct ctf_fs_trace *ctf_fs_trace,
const char *path)
{
- struct bt_ctf_field *packet_header_field = NULL;
- struct bt_ctf_field *packet_context_field = NULL;
- struct bt_ctf_stream_class *stream_class = NULL;
+ struct bt_field *packet_header_field = NULL;
+ struct bt_field *packet_context_field = NULL;
+ struct bt_stream_class *stream_class = NULL;
uint64_t stream_instance_id = -1ULL;
uint64_t begin_ns = -1ULL;
struct ctf_fs_ds_file_group *ds_file_group = NULL;
bool add_group = false;
int ret;
size_t i;
- struct ctf_fs_ds_file *ds_file;
+ struct ctf_fs_ds_file *ds_file = NULL;
struct ctf_fs_ds_index *index = NULL;
+ struct bt_notif_iter *notif_iter = NULL;
+
+ notif_iter = bt_notif_iter_create(ctf_fs_trace->metadata->trace,
+ bt_common_get_page_size() * 8, ctf_fs_ds_file_medops, NULL);
+ if (!notif_iter) {
+ BT_LOGE_STR("Cannot create a CTF notification iterator.");
+ goto error;
+ }
- ds_file = ctf_fs_ds_file_create(ctf_fs_trace, NULL, path);
+ ds_file = ctf_fs_ds_file_create(ctf_fs_trace, notif_iter, NULL, path);
if (!ds_file) {
goto error;
}
- ret = ctf_fs_ds_file_get_packet_header_context_fields(ds_file,
+ ret = ctf_fs_ds_file_borrow_packet_header_context_fields(ds_file,
&packet_header_field, &packet_context_field);
if (ret) {
BT_LOGE("Cannot get stream file's first packet's header and context fields (`%s`).",
packet_header_field);
begin_ns = get_packet_context_timestamp_begin_ns(ctf_fs_trace,
packet_context_field);
- stream_class = stream_class_from_packet_header(ctf_fs_trace,
- packet_header_field);
+ stream_class = ctf_utils_borrow_stream_class_from_packet_header(
+ ctf_fs_trace->metadata->trace, packet_header_field);
if (!stream_class) {
goto error;
}
* there's no timestamp to order the file within its
* group.
*/
-
ds_file_group = ctf_fs_ds_file_group_create(ctf_fs_trace,
stream_class, stream_instance_id);
if (!ds_file_group) {
}
ret = ctf_fs_ds_file_group_add_ds_file_info(ds_file_group,
- path, begin_ns, index);
+ path, begin_ns, index);
/* Ownership of index is transferred. */
index = NULL;
if (ret) {
goto end;
}
- assert(stream_instance_id != -1ULL);
- assert(begin_ns != -1ULL);
+ BT_ASSERT(stream_instance_id != -1ULL);
+ BT_ASSERT(begin_ns != -1ULL);
/* Find an existing stream file group with this ID */
for (i = 0; i < ctf_fs_trace->ds_file_groups->len; i++) {
- int64_t id;
- struct bt_ctf_stream_class *cand_stream_class;
-
ds_file_group = g_ptr_array_index(
ctf_fs_trace->ds_file_groups, i);
- id = bt_ctf_stream_get_id(ds_file_group->stream);
- cand_stream_class = bt_ctf_stream_get_class(
- ds_file_group->stream);
-
- assert(cand_stream_class);
- bt_put(cand_stream_class);
- if (cand_stream_class == stream_class &&
- (uint64_t) id == stream_instance_id) {
+ if (ds_file_group->stream_class == stream_class &&
+ ds_file_group->stream_id ==
+ stream_instance_id) {
break;
}
add_group = true;
}
- ret = ctf_fs_ds_file_group_add_ds_file_info(ds_file_group,
- path, begin_ns, index);
+ ret = ctf_fs_ds_file_group_add_ds_file_info(ds_file_group, path,
+ begin_ns, index);
index = NULL;
if (ret) {
goto error;
if (add_group && ds_file_group) {
g_ptr_array_add(ctf_fs_trace->ds_file_groups, ds_file_group);
}
+
ctf_fs_ds_file_destroy(ds_file);
+
+ if (notif_iter) {
+ bt_notif_iter_destroy(notif_iter);
+ }
+
ctf_fs_ds_index_destroy(index);
- bt_put(packet_header_field);
- bt_put(packet_context_field);
- bt_put(stream_class);
return ret;
}
const char *basename;
GError *error = NULL;
GDir *dir = NULL;
+ size_t i;
/* Check each file in the path directory, except specific ones */
dir = g_dir_open(ctf_fs_trace->path->str, 0, &error);
if (!strcmp(basename, CTF_FS_METADATA_FILENAME)) {
/* Ignore the metadata stream. */
- BT_LOGD("Ignoring metadata file `%s/%s`",
+ BT_LOGD("Ignoring metadata file `%s" G_DIR_SEPARATOR_S "%s`",
ctf_fs_trace->path->str, basename);
continue;
}
if (basename[0] == '.') {
- BT_LOGD("Ignoring hidden file `%s/%s`",
+ BT_LOGD("Ignoring hidden file `%s" G_DIR_SEPARATOR_S "%s`",
ctf_fs_trace->path->str, basename);
continue;
}
/* Create the file. */
file = ctf_fs_file_create();
if (!file) {
- BT_LOGE("Cannot create stream file object for file `%s/%s`",
+ BT_LOGE("Cannot create stream file object for file `%s" G_DIR_SEPARATOR_S "%s`",
ctf_fs_trace->path->str, basename);
goto error;
}
/* Create full path string. */
- g_string_append_printf(file->path, "%s/%s",
+ g_string_append_printf(file->path, "%s" G_DIR_SEPARATOR_S "%s",
ctf_fs_trace->path->str, basename);
if (!g_file_test(file->path->str, G_FILE_TEST_IS_REGULAR)) {
BT_LOGD("Ignoring non-regular file `%s`",
ret = add_ds_file_to_ds_file_group(ctf_fs_trace,
file->path->str);
if (ret) {
- BT_LOGD("Cannot add stream file `%s` to stream file group",
+ BT_LOGE("Cannot add stream file `%s` to stream file group",
file->path->str);
ctf_fs_file_destroy(file);
goto error;
ctf_fs_file_destroy(file);
}
+ /*
+ * At this point, DS file groupes are created, but their
+ * associated stream objects do not exist yet. This is because
+ * we need to name the created stream object with the data
+ * stream file's path. We have everything we need here to do
+ * this.
+ */
+ for (i = 0; i < ctf_fs_trace->ds_file_groups->len; i++) {
+ struct ctf_fs_ds_file_group *ds_file_group =
+ g_ptr_array_index(ctf_fs_trace->ds_file_groups, i);
+ GString *name = get_stream_instance_unique_name(ds_file_group);
+
+ if (!name) {
+ goto error;
+ }
+
+ if (ds_file_group->stream_id == -1ULL) {
+ /* No stream ID: use 0 */
+ ds_file_group->stream = bt_stream_create(
+ ds_file_group->stream_class, name->str,
+ ctf_fs_trace->next_stream_id);
+ ctf_fs_trace->next_stream_id++;
+ } else {
+ /* Specific stream ID */
+ ds_file_group->stream = bt_stream_create(
+ ds_file_group->stream_class, name->str,
+ ds_file_group->stream_id);
+ }
+
+ g_string_free(name, TRUE);
+
+ if (!ds_file_group->stream) {
+ BT_LOGE("Cannot create stream for DS file group: "
+ "addr=%p, stream-name=\"%s\"",
+ ds_file_group, name->str);
+ goto error;
+ }
+ }
+
goto end;
error:
size_t i;
int count;
- assert(ctf_fs_trace);
+ BT_ASSERT(ctf_fs_trace);
ctf_fs_trace->cc_prio_map = bt_clock_class_priority_map_create();
if (!ctf_fs_trace->cc_prio_map) {
ret = -1;
goto end;
}
- count = bt_ctf_trace_get_clock_class_count(
+ count = bt_trace_get_clock_class_count(
ctf_fs_trace->metadata->trace);
- assert(count >= 0);
+ BT_ASSERT(count >= 0);
for (i = 0; i < count; i++) {
- struct bt_ctf_clock_class *clock_class =
- bt_ctf_trace_get_clock_class_by_index(
+ struct bt_clock_class *clock_class =
+ bt_trace_borrow_clock_class_by_index(
ctf_fs_trace->metadata->trace, i);
- assert(clock_class);
+ BT_ASSERT(clock_class);
ret = bt_clock_class_priority_map_add_clock_class(
ctf_fs_trace->cc_prio_map, clock_class, 0);
- BT_PUT(clock_class);
if (ret) {
goto end;
BT_HIDDEN
struct ctf_fs_trace *ctf_fs_trace_create(const char *path, const char *name,
- struct metadata_overrides *overrides)
+ struct ctf_fs_metadata_config *metadata_config)
{
struct ctf_fs_trace *ctf_fs_trace;
int ret;
goto error;
}
- ret = ctf_fs_metadata_set_trace(ctf_fs_trace, overrides);
+ ret = ctf_fs_metadata_set_trace(ctf_fs_trace, metadata_config);
if (ret) {
goto error;
}
* trace needs. There won't be any more. Therefore it is safe to
* make this trace static.
*/
- (void) bt_ctf_trace_set_is_static(ctf_fs_trace->metadata->trace);
+ (void) bt_trace_set_is_static(ctf_fs_trace->metadata->trace);
goto end;
goto end;
}
- g_string_printf(metadata_path, "%s/%s", path, CTF_FS_METADATA_FILENAME);
+ g_string_printf(metadata_path, "%s" G_DIR_SEPARATOR_S "%s", path, CTF_FS_METADATA_FILENAME);
if (g_file_test(metadata_path->str, G_FILE_TEST_IS_REGULAR)) {
ret = 1;
goto end;
}
+ // FIXME: Remove or ifdef for __MINGW32__
if (strcmp(norm_path->str, "/") == 0) {
BT_LOGE("Opening a trace in `/` is not supported.");
ret = -1;
}
*trace_paths = g_list_prepend(*trace_paths, norm_path);
- assert(*trace_paths);
+ BT_ASSERT(*trace_paths);
norm_path = NULL;
end:
goto end;
}
- g_string_printf(sub_path, "%s/%s", start_path, basename);
+ g_string_printf(sub_path, "%s" G_DIR_SEPARATOR_S "%s", start_path, basename);
ret = ctf_fs_find_traces(trace_paths, sub_path->str);
g_string_free(sub_path, TRUE);
if (ret) {
last_sep = strrchr(base_path, G_DIR_SEPARATOR);
/* We know there's at least one separator */
- assert(last_sep);
+ BT_ASSERT(last_sep);
/* Distance to base */
base_dist = last_sep - base_path + 1;
GString *trace_name = g_string_new(NULL);
GString *trace_path = node->data;
- assert(trace_name);
+ BT_ASSERT(trace_name);
g_string_assign(trace_name, &trace_path->str[base_dist]);
trace_names = g_list_append(trace_names, trace_name);
}
GList *trace_names = NULL;
GList *tp_node;
GList *tn_node;
- struct metadata_overrides metadata_overrides = {
- .clock_offset_s = ctf_fs->options.clock_offset,
- .clock_offset_ns = ctf_fs->options.clock_offset_ns,
- };
norm_path = bt_common_normalize_path(path_param, NULL);
if (!norm_path) {
GString *trace_name = tn_node->data;
ctf_fs_trace = ctf_fs_trace_create(trace_path->str,
- trace_name->str, &metadata_overrides);
+ trace_name->str, &ctf_fs->metadata_config);
if (!ctf_fs_trace) {
BT_LOGE("Cannot create trace for `%s`.",
trace_path->str);
struct ctf_fs_component *ctf_fs;
struct bt_value *value = NULL;
const char *path_param;
- int ret;
+ enum bt_component_status ret;
+ enum bt_value_status value_ret;
ctf_fs = g_new0(struct ctf_fs_component, 1);
if (!ctf_fs) {
}
ret = bt_private_component_set_user_data(priv_comp, ctf_fs);
- assert(ret == 0);
+ BT_ASSERT(ret == BT_COMPONENT_STATUS_OK);
/*
* We don't need to get a new reference here because as long as
* private component should also exist.
*/
ctf_fs->priv_comp = priv_comp;
- value = bt_value_map_get(params, "path");
- if (!bt_value_is_string(value)) {
+ value = bt_value_map_borrow(params, "path");
+ if (value && !bt_value_is_string(value)) {
goto error;
}
- ret = bt_value_string_get(value, &path_param);
- assert(ret == 0);
- BT_PUT(value);
- value = bt_value_map_get(params, "offset-s");
+ value_ret = bt_value_string_get(value, &path_param);
+ BT_ASSERT(value_ret == BT_VALUE_STATUS_OK);
+ value = bt_value_map_borrow(params, "clock-class-offset-s");
if (value) {
- int64_t offset;
-
if (!bt_value_is_integer(value)) {
- BT_LOGE("offset-s should be an integer");
+ BT_LOGE("clock-class-offset-s should be an integer");
goto error;
}
- ret = bt_value_integer_get(value, &offset);
- assert(ret == 0);
- ctf_fs->options.clock_offset = offset;
- BT_PUT(value);
+ value_ret = bt_value_integer_get(value,
+ &ctf_fs->metadata_config.clock_class_offset_s);
+ BT_ASSERT(value_ret == BT_VALUE_STATUS_OK);
}
- value = bt_value_map_get(params, "offset-ns");
+ value = bt_value_map_borrow(params, "clock-class-offset-ns");
if (value) {
- int64_t offset;
-
if (!bt_value_is_integer(value)) {
- BT_LOGE("offset-ns should be an integer");
+ BT_LOGE("clock-class-offset-ns should be an integer");
goto error;
}
- ret = bt_value_integer_get(value, &offset);
- assert(ret == 0);
- ctf_fs->options.clock_offset_ns = offset;
- BT_PUT(value);
+ value_ret = bt_value_integer_get(value,
+ &ctf_fs->metadata_config.clock_class_offset_ns);
+ BT_ASSERT(value_ret == BT_VALUE_STATUS_OK);
}
ctf_fs->port_data = g_ptr_array_new_with_free_func(port_data_destroy);
goto error;
}
- ret = create_ctf_fs_traces(ctf_fs, path_param);
- if (ret) {
+ if (create_ctf_fs_traces(ctf_fs, path_param)) {
goto error;
}
ctf_fs_destroy(ctf_fs);
ctf_fs = NULL;
ret = bt_private_component_set_user_data(priv_comp, NULL);
- assert(ret == 0);
+ BT_ASSERT(ret == BT_COMPONENT_STATUS_OK);
end:
- bt_put(value);
return ctf_fs;
}
struct ctf_fs_component *ctf_fs;
enum bt_component_status ret = BT_COMPONENT_STATUS_OK;
- ctf_fs_debug = g_strcmp0(getenv("CTF_FS_DEBUG"), "1") == 0;
ctf_fs = ctf_fs_create(priv_comp, params);
if (!ctf_fs) {
ret = BT_COMPONENT_STATUS_ERROR;
}
BT_HIDDEN
-struct bt_value *ctf_fs_query(struct bt_component_class *comp_class,
+struct bt_component_class_query_method_return ctf_fs_query(
+ struct bt_component_class *comp_class,
+ struct bt_query_executor *query_exec,
const char *object, struct bt_value *params)
{
- struct bt_value *result = NULL;
+ struct bt_component_class_query_method_return ret = {
+ .result = NULL,
+ .status = BT_QUERY_STATUS_OK,
+ };
if (!strcmp(object, "metadata-info")) {
- result = metadata_info_query(comp_class, params);
+ ret = metadata_info_query(comp_class, params);
} else if (!strcmp(object, "trace-info")) {
- result = trace_info_query(comp_class, params);
+ ret = trace_info_query(comp_class, params);
} else {
BT_LOGE("Unknown query object `%s`", object);
+ ret.status = BT_QUERY_STATUS_INVALID_OBJECT;
goto end;
}
end:
- return result;
+ return ret;
}
projects / babeltrace.git / blobdiff