Rename bt_ctf_X -> bt_X, maintain backward compat. for pre-2.0 CTF writer
[babeltrace.git] / plugins / ctf / lttng-live / viewer-connection.c
index 9f8823a3d6d7a9560a6895039b690c3c1d52ec11..e66bd1e8aa9c0929b80b97476956af02ebf5a909 100644 (file)
@@ -20,6 +20,9 @@
  * SOFTWARE.
  */
 
+#define BT_LOG_TAG "PLUGIN-CTF-LTTNG-LIVE-SRC-VIEWER"
+#include "logging.h"
+
 #include <stdio.h>
 #include <stdint.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <glib.h>
 #include <inttypes.h>
-#include <sys/socket.h>
 #include <sys/types.h>
-#include <netinet/in.h>
-#include <netdb.h>
 #include <fcntl.h>
-#include <poll.h>
 
-#include <babeltrace/compat/send-internal.h>
+#include <babeltrace/compat/socket-internal.h>
+#include <babeltrace/endian-internal.h>
 #include <babeltrace/compiler-internal.h>
 #include <babeltrace/common-internal.h>
-#include <babeltrace/graph/graph.h>
-
-#define BT_LOG_TAG "PLUGIN-CTF-LTTNG-LIVE-VIEWER"
+#include <babeltrace/babeltrace.h>
 
 #include "lttng-live-internal.h"
 #include "viewer-connection.h"
@@ -54,17 +52,17 @@ static ssize_t lttng_live_recv(struct bt_live_viewer_connection *viewer_connecti
        size_t copied = 0, to_copy = len;
        struct lttng_live_component *lttng_live =
                        viewer_connection->lttng_live;
-       int fd = viewer_connection->control_sock;
+       BT_SOCKET sock = viewer_connection->control_sock;
 
        do {
-               ret = recv(fd, buf + copied, to_copy, 0);
+               ret = bt_socket_recv(sock, buf + copied, to_copy, 0);
                if (ret > 0) {
                        assert(ret <= to_copy);
                        copied += ret;
                        to_copy -= ret;
                }
-               if (ret < 0 && errno == EINTR) {
-                       if (lttng_live && bt_graph_is_canceled(lttng_live->graph)) {
+               if (ret == BT_SOCKET_ERROR && bt_socket_interrupted()) {
+                       if (lttng_live_is_canceled(lttng_live)) {
                                break;
                        } else {
                                continue;
@@ -73,7 +71,7 @@ static ssize_t lttng_live_recv(struct bt_live_viewer_connection *viewer_connecti
        } while (ret > 0 && to_copy > 0);
        if (ret > 0)
                ret = copied;
-       /* ret = 0 means orderly shutdown, ret < 0 is error. */
+       /* ret = 0 means orderly shutdown, ret == BT_SOCKET_ERROR is error. */
        return ret;
 }
 
@@ -82,13 +80,13 @@ static ssize_t lttng_live_send(struct bt_live_viewer_connection *viewer_connecti
 {
        struct lttng_live_component *lttng_live =
                        viewer_connection->lttng_live;
-       int fd = viewer_connection->control_sock;
+       BT_SOCKET sock = viewer_connection->control_sock;
        ssize_t ret;
 
        for (;;) {
-               ret = bt_send_nosigpipe(fd, buf, len);
-               if (ret < 0 && errno == EINTR) {
-                       if (lttng_live && bt_graph_is_canceled(lttng_live->graph)) {
+               ret = bt_socket_send_nosigpipe(sock, buf, len);
+               if (ret == BT_SOCKET_ERROR && bt_socket_interrupted()) {
+                       if (lttng_live_is_canceled(lttng_live)) {
                                break;
                        } else {
                                continue;
@@ -172,15 +170,15 @@ static int lttng_live_handshake(struct bt_live_viewer_connection *viewer_connect
        connect.type = htobe32(LTTNG_VIEWER_CLIENT_COMMAND);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &connect, sizeof(connect));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending version: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending version: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(connect));
@@ -190,14 +188,14 @@ static int lttng_live_handshake(struct bt_live_viewer_connection *viewer_connect
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving version: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving version: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(connect));
 
        BT_LOGD("Received viewer session ID : %" PRIu64,
-                       be64toh(connect.viewer_session_id));
+                       (uint64_t) be64toh(connect.viewer_session_id));
        BT_LOGD("Relayd version : %u.%u", be32toh(connect.major),
                        be32toh(connect.minor));
 
@@ -237,8 +235,8 @@ static int lttng_live_connect_viewer(struct bt_live_viewer_connection *viewer_co
                goto error;
        }
 
-       if ((viewer_connection->control_sock = socket(AF_INET, SOCK_STREAM, 0)) == -1) {
-               BT_LOGE("Socket creation failed: %s", strerror(errno));
+       if ((viewer_connection->control_sock = socket(AF_INET, SOCK_STREAM, 0)) == BT_INVALID_SOCKET) {
+               BT_LOGE("Socket creation failed: %s", bt_socket_errormsg());
                goto error;
        }
 
@@ -248,8 +246,8 @@ static int lttng_live_connect_viewer(struct bt_live_viewer_connection *viewer_co
        memset(&(server_addr.sin_zero), 0, 8);
 
        if (connect(viewer_connection->control_sock, (struct sockaddr *) &server_addr,
-                               sizeof(struct sockaddr)) == -1) {
-               BT_LOGE("Connection failed: %s", strerror(errno));
+                               sizeof(struct sockaddr)) == BT_SOCKET_ERROR) {
+               BT_LOGE("Connection failed: %s", bt_socket_errormsg());
                goto error;
        }
        if (lttng_live_handshake(viewer_connection)) {
@@ -261,23 +259,23 @@ static int lttng_live_connect_viewer(struct bt_live_viewer_connection *viewer_co
        return ret;
 
 error:
-       if (viewer_connection->control_sock >= 0) {
-               if (close(viewer_connection->control_sock)) {
-                       BT_LOGE("Close: %s", strerror(errno));
+       if (viewer_connection->control_sock != BT_INVALID_SOCKET) {
+               if (bt_socket_close(viewer_connection->control_sock) == BT_SOCKET_ERROR) {
+                       BT_LOGE("Close: %s", bt_socket_errormsg());
                }
        }
-       viewer_connection->control_sock = -1;
+       viewer_connection->control_sock = BT_INVALID_SOCKET;
        return -1;
 }
 
 static void lttng_live_disconnect_viewer(struct bt_live_viewer_connection *viewer_connection)
 {
-       if (viewer_connection->control_sock < 0) {
+       if (viewer_connection->control_sock == BT_INVALID_SOCKET) {
                return;
        }
-       if (close(viewer_connection->control_sock)) {
-               BT_LOGE("Close: %s", strerror(errno));
-               viewer_connection->control_sock = -1;
+       if (bt_socket_close(viewer_connection->control_sock) == BT_SOCKET_ERROR) {
+               BT_LOGE("Close: %s", bt_socket_errormsg());
+               viewer_connection->control_sock = BT_INVALID_SOCKET;
        }
 }
 
@@ -572,8 +570,8 @@ struct bt_value *bt_live_viewer_connection_list_sessions(struct bt_live_viewer_c
        cmd.cmd_version = htobe32(0);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
@@ -583,8 +581,8 @@ struct bt_value *bt_live_viewer_connection_list_sessions(struct bt_live_viewer_c
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving session list: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving session list: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(list));
@@ -599,8 +597,8 @@ struct bt_value *bt_live_viewer_connection_list_sessions(struct bt_live_viewer_c
                        BT_LOGI("Remote side has closed connection");
                        goto error;
                }
-               if (ret_len < 0) {
-                       BT_LOGE("Error receiving session: %s", strerror(errno));
+               if (ret_len == BT_SOCKET_ERROR) {
+                       BT_LOGE("Error receiving session: %s", bt_socket_errormsg());
                        goto error;
                }
                assert(ret_len == sizeof(lsession));
@@ -636,8 +634,8 @@ int lttng_live_query_session_ids(struct lttng_live_component *lttng_live)
        cmd.cmd_version = htobe32(0);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
@@ -647,8 +645,8 @@ int lttng_live_query_session_ids(struct lttng_live_component *lttng_live)
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving session list: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving session list: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(list));
@@ -661,8 +659,8 @@ int lttng_live_query_session_ids(struct lttng_live_component *lttng_live)
                        BT_LOGI("Remote side has closed connection");
                        goto error;
                }
-               if (ret_len < 0) {
-                       BT_LOGE("Error receiving session: %s", strerror(errno));
+               if (ret_len == BT_SOCKET_ERROR) {
+                       BT_LOGE("Error receiving session: %s", bt_socket_errormsg());
                        goto error;
                }
                assert(ret_len == sizeof(lsession));
@@ -670,12 +668,17 @@ int lttng_live_query_session_ids(struct lttng_live_component *lttng_live)
                lsession.session_name[LTTNG_VIEWER_NAME_MAX - 1] = '\0';
                session_id = be64toh(lsession.id);
 
+               BT_LOGD("Adding session %" PRIu64 " hostname: %s session_name: %s",
+                       session_id, lsession.hostname, lsession.session_name);
+
                if ((strncmp(lsession.session_name,
                        viewer_connection->session_name->str,
-                       MAXNAMLEN) == 0) && (strncmp(lsession.hostname,
+                       LTTNG_VIEWER_NAME_MAX) == 0) && (strncmp(lsession.hostname,
                                viewer_connection->target_hostname->str,
-                               MAXNAMLEN) == 0)) {
-                       if (lttng_live_add_session(lttng_live, session_id)) {
+                               LTTNG_VIEWER_HOST_NAME_MAX) == 0)) {
+                       if (lttng_live_add_session(lttng_live, session_id,
+                                       lsession.hostname,
+                                       lsession.session_name)) {
                                goto error;
                        }
                }
@@ -702,8 +705,8 @@ int lttng_live_create_viewer_session(struct lttng_live_component *lttng_live)
        cmd.cmd_version = htobe32(0);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
@@ -713,8 +716,8 @@ int lttng_live_create_viewer_session(struct lttng_live_component *lttng_live)
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving create session reply: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving create session reply: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(resp));
@@ -755,7 +758,7 @@ int receive_streams(struct lttng_live_session *session,
                        BT_LOGI("Remote side has closed connection");
                        goto error;
                }
-               if (ret_len < 0) {
+               if (ret_len == BT_SOCKET_ERROR) {
                        BT_LOGE("Error receiving stream");
                        goto error;
                }
@@ -770,7 +773,8 @@ int receive_streams(struct lttng_live_session *session,
                                        stream_id, stream.path_name,
                                        stream.channel_name);
                        if (lttng_live_metadata_create_stream(session,
-                                       ctf_trace_id, stream_id)) {
+                                       ctf_trace_id, stream_id,
+                                       stream.path_name)) {
                                BT_LOGE("Error creating metadata stream");
 
                                goto error;
@@ -822,15 +826,15 @@ int lttng_live_attach_session(struct lttng_live_session *session)
        rq.seek = htobe32(LTTNG_VIEWER_SEEK_LAST);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending attach request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending attach request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -840,8 +844,8 @@ int lttng_live_attach_session(struct lttng_live_session *session)
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving attach response: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving attach response: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rp));
@@ -905,15 +909,15 @@ int lttng_live_detach_session(struct lttng_live_session *session)
        rq.session_id = htobe64(session_id);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending detach request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending detach request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -923,8 +927,8 @@ int lttng_live_detach_session(struct lttng_live_session *session)
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving detach response: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving detach response: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rp));
@@ -974,15 +978,15 @@ ssize_t lttng_live_get_one_metadata_packet(struct lttng_live_trace *trace,
        cmd.cmd_version = htobe32(0);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending get_metadata request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending get_metadata request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -992,8 +996,8 @@ ssize_t lttng_live_get_one_metadata_packet(struct lttng_live_trace *trace,
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving get_metadata response: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving get_metadata response: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rp));
@@ -1030,8 +1034,8 @@ ssize_t lttng_live_get_one_metadata_packet(struct lttng_live_trace *trace,
                BT_LOGI("Remote side has closed connection");
                goto error_free_data;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving trace packet: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving trace packet: %s", bt_socket_errormsg());
                goto error_free_data;
        }
        assert(ret_len == len);
@@ -1074,7 +1078,7 @@ void lttng_index_to_packet_index(struct lttng_viewer_index *lindex,
 }
 
 BT_HIDDEN
-enum bt_ctf_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_live_component *lttng_live,
+enum bt_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_live_component *lttng_live,
                struct lttng_live_stream_iterator *stream,
                struct packet_index *index)
 {
@@ -1083,8 +1087,8 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_li
        ssize_t ret_len;
        struct lttng_viewer_index rp;
        uint32_t flags, status;
-       enum bt_ctf_lttng_live_iterator_status retstatus =
-                       BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_OK;
+       enum bt_lttng_live_iterator_status retstatus =
+                       BT_LTTNG_LIVE_ITERATOR_STATUS_OK;
        struct bt_live_viewer_connection *viewer_connection =
                        lttng_live->viewer_connection;
        struct lttng_live_trace *trace = stream->trace;
@@ -1097,15 +1101,15 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_li
        rq.stream_id = htobe64(stream->viewer_stream_id);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending get_next_index request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending get_next_index request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -1115,8 +1119,8 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_li
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving get_next_index response: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving get_next_index response: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rp));
@@ -1174,14 +1178,14 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_next_index(struct lttng_li
        case LTTNG_VIEWER_INDEX_RETRY:
                BT_LOGD("get_next_index: retry");
                memset(index, 0, sizeof(struct packet_index));
-               retstatus = BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
+               retstatus = BT_LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
                stream->state = LTTNG_LIVE_STREAM_ACTIVE_NO_DATA;
                goto end;
        case LTTNG_VIEWER_INDEX_HUP:
                BT_LOGD("get_next_index: stream hung up");
                memset(index, 0, sizeof(struct packet_index));
                index->offset = EOF;
-               retstatus = BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_END;
+               retstatus = BT_LTTNG_LIVE_ITERATOR_STATUS_END;
                stream->state = LTTNG_LIVE_STREAM_EOF;
                break;
        case LTTNG_VIEWER_INDEX_ERR:
@@ -1199,20 +1203,20 @@ end:
        return retstatus;
 
 error:
-       if (bt_graph_is_canceled(lttng_live->graph)) {
-               retstatus = BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
+       if (lttng_live_is_canceled(lttng_live)) {
+               retstatus = BT_LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
        } else {
-               retstatus = BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_ERROR;
+               retstatus = BT_LTTNG_LIVE_ITERATOR_STATUS_ERROR;
        }
        return retstatus;
 }
 
 BT_HIDDEN
-enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_live_component *lttng_live,
+enum bt_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_live_component *lttng_live,
                struct lttng_live_stream_iterator *stream, uint8_t *buf, uint64_t offset,
                uint64_t req_len, uint64_t *recv_len)
 {
-       enum bt_ctf_notif_iter_medium_status retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_OK;
+       enum bt_notif_iter_medium_status retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_OK;
        struct lttng_viewer_cmd cmd;
        struct lttng_viewer_get_packet rq;
        struct lttng_viewer_trace_packet rp;
@@ -1234,15 +1238,15 @@ enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_li
        rq.len = htobe32(req_len);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending get_data request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending get_data request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -1252,8 +1256,8 @@ enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_li
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving get_data response: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving get_data response: %s", bt_socket_errormsg());
                goto error;
        }
        if (ret_len != sizeof(rp)) {
@@ -1274,7 +1278,7 @@ enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_li
        case LTTNG_VIEWER_GET_PACKET_RETRY:
                /* Unimplemented by relay daemon */
                BT_LOGD("get_data_packet: retry");
-               retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
+               retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
                goto end;
        case LTTNG_VIEWER_GET_PACKET_ERR:
                if (flags & LTTNG_VIEWER_FLAG_NEW_METADATA) {
@@ -1287,13 +1291,13 @@ enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_li
                }
                if (flags & (LTTNG_VIEWER_FLAG_NEW_METADATA
                                | LTTNG_VIEWER_FLAG_NEW_STREAM)) {
-                       retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
+                       retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
                        goto end;
                }
                BT_LOGE("get_data_packet: error");
                goto error;
        case LTTNG_VIEWER_GET_PACKET_EOF:
-               retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_EOF;
+               retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_EOF;
                goto end;
        default:
                BT_LOGE("get_data_packet: unknown");
@@ -1309,8 +1313,8 @@ enum bt_ctf_notif_iter_medium_status lttng_live_get_stream_bytes(struct lttng_li
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
-               BT_LOGE("Error receiving trace packet: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error receiving trace packet: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == req_len);
@@ -1319,10 +1323,10 @@ end:
        return retstatus;
 
 error:
-       if (bt_graph_is_canceled(lttng_live->graph)) {
-               retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
+       if (lttng_live_is_canceled(lttng_live)) {
+               retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
        } else {
-               retstatus = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_ERROR;
+               retstatus = BT_NOTIF_ITER_MEDIUM_STATUS_ERROR;
        }
        return retstatus;
 }
@@ -1331,11 +1335,11 @@ error:
  * Request new streams for a session.
  */
 BT_HIDDEN
-enum bt_ctf_lttng_live_iterator_status lttng_live_get_new_streams(
+enum bt_lttng_live_iterator_status lttng_live_get_new_streams(
                struct lttng_live_session *session)
 {
-       enum bt_ctf_lttng_live_iterator_status status =
-                       BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_OK;
+       enum bt_lttng_live_iterator_status status =
+                       BT_LTTNG_LIVE_ITERATOR_STATUS_OK;
        struct lttng_viewer_cmd cmd;
        struct lttng_viewer_new_streams_request rq;
        struct lttng_viewer_new_streams_response rp;
@@ -1346,7 +1350,7 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_new_streams(
        uint32_t streams_count;
 
        if (!session->new_streams_needed) {
-               return BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_OK;
+               return BT_LTTNG_LIVE_ITERATOR_STATUS_OK;
        }
 
        cmd.cmd = htobe32(LTTNG_VIEWER_GET_NEW_STREAMS);
@@ -1357,15 +1361,15 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_new_streams(
        rq.session_id = htobe64(session->id);
 
        ret_len = lttng_live_send(viewer_connection, &cmd, sizeof(cmd));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending cmd: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending cmd: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(cmd));
 
        ret_len = lttng_live_send(viewer_connection, &rq, sizeof(rq));
-       if (ret_len < 0) {
-               BT_LOGE("Error sending get_new_streams request: %s", strerror(errno));
+       if (ret_len == BT_SOCKET_ERROR) {
+               BT_LOGE("Error sending get_new_streams request: %s", bt_socket_errormsg());
                goto error;
        }
        assert(ret_len == sizeof(rq));
@@ -1375,7 +1379,7 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_new_streams(
                BT_LOGI("Remote side has closed connection");
                goto error;
        }
-       if (ret_len < 0) {
+       if (ret_len == BT_SOCKET_ERROR) {
                BT_LOGE("Error receiving get_new_streams response");
                goto error;
        }
@@ -1393,7 +1397,7 @@ enum bt_ctf_lttng_live_iterator_status lttng_live_get_new_streams(
        case LTTNG_VIEWER_NEW_STREAMS_HUP:
                session->new_streams_needed = false;
                session->closed = true;
-               status = BT_CTF_LTTNG_LIVE_ITERATOR_STATUS_END;
+               status = BT_LTTNG_LIVE_ITERATOR_STATUS_END;
                goto end;
        case LTTNG_VIEWER_NEW_STREAMS_ERR:
                BT_LOGE("get_new_streams error");
@@ -1410,10 +1414,10 @@ end:
        return status;
 
 error:
-       if (bt_graph_is_canceled(lttng_live->graph)) {
-               status = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_AGAIN;
+       if (lttng_live_is_canceled(lttng_live)) {
+               status = BT_LTTNG_LIVE_ITERATOR_STATUS_AGAIN;
        } else {
-               status = BT_CTF_NOTIF_ITER_MEDIUM_STATUS_ERROR;
+               status = BT_LTTNG_LIVE_ITERATOR_STATUS_ERROR;
        }
        return status;
 }
@@ -1427,8 +1431,12 @@ struct bt_live_viewer_connection *
 
        viewer_connection = g_new0(struct bt_live_viewer_connection, 1);
 
+       if (bt_socket_init() != 0) {
+               goto error;
+       }
+
        bt_object_init(&viewer_connection->obj, connection_release);
-       viewer_connection->control_sock = -1;
+       viewer_connection->control_sock = BT_INVALID_SOCKET;
        viewer_connection->port = -1;
        viewer_connection->lttng_live = lttng_live;
        viewer_connection->url = g_string_new(url);
@@ -1466,4 +1474,6 @@ void bt_live_viewer_connection_destroy(struct bt_live_viewer_connection *viewer_
                g_string_free(viewer_connection->session_name, TRUE);
        }
        g_free(viewer_connection);
+
+       bt_socket_fini();
 }
This page took 0.03472 seconds and 4 git commands to generate.