lib: make public reference count functions have strict types

[babeltrace.git] / plugins / text / pretty / pretty.c

diff --git a/plugins/text/pretty/pretty.c b/plugins/text/pretty/pretty.c
index 2b83b1def33d8b890249014805902385e6531e06..846cbdae7265cbe33f8d4815d42e7bed9f129f6e 100644 (file)
--- a/plugins/text/pretty/pretty.c
+++ b/plugins/text/pretty/pretty.c
@@ -24,7 +24,6 @@
  */
 
 #include <babeltrace/babeltrace.h>
-#include <babeltrace/values.h>
 #include <babeltrace/compiler-internal.h>
 #include <babeltrace/common-internal.h>
 #include <plugins-common.h>
@@ -66,7 +65,7 @@ const char *plugin_options[] = {
 static
 void destroy_pretty_data(struct pretty_component *pretty)
 {
-       bt_object_put_ref(pretty->iterator);
+       bt_self_component_port_input_notification_iterator_put_ref(pretty->iterator);
 
        if (pretty->string) {
                (void) g_string_free(pretty->string, TRUE);
@@ -124,14 +123,14 @@ void pretty_finalize(struct bt_self_component_sink *comp)
 static
 enum bt_self_component_status handle_notification(
                struct pretty_component *pretty,
-               struct bt_notification *notification)
+               const struct bt_notification *notification)
 {
        enum bt_self_component_status ret = BT_SELF_COMPONENT_STATUS_OK;
 
        BT_ASSERT(pretty);
 
        switch (bt_notification_get_type(notification)) {
-       case BT_NOTIFICATION_TYPE_PACKET_BEGIN:
+       case BT_NOTIFICATION_TYPE_PACKET_BEGINNING:
                if (pretty_print_packet(pretty, notification)) {
                        ret = BT_SELF_COMPONENT_STATUS_ERROR;
                }
@@ -155,7 +154,7 @@ BT_HIDDEN
 enum bt_self_component_status pretty_port_connected(
                struct bt_self_component_sink *comp,
                struct bt_self_component_port_input *self_port,
-               struct bt_port_output *other_port)
+               const struct bt_port_output *other_port)
 {
        enum bt_self_component_status status = BT_SELF_COMPONENT_STATUS_OK;
        struct pretty_component *pretty;
@@ -178,7 +177,7 @@ enum bt_self_component_status pretty_consume(
                struct bt_self_component_sink *comp)
 {
        enum bt_self_component_status ret;
-       bt_notification_array notifs;
+       bt_notification_array_const notifs;
        struct bt_self_component_port_input_notification_iterator *it;
        struct pretty_component *pretty = bt_self_component_get_data(
                bt_self_component_sink_as_self_component(comp));
@@ -201,7 +200,8 @@ enum bt_self_component_status pretty_consume(
                goto end;
        case BT_NOTIFICATION_ITERATOR_STATUS_END:
                ret = BT_SELF_COMPONENT_STATUS_END;
-               BT_OBJECT_PUT_REF_AND_RESET(pretty->iterator);
+               BT_SELF_COMPONENT_PORT_INPUT_NOTIFICATION_ITERATOR_PUT_REF_AND_RESET(
+                       pretty->iterator);
                goto end;
        default:
                ret = BT_SELF_COMPONENT_STATUS_ERROR;
@@ -216,19 +216,19 @@ enum bt_self_component_status pretty_consume(
                        goto end;
                }
 
-               bt_object_put_ref(notifs[i]);
+               bt_notification_put_ref(notifs[i]);
        }
 
 end:
        for (; i < count; i++) {
-               bt_object_put_ref(notifs[i]);
+               bt_notification_put_ref(notifs[i]);
        }
 
        return ret;
 }
 
 static
-int add_params_to_map(struct bt_private_value *plugin_opt_map)
+int add_params_to_map(struct bt_value *plugin_opt_map)
 {
        int ret = 0;
        unsigned int i;
@@ -237,7 +237,7 @@ int add_params_to_map(struct bt_private_value *plugin_opt_map)
                const char *key = plugin_options[i];
                enum bt_value_status status;
 
-               status = bt_private_value_map_insert_entry(plugin_opt_map, key,
+               status = bt_value_map_insert_entry(plugin_opt_map, key,
                        bt_value_null);
                switch (status) {
                case BT_VALUE_STATUS_OK:
@@ -252,13 +252,13 @@ end:
 }
 
 static
-bt_bool check_param_exists(const char *key, struct bt_value *object, void *data)
+bt_bool check_param_exists(const char *key, const struct bt_value *object,
+               void *data)
 {
        struct pretty_component *pretty = data;
 
-       if (!bt_value_map_has_entry(
-                       bt_private_value_as_value(pretty->plugin_opt_map),
-                       key)) {
+       if (!bt_value_map_has_entry(pretty->plugin_opt_map,
+                                   key)) {
                fprintf(pretty->err,
                        "[warning] Parameter \"%s\" unknown to \"text.pretty\" sink component\n", key);
        }
@@ -266,12 +266,12 @@ bt_bool check_param_exists(const char *key, struct bt_value *object, void *data)
 }
 
 static
-void apply_one_string(const char *key, struct bt_value *params, char **option)
+void apply_one_string(const char *key, const struct bt_value *params, char **option)
 {
-       struct bt_value *value = NULL;
+       const struct bt_value *value = NULL;
        const char *str;
 
-       value = bt_value_map_borrow_entry_value(params, key);
+       value = bt_value_map_borrow_entry_value_const(params, key);
        if (!value) {
                goto end;
        }
@@ -286,13 +286,13 @@ end:
 }
 
 static
-void apply_one_bool(const char *key, struct bt_value *params, bool *option,
+void apply_one_bool(const char *key, const struct bt_value *params, bool *option,
                bool *found)
 {
-       struct bt_value *value = NULL;
+       const struct bt_value *value = NULL;
        bt_bool bool_val;
 
-       value = bt_value_map_borrow_entry_value(params, key);
+       value = bt_value_map_borrow_entry_value_const(params, key);
        if (!value) {
                goto end;
        }
@@ -337,14 +337,14 @@ end:
 }
 
 static
-int apply_params(struct pretty_component *pretty, struct bt_value *params)
+int apply_params(struct pretty_component *pretty, const struct bt_value *params)
 {
        int ret = 0;
        enum bt_value_status status;
        bool value, found;
        char *str = NULL;
 
-       pretty->plugin_opt_map = bt_private_value_map_create();
+       pretty->plugin_opt_map = bt_value_map_create();
        if (!pretty->plugin_opt_map) {
                ret = -1;
                goto end;
@@ -354,7 +354,8 @@ int apply_params(struct pretty_component *pretty, struct bt_value *params)
                goto end;
        }
        /* Report unknown parameters. */
-       status = bt_value_map_foreach_entry(params, check_param_exists, pretty);
+       status = bt_value_map_foreach_entry_const(params,
+               check_param_exists, pretty);
        switch (status) {
        case BT_VALUE_STATUS_OK:
                break;
@@ -365,10 +366,11 @@ int apply_params(struct pretty_component *pretty, struct bt_value *params)
        /* Known parameters. */
        pretty->options.color = PRETTY_COLOR_OPT_AUTO;
        if (bt_value_map_has_entry(params, "color")) {
-               struct bt_value *color_value;
+               const struct bt_value *color_value;
                const char *color;
 
-               color_value = bt_value_map_borrow_entry_value(params, "color");
+               color_value = bt_value_map_borrow_entry_value_const(params,
+                       "color");
                if (!color_value) {
                        goto end;
                }
@@ -591,7 +593,7 @@ int apply_params(struct pretty_component *pretty, struct bt_value *params)
        }
 
 end:
-       bt_object_put_ref(pretty->plugin_opt_map);
+       bt_value_put_ref(pretty->plugin_opt_map);
        pretty->plugin_opt_map = NULL;
        g_free(str);
        return ret;
@@ -636,7 +638,7 @@ void init_stream_packet_context_quarks(void)
 BT_HIDDEN
 enum bt_self_component_status pretty_init(
                struct bt_self_component_sink *comp,
-               struct bt_value *params,
+               const struct bt_value *params,
                UNUSED_VAR void *init_method_data)
 {
        enum bt_self_component_status ret;