doc/api/libbabeltrace2/DoxygenLayout.xml: use `topics` tab

[babeltrace.git] / src / ctf-writer / attributes.c

diff --git a/src/ctf-writer/attributes.c b/src/ctf-writer/attributes.c
index e79dc58f1d3d34158d757448c058dec3cd7dd96e..27b689e2e508b9f64c1c57610800c27731e8a987 100644 (file)
--- a/src/ctf-writer/attributes.c
+++ b/src/ctf-writer/attributes.c
@@ -1,37 +1,21 @@
 /*
- * attributes.c
- *
- * Babeltrace CTF writer - Attributes
+ * SPDX-License-Identifier: MIT
  *
  * Copyright (c) 2015 EfficiOS Inc. and Linux Foundation
  * Copyright (c) 2015 Philippe Proulx <pproulx@efficios.com>
  *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
+ * Babeltrace CTF writer - Attributes
  */
 
-#define BT_LOG_TAG "CTF-WRITER-ATTRS"
+#define BT_LOG_TAG "CTF-WRITER/ATTRS"
 #include "logging.h"
 
+#include "attributes.h"
+
 #include "common/assert.h"
-#include "common/babeltrace.h"
+#include "common/macros.h"
 #include "compat/string.h"
-#include <babeltrace2/ctf-writer/object.h>
+#include <babeltrace2-ctf-writer/object.h>
 #include <inttypes.h>
 
 #include "values.h"
@@ -39,7 +23,6 @@
 #define BT_CTF_ATTR_NAME_INDEX         0
 #define BT_CTF_ATTR_VALUE_INDEX                1
 
-BT_HIDDEN
 struct bt_ctf_private_value *bt_ctf_attributes_create(void)
 {
        struct bt_ctf_private_value *attr_obj;
@@ -70,20 +53,17 @@ struct bt_ctf_private_value *bt_ctf_attributes_create(void)
        return attr_obj;
 }
 
-BT_HIDDEN
 void bt_ctf_attributes_destroy(struct bt_ctf_private_value *attr_obj)
 {
        BT_LOGD("Destroying attributes object: addr=%p", attr_obj);
        bt_ctf_object_put_ref(attr_obj);
 }
 
-BT_HIDDEN
 int64_t bt_ctf_attributes_get_count(struct bt_ctf_private_value *attr_obj)
 {
-       return bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj));
+       return bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj));
 }
 
-BT_HIDDEN
 const char *bt_ctf_attributes_get_field_name(struct bt_ctf_private_value *attr_obj,
                uint64_t index)
 {
@@ -96,10 +76,10 @@ const char *bt_ctf_attributes_get_field_name(struct bt_ctf_private_value *attr_o
                goto end;
        }
 
-       if (index >= bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj))) {
+       if (index >= bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj))) {
                BT_LOGW("Invalid parameter: index is out of bounds: "
                        "index=%" PRIu64 ", count=%" PRId64,
-                       index, bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj)));
+                       index, bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj)));
                goto end;
        }
 
@@ -128,7 +108,6 @@ end:
        return ret;
 }
 
-BT_HIDDEN
 struct bt_ctf_private_value *bt_ctf_attributes_borrow_field_value(struct bt_ctf_private_value *attr_obj,
                uint64_t index)
 {
@@ -140,10 +119,10 @@ struct bt_ctf_private_value *bt_ctf_attributes_borrow_field_value(struct bt_ctf_
                goto end;
        }
 
-       if (index >= bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj))) {
+       if (index >= bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj))) {
                BT_LOGW("Invalid parameter: index is out of bounds: "
                        "index=%" PRIu64 ", count=%" PRId64,
-                       index, bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj)));
+                       index, bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj)));
                goto end;
        }
 
@@ -176,7 +155,7 @@ struct bt_ctf_private_value *bt_ctf_attributes_borrow_field_by_name(
        struct bt_ctf_private_value *value_obj = NULL;
        struct bt_ctf_private_value *attr_field_name_obj = NULL;
 
-       attr_size = bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj));
+       attr_size = bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj));
        if (attr_size < 0) {
                BT_LOGE("Cannot get array value's size: value-addr=%p",
                        attr_obj);
@@ -205,7 +184,7 @@ struct bt_ctf_private_value *bt_ctf_attributes_borrow_field_by_name(
                field_name = bt_ctf_value_string_get(
                        bt_ctf_private_value_as_value(attr_field_name_obj));
 
-               if (!strcmp(field_name, name)) {
+               if (strcmp(field_name, name) == 0) {
                        break;
                }
 
@@ -219,7 +198,6 @@ error:
        return value_obj;
 }
 
-BT_HIDDEN
 int bt_ctf_attributes_set_field_value(struct bt_ctf_private_value *attr_obj,
                const char *name, struct bt_ctf_private_value *value_obj)
 {
@@ -272,7 +250,6 @@ end:
        return ret;
 }
 
-BT_HIDDEN
 struct bt_ctf_private_value *bt_ctf_attributes_borrow_field_value_by_name(
                struct bt_ctf_private_value *attr_obj, const char *name)
 {
@@ -304,7 +281,6 @@ end:
        return value_obj;
 }
 
-BT_HIDDEN
 int bt_ctf_attributes_freeze(struct bt_ctf_private_value *attr_obj)
 {
        uint64_t i;
@@ -318,8 +294,8 @@ int bt_ctf_attributes_freeze(struct bt_ctf_private_value *attr_obj)
        }
 
        BT_LOGD("Freezing attributes object: value-addr=%p", attr_obj);
-       count = bt_ctf_value_array_get_size(bt_ctf_private_value_as_value(attr_obj));
-       BT_ASSERT(count >= 0);
+       count = bt_ctf_value_array_get_length(bt_ctf_private_value_as_value(attr_obj));
+       BT_ASSERT_DBG(count >= 0);
 
        /*
         * We do not freeze the array value object itself here, since