#include "../common/metadata/ctf-meta-configure-ir-trace.h"
#include "../common/msg-iter/msg-iter.h"
#include "query.h"
+#include "plugins/common/param-validation/param-validation.h"
struct tracer_info {
const char *name;
struct bt_msg_iter_packet_properties props;
bt_logging_level log_level = ctf_fs_trace->log_level;
bt_self_component *self_comp = ctf_fs_trace->self_comp;
+ bt_self_component_class *self_comp_class = ctf_fs_trace->self_comp_class;
msg_iter = bt_msg_iter_create(ctf_fs_trace->metadata->tc,
bt_common_get_page_size(log_level) * 8,
ret = bt_msg_iter_get_packet_properties(ds_file->msg_iter, &props);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
"Cannot get stream file's first packet's header and context fields (`%s`).",
path);
goto error;
sc->default_clock_class->offset_seconds,
sc->default_clock_class->offset_cycles, &begin_ns);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
"Cannot convert clock cycles to nanoseconds from origin (`%s`).",
path);
goto error;
GDir *dir = NULL;
bt_logging_level log_level = ctf_fs_trace->log_level;
bt_self_component *self_comp = ctf_fs_trace->self_comp;
+ bt_self_component_class *self_comp_class = ctf_fs_trace->self_comp_class;
/* Check each file in the path directory, except specific ones */
dir = g_dir_open(ctf_fs_trace->path->str, 0, &error);
if (!dir) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Cannot open directory `%s`: %s (code %d)",
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
+ "Cannot open directory `%s`: %s (code %d)",
ctf_fs_trace->path->str, error->message,
error->code);
goto error;
/* Create the file. */
file = ctf_fs_file_create(log_level, self_comp);
if (!file) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
"Cannot create stream file object for file `%s" G_DIR_SEPARATOR_S "%s`",
ctf_fs_trace->path->str, basename);
goto error;
ret = ctf_fs_file_open(file, "rb");
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Cannot open stream file `%s`",
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
+ "Cannot open stream file `%s`",
file->path->str);
goto error;
}
ret = add_ds_file_to_ds_file_group(ctf_fs_trace,
file->path->str);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
"Cannot add stream file `%s` to stream file group",
file->path->str);
ctf_fs_file_destroy(file);
}
static
-struct ctf_fs_trace *ctf_fs_trace_create(bt_self_component *self_comp,
+struct ctf_fs_trace *ctf_fs_trace_create(
+ bt_self_component *self_comp,
+ bt_self_component_class *self_comp_class,
const char *path, const char *name,
struct ctf_fs_metadata_config *metadata_config,
bt_logging_level log_level)
struct ctf_fs_trace *ctf_fs_trace;
int ret;
+ /* Only one of them must be set. */
+ BT_ASSERT(!self_comp != !self_comp_class);
+
ctf_fs_trace = g_new0(struct ctf_fs_trace, 1);
if (!ctf_fs_trace) {
goto end;
ctf_fs_trace->log_level = log_level;
ctf_fs_trace->self_comp = self_comp;
+ ctf_fs_trace->self_comp_class = self_comp_class;
ctf_fs_trace->path = g_string_new(path);
if (!ctf_fs_trace->path) {
goto error;
norm_path = bt_common_normalize_path(path_param, NULL);
if (!norm_path) {
BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "Failed to normalize path: `%s`.", path_param);
+ "Failed to normalize path: `%s`.",
+ path_param);
goto error;
}
ret = path_is_ctf_trace(norm_path->str);
if (ret < 0) {
BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "Failed to check if path is a CTF trace: path=%s", norm_path->str);
+ "Failed to check if path is a CTF trace: path=%s",
+ norm_path->str);
goto error;
} else if (ret == 0) {
BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "Path is not a CTF trace (does not contain a metadata file): `%s`.", norm_path->str);
+ "Path is not a CTF trace (does not contain a metadata file): `%s`.",
+ norm_path->str);
goto error;
}
goto end;
}
- ctf_fs_trace = ctf_fs_trace_create(self_comp, norm_path->str,
+ ctf_fs_trace = ctf_fs_trace_create(self_comp, self_comp_class, norm_path->str,
trace_name, &ctf_fs->metadata_config, log_level);
if (!ctf_fs_trace) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp, "Cannot create trace for `%s`.",
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
+ "Cannot create trace for `%s`.",
norm_path->str);
goto error;
}
*/
static
int fix_packet_index_tracer_bugs(struct ctf_fs_component *ctf_fs,
- bt_self_component *self_comp)
+ bt_self_component *self_comp,
+ bt_self_component_class *self_comp_class)
{
int ret = 0;
struct tracer_info current_tracer_info;
BT_LOGI_STR("Trace may be affected by LTTng tracer packet timestamp bug. Fixing up.");
ret = fix_index_lttng_event_after_packet_bug(ctf_fs->trace);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(
+ self_comp, self_comp_class,
"Failed to fix LTTng event-after-packet bug.");
goto end;
}
BT_LOGI_STR("Trace may be affected by barectf tracer packet timestamp bug. Fixing up.");
ret = fix_index_barectf_event_before_packet_bug(ctf_fs->trace);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(
+ self_comp, self_comp_class,
"Failed to fix barectf event-before-packet bug.");
goto end;
}
¤t_tracer_info)) {
ret = fix_index_lttng_crash_quirk(ctf_fs->trace);
if (ret) {
- BT_COMP_LOGE_APPEND_CAUSE(self_comp,
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(
+ self_comp, self_comp_class,
"Failed to fix lttng-crash timestamp quirks.");
goto end;
}
traces->pdata[0] = NULL;
}
- ret = fix_packet_index_tracer_bugs(ctf_fs, self_comp);
+ ret = fix_packet_index_tracer_bugs(ctf_fs, self_comp, self_comp_class);
if (ret) {
BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
"Failed to fix packet index tracer bugs.");
return ret;
}
-/*
- * Validate the "paths" parameter passed to this component. It must be
- * present, and it must be an array of strings.
- */
-
-static
-bool validate_inputs_parameter(struct ctf_fs_component *ctf_fs,
- const bt_value *inputs, bt_self_component *self_comp,
- bt_self_component_class *self_comp_class)
-{
- bool ret;
- bt_value_type type;
- uint64_t i;
- bt_logging_level log_level = ctf_fs->log_level;
-
- if (!inputs) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp,
- self_comp_class, "missing \"inputs\" parameter");
- goto error;
- }
-
- type = bt_value_get_type(inputs);
- if (type != BT_VALUE_TYPE_ARRAY) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp,
- self_comp_class, "`inputs` parameter: expecting array value: type=%s",
- bt_common_value_type_string(type));
- goto error;
- }
-
- if (bt_value_array_is_empty(inputs)) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp,
- self_comp_class, "`inputs` parameter must not be empty");
- goto error;
- }
-
- for (i = 0; i < bt_value_array_get_length(inputs); i++) {
- const bt_value *elem;
+static const struct bt_param_validation_value_descr inputs_elem_descr = {
+ .type = BT_VALUE_TYPE_STRING,
+};
- elem = bt_value_array_borrow_element_by_index_const(inputs, i);
- type = bt_value_get_type(elem);
- if (type != BT_VALUE_TYPE_STRING) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "`inputs` parameter: expecting string value: index=%" PRIu64 ", type=%s",
- i, bt_common_value_type_string(type));
- goto error;
+static const struct bt_param_validation_map_value_entry_descr fs_params_entries_descr[] = {
+ { "inputs", BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_MANDATORY, {
+ BT_VALUE_TYPE_ARRAY,
+ .array = {
+ .min_length = 1,
+ .max_length = BT_PARAM_VALIDATION_INFINITE,
+ .element_type = &inputs_elem_descr,
}
- }
-
- ret = true;
- goto end;
-
-error:
- ret = false;
+ }},
+ { "trace-name", BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_OPTIONAL, { .type = BT_VALUE_TYPE_STRING } },
+ { "clock-class-offset-s", BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_OPTIONAL, { .type = BT_VALUE_TYPE_SIGNED_INTEGER } },
+ { "clock-class-offset-ns", BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_OPTIONAL, { .type = BT_VALUE_TYPE_SIGNED_INTEGER } },
+ { "force-clock-class-origin-unix-epoch", BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_OPTIONAL, { .type = BT_VALUE_TYPE_BOOL } },
+ BT_PARAM_VALIDATION_MAP_VALUE_ENTRY_END
+};
-end:
- return ret;
-}
bool read_src_fs_parameters(const bt_value *params,
const bt_value **inputs,
bool ret;
const bt_value *value;
bt_logging_level log_level = ctf_fs->log_level;
+ enum bt_param_validation_status validate_value_status;
+ gchar *error = NULL;
+
+ validate_value_status = bt_param_validation_validate(params,
+ fs_params_entries_descr, &error);
+ if (validate_value_status != BT_PARAM_VALIDATION_STATUS_OK) {
+ BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
+ "%s", error);
+ ret = false;
+ goto end;
+ }
/* inputs parameter */
*inputs = bt_value_map_borrow_entry_value_const(params, "inputs");
- if (!validate_inputs_parameter(ctf_fs, *inputs, self_comp, self_comp_class)) {
- goto error;
- }
/* clock-class-offset-s parameter */
value = bt_value_map_borrow_entry_value_const(params,
"clock-class-offset-s");
if (value) {
- if (!bt_value_is_signed_integer(value)) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "clock-class-offset-s must be an integer");
- goto error;
- }
ctf_fs->metadata_config.clock_class_offset_s =
bt_value_integer_signed_get(value);
}
value = bt_value_map_borrow_entry_value_const(params,
"clock-class-offset-ns");
if (value) {
- if (!bt_value_is_signed_integer(value)) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "clock-class-offset-ns must be an integer");
- goto error;
- }
ctf_fs->metadata_config.clock_class_offset_ns =
bt_value_integer_signed_get(value);
}
value = bt_value_map_borrow_entry_value_const(params,
"force-clock-class-origin-unix-epoch");
if (value) {
- if (!bt_value_is_bool(value)) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "force-clock-class-origin-unix-epoch must be a boolean");
- goto error;
- }
-
ctf_fs->metadata_config.force_clock_class_origin_unix_epoch =
bt_value_bool_get(value);
}
/* trace-name parameter */
*trace_name = bt_value_map_borrow_entry_value_const(params, "trace-name");
- if (*trace_name) {
- if (!bt_value_is_string(*trace_name)) {
- BT_COMP_OR_COMP_CLASS_LOGE_APPEND_CAUSE(self_comp, self_comp_class,
- "trace-name must be a string");
- goto error;
- }
- }
ret = true;
- goto end;
-
-error:
- ret = false;
end:
+ g_free(error);
return ret;
}
static
struct ctf_fs_component *ctf_fs_create(
const bt_value *params,
- bt_self_component_source *self_comp_src,
- bt_self_component_class *self_comp_class)
+ bt_self_component_source *self_comp_src)
{
struct ctf_fs_component *ctf_fs = NULL;
const bt_value *inputs_value;
}
if (!read_src_fs_parameters(params, &inputs_value, &trace_name_value,
- ctf_fs, self_comp, self_comp_class)) {
+ ctf_fs, self_comp, NULL)) {
goto error;
}
bt_self_component_set_data(self_comp, ctf_fs);
if (ctf_fs_component_create_ctf_fs_trace(ctf_fs, inputs_value,
- trace_name_value, self_comp, self_comp_class)) {
+ trace_name_value, self_comp, NULL)) {
goto error;
}
bt_component_class_initialize_method_status ret =
BT_COMPONENT_CLASS_INITIALIZE_METHOD_STATUS_OK;
- ctf_fs = ctf_fs_create(params, self_comp_src, NULL);
+ ctf_fs = ctf_fs_create(params, self_comp_src);
if (!ctf_fs) {
ret = BT_COMPONENT_CLASS_INITIALIZE_METHOD_STATUS_ERROR;
}
projects / babeltrace.git / blobdiff