lib: rename functions to clearly indicate API inheritance
[babeltrace.git] / src / plugins / text / details / write.c
index 3ea4d41c97fbdbaf38ec42f20fdbcc678ad6417c..746a69cadd427813985617bbf0cb1d8a449ba091 100644 (file)
@@ -26,6 +26,7 @@
 
 #include "common/assert.h"
 #include "common/common.h"
+#include "common/uuid.h"
 #include "details.h"
 #include "write.h"
 #include "obj-lifetime-mgmt.h"
@@ -329,24 +330,9 @@ void write_uuid_prop_line(struct details_write_ctx *ctx, const char *prop_name,
        write_indent(ctx);
        write_prop_name(ctx, prop_name);
        g_string_append_printf(ctx->str,
-               ": %s%02x%02x%02x%02x-%02x%02x-%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x%s\n",
+               ": %s" BT_UUID_FMT "%s\n",
                color_bold(ctx),
-               (unsigned int) uuid[0],
-               (unsigned int) uuid[1],
-               (unsigned int) uuid[2],
-               (unsigned int) uuid[3],
-               (unsigned int) uuid[4],
-               (unsigned int) uuid[5],
-               (unsigned int) uuid[6],
-               (unsigned int) uuid[7],
-               (unsigned int) uuid[8],
-               (unsigned int) uuid[9],
-               (unsigned int) uuid[10],
-               (unsigned int) uuid[11],
-               (unsigned int) uuid[12],
-               (unsigned int) uuid[13],
-               (unsigned int) uuid[14],
-               (unsigned int) uuid[15],
+               BT_UUID_FMT_VALUES(uuid),
                color_reset(ctx));
 }
 
@@ -381,7 +367,7 @@ void write_int_field_class_props(struct details_write_ctx *ctx,
        }
 }
 
-struct enum_field_class_mapping_range {
+struct int_range {
        union {
                uint64_t u;
                int64_t i;
@@ -397,7 +383,7 @@ struct enum_field_class_mapping {
        /* Weak */
        const char *label;
 
-       /* Array of `struct enum_field_class_mapping_range` */
+       /* Array of `struct int_range` */
        GArray *ranges;
 };
 
@@ -409,9 +395,7 @@ gint compare_enum_field_class_mappings(struct enum_field_class_mapping **a,
 }
 
 static
-gint compare_enum_field_class_mapping_ranges_signed(
-               struct enum_field_class_mapping_range *a,
-               struct enum_field_class_mapping_range *b)
+gint compare_int_ranges_signed(struct int_range *a, struct int_range *b)
 {
 
        if (a->lower.i < b->lower.i) {
@@ -430,9 +414,7 @@ gint compare_enum_field_class_mapping_ranges_signed(
 }
 
 static
-gint compare_enum_field_class_mapping_ranges_unsigned(
-               struct enum_field_class_mapping_range *a,
-               struct enum_field_class_mapping_range *b)
+gint compare_int_ranges_unsigned(struct int_range *a, struct int_range *b)
 {
        if (a->lower.u < b->lower.u) {
                return -1;
@@ -449,6 +431,58 @@ gint compare_enum_field_class_mapping_ranges_unsigned(
        }
 }
 
+static
+GArray *range_set_to_int_ranges(const void *spec_range_set, bool is_signed)
+{
+       uint64_t i;
+       const bt_integer_range_set *range_set;
+       GArray *ranges = g_array_new(FALSE, TRUE, sizeof(struct int_range));
+
+       if (!ranges) {
+               goto end;
+       }
+
+       if (is_signed) {
+               range_set = bt_integer_range_set_signed_as_range_set_const(
+                       spec_range_set);
+       } else {
+               range_set = bt_integer_range_set_unsigned_as_range_set_const(
+                       spec_range_set);
+       }
+
+       for (i = 0; i < bt_integer_range_set_get_range_count(range_set); i++) {
+               struct int_range range;
+
+               if (is_signed) {
+                       const bt_integer_range_signed *orig_range =
+                               bt_integer_range_set_signed_borrow_range_by_index_const(
+                                       spec_range_set, i);
+
+                       range.lower.i = bt_integer_range_signed_get_lower(orig_range);
+                       range.upper.i = bt_integer_range_signed_get_upper(orig_range);
+               } else {
+                       const bt_integer_range_unsigned *orig_range =
+                               bt_integer_range_set_unsigned_borrow_range_by_index_const(
+                                       spec_range_set, i);
+
+                       range.lower.u = bt_integer_range_unsigned_get_lower(orig_range);
+                       range.upper.u = bt_integer_range_unsigned_get_upper(orig_range);
+               }
+
+               g_array_append_val(ranges, range);
+       }
+
+       if (is_signed) {
+               g_array_sort(ranges, (GCompareFunc) compare_int_ranges_signed);
+       } else {
+               g_array_sort(ranges,
+                       (GCompareFunc) compare_int_ranges_unsigned);
+       }
+
+end:
+       return ranges;
+}
+
 static
 void destroy_enum_field_class_mapping(struct enum_field_class_mapping *mapping)
 {
@@ -461,8 +495,14 @@ void destroy_enum_field_class_mapping(struct enum_field_class_mapping *mapping)
 }
 
 static
-void write_enum_field_class_mapping_range(struct details_write_ctx *ctx,
-               struct enum_field_class_mapping_range *range, bool is_signed)
+struct int_range *int_range_at(GArray *ranges, uint64_t index)
+{
+       return &g_array_index(ranges, struct int_range, index);
+}
+
+static
+void write_int_range(struct details_write_ctx *ctx,
+               struct int_range *range, bool is_signed)
 {
        g_string_append(ctx->str, "[");
 
@@ -472,12 +512,14 @@ void write_enum_field_class_mapping_range(struct details_write_ctx *ctx,
                write_int_prop_value(ctx, range->lower.u);
        }
 
-       g_string_append(ctx->str, ", ");
+       if (range->lower.u != range->upper.u) {
+               g_string_append(ctx->str, ", ");
 
-       if (is_signed) {
-               write_int_prop_value(ctx, range->upper.i);
-       } else {
-               write_int_prop_value(ctx, range->upper.u);
+               if (is_signed) {
+                       write_int_prop_value(ctx, range->upper.i);
+               } else {
+                       write_int_prop_value(ctx, range->upper.u);
+               }
        }
 
        g_string_append(ctx->str, "]");
@@ -503,66 +545,37 @@ void write_enum_field_class_mappings(struct details_write_ctx *ctx,
         */
        for (i = 0; i < bt_field_class_enumeration_get_mapping_count(fc); i++) {
                const void *fc_mapping;
+               const void *fc_range_set;
                struct enum_field_class_mapping *mapping = g_new0(
                        struct enum_field_class_mapping, 1);
 
                BT_ASSERT(mapping);
-               mapping->ranges = g_array_new(FALSE, TRUE,
-                       sizeof(struct enum_field_class_mapping_range));
-               BT_ASSERT(mapping->ranges);
 
                if (is_signed) {
-                       fc_mapping = bt_field_class_signed_enumeration_borrow_mapping_by_index_const(
+                       fc_mapping = bt_field_class_enumeration_signed_borrow_mapping_by_index_const(
                                fc, i);
+                       fc_range_set = bt_field_class_enumeration_signed_mapping_borrow_ranges_const(
+                               fc_mapping);
                } else {
-                       fc_mapping = bt_field_class_unsigned_enumeration_borrow_mapping_by_index_const(
+                       fc_mapping = bt_field_class_enumeration_unsigned_borrow_mapping_by_index_const(
                                fc, i);
+                       fc_range_set = bt_field_class_enumeration_unsigned_mapping_borrow_ranges_const(
+                               fc_mapping);
                }
 
                mapping->label = bt_field_class_enumeration_mapping_get_label(
-                       bt_field_class_signed_enumeration_mapping_as_mapping_const(
+                       bt_field_class_enumeration_signed_mapping_as_mapping_const(
                                fc_mapping));
-
-               for (range_i = 0;
-                               range_i < bt_field_class_enumeration_mapping_get_range_count(
-                                       bt_field_class_signed_enumeration_mapping_as_mapping_const(fc_mapping));
-                               range_i++) {
-                       struct enum_field_class_mapping_range range;
-
-                       if (is_signed) {
-                               bt_field_class_signed_enumeration_mapping_get_range_by_index(
-                                       fc_mapping, range_i,
-                                       &range.lower.i, &range.upper.i);
-                       } else {
-                               bt_field_class_unsigned_enumeration_mapping_get_range_by_index(
-                                       fc_mapping, range_i,
-                                       &range.lower.u, &range.upper.u);
-                       }
-
-                       g_array_append_val(mapping->ranges, range);
-               }
-
+               mapping->ranges = range_set_to_int_ranges(fc_range_set,
+                       is_signed);
+               BT_ASSERT(mapping->ranges);
                g_ptr_array_add(mappings, mapping);
        }
 
-       /* Sort mappings, and for each mapping, sort ranges */
+       /* Sort mappings (ranges are already sorted within mappings) */
        g_ptr_array_sort(mappings,
                (GCompareFunc) compare_enum_field_class_mappings);
 
-       for (i = 0; i < mappings->len; i++) {
-               struct enum_field_class_mapping *mapping = mappings->pdata[i];
-
-               if (is_signed) {
-                       g_array_sort(mapping->ranges,
-                               (GCompareFunc)
-                                       compare_enum_field_class_mapping_ranges_signed);
-               } else {
-                       g_array_sort(mapping->ranges,
-                               (GCompareFunc)
-                                       compare_enum_field_class_mapping_ranges_unsigned);
-               }
-       }
-
        /* Write mappings */
        for (i = 0; i < mappings->len; i++) {
                struct enum_field_class_mapping *mapping = mappings->pdata[i];
@@ -570,28 +583,12 @@ void write_enum_field_class_mappings(struct details_write_ctx *ctx,
                write_nl(ctx);
                write_compound_member_name(ctx, mapping->label);
 
-               if (mapping->ranges->len == 1) {
-                       /* Single one: write on same line */
-                       write_sp(ctx);
-                       write_enum_field_class_mapping_range(ctx,
-                               &g_array_index(mapping->ranges,
-                                       struct enum_field_class_mapping_range,
-                                       0), is_signed);
-                       continue;
-               }
-
-               incr_indent(ctx);
-
                for (range_i = 0; range_i < mapping->ranges->len; range_i++) {
-                       write_nl(ctx);
-                       write_indent(ctx);
-                       write_enum_field_class_mapping_range(ctx,
-                               &g_array_index(mapping->ranges,
-                                       struct enum_field_class_mapping_range,
-                                       range_i), is_signed);
+                       write_sp(ctx);
+                       write_int_range(ctx,
+                               int_range_at(mapping->ranges, range_i),
+                               is_signed);
                }
-
-               decr_indent(ctx);
        }
 
        g_ptr_array_free(mappings, TRUE);
@@ -649,19 +646,119 @@ void write_field_path(struct details_write_ctx *ctx,
 }
 
 static
-void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc,
-               const char *name)
+void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc);
+
+static
+void write_variant_field_class_option(struct details_write_ctx *ctx,
+               const bt_field_class *fc, uint64_t index)
 {
-       uint64_t i;
-       const char *type;
        bt_field_class_type fc_type = bt_field_class_get_type(fc);
+       const bt_field_class_variant_option *option =
+               bt_field_class_variant_borrow_option_by_index_const(
+                       fc, index);
+       const void *orig_ranges;
+       GArray *int_ranges = NULL;
+       bool is_signed;
 
-       /* Write field class's name */
-       if (name) {
-               write_compound_member_name(ctx, name);
+       write_nl(ctx);
+       write_compound_member_name(ctx,
+               bt_field_class_variant_option_get_name(option));
+
+       if (fc_type == BT_FIELD_CLASS_TYPE_VARIANT_WITH_UNSIGNED_SELECTOR) {
+               const bt_field_class_variant_with_selector_unsigned_option *spec_opt =
+                       bt_field_class_variant_with_selector_unsigned_borrow_option_by_index_const(
+                               fc, index);
+
+               orig_ranges =
+                       bt_field_class_variant_with_selector_unsigned_option_borrow_ranges_const(
+                               spec_opt);
+               is_signed = false;
+       } else {
+               const bt_field_class_variant_with_selector_signed_option *spec_opt =
+                       bt_field_class_variant_with_selector_signed_borrow_option_by_index_const(
+                               fc, index);
+
+               orig_ranges =
+                       bt_field_class_variant_with_selector_signed_option_borrow_ranges_const(
+                               spec_opt);
+               is_signed = true;
+       }
+
+       if (orig_ranges) {
+               uint64_t i;
+
+               int_ranges = range_set_to_int_ranges(orig_ranges, is_signed);
+               BT_ASSERT(int_ranges);
+
+               for (i = 0; i < int_ranges->len; i++) {
+                       struct int_range *range = int_range_at(int_ranges, i);
+
+                       write_sp(ctx);
+                       write_int_range(ctx, range, is_signed);
+               }
+
+               g_string_append(ctx->str, ": ");
+       } else {
                write_sp(ctx);
        }
 
+       write_field_class(ctx,
+               bt_field_class_variant_option_borrow_field_class_const(option));
+
+       if (int_ranges) {
+               g_array_free(int_ranges, TRUE);
+       }
+}
+
+static
+void write_variant_field_class(struct details_write_ctx *ctx,
+               const bt_field_class *fc)
+{
+       bt_field_class_type fc_type = bt_field_class_get_type(fc);
+       uint64_t option_count =
+               bt_field_class_variant_get_option_count(fc);
+       const bt_field_path *sel_field_path = NULL;
+
+       if (fc_type == BT_FIELD_CLASS_TYPE_VARIANT_WITH_UNSIGNED_SELECTOR) {
+               sel_field_path =
+                       bt_field_class_variant_with_selector_borrow_selector_field_path_const(
+                               fc);
+               BT_ASSERT(sel_field_path);
+       }
+
+       g_string_append(ctx->str, " (");
+       write_uint_prop_value(ctx, option_count);
+       g_string_append_printf(ctx->str, " option%s, ",
+               plural(option_count));
+
+       if (sel_field_path) {
+               g_string_append(ctx->str, "Selector field path ");
+               write_field_path(ctx, sel_field_path);
+       }
+
+       g_string_append_c(ctx->str, ')');
+
+       if (option_count > 0) {
+               uint64_t i;
+
+               g_string_append_c(ctx->str, ':');
+               incr_indent(ctx);
+
+               for (i = 0; i < option_count; i++) {
+                       write_variant_field_class_option(ctx, fc, i);
+               }
+
+               decr_indent(ctx);
+       }
+}
+
+static
+void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc)
+{
+       uint64_t i;
+       const char *type;
+       bt_field_class_type fc_type = bt_field_class_get_type(fc);
+
        /* Write field class's type */
        switch (fc_type) {
        case BT_FIELD_CLASS_TYPE_UNSIGNED_INTEGER:
@@ -691,8 +788,14 @@ void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc,
        case BT_FIELD_CLASS_TYPE_DYNAMIC_ARRAY:
                type = "Dynamic array";
                break;
-       case BT_FIELD_CLASS_TYPE_VARIANT:
-               type = "Variant";
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITHOUT_SELECTOR:
+               type = "Variant (no selector)";
+               break;
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_UNSIGNED_SELECTOR:
+               type = "Variant (unsigned selector)";
+               break;
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_SIGNED_SELECTOR:
+               type = "Variant (signed selector)";
                break;
        default:
                abort();
@@ -758,9 +861,11 @@ void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc,
                                                fc, i);
 
                                write_nl(ctx);
-                               write_field_class(ctx,
-                                       bt_field_class_structure_member_borrow_field_class_const(member),
+                               write_compound_member_name(ctx,
                                        bt_field_class_structure_member_get_name(member));
+                               write_sp(ctx);
+                               write_field_class(ctx,
+                                       bt_field_class_structure_member_borrow_field_class_const(member));
                        }
 
                        decr_indent(ctx);
@@ -773,11 +878,11 @@ void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc,
                if (fc_type == BT_FIELD_CLASS_TYPE_STATIC_ARRAY) {
                        g_string_append(ctx->str, " (Length ");
                        write_uint_prop_value(ctx,
-                               bt_field_class_static_array_get_length(fc));
+                               bt_field_class_array_static_get_length(fc));
                        g_string_append_c(ctx->str, ')');
                } else {
                        const bt_field_path *length_field_path =
-                               bt_field_class_dynamic_array_borrow_length_field_path_const(
+                               bt_field_class_array_dynamic_borrow_length_field_path_const(
                                        fc);
 
                        if (length_field_path) {
@@ -790,51 +895,17 @@ void write_field_class(struct details_write_ctx *ctx, const bt_field_class *fc,
                g_string_append_c(ctx->str, ':');
                write_nl(ctx);
                incr_indent(ctx);
+               write_compound_member_name(ctx, "Element");
+               write_sp(ctx);
                write_field_class(ctx,
-                       bt_field_class_array_borrow_element_field_class_const(fc),
-                       "Element");
+                       bt_field_class_array_borrow_element_field_class_const(fc));
                decr_indent(ctx);
                break;
-       case BT_FIELD_CLASS_TYPE_VARIANT:
-       {
-               uint64_t option_count =
-                       bt_field_class_variant_get_option_count(fc);
-               const bt_field_path *sel_field_path =
-                       bt_field_class_variant_borrow_selector_field_path_const(
-                               fc);
-
-               g_string_append(ctx->str, " (");
-               write_uint_prop_value(ctx, option_count);
-               g_string_append_printf(ctx->str, " option%s, ",
-                       plural(option_count));
-
-               if (sel_field_path) {
-                       g_string_append(ctx->str, "Selector field path ");
-                       write_field_path(ctx, sel_field_path);
-               }
-
-               g_string_append_c(ctx->str, ')');
-
-               if (option_count > 0) {
-                       g_string_append_c(ctx->str, ':');
-                       incr_indent(ctx);
-
-                       for (i = 0; i < option_count; i++) {
-                               const bt_field_class_variant_option *option =
-                                       bt_field_class_variant_borrow_option_by_index_const(
-                                               fc, i);
-
-                               write_nl(ctx);
-                               write_field_class(ctx,
-                                       bt_field_class_variant_option_borrow_field_class_const(option),
-                                       bt_field_class_variant_option_get_name(option));
-                       }
-
-                       decr_indent(ctx);
-               }
-
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITHOUT_SELECTOR:
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_UNSIGNED_SELECTOR:
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_SIGNED_SELECTOR:
+               write_variant_field_class(ctx, fc);
                break;
-       }
        default:
                break;
        }
@@ -849,7 +920,7 @@ void write_root_field_class(struct details_write_ctx *ctx, const char *name,
        write_indent(ctx);
        write_prop_name(ctx, name);
        g_string_append(ctx->str, ": ");
-       write_field_class(ctx, fc, NULL);
+       write_field_class(ctx, fc);
        write_nl(ctx);
 }
 
@@ -1039,23 +1110,36 @@ void write_stream_class(struct details_write_ctx *ctx,
 
        /* Write configuration */
        write_bool_prop_line(ctx,
-               "Packets have beginning default clock snapshot",
-               bt_stream_class_packets_have_beginning_default_clock_snapshot(sc));
-       write_bool_prop_line(ctx,
-               "Packets have end default clock snapshot",
-               bt_stream_class_packets_have_end_default_clock_snapshot(sc));
+               "Supports packets", bt_stream_class_supports_packets(sc));
+
+       if (bt_stream_class_supports_packets(sc)) {
+               write_bool_prop_line(ctx,
+                       "Packets have beginning default clock snapshot",
+                       bt_stream_class_packets_have_beginning_default_clock_snapshot(sc));
+               write_bool_prop_line(ctx,
+                       "Packets have end default clock snapshot",
+                       bt_stream_class_packets_have_end_default_clock_snapshot(sc));
+       }
+
        write_bool_prop_line(ctx,
                "Supports discarded events",
                bt_stream_class_supports_discarded_events(sc));
-       write_bool_prop_line(ctx,
-               "Discarded events have default clock snapshots",
-               bt_stream_class_discarded_events_have_default_clock_snapshots(sc));
+
+       if (bt_stream_class_supports_discarded_events(sc)) {
+               write_bool_prop_line(ctx,
+                       "Discarded events have default clock snapshots",
+                       bt_stream_class_discarded_events_have_default_clock_snapshots(sc));
+       }
+
        write_bool_prop_line(ctx,
                "Supports discarded packets",
                bt_stream_class_supports_discarded_packets(sc));
-       write_bool_prop_line(ctx,
-               "Discarded packets have default clock snapshots",
-               bt_stream_class_discarded_packets_have_default_clock_snapshots(sc));
+
+       if (bt_stream_class_supports_discarded_packets(sc)) {
+               write_bool_prop_line(ctx,
+                       "Discarded packets have default clock snapshots",
+                       bt_stream_class_discarded_packets_have_default_clock_snapshots(sc));
+       }
 
        /* Write default clock class */
        if (bt_stream_class_borrow_default_clock_class_const(sc)) {
@@ -1121,97 +1205,12 @@ static
 void write_trace_class(struct details_write_ctx *ctx, const bt_trace_class *tc)
 {
        GPtrArray *stream_classes = g_ptr_array_new();
-       GPtrArray *env_names = g_ptr_array_new();
-       uint64_t env_count;
        uint64_t i;
        bool printed_prop = false;
 
        write_indent(ctx);
        write_obj_type_name(ctx, "Trace class");
 
-       /* Write name */
-       if (ctx->details_comp->cfg.with_trace_class_name) {
-               const char *name = bt_trace_class_get_name(tc);
-
-               if (name) {
-                       g_string_append(ctx->str, " `");
-                       write_str_prop_value(ctx, name);
-                       g_string_append(ctx->str, "`");
-               }
-       }
-
-       /* Write properties */
-       incr_indent(ctx);
-
-       if (ctx->details_comp->cfg.with_uuid) {
-               bt_uuid uuid = bt_trace_class_get_uuid(tc);
-
-               if (uuid) {
-                       if (!printed_prop) {
-                               g_string_append(ctx->str, ":\n");
-                               printed_prop = true;
-                       }
-
-                       write_uuid_prop_line(ctx, "UUID", uuid);
-               }
-       }
-
-       /* Write environment */
-       env_count = bt_trace_class_get_environment_entry_count(tc);
-       if (env_count > 0) {
-               if (!printed_prop) {
-                       g_string_append(ctx->str, ":\n");
-                       printed_prop = true;
-               }
-
-               write_indent(ctx);
-               write_prop_name(ctx, "Environment");
-               g_string_append(ctx->str, " (");
-               write_uint_prop_value(ctx, env_count);
-               g_string_append_printf(ctx->str, " entr%s):",
-                       env_count == 1 ? "y" : "ies");
-               write_nl(ctx);
-               incr_indent(ctx);
-
-               for (i = 0; i < env_count; i++) {
-                       const char *name;
-                       const bt_value *value;
-
-                       bt_trace_class_borrow_environment_entry_by_index_const(
-                               tc, i, &name, &value);
-                       g_ptr_array_add(env_names, (gpointer) name);
-               }
-
-               g_ptr_array_sort(env_names, (GCompareFunc) compare_strings);
-
-               for (i = 0; i < env_names->len; i++) {
-                       const char *name = env_names->pdata[i];
-                       const bt_value *value =
-                               bt_trace_class_borrow_environment_entry_value_by_name_const(
-                                       tc, name);
-
-                       BT_ASSERT(value);
-                       write_compound_member_name(ctx, name);
-                       write_sp(ctx);
-
-                       if (bt_value_get_type(value) ==
-                                       BT_VALUE_TYPE_SIGNED_INTEGER) {
-                               write_int_prop_value(ctx,
-                                       bt_value_signed_integer_get(value));
-                       } else if (bt_value_get_type(value) ==
-                                       BT_VALUE_TYPE_STRING) {
-                               write_str_prop_value(ctx,
-                                       bt_value_string_get(value));
-                       } else {
-                               abort();
-                       }
-
-                       write_nl(ctx);
-               }
-
-               decr_indent(ctx);
-       }
-
        for (i = 0; i < bt_trace_class_get_stream_class_count(tc); i++) {
                g_ptr_array_add(stream_classes,
                        (gpointer) bt_trace_class_borrow_stream_class_by_index_const(
@@ -1227,18 +1226,18 @@ void write_trace_class(struct details_write_ctx *ctx, const bt_trace_class *tc)
                }
        }
 
+       incr_indent(ctx);
+
        for (i = 0; i < stream_classes->len; i++) {
                write_stream_class(ctx, stream_classes->pdata[i]);
        }
 
-       decr_indent(ctx);
-
        if (!printed_prop) {
                write_nl(ctx);
        }
 
+       decr_indent(ctx);
        g_ptr_array_free(stream_classes, TRUE);
-       g_ptr_array_free(env_names, TRUE);
 }
 
 static
@@ -1505,13 +1504,13 @@ void write_field(struct details_write_ctx *ctx, const bt_field *field,
                if (fc_type == BT_FIELD_CLASS_TYPE_UNSIGNED_INTEGER ||
                                fc_type == BT_FIELD_CLASS_TYPE_UNSIGNED_ENUMERATION) {
                        format_uint(buf,
-                               bt_field_unsigned_integer_get_value(field),
+                               bt_field_integer_unsigned_get_value(field),
                                fmt_base);
                        write_sp(ctx);
                        write_uint_str_prop_value(ctx, buf);
                } else {
                        format_int(buf,
-                               bt_field_signed_integer_get_value(field),
+                               bt_field_integer_signed_get_value(field),
                                fmt_base);
                        write_sp(ctx);
                        write_int_str_prop_value(ctx, buf);
@@ -1585,7 +1584,9 @@ void write_field(struct details_write_ctx *ctx, const bt_field *field,
                decr_indent(ctx);
                break;
        }
-       case BT_FIELD_CLASS_TYPE_VARIANT:
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITHOUT_SELECTOR:
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_UNSIGNED_SELECTOR:
+       case BT_FIELD_CLASS_TYPE_VARIANT_WITH_SIGNED_SELECTOR:
                write_field(ctx,
                        bt_field_variant_borrow_selected_option_field_const(
                                field), NULL);
@@ -1716,10 +1717,11 @@ static
 void write_trace(struct details_write_ctx *ctx, const bt_trace *trace)
 {
        const char *name;
-       const bt_trace_class *tc = bt_trace_borrow_class_const(trace);
        GPtrArray *streams = g_ptr_array_new();
        uint64_t i;
        bool printed_prop = false;
+       GPtrArray *env_names = g_ptr_array_new();
+       uint64_t env_count;
 
        write_indent(ctx);
        write_obj_type_name(ctx, "Trace");
@@ -1737,29 +1739,74 @@ void write_trace(struct details_write_ctx *ctx, const bt_trace *trace)
        /* Write properties */
        incr_indent(ctx);
 
-       if (ctx->details_comp->cfg.with_trace_class_name) {
-               name = bt_trace_class_get_name(tc);
-               if (name) {
+       /* Write UUID */
+       if (ctx->details_comp->cfg.with_uuid) {
+               bt_uuid uuid = bt_trace_get_uuid(trace);
+
+               if (uuid) {
                        if (!printed_prop) {
                                g_string_append(ctx->str, ":\n");
                                printed_prop = true;
                        }
 
-                       write_str_prop_line(ctx, "Class name", name);
+                       write_uuid_prop_line(ctx, "UUID", uuid);
                }
        }
 
-       if (ctx->details_comp->cfg.with_uuid) {
-               bt_uuid uuid = bt_trace_class_get_uuid(tc);
+       /* Write environment */
+       env_count = bt_trace_get_environment_entry_count(trace);
+       if (env_count > 0) {
+               if (!printed_prop) {
+                       g_string_append(ctx->str, ":\n");
+                       printed_prop = true;
+               }
 
-               if (uuid) {
-                       if (!printed_prop) {
-                               g_string_append(ctx->str, ":\n");
-                               printed_prop = true;
+               write_indent(ctx);
+               write_prop_name(ctx, "Environment");
+               g_string_append(ctx->str, " (");
+               write_uint_prop_value(ctx, env_count);
+               g_string_append_printf(ctx->str, " entr%s):",
+                       env_count == 1 ? "y" : "ies");
+               write_nl(ctx);
+               incr_indent(ctx);
+
+               for (i = 0; i < env_count; i++) {
+                       const char *name;
+                       const bt_value *value;
+
+                       bt_trace_borrow_environment_entry_by_index_const(
+                               trace, i, &name, &value);
+                       g_ptr_array_add(env_names, (gpointer) name);
+               }
+
+               g_ptr_array_sort(env_names, (GCompareFunc) compare_strings);
+
+               for (i = 0; i < env_names->len; i++) {
+                       const char *name = env_names->pdata[i];
+                       const bt_value *value =
+                               bt_trace_borrow_environment_entry_value_by_name_const(
+                                       trace, name);
+
+                       BT_ASSERT(value);
+                       write_compound_member_name(ctx, name);
+                       write_sp(ctx);
+
+                       if (bt_value_get_type(value) ==
+                                       BT_VALUE_TYPE_SIGNED_INTEGER) {
+                               write_int_prop_value(ctx,
+                                       bt_value_integer_signed_get(value));
+                       } else if (bt_value_get_type(value) ==
+                                       BT_VALUE_TYPE_STRING) {
+                               write_str_prop_value(ctx,
+                                       bt_value_string_get(value));
+                       } else {
+                               abort();
                        }
 
-                       write_uuid_prop_line(ctx, "Class UUID", uuid);
+                       write_nl(ctx);
                }
+
+               decr_indent(ctx);
        }
 
        for (i = 0; i < bt_trace_get_stream_count(trace); i++) {
@@ -1796,6 +1843,7 @@ void write_trace(struct details_write_ctx *ctx, const bt_trace *trace)
        }
 
        g_ptr_array_free(streams, TRUE);
+       g_ptr_array_free(env_names, TRUE);
 }
 
 static
@@ -1807,6 +1855,7 @@ int write_stream_beginning_message(struct details_write_ctx *ctx,
                bt_message_stream_beginning_borrow_stream_const(msg);
        const bt_trace *trace = bt_stream_borrow_trace_const(stream);
        const bt_stream_class *sc = bt_stream_borrow_class_const(stream);
+       const bt_clock_class *cc = bt_stream_class_borrow_default_clock_class_const(sc);
        const bt_trace_class *tc = bt_stream_class_borrow_trace_class_const(sc);
        const char *name;
 
@@ -1815,6 +1864,19 @@ int write_stream_beginning_message(struct details_write_ctx *ctx,
                goto end;
        }
 
+       /* Write time */
+       if (cc) {
+               const bt_clock_snapshot *cs;
+               bt_message_stream_clock_snapshot_state cs_state =
+                       bt_message_stream_beginning_borrow_default_clock_snapshot_const(msg, &cs);
+
+               if (cs_state == BT_MESSAGE_STREAM_CLOCK_SNAPSHOT_STATE_KNOWN) {
+                       write_time(ctx, cs);
+               } else {
+                       write_time_str(ctx, "Unknown");
+               }
+       }
+
        /* Write follow tag for message */
        ret = write_message_follow_tag(ctx, stream);
        if (ret) {
@@ -1860,87 +1922,22 @@ int write_stream_end_message(struct details_write_ctx *ctx,
        int ret = 0;
        const bt_stream *stream =
                bt_message_stream_end_borrow_stream_const(msg);
-
-       /* Write follow tag for message */
-       ret = write_message_follow_tag(ctx, stream);
-       if (ret) {
-               goto end;
-       }
-
-       /* Write stream properties */
-       write_obj_type_name(ctx, "Stream end\n");
-
-end:
-       return ret;
-}
-
-static
-int write_stream_activity_beginning_message(struct details_write_ctx *ctx,
-               const bt_message *msg)
-{
-       int ret = 0;
-       const bt_stream *stream =
-               bt_message_stream_activity_beginning_borrow_stream_const(msg);
-       bt_message_stream_activity_clock_snapshot_state cs_state;
-       const bt_clock_snapshot *cs = NULL;
+       const bt_stream_class *sc =
+               bt_stream_borrow_class_const(stream);
+       const bt_clock_class *cc =
+               bt_stream_class_borrow_default_clock_class_const(sc);
 
        /* Write time */
-       cs_state = bt_message_stream_activity_beginning_borrow_default_clock_snapshot_const(
-               msg, &cs);
-       switch (cs_state) {
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_KNOWN:
-               BT_ASSERT(cs);
-               write_time(ctx, cs);
-               break;
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_UNKNOWN:
-               write_time_str(ctx, "Unknown");
-               break;
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_INFINITE:
-               write_time_str(ctx, "-Infinity");
-               break;
-       default:
-               abort();
-       }
-
-       /* Write follow tag for message */
-       ret = write_message_follow_tag(ctx, stream);
-       if (ret) {
-               goto end;
-       }
-
-       write_obj_type_name(ctx, "Stream activity beginning");
-       write_nl(ctx);
-
-end:
-       return ret;
-}
+       if (cc) {
+               const bt_clock_snapshot *cs;
+               bt_message_stream_clock_snapshot_state cs_state =
+                       bt_message_stream_end_borrow_default_clock_snapshot_const(msg, &cs);
 
-static
-int write_stream_activity_end_message(struct details_write_ctx *ctx,
-               const bt_message *msg)
-{
-       int ret = 0;
-       const bt_stream *stream =
-               bt_message_stream_activity_end_borrow_stream_const(msg);
-       bt_message_stream_activity_clock_snapshot_state cs_state;
-       const bt_clock_snapshot *cs = NULL;
-
-       /* Write time */
-       cs_state = bt_message_stream_activity_end_borrow_default_clock_snapshot_const(
-               msg, &cs);
-       switch (cs_state) {
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_KNOWN:
-               BT_ASSERT(cs);
-               write_time(ctx, cs);
-               break;
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_UNKNOWN:
-               write_time_str(ctx, "Unknown");
-               break;
-       case BT_MESSAGE_STREAM_ACTIVITY_CLOCK_SNAPSHOT_STATE_INFINITE:
-               write_time_str(ctx, "+Infinity");
-               break;
-       default:
-               abort();
+               if (cs_state == BT_MESSAGE_STREAM_CLOCK_SNAPSHOT_STATE_KNOWN) {
+                       write_time(ctx, cs);
+               } else {
+                       write_time_str(ctx, "Unknown");
+               }
        }
 
        /* Write follow tag for message */
@@ -1949,8 +1946,8 @@ int write_stream_activity_end_message(struct details_write_ctx *ctx,
                goto end;
        }
 
-       write_obj_type_name(ctx, "Stream activity end");
-       write_nl(ctx);
+       /* Write stream properties */
+       write_obj_type_name(ctx, "Stream end\n");
 
 end:
        return ret;
@@ -2198,12 +2195,6 @@ int details_write_message(struct details_comp *details_comp,
        case BT_MESSAGE_TYPE_PACKET_END:
                ret = write_packet_end_message(&ctx, msg);
                break;
-       case BT_MESSAGE_TYPE_STREAM_ACTIVITY_BEGINNING:
-               ret = write_stream_activity_beginning_message(&ctx, msg);
-               break;
-       case BT_MESSAGE_TYPE_STREAM_ACTIVITY_END:
-               ret = write_stream_activity_end_message(&ctx, msg);
-               break;
        case BT_MESSAGE_TYPE_DISCARDED_EVENTS:
                ret = write_discarded_events_message(&ctx, msg);
                break;
This page took 0.034403 seconds and 4 git commands to generate.