`test_plugin.py`: use absolute paths for plugin path comparison

[babeltrace.git] / tests / bindings / python / bt2 / test_plugin.py

diff --git a/tests/bindings/python/bt2/test_plugin.py b/tests/bindings/python/bt2/test_plugin.py
index 4df92d0799dbe44a7b282e9127fb6a7ab57c5055..9ba6cd9a197a263e82ec9f68056f41c604225368 100644 (file)
--- a/tests/bindings/python/bt2/test_plugin.py
+++ b/tests/bindings/python/bt2/test_plugin.py
@@ -22,7 +22,8 @@ import bt2.plugin
 import os
 
 
-_TEST_PLUGIN_PLUGINS_PATH = os.environ['TEST_PLUGIN_PLUGINS_PATH']
+_TEST_PLUGIN_PLUGINS_PATH = os.environ['BT_PLUGINS_PATH']
+_TEST_PLUGIN_PLUGIN_EXTENSION_BY_OS = {'cygwin': 'dll', 'mingw': 'dll'}
 
 
 class PluginSetTestCase(unittest.TestCase):
@@ -47,23 +48,35 @@ class PluginSetTestCase(unittest.TestCase):
 
 
 class FindPluginsTestCase(unittest.TestCase):
-    def test_find_none(self):
-        pset = bt2.find_plugins('/this/does/not/exist/246703df-cb85-46d5-8406-5e8dc4a88b41')
-        self.assertIsNone(pset)
+    def test_find_nonexistent_dir(self):
+        with self.assertRaises(bt2.Error):
+            bt2.find_plugins(
+                '/this/does/not/exist/246703df-cb85-46d5-8406-5e8dc4a88b41'
+            )
+
+    def test_find_none_existing_dir(self):
+        plugins = bt2.find_plugins(_TEST_PLUGIN_PLUGINS_PATH, recurse=False)
+        self.assertIsNone(plugins)
 
     def test_find_dir(self):
         pset = bt2.find_plugins(_TEST_PLUGIN_PLUGINS_PATH)
         self.assertTrue(len(pset) >= 3)
 
     def test_find_file(self):
-        path = os.path.join(_TEST_PLUGIN_PLUGINS_PATH, 'utils', '.libs', 'babeltrace-plugin-utils.so')
+        extension = _TEST_PLUGIN_PLUGIN_EXTENSION_BY_OS.get(
+            os.environ['BT_OS_TYPE'], 'so'
+        )
+        plugin_name = 'babeltrace-plugin-utils.{}'.format(extension)
+        path = os.path.join(_TEST_PLUGIN_PLUGINS_PATH, 'utils', '.libs', plugin_name)
         pset = bt2.find_plugins(path)
         self.assertTrue(len(pset) == 1)
 
 
 class FindPluginTestCase(unittest.TestCase):
     def test_find_none(self):
-        plugin = bt2.find_plugin('this-does-not-exist-246703df-cb85-46d5-8406-5e8dc4a88b41')
+        plugin = bt2.find_plugin(
+            'this-does-not-exist-246703df-cb85-46d5-8406-5e8dc4a88b41'
+        )
         self.assertIsNone(plugin)
 
     def test_find_existing(self):
@@ -82,8 +95,8 @@ class PluginTestCase(unittest.TestCase):
         self.assertEqual(self._plugin.name, 'ctf')
 
     def test_path(self):
-        plugin_path = os.path.normcase(self._plugin.path)
-        plugin_path_env = os.path.normcase(_TEST_PLUGIN_PLUGINS_PATH)
+        plugin_path = os.path.abspath(os.path.normcase(self._plugin.path))
+        plugin_path_env = os.path.abspath(os.path.normcase(_TEST_PLUGIN_PLUGINS_PATH))
         self.assertTrue(plugin_path.startswith(plugin_path_env))
 
     def test_author(self):