X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=converter%2Fbabeltrace-cfg.c;h=6beaf383bfdfef77c2f69f0be9020986699a9891;hp=a2b2ac4f8968c80f135e4807b5d696a95bd9fe77;hb=ea103fa04f31ee62da4060066697a9b200d7394e;hpb=b7726e327a09e8ceadb4e131d7d757d500ba7d62 diff --git a/converter/babeltrace-cfg.c b/converter/babeltrace-cfg.c index a2b2ac4f..6beaf383 100644 --- a/converter/babeltrace-cfg.c +++ b/converter/babeltrace-cfg.c @@ -33,8 +33,16 @@ #include #include #include +#include +#include #include "babeltrace-cfg.h" +#define SYSTEM_PLUGIN_PATH INSTALL_LIBDIR "/babeltrace/plugins" +#define DEFAULT_SOURCE_COMPONENT_NAME "ctf.fs" +#define DEFAULT_SINK_COMPONENT_NAME "text.text" +#define HOME_ENV_VAR "HOME" +#define HOME_SUBPATH "/.babeltrace/plugins" + /* * Error printf() macro which prepends "Error: " the first time it's * called. This gives a nicer feel than having a bunch of error prefixes @@ -140,6 +148,9 @@ enum legacy_output_format { LEGACY_OUTPUT_FORMAT_DUMMY, }; +static bool omit_system_plugin_path; +static bool omit_home_plugin_path; + /* * Prints the "out of memory" error. */ @@ -722,7 +733,7 @@ void print_legacy_usage(FILE *fp) fprintf(fp, " \n"); fprintf(fp, " --clock-cycles Print timestamps in clock cycles\n"); fprintf(fp, " --clock-date Print timestamp dates\n"); - fprintf(fp, " --clock-gmt Print timestamps in GMT time zone\n"); + fprintf(fp, " --clock-gmt Print and parse timestamps in GMT time zone\n"); fprintf(fp, " (default: local time zone)\n"); fprintf(fp, " --clock-seconds Print the timestamps as [SEC.NS]\n"); fprintf(fp, " (default format: [HH:MM:SS.NS])\n"); @@ -754,20 +765,11 @@ void print_usage(FILE *fp) { fprintf(fp, "Usage: babeltrace [OPTIONS]\n"); fprintf(fp, "\n"); - fprintf(fp, " -B, --base-begin-ns=NS Set NS as the current base beginning\n"); - fprintf(fp, " timestamp of the following source component\n"); - fprintf(fp, " instances\n"); - fprintf(fp, " -E, --base-end-ns=NS Set NS as the current base end timestamp\n"); - fprintf(fp, " of the following source component instances\n"); fprintf(fp, " -b, --base-params=PARAMS Set PARAMS as the current base parameters\n"); fprintf(fp, " of the following source and sink component\n"); fprintf(fp, " instances (see the exact format of PARAMS\n"); fprintf(fp, " below)\n"); - fprintf(fp, " --begin-ns=NS Set the beginning timestamp of the latest\n"); - fprintf(fp, " source component instance to NS\n"); fprintf(fp, " -d, --debug Enable debug mode\n"); - fprintf(fp, " --end-ns=NS Set the end timestamp of the latest source\n"); - fprintf(fp, " component instance to NS\n"); fprintf(fp, " -l, --list List available plugins and their components\n"); fprintf(fp, " -P, --path=PATH Set the `path` parameter of the latest source\n"); fprintf(fp, " or sink component to PATH\n"); @@ -777,10 +779,6 @@ void print_usage(FILE *fp) fprintf(fp, " PARAMS below)\n"); fprintf(fp, " --plugin-path=PATH[:PATH]... Set paths from which dynamic plugins can be\n"); fprintf(fp, " loaded to PATH\n"); - fprintf(fp, " --reset-base-begin-ns Reset the current base beginning timestamp\n"); - fprintf(fp, " of the following source component instances\n"); - fprintf(fp, " --reset-base-end-ns Reset the current base end timestamp of the\n"); - fprintf(fp, " following source component instances\n"); fprintf(fp, " -r, --reset-base-params Reset the current base parameters of the\n"); fprintf(fp, " following source and sink component\n"); fprintf(fp, " instances to an empty map\n"); @@ -790,6 +788,11 @@ void print_usage(FILE *fp) fprintf(fp, " -i, --source=PLUGIN.COMPCLS Instantiate a source component from plugin\n"); fprintf(fp, " PLUGIN and component class COMPCLS (may be\n"); fprintf(fp, " repeated)\n"); + fprintf(fp, " --begin Start time: [YYYY-MM-DD [hh:mm:]]ss[.nnnnnnnnn]\n"); + fprintf(fp, " --end End time: [YYYY-MM-DD [hh:mm:]]ss[.nnnnnnnnn]\n"); + fprintf(fp, " --timerange Time range: begin,end or [begin,end] (where [] are actual brackets)\n"); + fprintf(fp, " --omit-system-plugin-path Omit system plugins from plugin search path\n"); + fprintf(fp, " --omit-home-plugin-path Omit home plugins from plugin search path\n"); fprintf(fp, " -h --help Show this help\n"); fprintf(fp, " --help-legacy Show Babeltrace 1.x legacy options\n"); fprintf(fp, " -v, --verbose Enable verbose output\n"); @@ -893,10 +896,6 @@ struct bt_config_component *bt_config_component_create(const char *plugin_name, goto error; } - /* Begin/end timestamp: not set */ - cfg_component->begin_ns = -1ULL; - cfg_component->end_ns = -1ULL; - goto end; error: @@ -968,6 +967,12 @@ end: return; } +static +bool is_setuid_setgid(void) +{ + return (geteuid() != getuid() || getegid() != getgid()); +} + /* * Extracts the various paths from the string arg, delimited by ':', * and converts them to an array value object. @@ -977,18 +982,12 @@ end: * Return value is owned by the caller. */ static -struct bt_value *plugin_paths_from_arg(const char *arg) +enum bt_value_status plugin_paths_from_arg(struct bt_value *plugin_paths, + const char *arg) { - struct bt_value *plugin_paths; const char *at = arg; const char *end = arg + strlen(arg); - plugin_paths = bt_value_array_create(); - if (!plugin_paths) { - print_err_oom(); - goto error; - } - while (at < end) { int ret; GString *path; @@ -1023,13 +1022,9 @@ struct bt_value *plugin_paths_from_arg(const char *arg) } } - goto end; - + return BT_VALUE_STATUS_OK; error: - BT_PUT(plugin_paths); - -end: - return plugin_paths; + return BT_VALUE_STATUS_ERROR; } /* @@ -1584,8 +1579,7 @@ static int append_sources_from_legacy_opts(GPtrArray *sources, enum legacy_input_format legacy_input_format, struct ctf_legacy_opts *ctf_legacy_opts, - struct bt_value *legacy_input_paths, - uint64_t begin_ns, uint64_t end_ns) + struct bt_value *legacy_input_paths) { int ret = 0; int i; @@ -1650,8 +1644,6 @@ int append_sources_from_legacy_opts(GPtrArray *sources, } BT_MOVE(bt_config_component->params, params); - bt_config_component->begin_ns = begin_ns; - bt_config_component->end_ns = end_ns; /* Move created component configuration to the array */ g_ptr_array_add(sources, bt_config_component); @@ -2000,28 +1992,6 @@ end: return; } -/* - * Validates a given source component configuration. - */ -static -bool validate_source_config_component(struct bt_config_component *cfg_comp) -{ - bool valid = false; - - if (cfg_comp->begin_ns != -1ULL && cfg_comp->end_ns != -1ULL) { - if (cfg_comp->begin_ns > cfg_comp->end_ns) { - printf_err("Beginning timestamp (%" PRIu64 ") is greater than end timestamp (%" PRIu64 ")\n", - cfg_comp->begin_ns, cfg_comp->end_ns); - goto end; - } - } - - valid = true; - -end: - return valid; -} - /* * Validates a given configuration, with optional legacy input and * output formats options. Prints useful error messages if anything @@ -2042,14 +2012,12 @@ bool validate_cfg(struct bt_config *cfg, /* Determine if the input and output should be legacy-style */ if (*legacy_input_format != LEGACY_INPUT_FORMAT_NONE || - cfg->sources->len == 0 || !bt_value_array_is_empty(legacy_input_paths) || ctf_legacy_opts_is_any_set(ctf_legacy_opts)) { legacy_input = true; } if (*legacy_output_format != LEGACY_OUTPUT_FORMAT_NONE || - cfg->sinks->len == 0 || text_legacy_opts_is_any_set(text_legacy_opts)) { legacy_output = true; } @@ -2146,40 +2114,11 @@ int parse_int64(const char *arg, int64_t *val) return 0; } -/* - * Parses a time in nanoseconds. - * - * Returns a negative value if anything goes wrong. - */ -static -int ns_from_arg(const char *arg, uint64_t *ns) -{ - int ret = 0; - int64_t value; - - if (parse_int64(arg, &value)) { - ret = -1; - goto end; - } - - if (value < 0) { - ret = -1; - goto end; - } - - *ns = (uint64_t) value; - -end: - return ret; -} - /* popt options */ enum { OPT_NONE = 0, - OPT_BASE_BEGIN_NS, - OPT_BASE_END_NS, OPT_BASE_PARAMS, - OPT_BEGIN_NS, + OPT_BEGIN, OPT_CLOCK_CYCLES, OPT_CLOCK_DATE, OPT_CLOCK_FORCE_CORRELATE, @@ -2191,7 +2130,7 @@ enum { OPT_DEBUG_INFO_DIR, OPT_DEBUG_INFO_FULL_PATH, OPT_DEBUG_INFO_TARGET_PREFIX, - OPT_END_NS, + OPT_END, OPT_FIELDS, OPT_HELP, OPT_HELP_LEGACY, @@ -2204,23 +2143,22 @@ enum { OPT_PATH, OPT_PARAMS, OPT_PLUGIN_PATH, - OPT_RESET_BASE_BEGIN_NS, - OPT_RESET_BASE_END_NS, OPT_RESET_BASE_PARAMS, OPT_SINK, OPT_SOURCE, OPT_STREAM_INTERSECTION, + OPT_TIMERANGE, OPT_VERBOSE, OPT_VERSION, + OPT_OMIT_SYSTEM_PLUGIN_PATH, + OPT_OMIT_HOME_PLUGIN_PATH, }; /* popt long option descriptions */ static struct poptOption long_options[] = { /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */ - { "base-begin-ns", 'B', POPT_ARG_STRING, NULL, OPT_BASE_BEGIN_NS, NULL, NULL }, - { "base-end-ns", 'E', POPT_ARG_STRING, NULL, OPT_BASE_END_NS, NULL, NULL }, { "base-params", 'b', POPT_ARG_STRING, NULL, OPT_BASE_PARAMS, NULL, NULL }, - { "begin-ns", '\0', POPT_ARG_STRING, NULL, OPT_BEGIN_NS, NULL, NULL }, + { "begin", '\0', POPT_ARG_STRING, NULL, OPT_BEGIN, NULL, NULL }, { "clock-cycles", '\0', POPT_ARG_NONE, NULL, OPT_CLOCK_CYCLES, NULL, NULL }, { "clock-date", '\0', POPT_ARG_NONE, NULL, OPT_CLOCK_DATE, NULL, NULL }, { "clock-force-correlate", '\0', POPT_ARG_NONE, NULL, OPT_CLOCK_FORCE_CORRELATE, NULL, NULL }, @@ -2232,7 +2170,7 @@ static struct poptOption long_options[] = { { "debug-info-dir", 0, POPT_ARG_STRING, NULL, OPT_DEBUG_INFO_DIR, NULL, NULL }, { "debug-info-full-path", 0, POPT_ARG_NONE, NULL, OPT_DEBUG_INFO_FULL_PATH, NULL, NULL }, { "debug-info-target-prefix", 0, POPT_ARG_STRING, NULL, OPT_DEBUG_INFO_TARGET_PREFIX, NULL, NULL }, - { "end-ns", '\0', POPT_ARG_STRING, NULL, OPT_END_NS, NULL, NULL }, + { "end", '\0', POPT_ARG_STRING, NULL, OPT_END, NULL, NULL }, { "fields", 'f', POPT_ARG_STRING, NULL, OPT_FIELDS, NULL, NULL }, { "help", 'h', POPT_ARG_NONE, NULL, OPT_HELP, NULL, NULL }, { "help-legacy", '\0', POPT_ARG_NONE, NULL, OPT_HELP_LEGACY, NULL, NULL }, @@ -2245,14 +2183,15 @@ static struct poptOption long_options[] = { { "path", 'P', POPT_ARG_STRING, NULL, OPT_PATH, NULL, NULL }, { "params", 'p', POPT_ARG_STRING, NULL, OPT_PARAMS, NULL, NULL }, { "plugin-path", '\0', POPT_ARG_STRING, NULL, OPT_PLUGIN_PATH, NULL, NULL }, - { "reset-base-begin-ns", '\0', POPT_ARG_NONE, NULL, OPT_RESET_BASE_BEGIN_NS, NULL, NULL }, - { "reset-base-end-ns", '\0', POPT_ARG_NONE, NULL, OPT_RESET_BASE_END_NS, NULL, NULL }, { "reset-base-params", 'r', POPT_ARG_NONE, NULL, OPT_RESET_BASE_PARAMS, NULL, NULL }, { "sink", '\0', POPT_ARG_STRING, NULL, OPT_SINK, NULL, NULL }, { "source", '\0', POPT_ARG_STRING, NULL, OPT_SOURCE, NULL, NULL }, { "stream-intersection", '\0', POPT_ARG_NONE, NULL, OPT_STREAM_INTERSECTION, NULL, NULL }, + { "timerange", '\0', POPT_ARG_STRING, NULL, OPT_TIMERANGE, NULL, NULL }, { "verbose", 'v', POPT_ARG_NONE, NULL, OPT_VERBOSE, NULL, NULL }, { "version", 'V', POPT_ARG_NONE, NULL, OPT_VERSION, NULL, NULL }, + { "omit-system-plugin-path", '\0', POPT_ARG_NONE, NULL, OPT_OMIT_SYSTEM_PLUGIN_PATH, NULL, NULL }, + { "omit-home-plugin-path", '\0', POPT_ARG_NONE, NULL, OPT_OMIT_HOME_PLUGIN_PATH, NULL, NULL }, { NULL, 0, 0, NULL, 0, NULL, NULL }, }; @@ -2285,6 +2224,129 @@ static void add_cfg_comp(struct bt_config *cfg, } } +static int split_timerange(const char *arg, const char **begin, const char **end) +{ + const char *c; + + /* Try to match [begin,end] */ + c = strchr(arg, '['); + if (!c) + goto skip; + *begin = ++c; + c = strchr(c, ','); + if (!c) + goto skip; + *end = ++c; + c = strchr(c, ']'); + if (!c) + goto skip; + goto found; + +skip: + /* Try to match begin,end */ + c = arg; + *begin = c; + c = strchr(c, ','); + if (!c) + goto not_found; + *end = ++c; + /* fall-through */ +found: + return 0; +not_found: + return -1; +} + +static char *bt_secure_getenv(const char *name) +{ + if (is_setuid_setgid()) { + printf_err("Disregarding %s environment variable for setuid/setgid binary", name); + return NULL; + } + return getenv(name); +} + +static const char *get_home_dir(void) +{ + char *val = NULL; + struct passwd *pwd; + + val = bt_secure_getenv(HOME_ENV_VAR); + if (val) { + goto end; + } + /* Fallback on password file. */ + pwd = getpwuid(getuid()); + if (!pwd) { + goto end; + } + val = pwd->pw_dir; +end: + return val; +} + +static int add_internal_plugin_paths(struct bt_config *cfg) +{ + if (!omit_home_plugin_path) { + char path[PATH_MAX]; + const char *home_dir; + + if (is_setuid_setgid()) { + printf_debug("Skipping non-system plugin paths for setuid/setgid binary."); + } else { + home_dir = get_home_dir(); + if (home_dir) { + if (strlen(home_dir) + strlen(HOME_SUBPATH) + 1 + >= PATH_MAX) { + printf_err("Home directory path too long\n"); + goto error; + } + strcpy(path, home_dir); + strcat(path, HOME_SUBPATH); + if (plugin_paths_from_arg(cfg->plugin_paths, path)) { + printf_err("Invalid home plugin path\n"); + goto error; + } + } + } + } + + if (!omit_system_plugin_path) { + if (plugin_paths_from_arg(cfg->plugin_paths, + SYSTEM_PLUGIN_PATH)) { + printf_err("Invalid system plugin path\n"); + goto error; + } + } + return 0; +error: + return -1; +} + +static int append_sources_from_implicit_params(GPtrArray *sources, + struct bt_config_component *implicit_source_comp) +{ + size_t i; + size_t len = sources->len; + + for (i = 0; i < len; i++) { + struct bt_config_component *comp; + struct bt_value *params_to_set; + + comp = g_ptr_array_index(sources, i); + params_to_set = bt_value_map_extend(comp->params, + implicit_source_comp->params); + if (!params_to_set) { + printf_err("Cannot extend legacy component parameters with non-legacy parameters\n"); + goto error; + } + BT_MOVE(comp->params, params_to_set); + } + return 0; +error: + return -1; +} + /* * Returns a Babeltrace configuration, out of command-line arguments, * containing everything that is needed to instanciate specific @@ -2295,7 +2357,7 @@ static void add_cfg_comp(struct bt_config *cfg, * * Return value is NULL on error, otherwise it's owned by the caller. */ -struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) +struct bt_config *bt_config_from_args(int argc, const char *argv[], int *exit_code) { struct bt_config *cfg = NULL; poptContext pc = NULL; @@ -2306,25 +2368,19 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) enum legacy_output_format legacy_output_format = LEGACY_OUTPUT_FORMAT_NONE; struct bt_value *legacy_input_paths = NULL; + struct bt_config_component *implicit_source_comp = NULL; struct bt_config_component *cur_cfg_comp = NULL; + bool cur_is_implicit_source = false; + bool use_implicit_source = false; enum bt_config_component_dest cur_cfg_comp_dest = BT_CONFIG_COMPONENT_DEST_SOURCE; struct bt_value *cur_base_params = NULL; - uint64_t cur_base_begin_ns = -1ULL; - uint64_t cur_base_end_ns = -1ULL; - int opt; - bool cur_cfg_comp_params_set = false; - unsigned int i; + int opt, nr_omit_opt = 0; memset(&ctf_legacy_opts, 0, sizeof(ctf_legacy_opts)); memset(&text_legacy_opts, 0, sizeof(text_legacy_opts)); *exit_code = 0; - if (argc <= 1) { - print_usage(stdout); - goto end; - } - text_legacy_opts.output = g_string_new(NULL); if (!text_legacy_opts.output) { print_err_oom(); @@ -2375,6 +2431,23 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) goto error; } + /* Note: implicit source never gets positional base params. */ + implicit_source_comp = bt_config_component_from_arg(DEFAULT_SOURCE_COMPONENT_NAME); + if (implicit_source_comp) { + cur_cfg_comp = implicit_source_comp; + cur_is_implicit_source = true; + use_implicit_source = true; + } else { + printf_debug("Cannot find implicit source plugin \"%s\"", + DEFAULT_SOURCE_COMPONENT_NAME); + } + + cfg->plugin_paths = bt_value_array_create(); + if (!cfg->plugin_paths) { + print_err_oom(); + goto error; + } + /* Parse options */ pc = poptGetContext(NULL, argc, (const char **) argv, long_options, 0); if (!pc) { @@ -2389,17 +2462,23 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) switch (opt) { case OPT_PLUGIN_PATH: - if (cfg->plugin_paths) { - printf_err("Duplicate --plugin-path option\n"); - goto error; - } - - cfg->plugin_paths = plugin_paths_from_arg(arg); - if (!cfg->plugin_paths) { - printf_err("Invalid --plugin-path option's argument\n"); - goto error; + if (is_setuid_setgid()) { + printf_debug("Skipping non-system plugin paths for setuid/setgid binary."); + } else { + if (plugin_paths_from_arg(cfg->plugin_paths, arg)) { + printf_err("Invalid --plugin-path option's argument\n"); + goto error; + } } break; + case OPT_OMIT_SYSTEM_PLUGIN_PATH: + omit_system_plugin_path = true; + nr_omit_opt += 2; + break; + case OPT_OMIT_HOME_PLUGIN_PATH: + omit_home_plugin_path = true; + nr_omit_opt += 2; + break; case OPT_OUTPUT_PATH: if (text_legacy_opts.output->len > 0) { printf_err("Duplicate --output option\n"); @@ -2451,8 +2530,10 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) } } + use_implicit_source = false; + /* Non-legacy: try to create a component config */ - if (cur_cfg_comp) { + if (cur_cfg_comp && !cur_is_implicit_source) { add_cfg_comp(cfg, cur_cfg_comp, cur_cfg_comp_dest); } @@ -2463,19 +2544,17 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) arg); goto error; } + cur_is_implicit_source = false; assert(cur_base_params); bt_put(cur_cfg_comp->params); cur_cfg_comp->params = bt_value_copy(cur_base_params); - if (!cur_cfg_comp) { + if (!cur_cfg_comp->params) { print_err_oom(); goto end; } - cur_cfg_comp->begin_ns = cur_base_begin_ns; - cur_cfg_comp->end_ns = cur_base_end_ns; cur_cfg_comp_dest = BT_CONFIG_COMPONENT_DEST_SOURCE; - cur_cfg_comp_params_set = false; break; } case OPT_OUTPUT_FORMAT: @@ -2516,7 +2595,7 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) } /* Non-legacy: try to create a component config */ - if (cur_cfg_comp) { + if (cur_cfg_comp && !cur_is_implicit_source) { add_cfg_comp(cfg, cur_cfg_comp, cur_cfg_comp_dest); } @@ -2527,17 +2606,17 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) arg); goto error; } + cur_is_implicit_source = false; assert(cur_base_params); bt_put(cur_cfg_comp->params); cur_cfg_comp->params = bt_value_copy(cur_base_params); - if (!cur_cfg_comp) { + if (!cur_cfg_comp->params) { print_err_oom(); goto end; } cur_cfg_comp_dest = BT_CONFIG_COMPONENT_DEST_SINK; - cur_cfg_comp_params_set = false; break; } case OPT_PARAMS: @@ -2546,14 +2625,8 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) struct bt_value *params_to_set; if (!cur_cfg_comp) { - printf_err("--params option must follow a --source or --sink option\n"); - goto error; - } - - if (cur_cfg_comp_params_set) { - printf_err("Duplicate --params option for the same current component\ninstance (class %s.%s)\n", - cur_cfg_comp->plugin_name->str, - cur_cfg_comp->component_name->str); + printf_err("Can not apply parameter to unavailable default source component \"%s\".\n", + DEFAULT_SOURCE_COMPONENT_NAME); goto error; } @@ -2564,22 +2637,22 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) goto error; } - params_to_set = bt_value_map_extend(cur_base_params, + params_to_set = bt_value_map_extend(cur_cfg_comp->params, params); BT_PUT(params); if (!params_to_set) { - printf_err("Cannot extend current base parameters with --params option's argument:\n %s\n", + printf_err("Cannot extend current component parameters with --params option's argument:\n %s\n", arg); goto error; } BT_MOVE(cur_cfg_comp->params, params_to_set); - cur_cfg_comp_params_set = true; break; } case OPT_PATH: if (!cur_cfg_comp) { - printf_err("--path option must follow a --source or --sink option\n"); + printf_err("Can not apply parameter to unavailable default source component \"%s\".\n", + DEFAULT_SOURCE_COMPONENT_NAME); goto error; } @@ -2612,52 +2685,6 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) goto error; } break; - case OPT_BASE_BEGIN_NS: - if (ns_from_arg(arg, &cur_base_begin_ns)) { - printf_err("Invalid --base-begin-ns option's argument:\n %s\n", - arg); - goto error; - } - break; - case OPT_BASE_END_NS: - if (ns_from_arg(arg, &cur_base_end_ns)) { - printf_err("Invalid --base-end-ns option's argument:\n %s\n", - arg); - goto error; - } - break; - case OPT_RESET_BASE_BEGIN_NS: - cur_base_begin_ns = -1ULL; - break; - case OPT_RESET_BASE_END_NS: - cur_base_end_ns = -1ULL; - break; - case OPT_BEGIN_NS: - if (!cur_cfg_comp || cur_cfg_comp_dest == - BT_CONFIG_COMPONENT_DEST_SINK) { - printf_err("--begin-ns option must follow a --source option\n"); - goto error; - } - - if (ns_from_arg(arg, &cur_cfg_comp->begin_ns)) { - printf_err("Invalid --begin-ns option's argument:\n %s\n", - arg); - goto error; - } - break; - case OPT_END_NS: - if (!cur_cfg_comp || cur_cfg_comp_dest == - BT_CONFIG_COMPONENT_DEST_SINK) { - printf_err("--end-ns option must follow a --source option\n"); - goto error; - } - - if (ns_from_arg(arg, &cur_cfg_comp->end_ns)) { - printf_err("Invalid --end-ns option's argument:\n %s\n", - arg); - goto error; - } - break; case OPT_NAMES: if (text_legacy_opts.names) { printf_err("Duplicate --names option\n"); @@ -2740,6 +2767,67 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) case OPT_CLOCK_FORCE_CORRELATE: cfg->force_correlate = true; break; + case OPT_BEGIN: + if (!cur_cfg_comp) { + printf_err("Can not apply parameter to unavailable default source component \"%s\".\n", + DEFAULT_SOURCE_COMPONENT_NAME); + goto error; + } + if (cur_cfg_comp_dest != BT_CONFIG_COMPONENT_DEST_SOURCE) { + printf_err("--begin option must follow a --source option\n"); + goto error; + } + if (bt_value_map_insert_string(cur_cfg_comp->params, + "begin", arg)) { + print_err_oom(); + goto error; + } + break; + case OPT_END: + if (!cur_cfg_comp) { + printf_err("Can not apply parameter to unavailable default source component \"%s\".\n", + DEFAULT_SOURCE_COMPONENT_NAME); + goto error; + } + if (cur_cfg_comp_dest != BT_CONFIG_COMPONENT_DEST_SOURCE) { + printf_err("--end option must follow a --source option\n"); + goto error; + } + if (bt_value_map_insert_string(cur_cfg_comp->params, + "end", arg)) { + print_err_oom(); + goto error; + } + break; + case OPT_TIMERANGE: + { + const char *begin, *end; + + if (!cur_cfg_comp) { + printf_err("Can not apply parameter to unavailable default source component \"%s\".\n", + DEFAULT_SOURCE_COMPONENT_NAME); + goto error; + } + if (cur_cfg_comp_dest != BT_CONFIG_COMPONENT_DEST_SOURCE) { + printf_err("--timerange option must follow a --source option\n"); + goto error; + } + if (split_timerange(arg, &begin, &end)) { + printf_err("Invalid --timerange format, expecting: begin,end or [begin,end] (where [] are actual brackets)\n"); + goto error; + } + if (bt_value_map_insert_string(cur_cfg_comp->params, + "begin", begin)) { + print_err_oom(); + goto error; + } + if (bt_value_map_insert_string(cur_cfg_comp->params, + "end", end)) { + print_err_oom(); + goto error; + } + break; + } case OPT_HELP: BT_PUT(cfg); print_usage(stdout); @@ -2771,10 +2859,9 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) arg = NULL; } - /* Append current component configuration, if any */ - if (cur_cfg_comp) { - add_cfg_comp(cfg, cur_cfg_comp, cur_cfg_comp_dest); - cur_cfg_comp = NULL; + if (argc - nr_omit_opt <= 1) { + print_usage(stdout); + goto put_cfg; } /* Check for option parsing error */ @@ -2799,6 +2886,16 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) } } + if (add_internal_plugin_paths(cfg)) { + goto error; + } + + /* Append current component configuration, if any */ + if (cur_cfg_comp && !cur_is_implicit_source) { + add_cfg_comp(cfg, cur_cfg_comp, cur_cfg_comp_dest); + } + cur_cfg_comp = NULL; + /* Validate legacy/non-legacy options */ if (!validate_cfg(cfg, &legacy_input_format, &legacy_output_format, legacy_input_paths, &ctf_legacy_opts, @@ -2814,11 +2911,28 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) if (legacy_input_format) { if (append_sources_from_legacy_opts(cfg->sources, legacy_input_format, &ctf_legacy_opts, - legacy_input_paths, cur_base_begin_ns, - cur_base_end_ns)) { + legacy_input_paths)) { printf_err("Cannot convert legacy input format options to source component instance(s)\n"); goto error; } + if (append_sources_from_implicit_params(cfg->sources, + implicit_source_comp)) { + printf_err("Cannot initialize legacy component parameters\n"); + goto error; + } + use_implicit_source = false; + } else { + if (use_implicit_source) { + add_cfg_comp(cfg, implicit_source_comp, + BT_CONFIG_COMPONENT_DEST_SOURCE); + implicit_source_comp = NULL; + } else { + if (implicit_source_comp + && !bt_value_map_is_empty(implicit_source_comp->params)) { + printf_err("Arguments specified for implicit source, but an explicit source has been specified, overriding it\n"); + goto error; + } + } } /* @@ -2833,28 +2947,25 @@ struct bt_config *bt_config_from_args(int argc, char *argv[], int *exit_code) } } - for (i = 0; i < cfg->sources->len; i++) { - struct bt_config_component *cfg_component = - bt_config_get_component(cfg->sources, i); - - /* Only peek */ - bt_put(cfg_component); - - if (!validate_source_config_component(cfg_component)) { - printf_err("Invalid source component instance (class %s.%s)\n", - cfg_component->plugin_name->str, - cfg_component->component_name->str); - goto error; + if (cfg->sinks->len == 0) { + /* Use implicit sink as default. */ + cur_cfg_comp = bt_config_component_from_arg(DEFAULT_SINK_COMPONENT_NAME); + if (!cur_cfg_comp) { + printf_error("Cannot find implicit sink plugin \"%s\"\n", + DEFAULT_SINK_COMPONENT_NAME); } + add_cfg_comp(cfg, cur_cfg_comp, + BT_CONFIG_COMPONENT_DEST_SINK); + cur_cfg_comp = NULL; } goto end; error: + *exit_code = 1; +put_cfg: BT_PUT(cfg); cfg = NULL; - *exit_code = 1; - end: if (pc) { poptFreeContext(pc); @@ -2873,6 +2984,7 @@ end: } free(arg); + BT_PUT(implicit_source_comp); BT_PUT(cur_cfg_comp); BT_PUT(cur_base_params); BT_PUT(text_legacy_opts.names);