X-Git-Url: http://git.efficios.com/?p=babeltrace.git;a=blobdiff_plain;f=converter%2Fbabeltrace.c;h=30b655d8dd938a67c878699b9be1bcd8b6fc10b1;hp=2870df8fdbdb03216b18c15c2f0e3bd2644b84ce;hb=d0d82191bdac8626adf2489b89279f47805282ea;hpb=d86d62f815e8fce21a7efb2cc0811720d62b0c11 diff --git a/converter/babeltrace.c b/converter/babeltrace.c index 2870df8f..30b655d8 100644 --- a/converter/babeltrace.c +++ b/converter/babeltrace.c @@ -18,10 +18,18 @@ * all copies or substantial portions of the Software. */ -#define _XOPEN_SOURCE 700 +#define _GNU_SOURCE #include -#include +#include #include +#include +#include +#include +/* TODO: fix object model for format-agnostic callbacks */ +#include +#include +#include +#include #include #include #include @@ -29,46 +37,80 @@ #include #include #include -#include -#include #include +#include +#include +#include + +#include /* for clocks */ + +#define PARTIAL_ERROR_SLEEP 3 /* 3 seconds */ #define DEFAULT_FILE_ARRAY_SIZE 1 -static char *opt_input_format; -static char *opt_output_format; -static const char *opt_input_path; -static const char *opt_output_path; +/* + * casting these to const char * to please libpopt. It allocates memory + * behind our back (this is of course not documented). + */ +static char *opt_input_format, *opt_output_format; + +static GPtrArray *opt_input_paths; +static char *opt_output_path; -static struct trace_collection trace_collection_read; static struct format *fmt_read; +static void strlower(char *str) { while (*str) { - *str = tolower(*str); + *str = tolower((int) *str); str++; } } enum { OPT_NONE = 0, + OPT_OUTPUT_PATH, + OPT_INPUT_FORMAT, + OPT_OUTPUT_FORMAT, OPT_HELP, OPT_LIST, OPT_VERBOSE, OPT_DEBUG, OPT_NAMES, + OPT_FIELDS, + OPT_NO_DELTA, + OPT_CLOCK_OFFSET, + OPT_CLOCK_CYCLES, + OPT_CLOCK_SECONDS, + OPT_CLOCK_DATE, + OPT_CLOCK_GMT, + OPT_CLOCK_FORCE_CORRELATE, }; +/* + * We are _not_ using POPT_ARG_STRING ability to store directly into + * variables, because we want to cast the return to non-const, which is + * not possible without using poptGetOptArg explicitly. + */ static struct poptOption long_options[] = { /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */ - { "input-format", 'i', POPT_ARG_STRING, &opt_input_format, OPT_NONE, NULL, NULL }, - { "output-format", 'o', POPT_ARG_STRING, &opt_output_format, OPT_NONE, NULL, NULL }, + { "output", 'w', POPT_ARG_STRING, NULL, OPT_NONE, NULL, NULL }, + { "input-format", 'i', POPT_ARG_STRING, NULL, OPT_INPUT_FORMAT, NULL, NULL }, + { "output-format", 'o', POPT_ARG_STRING, NULL, OPT_OUTPUT_FORMAT, NULL, NULL }, { "help", 'h', POPT_ARG_NONE, NULL, OPT_HELP, NULL, NULL }, { "list", 'l', POPT_ARG_NONE, NULL, OPT_LIST, NULL, NULL }, { "verbose", 'v', POPT_ARG_NONE, NULL, OPT_VERBOSE, NULL, NULL }, { "debug", 'd', POPT_ARG_NONE, NULL, OPT_DEBUG, NULL, NULL }, { "names", 'n', POPT_ARG_STRING, NULL, OPT_NAMES, NULL, NULL }, + { "fields", 'f', POPT_ARG_STRING, NULL, OPT_FIELDS, NULL, NULL }, + { "no-delta", 0, POPT_ARG_NONE, NULL, OPT_NO_DELTA, NULL, NULL }, + { "clock-offset", 0, POPT_ARG_STRING, NULL, OPT_CLOCK_OFFSET, NULL, NULL }, + { "clock-cycles", 0, POPT_ARG_NONE, NULL, OPT_CLOCK_CYCLES, NULL, NULL }, + { "clock-seconds", 0, POPT_ARG_NONE, NULL, OPT_CLOCK_SECONDS, NULL, NULL }, + { "clock-date", 0, POPT_ARG_NONE, NULL, OPT_CLOCK_DATE, NULL, NULL }, + { "clock-gmt", 0, POPT_ARG_NONE, NULL, OPT_CLOCK_GMT, NULL, NULL }, + { "clock-force-correlate", 0, POPT_ARG_NONE, NULL, OPT_CLOCK_FORCE_CORRELATE, NULL, NULL }, { NULL, 0, 0, NULL, 0, NULL, NULL }, }; @@ -80,11 +122,12 @@ static void list_formats(FILE *fp) static void usage(FILE *fp) { - fprintf(fp, "BabelTrace Trace Converter %s\n\n", VERSION); - fprintf(fp, "usage : babeltrace [OPTIONS] INPUT \n"); + fprintf(fp, "BabelTrace Trace Viewer and Converter %s\n\n", VERSION); + fprintf(fp, "usage : babeltrace [OPTIONS] FILE...\n"); fprintf(fp, "\n"); - fprintf(fp, " INPUT Input trace path\n"); - fprintf(fp, " OUTPUT Output trace path (default: stdout)\n"); + fprintf(fp, " FILE Input trace file(s) and/or directory(ies)\n"); + fprintf(fp, " (space-separated)\n"); + fprintf(fp, " -w, --output OUTPUT Output trace path (default: stdout)\n"); fprintf(fp, "\n"); fprintf(fp, " -i, --input-format FORMAT Input trace format (default: ctf)\n"); fprintf(fp, " -o, --output-format FORMAT Output trace format (default: text)\n"); @@ -95,13 +138,23 @@ static void usage(FILE *fp) fprintf(fp, " (or set BABELTRACE_VERBOSE environment variable)\n"); fprintf(fp, " -d, --debug Debug mode\n"); fprintf(fp, " (or set BABELTRACE_DEBUG environment variable)\n"); - fprintf(fp, " -n, --names name1<,name2,...> Print field names.\n"); - fprintf(fp, " Available field names:\n"); + fprintf(fp, " --no-delta Do not print time delta between consecutive events\n"); + fprintf(fp, " -n, --names name1<,name2,...> Print field names:\n"); fprintf(fp, " (payload OR args OR arg)\n"); - fprintf(fp, " all, scope, header, (context OR ctx)\n"); - fprintf(fp, " trace, trace:domain, trace:procname, trace:vpid,\n"); - fprintf(fp, " loglevel.\n"); - fprintf(fp, " (payload active by default)\n"); + fprintf(fp, " none, all, scope, header, (context OR ctx)\n"); + fprintf(fp, " (default: payload,context)\n"); + fprintf(fp, " -f, --fields name1<,name2,...> Print additional fields:\n"); + fprintf(fp, " all, trace, trace:hostname, trace:domain,\n"); + fprintf(fp, " trace:procname, trace:vpid, loglevel, emf, callsite.\n"); + fprintf(fp, " (default: trace:hostname,trace:procname,trace:vpid)\n"); + fprintf(fp, " --clock-cycles Timestamp in cycles\n"); + fprintf(fp, " --clock-offset seconds Clock offset in seconds\n"); + fprintf(fp, " --clock-seconds Print the timestamps as [sec.ns]\n"); + fprintf(fp, " (default is: [hh:mm:ss.ns])\n"); + fprintf(fp, " --clock-date Print clock date\n"); + fprintf(fp, " --clock-gmt Print clock in GMT time zone (default: local time zone)\n"); + fprintf(fp, " --clock-force-correlate Assume that clocks are inherently correlated\n"); + fprintf(fp, " across traces.\n"); list_formats(fp); fprintf(fp, "\n"); } @@ -109,8 +162,10 @@ static void usage(FILE *fp) static int get_names_args(poptContext *pc) { char *str, *strlist, *strctx; + int ret = 0; opt_payload_field_names = 0; + opt_context_field_names = 0; strlist = (char *) poptGetOptArg(*pc); if (!strlist) { return -EINVAL; @@ -127,22 +182,63 @@ static int get_names_args(poptContext *pc) opt_header_field_names = 1; else if (!strcmp(str, "payload") || !strcmp(str, "args") || !strcmp(str, "arg")) opt_payload_field_names = 1; + else if (!strcmp(str, "none")) { + opt_all_field_names = 0; + opt_scope_field_names = 0; + opt_context_field_names = 0; + opt_header_field_names = 0; + opt_payload_field_names = 0; + } else { + fprintf(stderr, "[error] unknown field name type %s\n", str); + free(strlist); + ret = -EINVAL; + goto end; + } + } while ((str = strtok_r(NULL, ",", &strctx))); +end: + free(strlist); + return ret; +} + +static int get_fields_args(poptContext *pc) +{ + char *str, *strlist, *strctx; + int ret = 0; + + strlist = (char *) poptGetOptArg(*pc); + if (!strlist) { + return -EINVAL; + } + str = strtok_r(strlist, ",", &strctx); + do { + opt_trace_default_fields = 0; + if (!strcmp(str, "all")) + opt_all_fields = 1; else if (!strcmp(str, "trace")) - opt_trace_name = 1; + opt_trace_field = 1; + else if (!strcmp(str, "trace:hostname")) + opt_trace_hostname_field = 1; else if (!strcmp(str, "trace:domain")) - opt_trace_domain = 1; + opt_trace_domain_field = 1; else if (!strcmp(str, "trace:procname")) - opt_trace_procname = 1; + opt_trace_procname_field = 1; else if (!strcmp(str, "trace:vpid")) - opt_trace_vpid = 1; + opt_trace_vpid_field = 1; else if (!strcmp(str, "loglevel")) - opt_loglevel = 1; + opt_loglevel_field = 1; + else if (!strcmp(str, "emf")) + opt_emf_field = 1; + else if (!strcmp(str, "callsite")) + opt_callsite_field = 1; else { - fprintf(stdout, "[error] unknown field name type %s\n", str); - return -EINVAL; + fprintf(stderr, "[error] unknown field type %s\n", str); + ret = -EINVAL; + goto end; } } while ((str = strtok_r(NULL, ",", &strctx))); - return 0; +end: + free(strlist); + return ret; } /* @@ -153,6 +249,7 @@ static int parse_options(int argc, char **argv) { poptContext pc; int opt, ret = 0; + char *ipath; if (argc == 1) { usage(stdout); @@ -163,10 +260,32 @@ static int parse_options(int argc, char **argv) poptReadDefaultConfig(pc, 0); /* set default */ + opt_context_field_names = 1; opt_payload_field_names = 1; while ((opt = poptGetNextOpt(pc)) != -1) { switch (opt) { + case OPT_OUTPUT_PATH: + opt_output_path = (char *) poptGetOptArg(pc); + if (!opt_output_path) { + ret = -EINVAL; + goto end; + } + break; + case OPT_INPUT_FORMAT: + opt_input_format = (char *) poptGetOptArg(pc); + if (!opt_input_format) { + ret = -EINVAL; + goto end; + } + break; + case OPT_OUTPUT_FORMAT: + opt_output_format = (char *) poptGetOptArg(pc); + if (!opt_output_format) { + ret = -EINVAL; + goto end; + } + break; case OPT_HELP: usage(stdout); ret = 1; /* exit cleanly */ @@ -184,21 +303,71 @@ static int parse_options(int argc, char **argv) goto end; } break; + case OPT_FIELDS: + if (get_fields_args(&pc)) { + ret = -EINVAL; + goto end; + } + break; case OPT_DEBUG: babeltrace_debug = 1; break; + case OPT_NO_DELTA: + opt_delta_field = 0; + break; + case OPT_CLOCK_CYCLES: + opt_clock_cycles = 1; + break; + case OPT_CLOCK_OFFSET: + { + char *str; + char *endptr; + + str = (char *) poptGetOptArg(pc); + if (!str) { + fprintf(stderr, "[error] Missing --clock-offset argument\n"); + ret = -EINVAL; + goto end; + } + errno = 0; + opt_clock_offset = strtoull(str, &endptr, 0); + if (*endptr != '\0' || str == endptr || errno != 0) { + fprintf(stderr, "[error] Incorrect --clock-offset argument: %s\n", str); + ret = -EINVAL; + free(str); + goto end; + } + free(str); + break; + } + case OPT_CLOCK_SECONDS: + opt_clock_seconds = 1; + break; + case OPT_CLOCK_DATE: + opt_clock_date = 1; + break; + case OPT_CLOCK_GMT: + opt_clock_gmt = 1; + break; + case OPT_CLOCK_FORCE_CORRELATE: + opt_clock_force_correlate = 1; + break; + default: ret = -EINVAL; goto end; } } - opt_input_path = poptGetArg(pc); - if (!opt_input_path) { + do { + ipath = (char *) poptGetArg(pc); + if (ipath) + g_ptr_array_add(opt_input_paths, (gpointer) ipath); + } while (ipath); + if (opt_input_paths->len == 0) { ret = -EINVAL; goto end; } - opt_output_path = poptGetArg(pc); end: if (pc) { @@ -207,87 +376,185 @@ end: return ret; } -static void init_trace_collection(struct trace_collection *tc) -{ - tc->array = g_ptr_array_sized_new(DEFAULT_FILE_ARRAY_SIZE); -} - -/* - * finalize_trace_collection() closes the opened traces for read - * and free the memory allocated for trace collection - */ -static void finalize_trace_collection(struct trace_collection *tc) -{ - int i; - - for (i = 0; i < tc->array->len; i++) { - struct trace_descriptor *temp = - g_ptr_array_index(tc->array, i); - fmt_read->close_trace(temp); - } - g_ptr_array_free(tc->array, TRUE); -} - -static void trace_collection_add(struct trace_collection *tc, - struct trace_descriptor *td) -{ - g_ptr_array_add(tc->array, td); -} +static GPtrArray *traversed_paths = 0; /* - * traverse_dir() is the callback functiion for File Tree Walk (nftw). + * traverse_trace_dir() is the callback function for File Tree Walk (nftw). * it receives the path of the current entry (file, dir, link..etc) with * a flag to indicate the type of the entry. * if the entry being visited is a directory and contains a metadata file, - * then open it for reading and save a trace_descriptor to that directory - * in the read trace collection. + * then add the path to a global list to be processed later in + * add_traces_recursive. */ -static int traverse_dir(const char *fpath, const struct stat *sb, +static int traverse_trace_dir(const char *fpath, const struct stat *sb, int tflag, struct FTW *ftwbuf) { - int dirfd; - int fd; - struct trace_descriptor *td_read; + int dirfd, metafd; + int closeret; if (tflag != FTW_D) return 0; + dirfd = open(fpath, 0); if (dirfd < 0) { - fprintf(stdout, "[error] unable to open trace " + fprintf(stderr, "[error] [Context] Unable to open trace " "directory file descriptor.\n"); - return -1; + return 0; /* partial error */ } - fd = openat(dirfd, "metadata", O_RDONLY); - if (fd < 0) { - close(dirfd); + metafd = openat(dirfd, "metadata", O_RDONLY); + if (metafd < 0) { + closeret = close(dirfd); + if (closeret < 0) { + perror("close"); + return -1; + } + /* No meta data, just return */ + return 0; } else { - close(fd); - close(dirfd); - td_read = fmt_read->open_trace(opt_input_path, - fpath, O_RDONLY, ctf_move_pos_slow, - NULL); - if (!td_read) { - fprintf(stdout, "Error opening trace \"%s\" " - "for reading.\n\n", fpath); - return -1; /* error */ + closeret = close(metafd); + if (closeret < 0) { + perror("close"); + return -1; /* failure */ } - trace_collection_add(&trace_collection_read, td_read); + closeret = close(dirfd); + if (closeret < 0) { + perror("close"); + return -1; /* failure */ + } + + /* Add path to the global list */ + if (traversed_paths == NULL) { + fprintf(stderr, "[error] [Context] Invalid open path array.\n"); + return -1; + } + g_ptr_array_add(traversed_paths, g_string_new(fpath)); } - return 0; /* success */ + + return 0; } -int main(int argc, char **argv) +/* + * bt_context_add_traces_recursive: Open a trace recursively + * + * Find each trace present in the subdirectory starting from the given + * path, and add them to the context. The packet_seek parameter can be + * NULL: this specify to use the default format packet_seek. + * + * Return: 0 on success, < 0 on failure, > 0 on partial failure. + * Unable to open toplevel: failure. + * Unable to open some subdirectory or file: warn and continue (partial + * failure); + */ +int bt_context_add_traces_recursive(struct bt_context *ctx, const char *path, + const char *format_str, + void (*packet_seek)(struct stream_pos *pos, + size_t offset, int whence)) +{ + + GArray *trace_ids; + int ret = 0; + int i; + + /* Should lock traversed_paths mutex here if used in multithread */ + + traversed_paths = g_ptr_array_new(); + trace_ids = g_array_new(FALSE, TRUE, sizeof(int)); + + ret = nftw(path, traverse_trace_dir, 10, 0); + + /* Process the array if ntfw did not return a fatal error */ + if (ret >= 0) { + for (i = 0; i < traversed_paths->len; i++) { + GString *trace_path = g_ptr_array_index(traversed_paths, + i); + int trace_id = bt_context_add_trace(ctx, + trace_path->str, + format_str, + packet_seek, + NULL, + NULL); + if (trace_id < 0) { + fprintf(stderr, "[warning] [Context] cannot open trace \"%s\" from %s " + "for reading.\n", trace_path->str, path); + /* Allow to skip erroneous traces. */ + ret = 1; /* partial error */ + } else { + g_array_append_val(trace_ids, trace_id); + } + g_string_free(trace_path, TRUE); + } + } + + g_ptr_array_free(traversed_paths, TRUE); + traversed_paths = NULL; + + /* Should unlock traversed paths mutex here if used in multithread */ + + /* + * Return an error if no trace can be opened. + */ + if (trace_ids->len == 0) { + fprintf(stderr, "[error] Cannot open any trace for reading.\n\n"); + ret = -ENOENT; /* failure */ + } + g_array_free(trace_ids, TRUE); + return ret; +} + +int convert_trace(struct trace_descriptor *td_write, + struct bt_context *ctx) { + struct bt_ctf_iter *iter; + struct ctf_text_stream_pos *sout; + struct bt_iter_pos begin_pos; + struct bt_ctf_event *ctf_event; int ret; + + sout = container_of(td_write, struct ctf_text_stream_pos, + trace_descriptor); + + begin_pos.type = BT_SEEK_BEGIN; + iter = bt_ctf_iter_create(ctx, &begin_pos, NULL); + if (!iter) { + ret = -1; + goto error_iter; + } + while ((ctf_event = bt_ctf_iter_read_event(iter))) { + ret = sout->parent.event_cb(&sout->parent, ctf_event->parent->stream); + if (ret) { + fprintf(stderr, "[error] Writing event failed.\n"); + goto end; + } + ret = bt_iter_next(bt_ctf_get_iter(iter)); + if (ret < 0) + goto end; + } + ret = 0; + +end: + bt_ctf_iter_destroy(iter); +error_iter: + return ret; +} + +int main(int argc, char **argv) +{ + int ret, partial_error = 0, open_success = 0; struct format *fmt_write; struct trace_descriptor *td_write; + struct bt_context *ctx; + int i; + + opt_input_paths = g_ptr_array_new(); ret = parse_options(argc, argv); if (ret < 0) { - fprintf(stdout, "Error parsing options.\n\n"); - usage(stdout); + fprintf(stderr, "Error parsing options.\n\n"); + usage(stderr); + g_ptr_array_free(opt_input_paths, TRUE); exit(EXIT_FAILURE); } else if (ret > 0) { + g_ptr_array_free(opt_input_paths, TRUE); exit(EXIT_SUCCESS); } printf_verbose("Verbose mode active.\n"); @@ -298,7 +565,11 @@ int main(int argc, char **argv) if (opt_output_format) strlower(opt_output_format); - printf_verbose("Converting from directory: %s\n", opt_input_path); + printf_verbose("Converting from directory(ies):\n"); + for (i = 0; i < opt_input_paths->len; i++) { + const char *ipath = g_ptr_array_index(opt_input_paths, i); + printf_verbose(" %s\n", ipath); + } printf_verbose("Converting from format: %s\n", opt_input_format ? : "ctf "); printf_verbose("Converting to directory: %s\n", @@ -306,67 +577,108 @@ int main(int argc, char **argv) printf_verbose("Converting to format: %s\n", opt_output_format ? : "text "); - if (!opt_input_format) - opt_input_format = "ctf"; - if (!opt_output_format) - opt_output_format = "text"; + if (!opt_input_format) { + opt_input_format = strdup("ctf"); + if (!opt_input_format) { + partial_error = 1; + goto end; + } + } + if (!opt_output_format) { + opt_output_format = strdup("text"); + if (!opt_output_format) { + partial_error = 1; + goto end; + } + } fmt_read = bt_lookup_format(g_quark_from_static_string(opt_input_format)); if (!fmt_read) { - fprintf(stdout, "[error] Format \"%s\" is not supported.\n\n", + fprintf(stderr, "[error] Format \"%s\" is not supported.\n\n", opt_input_format); - exit(EXIT_FAILURE); + partial_error = 1; + goto end; } fmt_write = bt_lookup_format(g_quark_from_static_string(opt_output_format)); if (!fmt_write) { - fprintf(stdout, "[error] format \"%s\" is not supported.\n\n", + fprintf(stderr, "[error] format \"%s\" is not supported.\n\n", opt_output_format); - exit(EXIT_FAILURE); + partial_error = 1; + goto end; } - /* - * pass the input path to nftw() . - * specify traverse_dir() as the callback function. - * depth = 10 which is the max number of file descriptors - * that nftw() can open at a given time. - * flags = 0 check nftw documentation for more info . - */ - init_trace_collection(&trace_collection_read); - ret = nftw(opt_input_path, traverse_dir, 10, 0); - if (ret != 0) { - fprintf(stdout, "[error] opening trace \"%s\" for reading.\n\n", - opt_input_path); + ctx = bt_context_create(); + if (!ctx) { goto error_td_read; } - if (trace_collection_read.array->len == 0) { - fprintf(stdout, "[warning] no metadata file was found." - " no output was generated\n"); - return 0; + + for (i = 0; i < opt_input_paths->len; i++) { + const char *ipath = g_ptr_array_index(opt_input_paths, i); + ret = bt_context_add_traces_recursive(ctx, ipath, + opt_input_format, NULL); + if (ret < 0) { + fprintf(stderr, "[error] opening trace \"%s\" for reading.\n\n", + ipath); + } else if (ret > 0) { + fprintf(stderr, "[warning] errors occurred when opening trace \"%s\" for reading, continuing anyway.\n\n", + ipath); + open_success = 1; /* some traces were OK */ + partial_error = 1; + } else { + open_success = 1; /* all traces were OK */ + } + } + if (!open_success) { + fprintf(stderr, "[error] none of the specified trace paths could be opened.\n\n"); + goto error_td_read; } - td_write = fmt_write->open_trace(NULL, opt_output_path, O_RDWR, NULL, NULL); + td_write = fmt_write->open_trace(opt_output_path, O_RDWR, NULL, NULL); if (!td_write) { - fprintf(stdout, "Error opening trace \"%s\" for writing.\n\n", + fprintf(stderr, "Error opening trace \"%s\" for writing.\n\n", opt_output_path ? : ""); goto error_td_write; } - ret = convert_trace(td_write, &trace_collection_read); + /* + * Errors happened when opening traces, but we continue anyway. + * sleep to let user see the stderr output before stdout. + */ + if (partial_error) + sleep(PARTIAL_ERROR_SLEEP); + + ret = convert_trace(td_write, ctx); if (ret) { - fprintf(stdout, "Error printing trace.\n\n"); + fprintf(stderr, "Error printing trace.\n\n"); goto error_copy_trace; } fmt_write->close_trace(td_write); - finalize_trace_collection(&trace_collection_read); + + bt_context_put(ctx); printf_verbose("finished converting. Output written to:\n%s\n", opt_output_path ? : ""); - exit(EXIT_SUCCESS); + goto end; /* Error handling */ error_copy_trace: fmt_write->close_trace(td_write); error_td_write: - finalize_trace_collection(&trace_collection_read); + bt_context_put(ctx); error_td_read: - exit(EXIT_FAILURE); + partial_error = 1; + + /* teardown and exit */ +end: + free(opt_input_format); + free(opt_output_format); + free(opt_output_path); + for (i = 0; i < opt_input_paths->len; i++) { + char *ipath = g_ptr_array_index(opt_input_paths, i); + free(ipath); + } + g_ptr_array_free(opt_input_paths, TRUE); + if (partial_error) + exit(EXIT_FAILURE); + else + exit(EXIT_SUCCESS); }